greybus: improve some error messages
Add a few error messages to help explain the reason for failures.
Add a missing space in a message in svc_management().
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
diff --git a/drivers/staging/greybus/ap.c b/drivers/staging/greybus/ap.c
index 24a15e9..a8cd7e7 100644
--- a/drivers/staging/greybus/ap.c
+++ b/drivers/staging/greybus/ap.c
@@ -150,7 +150,7 @@
management->link_up.interface_id,
management->link_up.device_id);
if (ret)
- dev_err(hd->parent, "error %d initializing"
+ dev_err(hd->parent, "error %d initializing "
"module %hhu interface %hhu\n",
ret, management->link_up.module_id,
management->link_up.interface_id);
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index c4b6505..1a8f53e 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -164,6 +164,7 @@
INIT_LIST_HEAD(&connection->protocol_links);
if (!gb_protocol_get(connection, protocol_id)) {
+ pr_err("protocol 0x%02hhx not found\n", protocol_id);
kfree(connection);
return NULL;
}
@@ -191,6 +192,8 @@
retval = device_add(&connection->dev);
if (retval) {
+ pr_err("failed to add connection device for cport 0x%04hx\n",
+ cport_id);
gb_connection_hd_cport_id_free(connection);
gb_protocol_put(connection);
put_device(&connection->dev);
diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c
index 163cdc4..eb63f63 100644
--- a/drivers/staging/greybus/interface.c
+++ b/drivers/staging/greybus/interface.c
@@ -78,6 +78,8 @@
retval = device_add(&interface->dev);
if (retval) {
+ pr_err("failed to add interface device for id 0x%02hhx\n",
+ interface_id);
kfree(interface);
return NULL;
}
diff --git a/drivers/staging/greybus/module.c b/drivers/staging/greybus/module.c
index 3a64a2b..9cf98cd 100644
--- a/drivers/staging/greybus/module.c
+++ b/drivers/staging/greybus/module.c
@@ -100,6 +100,8 @@
retval = device_add(&gmod->dev);
if (retval) {
+ pr_err("failed to add module device for id 0x%02hhx\n",
+ module_id);
put_device(&gmod->dev);
return NULL;
}