commit 6bc9d9d62cbc885414c7d4bb1926c43950498479
author Julia Lawall <Julia.Lawall@lip6.fr> Wed Oct 21 22:41:36 2015 +0200
committer Stephen Boyd <sboyd@codeaurora.org> Wed Oct 21 16:16:32 2015 -0700
tree 41e406b11eda8c306e1d272e90e324835ab285f6
parent 63243a4da7d0dfa19dcacd0a529782eeb2f86f92

clk: add missing of_node_put

for_each_matching_node_and_match performs an of_node_get on each iteration,
so a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression e1,e2,e;
local idexpression np;
@@

 for_each_matching_node_and_match(np, e1, e2) {
   ... when != of_node_put(np)
       when != e = np
(
   return np;
|
+  of_node_put(np);
?  return ...;
)
   ...
 }
// </smpl>

Besides the problem identified by the semantic patch, this patch adds an
of_node_get in front of saving np in a field of parent, to account for the
fact that this value will be put on going on to the next element in the
iteration, and then adds of_node_puts in the two loops where the parent
pointer can be freed.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

drivers/clk/clk.c

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ecb1e52..2eae76f 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -3197,13 +3197,15 @@
 			list_for_each_entry_safe(clk_provider, next,
 						 &clk_provider_list, node) {
 				list_del(&clk_provider->node);
+				of_node_put(clk_provider->np);
 				kfree(clk_provider);
 			}
+			of_node_put(np);
 			return;
 		}
 
 		parent->clk_init_cb = match->data;
-		parent->np = np;
+		parent->np = of_node_get(np);
 		list_add_tail(&parent->node, &clk_provider_list);
 	}
 
@@ -3217,6 +3219,7 @@
 				of_clk_set_defaults(clk_provider->np, true);
 
 				list_del(&clk_provider->node);
+				of_node_put(clk_provider->np);
 				kfree(clk_provider);
 				is_init_done = true;
 			}