commit 72c2d53192004845cbc19cd8a30b3212a9288140
author Al Viro <viro@zeniv.linux.org.uk> Sun Sep 22 16:27:52 2013 -0400
committer Al Viro <viro@zeniv.linux.org.uk> Thu Oct 24 23:34:54 2013 -0400
tree 31fcd924438f03d5aa09d13ffd813fb153da37c3
parent 22bd002ee76aa7d7a3393f39d977f6c106153c60

file->f_op is never NULL...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

fs/open.c

diff --git a/fs/open.c b/fs/open.c
index d420331..a1465b1 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -693,6 +693,10 @@
 	}
 
 	f->f_op = fops_get(inode->i_fop);
+	if (unlikely(WARN_ON(!f->f_op))) {
+		error = -ENODEV;
+		goto cleanup_all;
+	}
 
 	error = security_file_open(f, cred);
 	if (error)
@@ -702,7 +706,7 @@
 	if (error)
 		goto cleanup_all;
 
-	if (!open && f->f_op)
+	if (!open)
 		open = f->f_op->open;
 	if (open) {
 		error = open(inode, f);
@@ -1023,7 +1027,7 @@
 		return 0;
 	}
 
-	if (filp->f_op && filp->f_op->flush)
+	if (filp->f_op->flush)
 		retval = filp->f_op->flush(filp, id);
 
 	if (likely(!(filp->f_mode & FMODE_PATH))) {