tree 1f9889a6509ccc2fa22bc74a108174199a83dbad
parent d44f3ad7b06b84cff1c9f74efa3e4305c7b3e177
author Takashi Iwai <tiwai@suse.de> 1521711627 +0100
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> 1522255159 +0200

ALSA: aloop: Fix access to not-yet-ready substream via cable

commit 8e6b1a72a75bb5067ccb6b56d8ca4aa3a300a64e upstream.

In loopback_open() and loopback_close(), we assign and release the
substream object to the corresponding cable in a racy way.  It's
neither locked nor done in the right position.  The open callback
assigns the substream before its preparation finishes, hence the other
side of the cable may pick it up, which may lead to the invalid memory
access.

This patch addresses these: move the assignment to the end of the open
callback, and wrap with cable->lock for avoiding concurrent accesses.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>