commit 7acd4a794c1530af063e51f3f7171e75556458f3
author Andy Grover <andy.grover@oracle.com> Thu Apr 09 14:09:40 2009 +0000
committer David S. Miller <davem@davemloft.net> Thu Apr 09 17:21:18 2009 -0700
tree 4c213f984afa23fbb704a9e94f6f754ed50bdb5d
parent 7b70d0336da777c00395cc7a503497c2cdabd1a8

RDS: Fix ordering in a conditional

Putting the constant first is a supposed "best practice" that actually makes
the code harder to read.

Thanks to Roland Dreier for finding a bug in this "simple, obviously correct"
patch.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/rds/rdma.c

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index eaeeb91..e390dc7 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -155,7 +155,7 @@
 			     nr_pages, write, 0, pages, NULL);
 	up_read(&current->mm->mmap_sem);
 
-	if (0 <= ret && (unsigned) ret < nr_pages) {
+	if (ret >= 0 && ret < nr_pages) {
 		while (ret--)
 			put_page(pages[ret]);
 		ret = -EFAULT;