tree 2ec9a70ecad5f7cb94136d53d98d587837f05ef3
parent 70967ab9c0c9017645d167d33675eab996633631
author Ben Hutchings <ben@decadent.org.uk> 1251043144 +0100
committer Dave Airlie <airlied@redhat.com> 1251673770 +1000

drm/r128: Add test for initialisation to all ioctls that require it

Almost all r128's private ioctls require that the CCE state has
already been initialised.  However, most do not test that this has
been done, and will proceed to dereference a null pointer.  This may
result in a security vulnerability, since some ioctls are
unprivileged.

This adds a macro for the common initialisation test and changes all
ioctl implementations that require prior initialisation to use that
macro.

Also, r128_do_init_cce() does not test that the CCE state has not
been initialised already.  Repeated initialisation may lead to a crash
or resource leak.  This adds that test.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>