firmware: Reword error messages when kernel is unable to find firmware
The current error message printed when kernel fails to find the firmware
suggests that the entire operation has failed when the user helper may
still find the firmware. As we pass the return code back up, let the
calling driver determine if the entire operation has failed or not.
Change-Id: I5d8ce65e533e1925e98a49a0a88280549af75cb9
Signed-off-by: Kyle Yan <kyan@codeaurora.org>
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index f18ae62..4256d9b 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1178,11 +1178,11 @@
ret = fw_get_filesystem_firmware(device, fw->priv);
if (ret) {
if (!(opt_flags & FW_OPT_NO_WARN))
- dev_warn(device,
- "Direct firmware load for %s failed with error %d\n",
+ dev_dbg(device,
+ "Firmware %s was not found in kernel paths. rc:%d\n",
name, ret);
if (opt_flags & FW_OPT_USERHELPER) {
- dev_warn(device, "Falling back to user helper\n");
+ dev_dbg(device, "Falling back to user helper\n");
ret = fw_load_from_user_helper(fw, name, device,
opt_flags, timeout);
}