tree 63b0390643a406600cbbc9aed15c0c4eaee030a2
parent 2e230aee0f756f1a844ace4059abae4dba43d1c5
author Nicolas Saenz Julienne <nsaenzjulienne@suse.de> 1576225634 +0800
committer jianzhou <jianzhou@codeaurora.org> 1579498650 +0800

HID: core: move Usage Page concatenation to Main item

[ Upstream commit 58e75155009cc800005629955d3482f36a1e0eec ]

As seen on some USB wireless keyboards manufactured by Primax, the HID
parser was using some assumptions that are not always true. In this case
it's s the fact that, inside the scope of a main item, an Usage Page
will always precede an Usage.

The spec is not pretty clear as 6.2.2.7 states "Any usage that follows
is interpreted as a Usage ID and concatenated with the Usage Page".
While 6.2.2.8 states "When the parser encounters a main item it
concatenates the last declared Usage Page with a Usage to form a
complete usage value." Being somewhat contradictory it was decided to
match Window's implementation, which follows 6.2.2.8.

In summary, the patch moves the Usage Page concatenation from the local
item parsing function to the main item parsing function.

Change-Id: I6580ed3ca583c740090a8fa9ae9f9ca450da3af0
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Terry Junge <terry.junge@poly.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Git-commit: 58e75155009cc800005629955d3482f36a1e0eec
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[jianzhou@codeaurora.org: resolved trivial conflict in drivers/hid/hid-core.c]
Signed-off-by: jianzhou <jianzhou@codeaurora.org>