tree 99a7a2a02ff76bee9c4a0620e6a90321517bba13
parent 26dacd0c9b2dc1dc987c376aeee4e80691a7dd0b
author James Bottomley <James.Bottomley@steeleye.com> 1157491601 -0500
committer James Bottomley <jejb@mulgrave.il.steeleye.com> 1157641723 -0500

[SCSI] Fix refcount breakage with 'echo "1" > scan' when target already present

Spotted by: Dan Aloni <da-xx@monatomic.org>

The problem is there's inconsistent locking semantic usage of
scsi_alloc_target().  Two callers assume the target comes back with
reference unincremented and the third assumes its incremented.  Fix by
always making the reference incremented on return.  Also fix path in
target alloc that could consistently increment the parent lock.
Finally document scsi_alloc_target() so its callers know what the
expectations are.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>