greybus: complete overflow responses
If a response arrives for an operation request and the allotted
buffer isn't big enough we report the error, but we don't finish
processing the response.
Instead, set the operation result, but then finish processing
the response (no different from any other operation error).
This will allow the normal completion handling to occur for
this error case.
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c
index 3e3fc73..d91cd5b 100644
--- a/drivers/staging/greybus/operation.c
+++ b/drivers/staging/greybus/operation.c
@@ -526,16 +526,15 @@
gb_pending_operation_remove(operation);
message = &operation->response;
- if (size > message->buffer_size) {
- operation->result = GB_OP_OVERFLOW;
+ if (size <= message->buffer_size) {
+ /* Transfer the operation result from the response header */
+ header = message->buffer;
+ operation->result = header->result;
+ } else {
gb_connection_err(connection, "recv buffer too small");
- return; /* XXX Should still complete operation */
+ operation->result = GB_OP_OVERFLOW;
}
- /* The status in the response is the result of the operation */
- header = message->buffer;
- operation->result = header->result;
-
/* We must ignore the payload if a bad status is returned */
if (operation->result == GB_OP_SUCCESS)
memcpy(message->buffer, data, size);