commit 9b389a8a022110b4bc055a19b888283544d9eba6
author Takashi Iwai <tiwai@suse.de> Mon Oct 28 11:24:23 2013 +0100
committer Takashi Iwai <tiwai@suse.de> Tue Oct 29 11:37:11 2013 +0100
tree 28a32f4c5aeb5adb1705a2d198babd213fdffcc9
parent 63437313daaf90b372d5b383a8cc6ec8dce185fa

ALSA: 6fire: Fix probe of multiple cards

The probe code of snd-usb-6fire driver overrides the devices[] pointer
wrongly without checking whether it's already occupied or not.  This
would screw up the device disconnection later.

Spotted by coverity CID 141423.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/usb/6fire/chip.c

diff --git a/sound/usb/6fire/chip.c b/sound/usb/6fire/chip.c
index c39c779..66edc4a 100644
--- a/sound/usb/6fire/chip.c
+++ b/sound/usb/6fire/chip.c
@@ -101,7 +101,7 @@
 			usb_set_intfdata(intf, chips[i]);
 			mutex_unlock(&register_mutex);
 			return 0;
-		} else if (regidx < 0)
+		} else if (!devices[i] && regidx < 0)
 			regidx = i;
 	}
 	if (regidx < 0) {