commit 9c9bdf4d50730fd04b06077e22d7a83b585f26b5
author Stefan Richter <stefanr@s5r6.in-berlin.de> Tue Jul 17 02:15:36 2007 +0200
committer Stefan Richter <stefanr@s5r6.in-berlin.de> Wed Jul 18 23:53:28 2007 +0200
tree a7d78a732aa2502a4e43d5a5c56966b17b51a4c8
parent 5d59a6f1ba90f15132d55d9d4d5a632f15a43d84

firewire: fix memory leak of fw_request instances

Found and debugged by Jay Fenlason <fenlason@redhat.com>.
The bug was especially noticeable with direct I/O over fw-sbp2.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>

drivers/firewire/fw-transaction.c

diff --git a/drivers/firewire/fw-transaction.c b/drivers/firewire/fw-transaction.c
index c4b3417..3ce8e2f 100644
--- a/drivers/firewire/fw-transaction.c
+++ b/drivers/firewire/fw-transaction.c
@@ -605,8 +605,10 @@
 	 * check is sufficient to ensure we don't send response to
 	 * broadcast packets or posted writes.
 	 */
-	if (request->ack != ACK_PENDING)
+	if (request->ack != ACK_PENDING) {
+		kfree(request);
 		return;
+	}
 
 	if (rcode == RCODE_COMPLETE)
 		fw_fill_response(&request->response, request->request_header,