msm: ipa4: Ignore newline ending character on ipa write input
ipa_write character device function is called from user space
to pass configuration during boot. Ignore ending \n character
at the given string.
Change-Id: I33ee23ddfcc40b9693da7542bbb7b1cebff975f4
CRs-fixed: 2156924
Signed-off-by: Ghanim Fodi <gfodi@codeaurora.org>
Signed-off-by: Amir Levy <alevy@codeaurora.org>
diff --git a/drivers/platform/msm/ipa/ipa_v3/ipa.c b/drivers/platform/msm/ipa/ipa_v3/ipa.c
index 57b988b..f994db5 100644
--- a/drivers/platform/msm/ipa/ipa_v3/ipa.c
+++ b/drivers/platform/msm/ipa/ipa_v3/ipa.c
@@ -4650,8 +4650,7 @@
return -EFAULT;
}
- if (count > 0)
- dbg_buff[count] = '\0';
+ dbg_buff[count] = '\0';
IPADBG("user input string %s\n", dbg_buff);
@@ -4680,11 +4679,15 @@
return count;
}
+ /* trim ending newline character if any */
+ if (count && (dbg_buff[count - 1] == '\n'))
+ dbg_buff[count - 1] = '\0';
+
if (!strcasecmp(dbg_buff, "MHI")) {
ipa3_ctx->ipa_config_is_mhi = true;
pr_info(
"IPA is loading with MHI configuration\n");
- } else if (!strcmp(dbg_buff, "1\n")) {
+ } else if (!strcmp(dbg_buff, "1")) {
pr_info(
"IPA is loading with non MHI configuration\n");
} else {