tree 78b7a67a5f44d0cd12e993471fc0c403819b296d
parent f290f1970f01287eaaffc798a677594a57ebd65e
author Julia Lawall <julia@diku.dk> 1233782249 +0100
committer James Bottomley <James.Bottomley@HansenPartnership.com> 1236880693 -0500

[SCSI] libfc: Correct use of ! and &

!ep->esb_stat is either 1 or 0, and the rightmost bit of ESB_ST_COMPLETE is
always 0, making the result of !ep->esb_stat & ESB_ST_COMPLETE always 0.
Thus parentheses around the argument to ! seem needed.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>