debug: add notifier chain debugging, v2
- unbreak ia64 (and powerpc) where function pointers dont
point at code but at data (reported by Tony Luck)
[ mingo@elte.hu: various cleanups ]
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/kernel/notifier.c b/kernel/notifier.c
index 143fdd7..0f39e39 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -21,10 +21,6 @@
static int notifier_chain_register(struct notifier_block **nl,
struct notifier_block *n)
{
- if (!kernel_text_address((unsigned long)n->notifier_call)) {
- WARN(1, "Invalid notifier registered!");
- return 0;
- }
while ((*nl) != NULL) {
if (n->priority > (*nl)->priority)
break;
@@ -38,10 +34,6 @@
static int notifier_chain_cond_register(struct notifier_block **nl,
struct notifier_block *n)
{
- if (!kernel_text_address((unsigned long)n->notifier_call)) {
- WARN(1, "Invalid notifier registered!");
- return 0;
- }
while ((*nl) != NULL) {
if ((*nl) == n)
return 0;
@@ -92,7 +84,7 @@
next_nb = rcu_dereference(nb->next);
#ifdef CONFIG_DEBUG_NOTIFIERS
- if (!kernel_text_address((unsigned long)nb->notifier_call)) {
+ if (unlikely(!func_ptr_is_kernel_text(nb->notifier_call))) {
WARN(1, "Invalid notifier called!");
nb = next_nb;
continue;