x86, vdso: Use <tools/le_byteshift.h> for littleendian access
There are no standard functions for littleendian data (unlike
bigendian data.) Thus, use <tools/le_byteshift.h> to access
littleendian data members. Those are fairly inefficient, but it
doesn't matter for this purpose (and can be optimized later.) This
avoids portability problems.
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Tested-by: Andy Lutomirski <luto@amacapital.net>
Link: http://lkml.kernel.org/r/20140606140017.afb7f91142f66cb3dd13c186@linux-foundation.org
diff --git a/arch/x86/vdso/vdso2c.c b/arch/x86/vdso/vdso2c.c
index deabaf5..450ac6e 100644
--- a/arch/x86/vdso/vdso2c.c
+++ b/arch/x86/vdso/vdso2c.c
@@ -11,6 +11,8 @@
#include <sys/mman.h>
#include <sys/types.h>
+#include <tools/le_byteshift.h>
+
#include <linux/elf.h>
#include <linux/types.h>
@@ -56,12 +58,12 @@
*/
#define GLE(x, bits, ifnot) \
__builtin_choose_expr( \
- (sizeof(x) == bits/8), \
- (__typeof__(x))le##bits##toh(x), ifnot)
+ (sizeof(*(x)) == bits/8), \
+ (__typeof__(*(x)))get_unaligned_le##bits(x), ifnot)
-extern void bad_get_le(uint64_t);
+extern void bad_get_le(void);
#define LAST_LE(x) \
- __builtin_choose_expr(sizeof(x) == 1, (x), bad_get_le(x))
+ __builtin_choose_expr(sizeof(*(x)) == 1, *(x), bad_get_le())
#define GET_LE(x) \
GLE(x, 64, GLE(x, 32, GLE(x, 16, LAST_LE(x))))