tree 553b2d7b1422545032cf3c048db7dff5f5c8dbd3
parent 79b9677d885d1a792bc103f2febb06f91f92de43
author James Bottomley <James.Bottomley@HansenPartnership.com> 1310071540 -0500
committer James Bottomley <JBottomley@Parallels.com> 1311283278 -0700

[SCSI] fix crash in scsi_dispatch_cmd()

USB surprise removal of sr is triggering an oops in
scsi_dispatch_command().  What seems to be happening is that USB is
hanging on to a queue reference until the last close of the upper
device, so the crash is caused by surprise remove of a mounted CD
followed by attempted unmount.

The problem is that USB doesn't issue its final commands as part of
the SCSI teardown path, but on last close when the block queue is long
gone.  The long term fix is probably to make sr do the teardown in the
same way as sd (so remove all the lower bits on ejection, but keep the
upper disk alive until last close of user space).  However, the
current oops can be simply fixed by not allowing any commands to be
sent to a dead queue.

Cc: stable@kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>