commit d348446b8840602091872b8272855dee196f6dd5
author Dan Carpenter <dan.carpenter@oracle.com> Tue Jul 10 20:32:51 2012 +0000
committer David S. Miller <davem@davemloft.net> Thu Jul 12 07:54:45 2012 -0700
tree 52822f855dd80de30de0dc2f1c7f26d109dfa00c
parent 064bff1c9f70ba495f83668a3ee2f10ea3f1c99c

smsc95xx: signedness bug in get_regs()

"retval" has to be a signed integer for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/usb/smsc95xx.c

diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 05ecf14..bd7cbaa 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -589,7 +589,8 @@
 			 void *buf)
 {
 	struct usbnet *dev = netdev_priv(netdev);
-	unsigned int i, j, retval;
+	unsigned int i, j;
+	int retval;
 	u32 *data = buf;
 
 	retval = smsc95xx_read_reg(dev, ID_REV, &regs->version);