commit d8840ac907c7943bc7e196b11812adfa95cb28ef
author Alexey Dobriyan <adobriyan@gmail.com> Fri Oct 07 02:05:23 2005 +0400
committer Jeff Garzik <jgarzik@pobox.com> Fri Oct 28 16:16:59 2005 -0400
tree 59f0cd61bbb19ee979672012c3de33c591d336d5
parent 712cb1ebb1653538527500165d8382ca48a7fca1

[PATCH] starfire: free_irq() on error path of netdev_open()

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>

drivers/net/starfire.c

diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c
index efdb179..38b2b0a 100644
--- a/drivers/net/starfire.c
+++ b/drivers/net/starfire.c
@@ -1091,8 +1091,10 @@
 		rx_ring_size = sizeof(struct starfire_rx_desc) * RX_RING_SIZE;
 		np->queue_mem_size = tx_done_q_size + rx_done_q_size + tx_ring_size + rx_ring_size;
 		np->queue_mem = pci_alloc_consistent(np->pci_dev, np->queue_mem_size, &np->queue_mem_dma);
-		if (np->queue_mem == 0)
+		if (np->queue_mem == NULL) {
+			free_irq(dev->irq, dev);
 			return -ENOMEM;
+		}
 
 		np->tx_done_q     = np->queue_mem;
 		np->tx_done_q_dma = np->queue_mem_dma;