tree 56c9ca467f36588615993f2b163c29bc64109568
parent 804b1737d71253f01621d2a37a0dce6279a2d440
author Mike Marshall <hubcap@omnibond.com> 1478291545 -0400
committer Mike Marshall <hubcap@omnibond.com> 1478533315 -0500

orangefs: clean up debugfs

We recently refactored the Orangefs debugfs code.
The refactor seemed to trigger dan.carpenter@oracle.com's
static tester to find a possible double-free in the code.

While designing the fix we saw a condition under which the
buffer being freed could also be overflowed.

We also realized how to rebuild the related debugfs file's
"contents" (a string) without deleting and re-creating the file.

This fix should eliminate the possible double-free, the
potential overflow and improve code readability.

Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Martin Brandenburg <martin@omnibond.com>