V4L/DVB (4028): Change dvb_frontend_ops to be a real field instead of a pointer field inside dvb_frontend
The dvb_frontend_ops is a pointer inside dvb_frontend. That's why every demod-driver
is having a field of dvb_frontend_ops in its private-state-struct and
using the reference for filling the pointer-field in dvb_frontend.
- It saves at least two lines of code per demod-driver,
- reduces object size (one less dereference per frontend_ops-access),
- be coherent with dvb_tuner_ops,
- makes it a little bit easier for newbies to understand how it works and
- avoids stupid mistakes because you would have to copy the dvb_frontend_ops
always, before you could assign the static pointer directly, which was
dangerous.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
diff --git a/drivers/media/dvb/frontends/isl6421.c b/drivers/media/dvb/frontends/isl6421.c
index 3699207..58c34db 100644
--- a/drivers/media/dvb/frontends/isl6421.c
+++ b/drivers/media/dvb/frontends/isl6421.c
@@ -99,11 +99,11 @@
isl6421_set_voltage(fe, SEC_VOLTAGE_OFF);
/* free data & call next release routine */
- fe->ops->release = isl6421->release_chain;
+ fe->ops.release = isl6421->release_chain;
kfree(fe->misc_priv);
fe->misc_priv = NULL;
- if (fe->ops->release)
- fe->ops->release(fe);
+ if (fe->ops.release)
+ fe->ops.release(fe);
}
int isl6421_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, u8 i2c_addr,
@@ -133,12 +133,12 @@
}
/* install release callback */
- isl6421->release_chain = fe->ops->release;
- fe->ops->release = isl6421_release;
+ isl6421->release_chain = fe->ops.release;
+ fe->ops.release = isl6421_release;
/* override frontend ops */
- fe->ops->set_voltage = isl6421_set_voltage;
- fe->ops->enable_high_lnb_voltage = isl6421_enable_high_lnb_voltage;
+ fe->ops.set_voltage = isl6421_set_voltage;
+ fe->ops.enable_high_lnb_voltage = isl6421_enable_high_lnb_voltage;
return 0;
}