commit e0182909297da8d38a5d473ae7bee3d0324632a1
author Al Viro <viro@zeniv.linux.org.uk> Thu May 18 08:28:02 2006 -0400
committer Al Viro <viro@zeniv.linux.org.uk> Tue Jun 20 05:25:24 2006 -0400
tree 0c5c06bac1d626ba66aba1142f439b0f34c75282
parent ac03221a4fdda9bfdabf99bcd129847f20fc1d80

[PATCH] proc_loginuid_write() uses simple_strtoul() on non-terminated array

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

fs/proc/base.c

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 6cc77dc..6afff72 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1019,8 +1019,8 @@
 	if (current != task)
 		return -EPERM;
 
-	if (count > PAGE_SIZE)
-		count = PAGE_SIZE;
+	if (count >= PAGE_SIZE)
+		count = PAGE_SIZE - 1;
 
 	if (*ppos != 0) {
 		/* No partial writes. */
@@ -1033,6 +1033,7 @@
 	if (copy_from_user(page, buf, count))
 		goto out_free_page;
 
+	page[count] = '\0';
 	loginuid = simple_strtoul(page, &tmp, 10);
 	if (tmp == page) {
 		length = -EINVAL;