| commit | e25fbe380c4e3c09afa98bcdcd9d3921443adab8 | [log] [tgz] |
|---|---|---|
| author | Xi Wang <xi.wang@gmail.com> | Fri Jan 04 03:22:57 2013 -0500 |
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | Fri Jan 04 10:54:43 2013 -0500 |
| tree | 91aeee4cfe6cfa4a07e2373d7d1f4d3d65b0b549 | |
| parent | 39e88fcfb1d5c6c4b1ff76ca2ab76cf449b850e8 [diff] |
nfs: fix null checking in nfs_get_option_str()
The following null pointer check is broken.
*option = match_strdup(args);
return !option;
The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.
The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some
cut-and-paste code.").
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>