commit e30520c2b075fae3977d482a31b54b0256160a57
author Arnd Bergmann <arnd@arndb.de> Mon Oct 24 17:54:18 2016 +0200
committer David S. Miller <davem@davemloft.net> Thu Oct 27 16:27:34 2016 -0400
tree 1850cde4f291668d6a54d9fbfbbfba6c2114796c
parent e0f841f5cbf2a195c63f3441f3d8ef1cd2bdeeed

kalmia: avoid potential uninitialized variable use

The kalmia_send_init_packet() returns zero or a negative return
code, but gcc has no way of knowing that there cannot be a
positive return code, so it determines that copying the ethernet
address at the end of kalmia_bind() will access uninitialized
data:

drivers/net/usb/kalmia.c: In function ‘kalmia_bind’:
arch/x86/include/asm/string_32.h:78:22: error: ‘*((void *)&ethernet_addr+4)’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   *((short *)to + 2) = *((short *)from + 2);
                      ^
drivers/net/usb/kalmia.c:138:5: note: ‘*((void *)&ethernet_addr+4)’ was declared here

This warning is harmless, but for consistency, we should make
the check for the return code match what the driver does everywhere
else and just progate it, which then gets rid of the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>