tree 8f13ed6c43d8e81911f451e9c6012ceb14e2d330
parent a4ed2d4cd96dd71b0f2e04a88f83abcab6ddd023
author Ben Hutchings <bhutchings@solarflare.com> 1341266582 +0100
committer Ben Hutchings <bhutchings@solarflare.com> 1342537952 +0100

sfc: Use dev_kfree_skb() in efx_end_loopback()

Fix CID 102619 in the Coverity report on Linux.

efx_end_loopback() iterates over an array of skb pointers of which
some may be null (if efx_begin_loopback() failed).  It should not use
dev_kfree_skb_irq(), which requires non-null pointers.  In practice
this is safe because it does not run in interrupt context and
therefore always ends up calling dev_kfree_skb(), which does allow
null pointers.  But we should make that explicit.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>