commit e92bcf8d8abb654cb916f3e615697320bc6bf1e1
author Steven Toth <stoth@kernellabs.com> Mon Oct 10 11:09:55 2011 -0300
committer Mauro Carvalho Chehab <mchehab@redhat.com> Fri Oct 14 17:19:46 2011 -0300
tree 63cbe676f45fa266b42c124ced144954cefded45
parent 2cb9ccd4612907c0a30de9be1c694672e0cd8933

[media] cx23885: fixes related to maximum number of inputs and range checking

Signed-off-by: Steven Toth <stoth@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/video/cx23885/cx23885-video.c

diff --git a/drivers/media/video/cx23885/cx23885-video.c b/drivers/media/video/cx23885/cx23885-video.c
index f13c40e..596b46e 100644
--- a/drivers/media/video/cx23885/cx23885-video.c
+++ b/drivers/media/video/cx23885/cx23885-video.c
@@ -1239,7 +1239,7 @@
 	dprintk(1, "%s()\n", __func__);
 
 	n = i->index;
-	if (n >= 4)
+	if (n >= MAX_CX23885_INPUT)
 		return -EINVAL;
 
 	if (0 == INPUT(n)->type)
@@ -1279,11 +1279,14 @@
 
 	dprintk(1, "%s(%d)\n", __func__, i);
 
-	if (i >= 4) {
+	if (i >= MAX_CX23885_INPUT) {
 		dprintk(1, "%s() -EINVAL\n", __func__);
 		return -EINVAL;
 	}
 
+	if (INPUT(i)->type == 0)
+		return -EINVAL;
+
 	mutex_lock(&dev->lock);
 	cx23885_video_mux(dev, i);
 	mutex_unlock(&dev->lock);