commit ead9a76ceec34df18dc84cb22053253bd5564376
author David S. Miller <davem@davemloft.net> Sun Apr 01 20:23:06 2012 -0400
committer David S. Miller <davem@davemloft.net> Mon Apr 02 04:33:43 2012 -0400
tree 387df8997ce0d054e6ed1c7c9606d7dda3c91513
parent 1a106de6e6543e7d44dbe1bc5f37a8964607dfa6

macvlan: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/macvlan.c

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index f975afd..b17fc90 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -773,7 +773,8 @@
 {
 	struct macvlan_dev *vlan = netdev_priv(dev);
 
-	NLA_PUT_U32(skb, IFLA_MACVLAN_MODE, vlan->mode);
+	if (nla_put_u32(skb, IFLA_MACVLAN_MODE, vlan->mode))
+		goto nla_put_failure;
 	return 0;
 
 nla_put_failure: