commit f27725756be8a2c2dc65eaf70d0b52807aa2f113
author Len Brown <len.brown@intel.com> Sat Dec 26 22:04:03 2009 -0500
committer Len Brown <len.brown@intel.com> Wed Dec 30 02:48:52 2009 -0500
tree e8875a7dc8821c36759a2e27acc433cecd8b0069
parent abb631bfe271a9102fb5b05419272b7aec37a974

ACPI: hp-wmi, msi-wmi: clarify that wmi_install_notify_handler() returns an acpi_status

Emphasize that that wmi_install_notify_handler() returns an acpi_status
rather than -errno by by testing ACPI_SUCCESS(), ACPI_FAILURE().

No functional change in this patch, but this confusion caused a bug in dell-wmi.

Signed-off-by: Len Brown <len.brown@intel.com>

drivers/platform/x86/msi-wmi.c

diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
index 7f77f90..f746c67 100644
--- a/drivers/platform/x86/msi-wmi.c
+++ b/drivers/platform/x86/msi-wmi.c
@@ -236,7 +236,7 @@
 	}
 	err = wmi_install_notify_handler(MSIWMI_EVENT_GUID,
 			msi_wmi_notify, NULL);
-	if (err)
+	if (ACPI_FAILURE(err))
 		return -EINVAL;
 
 	err = msi_wmi_input_setup();