blob: 9b313f7810f5207d02ceb63fe864b7eba1b9637d [file] [log] [blame]
Christoph Mair5bf1d292010-08-09 17:20:28 -07001/* Copyright (c) 2010 Christoph Mair <christoph.mair@gmail.com>
Eric Anderssone939ca02012-04-09 22:16:15 +02002 * Copyright (c) 2012 Bosch Sensortec GmbH
3 * Copyright (c) 2012 Unixphere AB
4 *
Eric Andersson985087d2012-04-09 22:16:17 +02005 * This driver supports the bmp085 and bmp18x digital barometric pressure
6 * and temperature sensors from Bosch Sensortec. The datasheets
7 * are available from their website:
Eric Anderssone939ca02012-04-09 22:16:15 +02008 * http://www.bosch-sensortec.com/content/language1/downloads/BST-BMP085-DS000-05.pdf
Eric Andersson985087d2012-04-09 22:16:17 +02009 * http://www.bosch-sensortec.com/content/language1/downloads/BST-BMP180-DS000-07.pdf
Eric Anderssone939ca02012-04-09 22:16:15 +020010 *
11 * A pressure measurement is issued by reading from pressure0_input.
12 * The return value ranges from 30000 to 110000 pascal with a resulution
13 * of 1 pascal (0.01 millibar) which enables measurements from 9000m above
14 * to 500m below sea level.
15 *
16 * The temperature can be read from temp0_input. Values range from
17 * -400 to 850 representing the ambient temperature in degree celsius
18 * multiplied by 10.The resolution is 0.1 celsius.
19 *
20 * Because ambient pressure is temperature dependent, a temperature
21 * measurement will be executed automatically even if the user is reading
22 * from pressure0_input. This happens if the last temperature measurement
23 * has been executed more then one second ago.
24 *
25 * To decrease RMS noise from pressure measurements, the bmp085 can
26 * autonomously calculate the average of up to eight samples. This is
27 * set up by writing to the oversampling sysfs file. Accepted values
28 * are 0, 1, 2 and 3. 2^x when x is the value written to this file
29 * specifies the number of samples used to calculate the ambient pressure.
30 * RMS noise is specified with six pascal (without averaging) and decreases
31 * down to 3 pascal when using an oversampling setting of 3.
32 *
33 * This program is free software; you can redistribute it and/or modify
34 * it under the terms of the GNU General Public License as published by
35 * the Free Software Foundation; either version 2 of the License, or
36 * (at your option) any later version.
37 *
38 * This program is distributed in the hope that it will be useful,
39 * but WITHOUT ANY WARRANTY; without even the implied warranty of
40 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
41 * GNU General Public License for more details.
42 *
43 * You should have received a copy of the GNU General Public License
44 * along with this program; if not, write to the Free Software
45 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
46 */
Christoph Mair5bf1d292010-08-09 17:20:28 -070047
48#include <linux/module.h>
Eric Anderssone939ca02012-04-09 22:16:15 +020049#include <linux/device.h>
Christoph Mair5bf1d292010-08-09 17:20:28 -070050#include <linux/slab.h>
Eric Anderssonc5a86ab2012-04-09 22:16:16 +020051#include <linux/of.h>
Eric Andersson985087d2012-04-09 22:16:17 +020052#include "bmp085.h"
Marek Beliskoc07f85c2013-11-30 16:26:00 +010053#include <linux/interrupt.h>
54#include <linux/completion.h>
55#include <linux/gpio.h>
Christoph Mair5bf1d292010-08-09 17:20:28 -070056
Christoph Mair5bf1d292010-08-09 17:20:28 -070057#define BMP085_CHIP_ID 0x55
Christoph Mair5bf1d292010-08-09 17:20:28 -070058#define BMP085_CALIBRATION_DATA_START 0xAA
59#define BMP085_CALIBRATION_DATA_LENGTH 11 /* 16 bit values */
60#define BMP085_CHIP_ID_REG 0xD0
Christoph Mair5bf1d292010-08-09 17:20:28 -070061#define BMP085_CTRL_REG 0xF4
62#define BMP085_TEMP_MEASUREMENT 0x2E
63#define BMP085_PRESSURE_MEASUREMENT 0x34
64#define BMP085_CONVERSION_REGISTER_MSB 0xF6
65#define BMP085_CONVERSION_REGISTER_LSB 0xF7
66#define BMP085_CONVERSION_REGISTER_XLSB 0xF8
67#define BMP085_TEMP_CONVERSION_TIME 5
68
Christoph Mair5bf1d292010-08-09 17:20:28 -070069struct bmp085_calibration_data {
70 s16 AC1, AC2, AC3;
71 u16 AC4, AC5, AC6;
72 s16 B1, B2;
73 s16 MB, MC, MD;
74};
75
Christoph Mair5bf1d292010-08-09 17:20:28 -070076struct bmp085_data {
Eric Andersson985087d2012-04-09 22:16:17 +020077 struct device *dev;
78 struct regmap *regmap;
Eric Anderssone939ca02012-04-09 22:16:15 +020079 struct mutex lock;
80 struct bmp085_calibration_data calibration;
81 u8 oversampling_setting;
82 u32 raw_temperature;
83 u32 raw_pressure;
84 u32 temp_measurement_period;
Bernhard Walleb2222582012-02-25 10:28:12 +010085 unsigned long last_temp_measurement;
Eric Anderssonc5a86ab2012-04-09 22:16:16 +020086 u8 chip_id;
Eric Anderssone939ca02012-04-09 22:16:15 +020087 s32 b6; /* calculated temperature correction coefficient */
Marek Beliskoc07f85c2013-11-30 16:26:00 +010088 int irq;
89 struct completion done;
Christoph Mair5bf1d292010-08-09 17:20:28 -070090};
91
Marek Beliskoc07f85c2013-11-30 16:26:00 +010092static irqreturn_t bmp085_eoc_isr(int irq, void *devid)
93{
94 struct bmp085_data *data = devid;
95
96 complete(&data->done);
97
98 return IRQ_HANDLED;
99}
100
Eric Andersson985087d2012-04-09 22:16:17 +0200101static s32 bmp085_read_calibration_data(struct bmp085_data *data)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700102{
103 u16 tmp[BMP085_CALIBRATION_DATA_LENGTH];
Christoph Mair5bf1d292010-08-09 17:20:28 -0700104 struct bmp085_calibration_data *cali = &(data->calibration);
Eric Andersson985087d2012-04-09 22:16:17 +0200105 s32 status = regmap_bulk_read(data->regmap,
106 BMP085_CALIBRATION_DATA_START, (u8 *)tmp,
107 (BMP085_CALIBRATION_DATA_LENGTH << 1));
Christoph Mair5bf1d292010-08-09 17:20:28 -0700108 if (status < 0)
109 return status;
110
Christoph Mair5bf1d292010-08-09 17:20:28 -0700111 cali->AC1 = be16_to_cpu(tmp[0]);
112 cali->AC2 = be16_to_cpu(tmp[1]);
113 cali->AC3 = be16_to_cpu(tmp[2]);
114 cali->AC4 = be16_to_cpu(tmp[3]);
115 cali->AC5 = be16_to_cpu(tmp[4]);
116 cali->AC6 = be16_to_cpu(tmp[5]);
117 cali->B1 = be16_to_cpu(tmp[6]);
118 cali->B2 = be16_to_cpu(tmp[7]);
119 cali->MB = be16_to_cpu(tmp[8]);
120 cali->MC = be16_to_cpu(tmp[9]);
121 cali->MD = be16_to_cpu(tmp[10]);
122 return 0;
123}
124
Christoph Mair5bf1d292010-08-09 17:20:28 -0700125static s32 bmp085_update_raw_temperature(struct bmp085_data *data)
126{
127 u16 tmp;
128 s32 status;
129
130 mutex_lock(&data->lock);
Marek Beliskoc07f85c2013-11-30 16:26:00 +0100131
132 init_completion(&data->done);
133
Eric Andersson985087d2012-04-09 22:16:17 +0200134 status = regmap_write(data->regmap, BMP085_CTRL_REG,
135 BMP085_TEMP_MEASUREMENT);
Eric Anderssone939ca02012-04-09 22:16:15 +0200136 if (status < 0) {
Eric Andersson985087d2012-04-09 22:16:17 +0200137 dev_err(data->dev,
Christoph Mair5bf1d292010-08-09 17:20:28 -0700138 "Error while requesting temperature measurement.\n");
139 goto exit;
140 }
Marek Beliskoc07f85c2013-11-30 16:26:00 +0100141 wait_for_completion_timeout(&data->done, 1 + msecs_to_jiffies(
142 BMP085_TEMP_CONVERSION_TIME));
Christoph Mair5bf1d292010-08-09 17:20:28 -0700143
Eric Andersson985087d2012-04-09 22:16:17 +0200144 status = regmap_bulk_read(data->regmap, BMP085_CONVERSION_REGISTER_MSB,
145 &tmp, sizeof(tmp));
146 if (status < 0) {
147 dev_err(data->dev,
Christoph Mair5bf1d292010-08-09 17:20:28 -0700148 "Error while reading temperature measurement result\n");
Christoph Mair5bf1d292010-08-09 17:20:28 -0700149 goto exit;
150 }
151 data->raw_temperature = be16_to_cpu(tmp);
152 data->last_temp_measurement = jiffies;
153 status = 0; /* everything ok, return 0 */
154
155exit:
156 mutex_unlock(&data->lock);
157 return status;
158}
159
160static s32 bmp085_update_raw_pressure(struct bmp085_data *data)
161{
162 u32 tmp = 0;
163 s32 status;
164
165 mutex_lock(&data->lock);
Marek Beliskoc07f85c2013-11-30 16:26:00 +0100166
167 init_completion(&data->done);
168
Eric Andersson985087d2012-04-09 22:16:17 +0200169 status = regmap_write(data->regmap, BMP085_CTRL_REG,
Eric Anderssone939ca02012-04-09 22:16:15 +0200170 BMP085_PRESSURE_MEASUREMENT +
171 (data->oversampling_setting << 6));
172 if (status < 0) {
Eric Andersson985087d2012-04-09 22:16:17 +0200173 dev_err(data->dev,
Christoph Mair5bf1d292010-08-09 17:20:28 -0700174 "Error while requesting pressure measurement.\n");
175 goto exit;
176 }
177
178 /* wait for the end of conversion */
Marek Beliskoc07f85c2013-11-30 16:26:00 +0100179 wait_for_completion_timeout(&data->done, 1 + msecs_to_jiffies(
180 2+(3 << data->oversampling_setting)));
Christoph Mair5bf1d292010-08-09 17:20:28 -0700181 /* copy data into a u32 (4 bytes), but skip the first byte. */
Eric Andersson985087d2012-04-09 22:16:17 +0200182 status = regmap_bulk_read(data->regmap, BMP085_CONVERSION_REGISTER_MSB,
183 ((u8 *)&tmp)+1, 3);
184 if (status < 0) {
185 dev_err(data->dev,
Christoph Mair5bf1d292010-08-09 17:20:28 -0700186 "Error while reading pressure measurement results\n");
Christoph Mair5bf1d292010-08-09 17:20:28 -0700187 goto exit;
188 }
189 data->raw_pressure = be32_to_cpu((tmp));
190 data->raw_pressure >>= (8-data->oversampling_setting);
191 status = 0; /* everything ok, return 0 */
192
193exit:
194 mutex_unlock(&data->lock);
195 return status;
196}
197
Christoph Mair5bf1d292010-08-09 17:20:28 -0700198/*
199 * This function starts the temperature measurement and returns the value
200 * in tenth of a degree celsius.
201 */
202static s32 bmp085_get_temperature(struct bmp085_data *data, int *temperature)
203{
204 struct bmp085_calibration_data *cali = &data->calibration;
205 long x1, x2;
206 int status;
207
208 status = bmp085_update_raw_temperature(data);
Eric Anderssone939ca02012-04-09 22:16:15 +0200209 if (status < 0)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700210 goto exit;
211
212 x1 = ((data->raw_temperature - cali->AC6) * cali->AC5) >> 15;
213 x2 = (cali->MC << 11) / (x1 + cali->MD);
214 data->b6 = x1 + x2 - 4000;
215 /* if NULL just update b6. Used for pressure only measurements */
216 if (temperature != NULL)
217 *temperature = (x1+x2+8) >> 4;
218
219exit:
Jesper Juhlf80ea662011-12-17 23:52:27 +0100220 return status;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700221}
222
223/*
224 * This function starts the pressure measurement and returns the value
225 * in millibar. Since the pressure depends on the ambient temperature,
Eric Anderssone939ca02012-04-09 22:16:15 +0200226 * a temperature measurement is executed according to the given temperature
227 * measurement period (default is 1 sec boundary). This period could vary
228 * and needs to be adjusted according to the sensor environment, i.e. if big
229 * temperature variations then the temperature needs to be read out often.
Christoph Mair5bf1d292010-08-09 17:20:28 -0700230 */
231static s32 bmp085_get_pressure(struct bmp085_data *data, int *pressure)
232{
233 struct bmp085_calibration_data *cali = &data->calibration;
234 s32 x1, x2, x3, b3;
235 u32 b4, b7;
236 s32 p;
237 int status;
238
239 /* alt least every second force an update of the ambient temperature */
Eric Anderssone939ca02012-04-09 22:16:15 +0200240 if ((data->last_temp_measurement == 0) ||
241 time_is_before_jiffies(data->last_temp_measurement + 1*HZ)) {
Christoph Mair5bf1d292010-08-09 17:20:28 -0700242 status = bmp085_get_temperature(data, NULL);
Eric Anderssone939ca02012-04-09 22:16:15 +0200243 if (status < 0)
244 return status;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700245 }
246
247 status = bmp085_update_raw_pressure(data);
Eric Anderssone939ca02012-04-09 22:16:15 +0200248 if (status < 0)
249 return status;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700250
251 x1 = (data->b6 * data->b6) >> 12;
252 x1 *= cali->B2;
253 x1 >>= 11;
254
255 x2 = cali->AC2 * data->b6;
256 x2 >>= 11;
257
258 x3 = x1 + x2;
259
260 b3 = (((((s32)cali->AC1) * 4 + x3) << data->oversampling_setting) + 2);
261 b3 >>= 2;
262
263 x1 = (cali->AC3 * data->b6) >> 13;
264 x2 = (cali->B1 * ((data->b6 * data->b6) >> 12)) >> 16;
265 x3 = (x1 + x2 + 2) >> 2;
266 b4 = (cali->AC4 * (u32)(x3 + 32768)) >> 15;
267
268 b7 = ((u32)data->raw_pressure - b3) *
269 (50000 >> data->oversampling_setting);
270 p = ((b7 < 0x80000000) ? ((b7 << 1) / b4) : ((b7 / b4) * 2));
271
272 x1 = p >> 8;
273 x1 *= x1;
274 x1 = (x1 * 3038) >> 16;
275 x2 = (-7357 * p) >> 16;
276 p += (x1 + x2 + 3791) >> 4;
277
278 *pressure = p;
279
Eric Anderssone939ca02012-04-09 22:16:15 +0200280 return 0;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700281}
282
283/*
284 * This function sets the chip-internal oversampling. Valid values are 0..3.
285 * The chip will use 2^oversampling samples for internal averaging.
286 * This influences the measurement time and the accuracy; larger values
Eric Anderssone939ca02012-04-09 22:16:15 +0200287 * increase both. The datasheet gives an overview on how measurement time,
Christoph Mair5bf1d292010-08-09 17:20:28 -0700288 * accuracy and noise correlate.
289 */
290static void bmp085_set_oversampling(struct bmp085_data *data,
291 unsigned char oversampling)
292{
293 if (oversampling > 3)
294 oversampling = 3;
295 data->oversampling_setting = oversampling;
296}
297
298/*
299 * Returns the currently selected oversampling. Range: 0..3
300 */
301static unsigned char bmp085_get_oversampling(struct bmp085_data *data)
302{
303 return data->oversampling_setting;
304}
305
306/* sysfs callbacks */
307static ssize_t set_oversampling(struct device *dev,
308 struct device_attribute *attr,
309 const char *buf, size_t count)
310{
Eric Andersson985087d2012-04-09 22:16:17 +0200311 struct bmp085_data *data = dev_get_drvdata(dev);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700312 unsigned long oversampling;
Eric Anderssone939ca02012-04-09 22:16:15 +0200313 int err = kstrtoul(buf, 10, &oversampling);
314
315 if (err == 0) {
316 mutex_lock(&data->lock);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700317 bmp085_set_oversampling(data, oversampling);
Eric Anderssone939ca02012-04-09 22:16:15 +0200318 mutex_unlock(&data->lock);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700319 return count;
320 }
Eric Anderssone939ca02012-04-09 22:16:15 +0200321
322 return err;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700323}
324
325static ssize_t show_oversampling(struct device *dev,
326 struct device_attribute *attr, char *buf)
327{
Eric Andersson985087d2012-04-09 22:16:17 +0200328 struct bmp085_data *data = dev_get_drvdata(dev);
Eric Anderssone939ca02012-04-09 22:16:15 +0200329
Christoph Mair5bf1d292010-08-09 17:20:28 -0700330 return sprintf(buf, "%u\n", bmp085_get_oversampling(data));
331}
332static DEVICE_ATTR(oversampling, S_IWUSR | S_IRUGO,
333 show_oversampling, set_oversampling);
334
335
336static ssize_t show_temperature(struct device *dev,
337 struct device_attribute *attr, char *buf)
338{
339 int temperature;
340 int status;
Eric Andersson985087d2012-04-09 22:16:17 +0200341 struct bmp085_data *data = dev_get_drvdata(dev);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700342
343 status = bmp085_get_temperature(data, &temperature);
Eric Anderssone939ca02012-04-09 22:16:15 +0200344 if (status < 0)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700345 return status;
346 else
347 return sprintf(buf, "%d\n", temperature);
348}
349static DEVICE_ATTR(temp0_input, S_IRUGO, show_temperature, NULL);
350
351
352static ssize_t show_pressure(struct device *dev,
353 struct device_attribute *attr, char *buf)
354{
355 int pressure;
356 int status;
Eric Andersson985087d2012-04-09 22:16:17 +0200357 struct bmp085_data *data = dev_get_drvdata(dev);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700358
359 status = bmp085_get_pressure(data, &pressure);
Eric Anderssone939ca02012-04-09 22:16:15 +0200360 if (status < 0)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700361 return status;
362 else
363 return sprintf(buf, "%d\n", pressure);
364}
365static DEVICE_ATTR(pressure0_input, S_IRUGO, show_pressure, NULL);
366
367
368static struct attribute *bmp085_attributes[] = {
369 &dev_attr_temp0_input.attr,
370 &dev_attr_pressure0_input.attr,
371 &dev_attr_oversampling.attr,
372 NULL
373};
374
375static const struct attribute_group bmp085_attr_group = {
376 .attrs = bmp085_attributes,
377};
378
Eric Andersson985087d2012-04-09 22:16:17 +0200379int bmp085_detect(struct device *dev)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700380{
Eric Andersson985087d2012-04-09 22:16:17 +0200381 struct bmp085_data *data = dev_get_drvdata(dev);
382 unsigned int id;
383 int ret;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700384
Eric Andersson985087d2012-04-09 22:16:17 +0200385 ret = regmap_read(data->regmap, BMP085_CHIP_ID_REG, &id);
386 if (ret < 0)
387 return ret;
388
389 if (id != data->chip_id)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700390 return -ENODEV;
391
392 return 0;
393}
Eric Andersson985087d2012-04-09 22:16:17 +0200394EXPORT_SYMBOL_GPL(bmp085_detect);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700395
Chen Gangd3960342013-09-02 15:54:03 +0800396static void bmp085_get_of_properties(struct bmp085_data *data)
Eric Anderssonc5a86ab2012-04-09 22:16:16 +0200397{
398#ifdef CONFIG_OF
Eric Andersson985087d2012-04-09 22:16:17 +0200399 struct device_node *np = data->dev->of_node;
Eric Anderssonc5a86ab2012-04-09 22:16:16 +0200400 u32 prop;
401
402 if (!np)
403 return;
404
405 if (!of_property_read_u32(np, "chip-id", &prop))
406 data->chip_id = prop & 0xff;
407
408 if (!of_property_read_u32(np, "temp-measurement-period", &prop))
409 data->temp_measurement_period = (prop/100)*HZ;
410
411 if (!of_property_read_u32(np, "default-oversampling", &prop))
412 data->oversampling_setting = prop & 0xff;
413#endif
414}
415
Eric Andersson985087d2012-04-09 22:16:17 +0200416static int bmp085_init_client(struct bmp085_data *data)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700417{
Eric Andersson985087d2012-04-09 22:16:17 +0200418 int status = bmp085_read_calibration_data(data);
Eric Anderssone939ca02012-04-09 22:16:15 +0200419
420 if (status < 0)
421 return status;
422
Eric Anderssonc5a86ab2012-04-09 22:16:16 +0200423 /* default settings */
Eric Anderssonc5a86ab2012-04-09 22:16:16 +0200424 data->chip_id = BMP085_CHIP_ID;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700425 data->last_temp_measurement = 0;
Eric Anderssone939ca02012-04-09 22:16:15 +0200426 data->temp_measurement_period = 1*HZ;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700427 data->oversampling_setting = 3;
Eric Anderssonc5a86ab2012-04-09 22:16:16 +0200428
Eric Andersson985087d2012-04-09 22:16:17 +0200429 bmp085_get_of_properties(data);
Eric Anderssonc5a86ab2012-04-09 22:16:16 +0200430
Christoph Mair5bf1d292010-08-09 17:20:28 -0700431 mutex_init(&data->lock);
Eric Anderssone939ca02012-04-09 22:16:15 +0200432
433 return 0;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700434}
435
Eric Andersson985087d2012-04-09 22:16:17 +0200436struct regmap_config bmp085_regmap_config = {
437 .reg_bits = 8,
438 .val_bits = 8
439};
440EXPORT_SYMBOL_GPL(bmp085_regmap_config);
441
Marek Beliskoc07f85c2013-11-30 16:26:00 +0100442int bmp085_probe(struct device *dev, struct regmap *regmap, int irq)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700443{
444 struct bmp085_data *data;
445 int err = 0;
446
447 data = kzalloc(sizeof(struct bmp085_data), GFP_KERNEL);
448 if (!data) {
449 err = -ENOMEM;
450 goto exit;
451 }
452
Eric Andersson985087d2012-04-09 22:16:17 +0200453 dev_set_drvdata(dev, data);
454 data->dev = dev;
455 data->regmap = regmap;
Marek Beliskoc07f85c2013-11-30 16:26:00 +0100456 data->irq = irq;
457
458 if (data->irq > 0) {
459 err = devm_request_irq(dev, data->irq, bmp085_eoc_isr,
460 IRQF_TRIGGER_RISING, "bmp085",
461 data);
462 if (err < 0)
463 goto exit_free;
464 }
Christoph Mair5bf1d292010-08-09 17:20:28 -0700465
466 /* Initialize the BMP085 chip */
Eric Andersson985087d2012-04-09 22:16:17 +0200467 err = bmp085_init_client(data);
Eric Anderssone939ca02012-04-09 22:16:15 +0200468 if (err < 0)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700469 goto exit_free;
470
Eric Andersson985087d2012-04-09 22:16:17 +0200471 err = bmp085_detect(dev);
472 if (err < 0) {
473 dev_err(dev, "%s: chip_id failed!\n", BMP085_NAME);
474 goto exit_free;
475 }
476
Christoph Mair5bf1d292010-08-09 17:20:28 -0700477 /* Register sysfs hooks */
Eric Andersson985087d2012-04-09 22:16:17 +0200478 err = sysfs_create_group(&dev->kobj, &bmp085_attr_group);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700479 if (err)
480 goto exit_free;
481
Eric Andersson985087d2012-04-09 22:16:17 +0200482 dev_info(dev, "Successfully initialized %s!\n", BMP085_NAME);
Eric Anderssone939ca02012-04-09 22:16:15 +0200483
484 return 0;
Christoph Mair5bf1d292010-08-09 17:20:28 -0700485
486exit_free:
487 kfree(data);
488exit:
489 return err;
490}
Eric Andersson985087d2012-04-09 22:16:17 +0200491EXPORT_SYMBOL_GPL(bmp085_probe);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700492
Eric Andersson985087d2012-04-09 22:16:17 +0200493int bmp085_remove(struct device *dev)
Christoph Mair5bf1d292010-08-09 17:20:28 -0700494{
Eric Andersson985087d2012-04-09 22:16:17 +0200495 struct bmp085_data *data = dev_get_drvdata(dev);
Eric Anderssone939ca02012-04-09 22:16:15 +0200496
Eric Andersson985087d2012-04-09 22:16:17 +0200497 sysfs_remove_group(&data->dev->kobj, &bmp085_attr_group);
Eric Anderssone939ca02012-04-09 22:16:15 +0200498 kfree(data);
499
Christoph Mair5bf1d292010-08-09 17:20:28 -0700500 return 0;
501}
Eric Andersson985087d2012-04-09 22:16:17 +0200502EXPORT_SYMBOL_GPL(bmp085_remove);
Christoph Mair5bf1d292010-08-09 17:20:28 -0700503
Eric Anderssone939ca02012-04-09 22:16:15 +0200504MODULE_AUTHOR("Christoph Mair <christoph.mair@gmail.com>");
Christoph Mair5bf1d292010-08-09 17:20:28 -0700505MODULE_DESCRIPTION("BMP085 driver");
506MODULE_LICENSE("GPL");