blob: 655486099b76483bd2300744af1918d410f743bb [file] [log] [blame]
Jesse Barnes79e53942008-11-07 14:24:08 -08001/*
2 * Copyright © 2006-2007 Intel Corporation
3 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
4 *
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
11 *
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
14 * Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
23 *
24 * Authors:
25 * Eric Anholt <eric@anholt.net>
26 * Dave Airlie <airlied@linux.ie>
27 * Jesse Barnes <jesse.barnes@intel.com>
28 */
29
Jesse Barnesc1c7af62009-09-10 15:28:03 -070030#include <acpi/button.h>
Paul Collins565dcd42009-02-04 23:05:41 +130031#include <linux/dmi.h>
Jesse Barnes79e53942008-11-07 14:24:08 -080032#include <linux/i2c.h>
Tejun Heo5a0e3ad2010-03-24 17:04:11 +090033#include <linux/slab.h>
David Howells760285e2012-10-02 18:01:07 +010034#include <drm/drmP.h>
35#include <drm/drm_crtc.h>
36#include <drm/drm_edid.h>
Jesse Barnes79e53942008-11-07 14:24:08 -080037#include "intel_drv.h"
David Howells760285e2012-10-02 18:01:07 +010038#include <drm/i915_drm.h>
Jesse Barnes79e53942008-11-07 14:24:08 -080039#include "i915_drv.h"
Zhao Yakuie99da352009-06-26 09:46:18 +080040#include <linux/acpi.h>
Jesse Barnes79e53942008-11-07 14:24:08 -080041
Zhao Yakui3fbe18d2009-06-22 15:31:25 +080042/* Private structure for the integrated LVDS support */
Jani Nikulac7362c42012-10-19 14:51:44 +030043struct intel_lvds_connector {
44 struct intel_connector base;
Jani Nikuladb1740a2012-10-19 14:51:45 +030045
46 struct notifier_block lid_notifier;
Jani Nikulac7362c42012-10-19 14:51:44 +030047};
48
Jani Nikula29b99b42012-10-19 14:51:43 +030049struct intel_lvds_encoder {
Chris Wilsonea5b2132010-08-04 13:50:23 +010050 struct intel_encoder base;
Chris Wilson788319d2010-09-12 17:34:41 +010051
Daniel Vetter13c7d872012-11-26 17:22:10 +010052 bool is_dual_link;
Daniel Vetter7dec0602012-09-11 14:12:25 +020053 u32 reg;
Chris Wilson788319d2010-09-12 17:34:41 +010054
Jani Nikula62165e02012-10-19 14:51:47 +030055 struct intel_lvds_connector *attached_connector;
Zhao Yakui3fbe18d2009-06-22 15:31:25 +080056};
57
Jani Nikula29b99b42012-10-19 14:51:43 +030058static struct intel_lvds_encoder *to_lvds_encoder(struct drm_encoder *encoder)
Chris Wilsonea5b2132010-08-04 13:50:23 +010059{
Jani Nikula29b99b42012-10-19 14:51:43 +030060 return container_of(encoder, struct intel_lvds_encoder, base.base);
Chris Wilsonea5b2132010-08-04 13:50:23 +010061}
62
Jani Nikulac7362c42012-10-19 14:51:44 +030063static struct intel_lvds_connector *to_lvds_connector(struct drm_connector *connector)
Chris Wilson788319d2010-09-12 17:34:41 +010064{
Jani Nikulac7362c42012-10-19 14:51:44 +030065 return container_of(connector, struct intel_lvds_connector, base.base);
Chris Wilson788319d2010-09-12 17:34:41 +010066}
67
Daniel Vetterb1dc3322012-07-02 21:09:00 +020068static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
69 enum pipe *pipe)
70{
71 struct drm_device *dev = encoder->base.dev;
72 struct drm_i915_private *dev_priv = dev->dev_private;
Daniel Vetter7dec0602012-09-11 14:12:25 +020073 struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
74 u32 tmp;
Daniel Vetterb1dc3322012-07-02 21:09:00 +020075
Daniel Vetter7dec0602012-09-11 14:12:25 +020076 tmp = I915_READ(lvds_encoder->reg);
Daniel Vetterb1dc3322012-07-02 21:09:00 +020077
78 if (!(tmp & LVDS_PORT_EN))
79 return false;
80
81 if (HAS_PCH_CPT(dev))
82 *pipe = PORT_TO_PIPE_CPT(tmp);
83 else
84 *pipe = PORT_TO_PIPE(tmp);
85
86 return true;
87}
88
Jesse Barnes045ac3b2013-05-14 17:08:26 -070089static void intel_lvds_get_config(struct intel_encoder *encoder,
90 struct intel_crtc_config *pipe_config)
91{
92 struct drm_device *dev = encoder->base.dev;
93 struct drm_i915_private *dev_priv = dev->dev_private;
94 u32 lvds_reg, tmp, flags = 0;
95
96 if (HAS_PCH_SPLIT(dev))
97 lvds_reg = PCH_LVDS;
98 else
99 lvds_reg = LVDS;
100
101 tmp = I915_READ(lvds_reg);
102 if (tmp & LVDS_HSYNC_POLARITY)
103 flags |= DRM_MODE_FLAG_NHSYNC;
104 else
105 flags |= DRM_MODE_FLAG_PHSYNC;
106 if (tmp & LVDS_VSYNC_POLARITY)
107 flags |= DRM_MODE_FLAG_NVSYNC;
108 else
109 flags |= DRM_MODE_FLAG_PVSYNC;
110
111 pipe_config->adjusted_mode.flags |= flags;
112}
113
Daniel Vetterfc683092012-11-26 17:22:12 +0100114/* The LVDS pin pair needs to be on before the DPLLs are enabled.
115 * This is an exception to the general rule that mode_set doesn't turn
116 * things on.
117 */
118static void intel_pre_pll_enable_lvds(struct intel_encoder *encoder)
119{
120 struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
121 struct drm_device *dev = encoder->base.dev;
122 struct drm_i915_private *dev_priv = dev->dev_private;
123 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc);
124 struct drm_display_mode *fixed_mode =
125 lvds_encoder->attached_connector->base.panel.fixed_mode;
126 int pipe = intel_crtc->pipe;
127 u32 temp;
128
Daniel Vetterfc683092012-11-26 17:22:12 +0100129 temp = I915_READ(lvds_encoder->reg);
130 temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP;
Daniel Vetter62810e52012-11-26 17:22:13 +0100131
132 if (HAS_PCH_CPT(dev)) {
133 temp &= ~PORT_TRANS_SEL_MASK;
134 temp |= PORT_TRANS_SEL_CPT(pipe);
Daniel Vetterfc683092012-11-26 17:22:12 +0100135 } else {
Daniel Vetter62810e52012-11-26 17:22:13 +0100136 if (pipe == 1) {
137 temp |= LVDS_PIPEB_SELECT;
138 } else {
139 temp &= ~LVDS_PIPEB_SELECT;
140 }
Daniel Vetterfc683092012-11-26 17:22:12 +0100141 }
Daniel Vetter62810e52012-11-26 17:22:13 +0100142
Daniel Vetterfc683092012-11-26 17:22:12 +0100143 /* set the corresponsding LVDS_BORDER bit */
Daniel Vetter2fa2fe92013-05-07 23:34:16 +0200144 temp &= ~LVDS_BORDER_ENABLE;
Daniel Vetter68fc8742013-04-25 22:52:16 +0200145 temp |= intel_crtc->config.gmch_pfit.lvds_border_bits;
Daniel Vetterfc683092012-11-26 17:22:12 +0100146 /* Set the B0-B3 data pairs corresponding to whether we're going to
147 * set the DPLLs for dual-channel mode or not.
148 */
149 if (lvds_encoder->is_dual_link)
150 temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP;
151 else
152 temp &= ~(LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP);
153
154 /* It would be nice to set 24 vs 18-bit mode (LVDS_A3_POWER_UP)
155 * appropriately here, but we need to look more thoroughly into how
156 * panels behave in the two modes.
157 */
Daniel Vetter62810e52012-11-26 17:22:13 +0100158
159 /* Set the dithering flag on LVDS as needed, note that there is no
160 * special lvds dither control bit on pch-split platforms, dithering is
161 * only controlled through the PIPECONF reg. */
162 if (INTEL_INFO(dev)->gen == 4) {
Daniel Vetterd8b32242013-04-25 17:54:44 +0200163 /* Bspec wording suggests that LVDS port dithering only exists
164 * for 18bpp panels. */
165 if (intel_crtc->config.dither &&
166 intel_crtc->config.pipe_bpp == 18)
Daniel Vetterfc683092012-11-26 17:22:12 +0100167 temp |= LVDS_ENABLE_DITHER;
168 else
169 temp &= ~LVDS_ENABLE_DITHER;
170 }
171 temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY);
172 if (fixed_mode->flags & DRM_MODE_FLAG_NHSYNC)
173 temp |= LVDS_HSYNC_POLARITY;
174 if (fixed_mode->flags & DRM_MODE_FLAG_NVSYNC)
175 temp |= LVDS_VSYNC_POLARITY;
176
177 I915_WRITE(lvds_encoder->reg, temp);
178}
179
Jesse Barnes79e53942008-11-07 14:24:08 -0800180/**
Jesse Barnes79e53942008-11-07 14:24:08 -0800181 * Sets the power state for the panel.
182 */
Daniel Vetterc22834e2012-06-30 15:31:28 +0200183static void intel_enable_lvds(struct intel_encoder *encoder)
Jesse Barnes79e53942008-11-07 14:24:08 -0800184{
Daniel Vetterc22834e2012-06-30 15:31:28 +0200185 struct drm_device *dev = encoder->base.dev;
Jani Nikula29b99b42012-10-19 14:51:43 +0300186 struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
Daniel Vetterc22834e2012-06-30 15:31:28 +0200187 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc);
Jesse Barnes79e53942008-11-07 14:24:08 -0800188 struct drm_i915_private *dev_priv = dev->dev_private;
Daniel Vetter7dec0602012-09-11 14:12:25 +0200189 u32 ctl_reg, stat_reg;
Zhenyu Wang541998a2009-06-05 15:38:44 +0800190
Eric Anholtc619eed2010-01-28 16:45:52 -0800191 if (HAS_PCH_SPLIT(dev)) {
Zhenyu Wang541998a2009-06-05 15:38:44 +0800192 ctl_reg = PCH_PP_CONTROL;
Keith Packardde842ef2011-08-06 10:30:45 -0700193 stat_reg = PCH_PP_STATUS;
Zhenyu Wang541998a2009-06-05 15:38:44 +0800194 } else {
195 ctl_reg = PP_CONTROL;
Keith Packardde842ef2011-08-06 10:30:45 -0700196 stat_reg = PP_STATUS;
Zhenyu Wang541998a2009-06-05 15:38:44 +0800197 }
Jesse Barnes79e53942008-11-07 14:24:08 -0800198
Daniel Vetter7dec0602012-09-11 14:12:25 +0200199 I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) | LVDS_PORT_EN);
Chris Wilsone9e331a2010-09-13 01:16:10 +0100200
Chris Wilson2a1292f2010-12-05 19:21:18 +0000201 I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
Daniel Vetter7dec0602012-09-11 14:12:25 +0200202 POSTING_READ(lvds_encoder->reg);
Keith Packardde842ef2011-08-06 10:30:45 -0700203 if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
204 DRM_ERROR("timed out waiting for panel to power on\n");
Chris Wilson2a1292f2010-12-05 19:21:18 +0000205
Daniel Vetter24ded202012-06-05 12:14:54 +0200206 intel_panel_enable_backlight(dev, intel_crtc->pipe);
Chris Wilson2a1292f2010-12-05 19:21:18 +0000207}
208
Daniel Vetterc22834e2012-06-30 15:31:28 +0200209static void intel_disable_lvds(struct intel_encoder *encoder)
Chris Wilson2a1292f2010-12-05 19:21:18 +0000210{
Daniel Vetterc22834e2012-06-30 15:31:28 +0200211 struct drm_device *dev = encoder->base.dev;
Jani Nikula29b99b42012-10-19 14:51:43 +0300212 struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
Chris Wilson2a1292f2010-12-05 19:21:18 +0000213 struct drm_i915_private *dev_priv = dev->dev_private;
Daniel Vetter7dec0602012-09-11 14:12:25 +0200214 u32 ctl_reg, stat_reg;
Chris Wilson2a1292f2010-12-05 19:21:18 +0000215
216 if (HAS_PCH_SPLIT(dev)) {
217 ctl_reg = PCH_PP_CONTROL;
Keith Packardde842ef2011-08-06 10:30:45 -0700218 stat_reg = PCH_PP_STATUS;
Chris Wilson2a1292f2010-12-05 19:21:18 +0000219 } else {
220 ctl_reg = PP_CONTROL;
Keith Packardde842ef2011-08-06 10:30:45 -0700221 stat_reg = PP_STATUS;
Chris Wilson2a1292f2010-12-05 19:21:18 +0000222 }
223
Chris Wilson47356eb2011-01-11 17:06:04 +0000224 intel_panel_disable_backlight(dev);
Chris Wilson2a1292f2010-12-05 19:21:18 +0000225
226 I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
Keith Packardde842ef2011-08-06 10:30:45 -0700227 if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
228 DRM_ERROR("timed out waiting for panel to power off\n");
Chris Wilson2a1292f2010-12-05 19:21:18 +0000229
Daniel Vetter7dec0602012-09-11 14:12:25 +0200230 I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) & ~LVDS_PORT_EN);
231 POSTING_READ(lvds_encoder->reg);
Jesse Barnes79e53942008-11-07 14:24:08 -0800232}
233
Jesse Barnes79e53942008-11-07 14:24:08 -0800234static int intel_lvds_mode_valid(struct drm_connector *connector,
235 struct drm_display_mode *mode)
236{
Jani Nikuladd06f902012-10-19 14:51:50 +0300237 struct intel_connector *intel_connector = to_intel_connector(connector);
238 struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
Jesse Barnes79e53942008-11-07 14:24:08 -0800239
Chris Wilson788319d2010-09-12 17:34:41 +0100240 if (mode->hdisplay > fixed_mode->hdisplay)
241 return MODE_PANEL;
242 if (mode->vdisplay > fixed_mode->vdisplay)
243 return MODE_PANEL;
Jesse Barnes79e53942008-11-07 14:24:08 -0800244
245 return MODE_OK;
246}
247
Daniel Vetter7ae89232013-03-27 00:44:52 +0100248static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,
249 struct intel_crtc_config *pipe_config)
Jesse Barnes79e53942008-11-07 14:24:08 -0800250{
Daniel Vetter7ae89232013-03-27 00:44:52 +0100251 struct drm_device *dev = intel_encoder->base.dev;
Jesse Barnes79e53942008-11-07 14:24:08 -0800252 struct drm_i915_private *dev_priv = dev->dev_private;
Daniel Vetter7ae89232013-03-27 00:44:52 +0100253 struct intel_lvds_encoder *lvds_encoder =
254 to_lvds_encoder(&intel_encoder->base);
Jani Nikula4d891522012-10-26 12:03:59 +0300255 struct intel_connector *intel_connector =
256 &lvds_encoder->attached_connector->base;
Daniel Vetter7ae89232013-03-27 00:44:52 +0100257 struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
Jani Nikula29b99b42012-10-19 14:51:43 +0300258 struct intel_crtc *intel_crtc = lvds_encoder->base.new_crtc;
Daniel Vetter4e53c2e2013-03-27 00:44:58 +0100259 unsigned int lvds_bpp;
Jesse Barnes79e53942008-11-07 14:24:08 -0800260
261 /* Should never happen!! */
Chris Wilsona6c45cf2010-09-17 00:32:17 +0100262 if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
Keith Packard1ae8c0a2009-06-28 15:42:17 -0700263 DRM_ERROR("Can't support LVDS on pipe A\n");
Jesse Barnes79e53942008-11-07 14:24:08 -0800264 return false;
265 }
266
Jani Nikula29b99b42012-10-19 14:51:43 +0300267 if (intel_encoder_check_is_cloned(&lvds_encoder->base))
Daniel Vettere24c5c22012-07-08 20:17:15 +0200268 return false;
Chris Wilson1d8e1c72010-08-07 11:01:28 +0100269
Daniel Vetter4e53c2e2013-03-27 00:44:58 +0100270 if ((I915_READ(lvds_encoder->reg) & LVDS_A3_POWER_MASK) ==
271 LVDS_A3_POWER_UP)
272 lvds_bpp = 8*3;
273 else
274 lvds_bpp = 6*3;
275
Daniel Vettere29c22c2013-02-21 00:00:16 +0100276 if (lvds_bpp != pipe_config->pipe_bpp && !pipe_config->bw_constrained) {
Daniel Vetter4e53c2e2013-03-27 00:44:58 +0100277 DRM_DEBUG_KMS("forcing display bpp (was %d) to LVDS (%d)\n",
278 pipe_config->pipe_bpp, lvds_bpp);
279 pipe_config->pipe_bpp = lvds_bpp;
280 }
Daniel Vetterd8b32242013-04-25 17:54:44 +0200281
Jesse Barnes79e53942008-11-07 14:24:08 -0800282 /*
Chris Wilson71677042010-07-17 13:38:43 +0100283 * We have timings from the BIOS for the panel, put them in
Jesse Barnes79e53942008-11-07 14:24:08 -0800284 * to the adjusted mode. The CRTC will be set up for this mode,
285 * with the panel scaling set up to source from the H/VDisplay
286 * of the original mode.
287 */
Jani Nikula4d891522012-10-26 12:03:59 +0300288 intel_fixed_panel_mode(intel_connector->panel.fixed_mode,
Jani Nikuladd06f902012-10-19 14:51:50 +0300289 adjusted_mode);
Chris Wilson1d8e1c72010-08-07 11:01:28 +0100290
291 if (HAS_PCH_SPLIT(dev)) {
Daniel Vetter5bfe2ac2013-03-27 00:44:55 +0100292 pipe_config->has_pch_encoder = true;
293
Jesse Barnesb074cec2013-04-25 12:55:02 -0700294 intel_pch_panel_fitting(intel_crtc, pipe_config,
295 intel_connector->panel.fitting_mode);
Chris Wilson1d8e1c72010-08-07 11:01:28 +0100296 return true;
Jesse Barnes2dd24552013-04-25 12:55:01 -0700297 } else {
298 intel_gmch_panel_fitting(intel_crtc, pipe_config,
299 intel_connector->panel.fitting_mode);
Chris Wilson1d8e1c72010-08-07 11:01:28 +0100300 }
Jesse Barnes79e53942008-11-07 14:24:08 -0800301
Daniel Vetterf9bef082012-04-15 19:53:19 +0200302 drm_mode_set_crtcinfo(adjusted_mode, 0);
Daniel Vetter7ae89232013-03-27 00:44:52 +0100303 pipe_config->timings_set = true;
Daniel Vetterf9bef082012-04-15 19:53:19 +0200304
Zhao Yakuia3e17eb2009-10-10 10:42:37 +0800305 /*
Jesse Barnes79e53942008-11-07 14:24:08 -0800306 * XXX: It would be nice to support lower refresh rates on the
307 * panels to reduce power consumption, and perhaps match the
308 * user's requested refresh rate.
309 */
310
311 return true;
312}
313
Jesse Barnes79e53942008-11-07 14:24:08 -0800314static void intel_lvds_mode_set(struct drm_encoder *encoder,
315 struct drm_display_mode *mode,
316 struct drm_display_mode *adjusted_mode)
317{
Jesse Barnes79e53942008-11-07 14:24:08 -0800318 /*
319 * The LVDS pin pair will already have been turned on in the
320 * intel_crtc_mode_set since it has a large impact on the DPLL
321 * settings.
322 */
Jesse Barnes79e53942008-11-07 14:24:08 -0800323}
324
325/**
326 * Detect the LVDS connection.
327 *
Jesse Barnesb42d4c52009-09-10 15:28:04 -0700328 * Since LVDS doesn't have hotlug, we use the lid as a proxy. Open means
329 * connected and closed means disconnected. We also send hotplug events as
330 * needed, using lid status notification from the input layer.
Jesse Barnes79e53942008-11-07 14:24:08 -0800331 */
Chris Wilson7b334fc2010-09-09 23:51:02 +0100332static enum drm_connector_status
Chris Wilson930a9e22010-09-14 11:07:23 +0100333intel_lvds_detect(struct drm_connector *connector, bool force)
Jesse Barnes79e53942008-11-07 14:24:08 -0800334{
Jesse Barnes7b9c5ab2010-02-12 09:30:00 -0800335 struct drm_device *dev = connector->dev;
Chris Wilson6ee3b5a2011-03-24 13:26:43 +0000336 enum drm_connector_status status;
Jesse Barnesb42d4c52009-09-10 15:28:04 -0700337
Chris Wilsonfe16d942011-02-12 10:29:38 +0000338 status = intel_panel_detect(dev);
339 if (status != connector_status_unknown)
340 return status;
Chris Wilson01fe9db2011-01-16 19:37:30 +0000341
Chris Wilson6ee3b5a2011-03-24 13:26:43 +0000342 return connector_status_connected;
Jesse Barnes79e53942008-11-07 14:24:08 -0800343}
344
345/**
346 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
347 */
348static int intel_lvds_get_modes(struct drm_connector *connector)
349{
Jani Nikula62165e02012-10-19 14:51:47 +0300350 struct intel_lvds_connector *lvds_connector = to_lvds_connector(connector);
Jesse Barnes79e53942008-11-07 14:24:08 -0800351 struct drm_device *dev = connector->dev;
Chris Wilson788319d2010-09-12 17:34:41 +0100352 struct drm_display_mode *mode;
Jesse Barnes79e53942008-11-07 14:24:08 -0800353
Jani Nikula9cd300e2012-10-19 14:51:52 +0300354 /* use cached edid if we have one */
Chris Wilson2aa4f092012-11-21 16:14:04 +0000355 if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
Jani Nikula9cd300e2012-10-19 14:51:52 +0300356 return drm_add_edid_modes(connector, lvds_connector->base.edid);
Jesse Barnes79e53942008-11-07 14:24:08 -0800357
Jani Nikuladd06f902012-10-19 14:51:50 +0300358 mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode);
Chris Wilson311bd682011-01-13 19:06:50 +0000359 if (mode == NULL)
Chris Wilson788319d2010-09-12 17:34:41 +0100360 return 0;
Jesse Barnes79e53942008-11-07 14:24:08 -0800361
Chris Wilson788319d2010-09-12 17:34:41 +0100362 drm_mode_probed_add(connector, mode);
363 return 1;
Jesse Barnes79e53942008-11-07 14:24:08 -0800364}
365
Thomas Bächler0544edf2010-07-02 10:44:23 +0200366static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
367{
Daniel Vetterbc0daf42012-04-01 13:16:49 +0200368 DRM_INFO("Skipping forced modeset for %s\n", id->ident);
Thomas Bächler0544edf2010-07-02 10:44:23 +0200369 return 1;
370}
371
372/* The GPU hangs up on these systems if modeset is performed on LID open */
373static const struct dmi_system_id intel_no_modeset_on_lid[] = {
374 {
375 .callback = intel_no_modeset_on_lid_dmi_callback,
376 .ident = "Toshiba Tecra A11",
377 .matches = {
378 DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
379 DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
380 },
381 },
382
383 { } /* terminating entry */
384};
385
Linus Torvaldsc9354c82009-11-02 09:29:55 -0800386/*
Zhang Ruib8efb172013-02-05 15:41:53 +0800387 * Lid events. Note the use of 'modeset':
388 * - we set it to MODESET_ON_LID_OPEN on lid close,
389 * and set it to MODESET_DONE on open
Linus Torvaldsc9354c82009-11-02 09:29:55 -0800390 * - we use it as a "only once" bit (ie we ignore
Zhang Ruib8efb172013-02-05 15:41:53 +0800391 * duplicate events where it was already properly set)
392 * - the suspend/resume paths will set it to
393 * MODESET_SUSPENDED and ignore the lid open event,
394 * because they restore the mode ("lid open").
Linus Torvaldsc9354c82009-11-02 09:29:55 -0800395 */
Jesse Barnesc1c7af62009-09-10 15:28:03 -0700396static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
397 void *unused)
398{
Jani Nikuladb1740a2012-10-19 14:51:45 +0300399 struct intel_lvds_connector *lvds_connector =
400 container_of(nb, struct intel_lvds_connector, lid_notifier);
401 struct drm_connector *connector = &lvds_connector->base.base;
402 struct drm_device *dev = connector->dev;
403 struct drm_i915_private *dev_priv = dev->dev_private;
Jesse Barnesc1c7af62009-09-10 15:28:03 -0700404
Alex Williamson2fb4e612011-04-21 16:08:14 -0600405 if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
406 return NOTIFY_OK;
407
Zhang Ruib8efb172013-02-05 15:41:53 +0800408 mutex_lock(&dev_priv->modeset_restore_lock);
409 if (dev_priv->modeset_restore == MODESET_SUSPENDED)
410 goto exit;
Zhao Yakuia2565372009-12-11 09:26:11 +0800411 /*
412 * check and update the status of LVDS connector after receiving
413 * the LID nofication event.
414 */
Jani Nikuladb1740a2012-10-19 14:51:45 +0300415 connector->status = connector->funcs->detect(connector, false);
Chris Wilson7b334fc2010-09-09 23:51:02 +0100416
Thomas Bächler0544edf2010-07-02 10:44:23 +0200417 /* Don't force modeset on machines where it causes a GPU lockup */
418 if (dmi_check_system(intel_no_modeset_on_lid))
Zhang Ruib8efb172013-02-05 15:41:53 +0800419 goto exit;
Linus Torvaldsc9354c82009-11-02 09:29:55 -0800420 if (!acpi_lid_open()) {
Zhang Ruib8efb172013-02-05 15:41:53 +0800421 /* do modeset on next lid open event */
422 dev_priv->modeset_restore = MODESET_ON_LID_OPEN;
423 goto exit;
Jesse Barnes06891e22009-09-14 10:58:48 -0700424 }
Jesse Barnesc1c7af62009-09-10 15:28:03 -0700425
Zhang Ruib8efb172013-02-05 15:41:53 +0800426 if (dev_priv->modeset_restore == MODESET_DONE)
427 goto exit;
Linus Torvaldsc9354c82009-11-02 09:29:55 -0800428
Daniel Vettera0e99e62012-12-02 01:05:46 +0100429 drm_modeset_lock_all(dev);
Daniel Vetter45e2b5f2012-11-23 18:16:34 +0100430 intel_modeset_setup_hw_state(dev, true);
Daniel Vettera0e99e62012-12-02 01:05:46 +0100431 drm_modeset_unlock_all(dev);
Jesse Barnes06324192009-09-10 15:28:05 -0700432
Zhang Ruib8efb172013-02-05 15:41:53 +0800433 dev_priv->modeset_restore = MODESET_DONE;
434
435exit:
436 mutex_unlock(&dev_priv->modeset_restore_lock);
Jesse Barnesc1c7af62009-09-10 15:28:03 -0700437 return NOTIFY_OK;
438}
439
Jesse Barnes79e53942008-11-07 14:24:08 -0800440/**
441 * intel_lvds_destroy - unregister and free LVDS structures
442 * @connector: connector to free
443 *
444 * Unregister the DDC bus for this connector then free the driver private
445 * structure.
446 */
447static void intel_lvds_destroy(struct drm_connector *connector)
448{
Jani Nikuladb1740a2012-10-19 14:51:45 +0300449 struct intel_lvds_connector *lvds_connector =
450 to_lvds_connector(connector);
Jesse Barnes79e53942008-11-07 14:24:08 -0800451
Jani Nikuladb1740a2012-10-19 14:51:45 +0300452 if (lvds_connector->lid_notifier.notifier_call)
453 acpi_lid_notifier_unregister(&lvds_connector->lid_notifier);
Matthew Garrettaaa6fd22011-08-12 12:11:33 +0200454
Jani Nikula9cd300e2012-10-19 14:51:52 +0300455 if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
456 kfree(lvds_connector->base.edid);
457
Jani Nikula1d508702012-10-19 14:51:49 +0300458 intel_panel_fini(&lvds_connector->base.panel);
Jani Nikuladb1740a2012-10-19 14:51:45 +0300459
Jesse Barnes79e53942008-11-07 14:24:08 -0800460 drm_sysfs_connector_remove(connector);
461 drm_connector_cleanup(connector);
462 kfree(connector);
463}
464
Jesse Barnes335041e2009-01-22 22:22:06 +1000465static int intel_lvds_set_property(struct drm_connector *connector,
466 struct drm_property *property,
467 uint64_t value)
468{
Jani Nikula4d891522012-10-26 12:03:59 +0300469 struct intel_connector *intel_connector = to_intel_connector(connector);
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800470 struct drm_device *dev = connector->dev;
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800471
Chris Wilson788319d2010-09-12 17:34:41 +0100472 if (property == dev->mode_config.scaling_mode_property) {
Jani Nikula62165e02012-10-19 14:51:47 +0300473 struct drm_crtc *crtc;
Zhenyu Wangbb8a3562010-03-29 16:40:50 +0800474
Jesse Barnes53bd8382009-07-01 10:04:40 -0700475 if (value == DRM_MODE_SCALE_NONE) {
476 DRM_DEBUG_KMS("no scaling not supported\n");
Chris Wilson788319d2010-09-12 17:34:41 +0100477 return -EINVAL;
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800478 }
Chris Wilson788319d2010-09-12 17:34:41 +0100479
Jani Nikula4d891522012-10-26 12:03:59 +0300480 if (intel_connector->panel.fitting_mode == value) {
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800481 /* the LVDS scaling property is not changed */
482 return 0;
483 }
Jani Nikula4d891522012-10-26 12:03:59 +0300484 intel_connector->panel.fitting_mode = value;
Jani Nikula62165e02012-10-19 14:51:47 +0300485
486 crtc = intel_attached_encoder(connector)->base.crtc;
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800487 if (crtc && crtc->enabled) {
488 /*
489 * If the CRTC is enabled, the display will be changed
490 * according to the new panel fitting mode.
491 */
Chris Wilsonc0c36b942012-12-19 16:08:43 +0000492 intel_crtc_restore_mode(crtc);
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800493 }
494 }
495
Jesse Barnes335041e2009-01-22 22:22:06 +1000496 return 0;
497}
498
Jesse Barnes79e53942008-11-07 14:24:08 -0800499static const struct drm_encoder_helper_funcs intel_lvds_helper_funcs = {
Jesse Barnes79e53942008-11-07 14:24:08 -0800500 .mode_set = intel_lvds_mode_set,
Jesse Barnes79e53942008-11-07 14:24:08 -0800501};
502
503static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
504 .get_modes = intel_lvds_get_modes,
505 .mode_valid = intel_lvds_mode_valid,
Chris Wilsondf0e9242010-09-09 16:20:55 +0100506 .best_encoder = intel_best_encoder,
Jesse Barnes79e53942008-11-07 14:24:08 -0800507};
508
509static const struct drm_connector_funcs intel_lvds_connector_funcs = {
Daniel Vetterc22834e2012-06-30 15:31:28 +0200510 .dpms = intel_connector_dpms,
Jesse Barnes79e53942008-11-07 14:24:08 -0800511 .detect = intel_lvds_detect,
512 .fill_modes = drm_helper_probe_single_connector_modes,
Jesse Barnes335041e2009-01-22 22:22:06 +1000513 .set_property = intel_lvds_set_property,
Jesse Barnes79e53942008-11-07 14:24:08 -0800514 .destroy = intel_lvds_destroy,
515};
516
Jesse Barnes79e53942008-11-07 14:24:08 -0800517static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
Chris Wilsonea5b2132010-08-04 13:50:23 +0100518 .destroy = intel_encoder_destroy,
Jesse Barnes79e53942008-11-07 14:24:08 -0800519};
520
Jarod Wilson425d2442009-05-05 10:00:25 -0400521static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
522{
Daniel Vetterbc0daf42012-04-01 13:16:49 +0200523 DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
Jarod Wilson425d2442009-05-05 10:00:25 -0400524 return 1;
525}
Jesse Barnes79e53942008-11-07 14:24:08 -0800526
Jarod Wilson425d2442009-05-05 10:00:25 -0400527/* These systems claim to have LVDS, but really don't */
Jaswinder Singh Rajput93c05f22009-06-04 09:41:19 +1000528static const struct dmi_system_id intel_no_lvds[] = {
Jarod Wilson425d2442009-05-05 10:00:25 -0400529 {
530 .callback = intel_no_lvds_dmi_callback,
531 .ident = "Apple Mac Mini (Core series)",
532 .matches = {
Keith Packard98acd462009-06-14 12:31:58 -0700533 DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
Jarod Wilson425d2442009-05-05 10:00:25 -0400534 DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
535 },
536 },
537 {
538 .callback = intel_no_lvds_dmi_callback,
539 .ident = "Apple Mac Mini (Core 2 series)",
540 .matches = {
Keith Packard98acd462009-06-14 12:31:58 -0700541 DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
Jarod Wilson425d2442009-05-05 10:00:25 -0400542 DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
543 },
544 },
545 {
546 .callback = intel_no_lvds_dmi_callback,
547 .ident = "MSI IM-945GSE-A",
548 .matches = {
549 DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
550 DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
551 },
552 },
553 {
554 .callback = intel_no_lvds_dmi_callback,
555 .ident = "Dell Studio Hybrid",
556 .matches = {
557 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
558 DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
559 },
560 },
Jarod Wilson70aa96c2009-05-27 17:20:39 -0400561 {
562 .callback = intel_no_lvds_dmi_callback,
Pieterjan Camerlynckb0662542011-07-26 16:23:54 +0200563 .ident = "Dell OptiPlex FX170",
564 .matches = {
565 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
566 DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
567 },
568 },
569 {
570 .callback = intel_no_lvds_dmi_callback,
Jarod Wilson70aa96c2009-05-27 17:20:39 -0400571 .ident = "AOpen Mini PC",
572 .matches = {
573 DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
574 DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
575 },
576 },
Michael Cousinfa0864b2009-06-05 21:16:22 +0200577 {
578 .callback = intel_no_lvds_dmi_callback,
Tormod Voldened8c7542009-07-13 22:26:48 +0200579 .ident = "AOpen Mini PC MP915",
580 .matches = {
581 DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
582 DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
583 },
584 },
585 {
586 .callback = intel_no_lvds_dmi_callback,
Knut Petersen22ab70d2011-01-14 15:38:10 +0000587 .ident = "AOpen i915GMm-HFS",
588 .matches = {
589 DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
590 DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
591 },
592 },
593 {
594 .callback = intel_no_lvds_dmi_callback,
Daniel Vettere57b6882012-02-08 16:42:52 +0100595 .ident = "AOpen i45GMx-I",
596 .matches = {
597 DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
598 DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
599 },
600 },
601 {
602 .callback = intel_no_lvds_dmi_callback,
Michael Cousinfa0864b2009-06-05 21:16:22 +0200603 .ident = "Aopen i945GTt-VFA",
604 .matches = {
605 DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
606 },
607 },
Stefan Bader9875557ee82010-03-29 17:53:12 +0200608 {
609 .callback = intel_no_lvds_dmi_callback,
610 .ident = "Clientron U800",
611 .matches = {
612 DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
613 DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
614 },
615 },
Hans de Goede6a574b52011-06-04 15:39:21 +0200616 {
Joel Sass44306ab2012-01-10 13:03:55 -0500617 .callback = intel_no_lvds_dmi_callback,
618 .ident = "Clientron E830",
619 .matches = {
620 DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
621 DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
622 },
623 },
624 {
Hans de Goede6a574b52011-06-04 15:39:21 +0200625 .callback = intel_no_lvds_dmi_callback,
626 .ident = "Asus EeeBox PC EB1007",
627 .matches = {
628 DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
629 DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
630 },
631 },
Adam Jackson0999bbe2011-11-28 12:22:56 -0500632 {
633 .callback = intel_no_lvds_dmi_callback,
634 .ident = "Asus AT5NM10T-I",
635 .matches = {
636 DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
637 DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
638 },
639 },
Marc Gariepyf5b8a7e2012-02-09 09:35:21 -0500640 {
641 .callback = intel_no_lvds_dmi_callback,
Jan-Benedict Glaw33471112012-05-22 15:21:53 +0200642 .ident = "Hewlett-Packard HP t5740e Thin Client",
643 .matches = {
644 DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
645 DMI_MATCH(DMI_PRODUCT_NAME, "HP t5740e Thin Client"),
646 },
647 },
648 {
649 .callback = intel_no_lvds_dmi_callback,
Marc Gariepyf5b8a7e2012-02-09 09:35:21 -0500650 .ident = "Hewlett-Packard t5745",
651 .matches = {
652 DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
Marc Gariepy62004972012-05-01 13:37:57 -0400653 DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
Marc Gariepyf5b8a7e2012-02-09 09:35:21 -0500654 },
655 },
656 {
657 .callback = intel_no_lvds_dmi_callback,
658 .ident = "Hewlett-Packard st5747",
659 .matches = {
660 DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
Marc Gariepy62004972012-05-01 13:37:57 -0400661 DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
Marc Gariepyf5b8a7e2012-02-09 09:35:21 -0500662 },
663 },
Anisse Astier97effad2012-03-07 18:36:35 +0100664 {
665 .callback = intel_no_lvds_dmi_callback,
666 .ident = "MSI Wind Box DC500",
667 .matches = {
668 DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
669 DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
670 },
671 },
Sjoerd Simons9756fe32012-06-22 09:43:07 +0200672 {
673 .callback = intel_no_lvds_dmi_callback,
Calvin Waltona51d4ed2012-08-24 07:56:31 -0400674 .ident = "Gigabyte GA-D525TUD",
675 .matches = {
676 DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
677 DMI_MATCH(DMI_BOARD_NAME, "D525TUD"),
678 },
679 },
Chris Wilsonc31407a2012-10-18 21:07:01 +0100680 {
681 .callback = intel_no_lvds_dmi_callback,
682 .ident = "Supermicro X7SPA-H",
683 .matches = {
684 DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
685 DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"),
686 },
687 },
Christian Lamparter9e9dd0e2013-04-03 14:34:11 +0200688 {
689 .callback = intel_no_lvds_dmi_callback,
690 .ident = "Fujitsu Esprimo Q900",
691 .matches = {
692 DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
693 DMI_MATCH(DMI_PRODUCT_NAME, "ESPRIMO Q900"),
694 },
695 },
Jarod Wilson425d2442009-05-05 10:00:25 -0400696
697 { } /* terminating entry */
698};
Jesse Barnes79e53942008-11-07 14:24:08 -0800699
700/**
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000701 * intel_find_lvds_downclock - find the reduced downclock for LVDS in EDID
702 * @dev: drm device
703 * @connector: LVDS connector
704 *
705 * Find the reduced downclock for LVDS in EDID.
706 */
707static void intel_find_lvds_downclock(struct drm_device *dev,
Chris Wilson788319d2010-09-12 17:34:41 +0100708 struct drm_display_mode *fixed_mode,
709 struct drm_connector *connector)
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000710{
711 struct drm_i915_private *dev_priv = dev->dev_private;
Chris Wilson788319d2010-09-12 17:34:41 +0100712 struct drm_display_mode *scan;
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000713 int temp_downclock;
714
Chris Wilson788319d2010-09-12 17:34:41 +0100715 temp_downclock = fixed_mode->clock;
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000716 list_for_each_entry(scan, &connector->probed_modes, head) {
717 /*
718 * If one mode has the same resolution with the fixed_panel
719 * mode while they have the different refresh rate, it means
720 * that the reduced downclock is found for the LVDS. In such
721 * case we can set the different FPx0/1 to dynamically select
722 * between low and high frequency.
723 */
Chris Wilson788319d2010-09-12 17:34:41 +0100724 if (scan->hdisplay == fixed_mode->hdisplay &&
725 scan->hsync_start == fixed_mode->hsync_start &&
726 scan->hsync_end == fixed_mode->hsync_end &&
727 scan->htotal == fixed_mode->htotal &&
728 scan->vdisplay == fixed_mode->vdisplay &&
729 scan->vsync_start == fixed_mode->vsync_start &&
730 scan->vsync_end == fixed_mode->vsync_end &&
731 scan->vtotal == fixed_mode->vtotal) {
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000732 if (scan->clock < temp_downclock) {
733 /*
734 * The downclock is already found. But we
735 * expect to find the lower downclock.
736 */
737 temp_downclock = scan->clock;
738 }
739 }
740 }
Chris Wilson788319d2010-09-12 17:34:41 +0100741 if (temp_downclock < fixed_mode->clock && i915_lvds_downclock) {
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000742 /* We found the downclock for LVDS. */
743 dev_priv->lvds_downclock_avail = 1;
744 dev_priv->lvds_downclock = temp_downclock;
745 DRM_DEBUG_KMS("LVDS downclock is found in EDID. "
Chris Wilson788319d2010-09-12 17:34:41 +0100746 "Normal clock %dKhz, downclock %dKhz\n",
747 fixed_mode->clock, temp_downclock);
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000748 }
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000749}
750
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800751/*
752 * Enumerate the child dev array parsed from VBT to check whether
753 * the LVDS is present.
754 * If it is present, return 1.
755 * If it is not present, return false.
756 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800757 */
Chris Wilson270eea02010-09-24 01:15:02 +0100758static bool lvds_is_present_in_vbt(struct drm_device *dev,
759 u8 *i2c_pin)
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800760{
761 struct drm_i915_private *dev_priv = dev->dev_private;
Chris Wilson425904d2010-08-22 18:21:42 +0100762 int i;
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800763
Rodrigo Vivi41aa3442013-05-09 20:03:18 -0300764 if (!dev_priv->vbt.child_dev_num)
Chris Wilson425904d2010-08-22 18:21:42 +0100765 return true;
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800766
Rodrigo Vivi41aa3442013-05-09 20:03:18 -0300767 for (i = 0; i < dev_priv->vbt.child_dev_num; i++) {
768 struct child_device_config *child = dev_priv->vbt.child_dev + i;
Chris Wilson425904d2010-08-22 18:21:42 +0100769
770 /* If the device type is not LFP, continue.
771 * We have to check both the new identifiers as well as the
772 * old for compatibility with some BIOSes.
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800773 */
Chris Wilson425904d2010-08-22 18:21:42 +0100774 if (child->device_type != DEVICE_TYPE_INT_LFP &&
775 child->device_type != DEVICE_TYPE_LFP)
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800776 continue;
777
Daniel Kurtz3bd7d902012-03-28 02:36:14 +0800778 if (intel_gmbus_is_port_valid(child->i2c_pin))
779 *i2c_pin = child->i2c_pin;
Chris Wilson270eea02010-09-24 01:15:02 +0100780
Chris Wilson425904d2010-08-22 18:21:42 +0100781 /* However, we cannot trust the BIOS writers to populate
782 * the VBT correctly. Since LVDS requires additional
783 * information from AIM blocks, a non-zero addin offset is
784 * a good indicator that the LVDS is actually present.
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800785 */
Chris Wilson425904d2010-08-22 18:21:42 +0100786 if (child->addin_offset)
787 return true;
788
789 /* But even then some BIOS writers perform some black magic
790 * and instantiate the device without reference to any
791 * additional data. Trust that if the VBT was written into
792 * the OpRegion then they have validated the LVDS's existence.
793 */
794 if (dev_priv->opregion.vbt)
795 return true;
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800796 }
Chris Wilson425904d2010-08-22 18:21:42 +0100797
798 return false;
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800799}
800
Daniel Vetter1974cad2012-11-26 17:22:09 +0100801static int intel_dual_link_lvds_callback(const struct dmi_system_id *id)
802{
803 DRM_INFO("Forcing lvds to dual link mode on %s\n", id->ident);
804 return 1;
805}
806
807static const struct dmi_system_id intel_dual_link_lvds[] = {
808 {
809 .callback = intel_dual_link_lvds_callback,
810 .ident = "Apple MacBook Pro (Core i5/i7 Series)",
811 .matches = {
812 DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
813 DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro8,2"),
814 },
815 },
816 { } /* terminating entry */
817};
818
819bool intel_is_dual_link_lvds(struct drm_device *dev)
820{
Daniel Vetter13c7d872012-11-26 17:22:10 +0100821 struct intel_encoder *encoder;
822 struct intel_lvds_encoder *lvds_encoder;
823
824 list_for_each_entry(encoder, &dev->mode_config.encoder_list,
825 base.head) {
826 if (encoder->type == INTEL_OUTPUT_LVDS) {
827 lvds_encoder = to_lvds_encoder(&encoder->base);
828
829 return lvds_encoder->is_dual_link;
830 }
831 }
832
833 return false;
834}
835
Daniel Vetter7dec0602012-09-11 14:12:25 +0200836static bool compute_is_dual_link_lvds(struct intel_lvds_encoder *lvds_encoder)
Daniel Vetter13c7d872012-11-26 17:22:10 +0100837{
Daniel Vetter7dec0602012-09-11 14:12:25 +0200838 struct drm_device *dev = lvds_encoder->base.base.dev;
Daniel Vetter1974cad2012-11-26 17:22:09 +0100839 unsigned int val;
840 struct drm_i915_private *dev_priv = dev->dev_private;
Daniel Vetter1974cad2012-11-26 17:22:09 +0100841
842 /* use the module option value if specified */
843 if (i915_lvds_channel_mode > 0)
844 return i915_lvds_channel_mode == 2;
845
846 if (dmi_check_system(intel_dual_link_lvds))
847 return true;
848
Daniel Vetter13c7d872012-11-26 17:22:10 +0100849 /* BIOS should set the proper LVDS register value at boot, but
850 * in reality, it doesn't set the value when the lid is closed;
851 * we need to check "the value to be set" in VBT when LVDS
852 * register is uninitialized.
853 */
Daniel Vetter7dec0602012-09-11 14:12:25 +0200854 val = I915_READ(lvds_encoder->reg);
Daniel Vetter13c7d872012-11-26 17:22:10 +0100855 if (!(val & ~(LVDS_PIPE_MASK | LVDS_DETECTED)))
Rodrigo Vivi41aa3442013-05-09 20:03:18 -0300856 val = dev_priv->vbt.bios_lvds_val;
Daniel Vetter13c7d872012-11-26 17:22:10 +0100857
Daniel Vetter1974cad2012-11-26 17:22:09 +0100858 return (val & LVDS_CLKB_POWER_MASK) == LVDS_CLKB_POWER_UP;
859}
860
Chris Wilsonf3cfcba2012-02-09 09:35:53 +0000861static bool intel_lvds_supported(struct drm_device *dev)
862{
863 /* With the introduction of the PCH we gained a dedicated
864 * LVDS presence pin, use it. */
Paulo Zanoni311e3592013-03-06 20:03:19 -0300865 if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
Chris Wilsonf3cfcba2012-02-09 09:35:53 +0000866 return true;
867
868 /* Otherwise LVDS was only attached to mobile products,
869 * except for the inglorious 830gm */
Paulo Zanoni311e3592013-03-06 20:03:19 -0300870 if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev))
871 return true;
872
873 return false;
Chris Wilsonf3cfcba2012-02-09 09:35:53 +0000874}
875
Zhao Yakui18f9ed12009-11-20 03:24:16 +0000876/**
Jesse Barnes79e53942008-11-07 14:24:08 -0800877 * intel_lvds_init - setup LVDS connectors on this device
878 * @dev: drm device
879 *
880 * Create the connector, register the LVDS DDC bus, and try to figure out what
881 * modes we can display on the LVDS panel (if present).
882 */
Chris Wilsonc5d1b512010-11-29 18:00:23 +0000883bool intel_lvds_init(struct drm_device *dev)
Jesse Barnes79e53942008-11-07 14:24:08 -0800884{
885 struct drm_i915_private *dev_priv = dev->dev_private;
Jani Nikula29b99b42012-10-19 14:51:43 +0300886 struct intel_lvds_encoder *lvds_encoder;
Eric Anholt21d40d32010-03-25 11:11:14 -0700887 struct intel_encoder *intel_encoder;
Jani Nikulac7362c42012-10-19 14:51:44 +0300888 struct intel_lvds_connector *lvds_connector;
Zhenyu Wangbb8a3562010-03-29 16:40:50 +0800889 struct intel_connector *intel_connector;
Jesse Barnes79e53942008-11-07 14:24:08 -0800890 struct drm_connector *connector;
891 struct drm_encoder *encoder;
892 struct drm_display_mode *scan; /* *modes, *bios_mode; */
Jani Nikuladd06f902012-10-19 14:51:50 +0300893 struct drm_display_mode *fixed_mode = NULL;
Jani Nikula9cd300e2012-10-19 14:51:52 +0300894 struct edid *edid;
Jesse Barnes79e53942008-11-07 14:24:08 -0800895 struct drm_crtc *crtc;
896 u32 lvds;
Chris Wilson270eea02010-09-24 01:15:02 +0100897 int pipe;
898 u8 pin;
Jesse Barnes79e53942008-11-07 14:24:08 -0800899
Chris Wilsonf3cfcba2012-02-09 09:35:53 +0000900 if (!intel_lvds_supported(dev))
901 return false;
902
Jarod Wilson425d2442009-05-05 10:00:25 -0400903 /* Skip init on machines we know falsely report LVDS */
904 if (dmi_check_system(intel_no_lvds))
Chris Wilsonc5d1b512010-11-29 18:00:23 +0000905 return false;
Paul Collins565dcd42009-02-04 23:05:41 +1300906
Chris Wilson270eea02010-09-24 01:15:02 +0100907 pin = GMBUS_PORT_PANEL;
908 if (!lvds_is_present_in_vbt(dev, &pin)) {
Matthew Garrett11ba1592009-12-15 13:55:24 -0500909 DRM_DEBUG_KMS("LVDS is not present in VBT\n");
Chris Wilsonc5d1b512010-11-29 18:00:23 +0000910 return false;
Zhao Yakui7cf4f692009-11-24 09:48:47 +0800911 }
Zhao Yakuie99da352009-06-26 09:46:18 +0800912
Eric Anholtc619eed2010-01-28 16:45:52 -0800913 if (HAS_PCH_SPLIT(dev)) {
Zhenyu Wang541998a2009-06-05 15:38:44 +0800914 if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
Chris Wilsonc5d1b512010-11-29 18:00:23 +0000915 return false;
Rodrigo Vivi41aa3442013-05-09 20:03:18 -0300916 if (dev_priv->vbt.edp_support) {
Zhao Yakui28c97732009-10-09 11:39:41 +0800917 DRM_DEBUG_KMS("disable LVDS for eDP support\n");
Chris Wilsonc5d1b512010-11-29 18:00:23 +0000918 return false;
Zhenyu Wang32f9d652009-07-24 01:00:32 +0800919 }
Zhenyu Wang541998a2009-06-05 15:38:44 +0800920 }
921
Jani Nikula29b99b42012-10-19 14:51:43 +0300922 lvds_encoder = kzalloc(sizeof(struct intel_lvds_encoder), GFP_KERNEL);
923 if (!lvds_encoder)
Chris Wilsonc5d1b512010-11-29 18:00:23 +0000924 return false;
Jesse Barnes79e53942008-11-07 14:24:08 -0800925
Jani Nikulac7362c42012-10-19 14:51:44 +0300926 lvds_connector = kzalloc(sizeof(struct intel_lvds_connector), GFP_KERNEL);
927 if (!lvds_connector) {
Jani Nikula29b99b42012-10-19 14:51:43 +0300928 kfree(lvds_encoder);
Jesse Barnes79e53942008-11-07 14:24:08 -0800929 return false;
930 }
931
Jani Nikula62165e02012-10-19 14:51:47 +0300932 lvds_encoder->attached_connector = lvds_connector;
Zhenyu Wangbb8a3562010-03-29 16:40:50 +0800933
Jani Nikula29b99b42012-10-19 14:51:43 +0300934 intel_encoder = &lvds_encoder->base;
Chris Wilson4ef69c72010-09-09 15:14:28 +0100935 encoder = &intel_encoder->base;
Jani Nikulac7362c42012-10-19 14:51:44 +0300936 intel_connector = &lvds_connector->base;
Chris Wilsonea5b2132010-08-04 13:50:23 +0100937 connector = &intel_connector->base;
Zhenyu Wangbb8a3562010-03-29 16:40:50 +0800938 drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
Jesse Barnes79e53942008-11-07 14:24:08 -0800939 DRM_MODE_CONNECTOR_LVDS);
940
Chris Wilson4ef69c72010-09-09 15:14:28 +0100941 drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
Jesse Barnes79e53942008-11-07 14:24:08 -0800942 DRM_MODE_ENCODER_LVDS);
943
Daniel Vetterc22834e2012-06-30 15:31:28 +0200944 intel_encoder->enable = intel_enable_lvds;
Daniel Vetterfc683092012-11-26 17:22:12 +0100945 intel_encoder->pre_pll_enable = intel_pre_pll_enable_lvds;
Daniel Vetter7ae89232013-03-27 00:44:52 +0100946 intel_encoder->compute_config = intel_lvds_compute_config;
Daniel Vetterc22834e2012-06-30 15:31:28 +0200947 intel_encoder->disable = intel_disable_lvds;
Daniel Vetterb1dc3322012-07-02 21:09:00 +0200948 intel_encoder->get_hw_state = intel_lvds_get_hw_state;
Jesse Barnes045ac3b2013-05-14 17:08:26 -0700949 intel_encoder->get_config = intel_lvds_get_config;
Daniel Vetterb1dc3322012-07-02 21:09:00 +0200950 intel_connector->get_hw_state = intel_connector_get_hw_state;
Daniel Vetterc22834e2012-06-30 15:31:28 +0200951
Chris Wilsondf0e9242010-09-09 16:20:55 +0100952 intel_connector_attach_encoder(intel_connector, intel_encoder);
Eric Anholt21d40d32010-03-25 11:11:14 -0700953 intel_encoder->type = INTEL_OUTPUT_LVDS;
Jesse Barnes79e53942008-11-07 14:24:08 -0800954
Daniel Vetter66a92782012-07-12 20:08:18 +0200955 intel_encoder->cloneable = false;
Jesse Barnes27f82272011-09-02 12:54:37 -0700956 if (HAS_PCH_SPLIT(dev))
957 intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
Daniel Vetter0b9f43a2012-06-05 10:07:11 +0200958 else if (IS_GEN4(dev))
959 intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
Jesse Barnes27f82272011-09-02 12:54:37 -0700960 else
961 intel_encoder->crtc_mask = (1 << 1);
962
Jesse Barnes79e53942008-11-07 14:24:08 -0800963 drm_encoder_helper_add(encoder, &intel_lvds_helper_funcs);
964 drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
965 connector->display_info.subpixel_order = SubPixelHorizontalRGB;
966 connector->interlace_allowed = false;
967 connector->doublescan_allowed = false;
968
Daniel Vetter7dec0602012-09-11 14:12:25 +0200969 if (HAS_PCH_SPLIT(dev)) {
970 lvds_encoder->reg = PCH_LVDS;
971 } else {
972 lvds_encoder->reg = LVDS;
973 }
974
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800975 /* create the scaling mode property */
976 drm_mode_create_scaling_mode_property(dev);
Rob Clark662595d2012-10-11 20:36:04 -0500977 drm_object_attach_property(&connector->base,
Zhao Yakui3fbe18d2009-06-22 15:31:25 +0800978 dev->mode_config.scaling_mode_property,
Jesse Barnesdd1ea372010-06-24 11:05:10 -0700979 DRM_MODE_SCALE_ASPECT);
Jani Nikula4d891522012-10-26 12:03:59 +0300980 intel_connector->panel.fitting_mode = DRM_MODE_SCALE_ASPECT;
Jesse Barnes79e53942008-11-07 14:24:08 -0800981 /*
982 * LVDS discovery:
983 * 1) check for EDID on DDC
984 * 2) check for VBT data
985 * 3) check to see if LVDS is already on
986 * if none of the above, no panel
987 * 4) make sure lid is open
988 * if closed, act like it's not there for now
989 */
990
Jesse Barnes79e53942008-11-07 14:24:08 -0800991 /*
992 * Attempt to get the fixed panel mode from DDC. Assume that the
993 * preferred mode is the right one.
994 */
Jani Nikula9cd300e2012-10-19 14:51:52 +0300995 edid = drm_get_edid(connector, intel_gmbus_get_adapter(dev_priv, pin));
996 if (edid) {
997 if (drm_add_edid_modes(connector, edid)) {
Chris Wilson3f8ff0e2010-11-08 23:20:52 +0000998 drm_mode_connector_update_edid_property(connector,
Jani Nikula9cd300e2012-10-19 14:51:52 +0300999 edid);
Chris Wilson3f8ff0e2010-11-08 23:20:52 +00001000 } else {
Jani Nikula9cd300e2012-10-19 14:51:52 +03001001 kfree(edid);
1002 edid = ERR_PTR(-EINVAL);
Chris Wilson3f8ff0e2010-11-08 23:20:52 +00001003 }
Jani Nikula9cd300e2012-10-19 14:51:52 +03001004 } else {
1005 edid = ERR_PTR(-ENOENT);
Chris Wilson3f8ff0e2010-11-08 23:20:52 +00001006 }
Jani Nikula9cd300e2012-10-19 14:51:52 +03001007 lvds_connector->base.edid = edid;
1008
1009 if (IS_ERR_OR_NULL(edid)) {
Chris Wilson788319d2010-09-12 17:34:41 +01001010 /* Didn't get an EDID, so
1011 * Set wide sync ranges so we get all modes
1012 * handed to valid_mode for checking
1013 */
1014 connector->display_info.min_vfreq = 0;
1015 connector->display_info.max_vfreq = 200;
1016 connector->display_info.min_hfreq = 0;
1017 connector->display_info.max_hfreq = 200;
1018 }
Jesse Barnes79e53942008-11-07 14:24:08 -08001019
1020 list_for_each_entry(scan, &connector->probed_modes, head) {
Jesse Barnes79e53942008-11-07 14:24:08 -08001021 if (scan->type & DRM_MODE_TYPE_PREFERRED) {
Chris Wilson6a9d51b2012-11-21 16:14:03 +00001022 DRM_DEBUG_KMS("using preferred mode from EDID: ");
1023 drm_mode_debug_printmodeline(scan);
1024
Jani Nikuladd06f902012-10-19 14:51:50 +03001025 fixed_mode = drm_mode_duplicate(dev, scan);
Chris Wilson6a9d51b2012-11-21 16:14:03 +00001026 if (fixed_mode) {
1027 intel_find_lvds_downclock(dev, fixed_mode,
1028 connector);
1029 goto out;
1030 }
Jesse Barnes79e53942008-11-07 14:24:08 -08001031 }
Jesse Barnes79e53942008-11-07 14:24:08 -08001032 }
1033
1034 /* Failed to get EDID, what about VBT? */
Rodrigo Vivi41aa3442013-05-09 20:03:18 -03001035 if (dev_priv->vbt.lfp_lvds_vbt_mode) {
Chris Wilson6a9d51b2012-11-21 16:14:03 +00001036 DRM_DEBUG_KMS("using mode from VBT: ");
Rodrigo Vivi41aa3442013-05-09 20:03:18 -03001037 drm_mode_debug_printmodeline(dev_priv->vbt.lfp_lvds_vbt_mode);
Chris Wilson6a9d51b2012-11-21 16:14:03 +00001038
Rodrigo Vivi41aa3442013-05-09 20:03:18 -03001039 fixed_mode = drm_mode_duplicate(dev, dev_priv->vbt.lfp_lvds_vbt_mode);
Jani Nikuladd06f902012-10-19 14:51:50 +03001040 if (fixed_mode) {
1041 fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
Jesse Barnese285f3cd2009-01-14 10:53:36 -08001042 goto out;
1043 }
Jesse Barnes79e53942008-11-07 14:24:08 -08001044 }
1045
1046 /*
1047 * If we didn't get EDID, try checking if the panel is already turned
1048 * on. If so, assume that whatever is currently programmed is the
1049 * correct mode.
1050 */
Zhenyu Wang541998a2009-06-05 15:38:44 +08001051
Adam Jacksonf2b115e2009-12-03 17:14:42 -05001052 /* Ironlake: FIXME if still fail, not try pipe mode now */
Eric Anholtc619eed2010-01-28 16:45:52 -08001053 if (HAS_PCH_SPLIT(dev))
Zhenyu Wang541998a2009-06-05 15:38:44 +08001054 goto failed;
1055
Jesse Barnes79e53942008-11-07 14:24:08 -08001056 lvds = I915_READ(LVDS);
1057 pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
Chris Wilsonf875c152010-09-09 15:44:14 +01001058 crtc = intel_get_crtc_for_pipe(dev, pipe);
Jesse Barnes79e53942008-11-07 14:24:08 -08001059
1060 if (crtc && (lvds & LVDS_PORT_EN)) {
Jani Nikuladd06f902012-10-19 14:51:50 +03001061 fixed_mode = intel_crtc_mode_get(dev, crtc);
1062 if (fixed_mode) {
Chris Wilson6a9d51b2012-11-21 16:14:03 +00001063 DRM_DEBUG_KMS("using current (BIOS) mode: ");
1064 drm_mode_debug_printmodeline(fixed_mode);
Jani Nikuladd06f902012-10-19 14:51:50 +03001065 fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
Paul Collins565dcd42009-02-04 23:05:41 +13001066 goto out;
Jesse Barnes79e53942008-11-07 14:24:08 -08001067 }
1068 }
1069
1070 /* If we still don't have a mode after all that, give up. */
Jani Nikuladd06f902012-10-19 14:51:50 +03001071 if (!fixed_mode)
Jesse Barnes79e53942008-11-07 14:24:08 -08001072 goto failed;
1073
Jesse Barnes79e53942008-11-07 14:24:08 -08001074out:
Daniel Vetter7dec0602012-09-11 14:12:25 +02001075 lvds_encoder->is_dual_link = compute_is_dual_link_lvds(lvds_encoder);
Daniel Vetter13c7d872012-11-26 17:22:10 +01001076 DRM_DEBUG_KMS("detected %s-link lvds configuration\n",
1077 lvds_encoder->is_dual_link ? "dual" : "single");
1078
Daniel Vetter24ded202012-06-05 12:14:54 +02001079 /*
1080 * Unlock registers and just
1081 * leave them unlocked
1082 */
Eric Anholtc619eed2010-01-28 16:45:52 -08001083 if (HAS_PCH_SPLIT(dev)) {
Keith Packarded10fca2011-08-06 10:33:12 -07001084 I915_WRITE(PCH_PP_CONTROL,
1085 I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
1086 } else {
Keith Packarded10fca2011-08-06 10:33:12 -07001087 I915_WRITE(PP_CONTROL,
1088 I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
Zhenyu Wang541998a2009-06-05 15:38:44 +08001089 }
Jani Nikuladb1740a2012-10-19 14:51:45 +03001090 lvds_connector->lid_notifier.notifier_call = intel_lid_notify;
1091 if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) {
Zhao Yakui28c97732009-10-09 11:39:41 +08001092 DRM_DEBUG_KMS("lid notifier registration failed\n");
Jani Nikuladb1740a2012-10-19 14:51:45 +03001093 lvds_connector->lid_notifier.notifier_call = NULL;
Jesse Barnesc1c7af62009-09-10 15:28:03 -07001094 }
Jesse Barnes79e53942008-11-07 14:24:08 -08001095 drm_sysfs_connector_add(connector);
Matthew Garrettaaa6fd22011-08-12 12:11:33 +02001096
Jani Nikuladd06f902012-10-19 14:51:50 +03001097 intel_panel_init(&intel_connector->panel, fixed_mode);
Jani Nikula0657b6b2012-10-19 14:51:46 +03001098 intel_panel_setup_backlight(connector);
Matthew Garrettaaa6fd22011-08-12 12:11:33 +02001099
Chris Wilsonc5d1b512010-11-29 18:00:23 +00001100 return true;
Jesse Barnes79e53942008-11-07 14:24:08 -08001101
1102failed:
Zhao Yakui8a4c47f2009-07-20 13:48:04 +08001103 DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
Jesse Barnes79e53942008-11-07 14:24:08 -08001104 drm_connector_cleanup(connector);
Shaohua Li1991bdf2009-11-17 17:19:23 +08001105 drm_encoder_cleanup(encoder);
Jani Nikuladd06f902012-10-19 14:51:50 +03001106 if (fixed_mode)
1107 drm_mode_destroy(dev, fixed_mode);
Jani Nikula29b99b42012-10-19 14:51:43 +03001108 kfree(lvds_encoder);
Jani Nikulac7362c42012-10-19 14:51:44 +03001109 kfree(lvds_connector);
Chris Wilsonc5d1b512010-11-29 18:00:23 +00001110 return false;
Jesse Barnes79e53942008-11-07 14:24:08 -08001111}