blob: 83bbc271bcfb5e92e1321a5a5842ea1fab26830a [file] [log] [blame]
Alan Cox1b082cc2011-11-03 18:22:26 +00001/*
2 * Copyright © 2006-2009 Intel Corporation
3 *
4 * This program is free software; you can redistribute it and/or modify it
5 * under the terms and conditions of the GNU General Public License,
6 * version 2, as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope it will be useful, but WITHOUT
9 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
11 * more details.
12 *
13 * You should have received a copy of the GNU General Public License along with
14 * this program; if not, write to the Free Software Foundation, Inc.,
15 * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
16 *
17 * Authors:
18 * Eric Anholt <eric@anholt.net>
19 * Dave Airlie <airlied@linux.ie>
20 * Jesse Barnes <jesse.barnes@intel.com>
21 */
22
23#include <linux/i2c.h>
24#include <drm/drmP.h>
Kuppuswamy Sathyanarayanan05454c22013-10-17 15:35:27 -070025#include <asm/intel-mid.h>
Alan Cox1b082cc2011-11-03 18:22:26 +000026
27#include "intel_bios.h"
28#include "psb_drv.h"
29#include "psb_intel_drv.h"
30#include "psb_intel_reg.h"
31#include "power.h"
32#include <linux/pm_runtime.h>
33
34/* The max/min PWM frequency in BPCR[31:17] - */
35/* The smallest number is 1 (not 0) that can fit in the
36 * 15-bit field of the and then*/
37/* shifts to the left by one bit to get the actual 16-bit
38 * value that the 15-bits correspond to.*/
39#define MRST_BLC_MAX_PWM_REG_FREQ 0xFFFF
40#define BRIGHTNESS_MAX_LEVEL 100
41
42/**
43 * Sets the power state for the panel.
44 */
45static void oaktrail_lvds_set_power(struct drm_device *dev,
Patrik Jakobsson367e4402013-07-22 17:45:26 +020046 struct gma_encoder *gma_encoder,
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +000047 bool on)
Alan Cox1b082cc2011-11-03 18:22:26 +000048{
49 u32 pp_status;
50 struct drm_psb_private *dev_priv = dev->dev_private;
51
52 if (!gma_power_begin(dev, true))
53 return;
54
55 if (on) {
56 REG_WRITE(PP_CONTROL, REG_READ(PP_CONTROL) |
57 POWER_TARGET_ON);
58 do {
59 pp_status = REG_READ(PP_STATUS);
60 } while ((pp_status & (PP_ON | PP_READY)) == PP_READY);
61 dev_priv->is_lvds_on = true;
62 if (dev_priv->ops->lvds_bl_power)
63 dev_priv->ops->lvds_bl_power(dev, true);
64 } else {
65 if (dev_priv->ops->lvds_bl_power)
66 dev_priv->ops->lvds_bl_power(dev, false);
67 REG_WRITE(PP_CONTROL, REG_READ(PP_CONTROL) &
68 ~POWER_TARGET_ON);
69 do {
70 pp_status = REG_READ(PP_STATUS);
71 } while (pp_status & PP_ON);
72 dev_priv->is_lvds_on = false;
73 pm_request_idle(&dev->pdev->dev);
74 }
75 gma_power_end(dev);
76}
77
78static void oaktrail_lvds_dpms(struct drm_encoder *encoder, int mode)
79{
80 struct drm_device *dev = encoder->dev;
Patrik Jakobsson367e4402013-07-22 17:45:26 +020081 struct gma_encoder *gma_encoder = to_gma_encoder(encoder);
Alan Cox1b082cc2011-11-03 18:22:26 +000082
83 if (mode == DRM_MODE_DPMS_ON)
Patrik Jakobsson367e4402013-07-22 17:45:26 +020084 oaktrail_lvds_set_power(dev, gma_encoder, true);
Alan Cox1b082cc2011-11-03 18:22:26 +000085 else
Patrik Jakobsson367e4402013-07-22 17:45:26 +020086 oaktrail_lvds_set_power(dev, gma_encoder, false);
Alan Cox1b082cc2011-11-03 18:22:26 +000087
88 /* XXX: We never power down the LVDS pairs. */
89}
90
91static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
92 struct drm_display_mode *mode,
93 struct drm_display_mode *adjusted_mode)
94{
Alan Cox1b082cc2011-11-03 18:22:26 +000095 struct drm_device *dev = encoder->dev;
96 struct drm_psb_private *dev_priv = dev->dev_private;
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +000097 struct psb_intel_mode_device *mode_dev = &dev_priv->mode_dev;
98 struct drm_mode_config *mode_config = &dev->mode_config;
99 struct drm_connector *connector = NULL;
100 struct drm_crtc *crtc = encoder->crtc;
Alan Cox1b082cc2011-11-03 18:22:26 +0000101 u32 lvds_port;
102 uint64_t v = DRM_MODE_SCALE_FULLSCREEN;
103
104 if (!gma_power_begin(dev, true))
105 return;
106
107 /*
108 * The LVDS pin pair will already have been turned on in the
109 * psb_intel_crtc_mode_set since it has a large impact on the DPLL
110 * settings.
111 */
112 lvds_port = (REG_READ(LVDS) &
113 (~LVDS_PIPEB_SELECT)) |
114 LVDS_PORT_EN |
115 LVDS_BORDER_EN;
116
117 /* If the firmware says dither on Moorestown, or the BIOS does
118 on Oaktrail then enable dithering */
119 if (mode_dev->panel_wants_dither || dev_priv->lvds_dither)
120 lvds_port |= MRST_PANEL_8TO6_DITHER_ENABLE;
121
122 REG_WRITE(LVDS, lvds_port);
123
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000124 /* Find the connector we're trying to set up */
125 list_for_each_entry(connector, &mode_config->connector_list, head) {
126 if (!connector->encoder || connector->encoder->crtc != crtc)
127 continue;
128 }
129
130 if (!connector) {
131 DRM_ERROR("Couldn't find connector when setting mode");
132 return;
133 }
134
Rob Clarka69ac9e2012-10-11 20:38:23 -0500135 drm_object_property_get_value(
136 &connector->base,
Alan Cox1b082cc2011-11-03 18:22:26 +0000137 dev->mode_config.scaling_mode_property,
138 &v);
139
140 if (v == DRM_MODE_SCALE_NO_SCALE)
141 REG_WRITE(PFIT_CONTROL, 0);
142 else if (v == DRM_MODE_SCALE_ASPECT) {
143 if ((mode->vdisplay != adjusted_mode->crtc_vdisplay) ||
144 (mode->hdisplay != adjusted_mode->crtc_hdisplay)) {
145 if ((adjusted_mode->crtc_hdisplay * mode->vdisplay) ==
146 (mode->hdisplay * adjusted_mode->crtc_vdisplay))
147 REG_WRITE(PFIT_CONTROL, PFIT_ENABLE);
148 else if ((adjusted_mode->crtc_hdisplay *
149 mode->vdisplay) > (mode->hdisplay *
150 adjusted_mode->crtc_vdisplay))
151 REG_WRITE(PFIT_CONTROL, PFIT_ENABLE |
152 PFIT_SCALING_MODE_PILLARBOX);
153 else
154 REG_WRITE(PFIT_CONTROL, PFIT_ENABLE |
155 PFIT_SCALING_MODE_LETTERBOX);
156 } else
157 REG_WRITE(PFIT_CONTROL, PFIT_ENABLE);
158 } else /*(v == DRM_MODE_SCALE_FULLSCREEN)*/
159 REG_WRITE(PFIT_CONTROL, PFIT_ENABLE);
160
161 gma_power_end(dev);
162}
163
164static void oaktrail_lvds_prepare(struct drm_encoder *encoder)
165{
166 struct drm_device *dev = encoder->dev;
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000167 struct drm_psb_private *dev_priv = dev->dev_private;
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200168 struct gma_encoder *gma_encoder = to_gma_encoder(encoder);
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000169 struct psb_intel_mode_device *mode_dev = &dev_priv->mode_dev;
Alan Cox1b082cc2011-11-03 18:22:26 +0000170
171 if (!gma_power_begin(dev, true))
172 return;
173
174 mode_dev->saveBLC_PWM_CTL = REG_READ(BLC_PWM_CTL);
175 mode_dev->backlight_duty_cycle = (mode_dev->saveBLC_PWM_CTL &
176 BACKLIGHT_DUTY_CYCLE_MASK);
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200177 oaktrail_lvds_set_power(dev, gma_encoder, false);
Alan Cox1b082cc2011-11-03 18:22:26 +0000178 gma_power_end(dev);
179}
180
181static u32 oaktrail_lvds_get_max_backlight(struct drm_device *dev)
182{
183 struct drm_psb_private *dev_priv = dev->dev_private;
184 u32 ret;
185
186 if (gma_power_begin(dev, false)) {
187 ret = ((REG_READ(BLC_PWM_CTL) &
188 BACKLIGHT_MODULATION_FREQ_MASK) >>
189 BACKLIGHT_MODULATION_FREQ_SHIFT) * 2;
190
191 gma_power_end(dev);
192 } else
Alan Cox648a8e32012-03-08 16:00:31 +0000193 ret = ((dev_priv->regs.saveBLC_PWM_CTL &
Alan Cox1b082cc2011-11-03 18:22:26 +0000194 BACKLIGHT_MODULATION_FREQ_MASK) >>
195 BACKLIGHT_MODULATION_FREQ_SHIFT) * 2;
196
197 return ret;
198}
199
200static void oaktrail_lvds_commit(struct drm_encoder *encoder)
201{
202 struct drm_device *dev = encoder->dev;
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000203 struct drm_psb_private *dev_priv = dev->dev_private;
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200204 struct gma_encoder *gma_encoder = to_gma_encoder(encoder);
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000205 struct psb_intel_mode_device *mode_dev = &dev_priv->mode_dev;
Alan Cox1b082cc2011-11-03 18:22:26 +0000206
207 if (mode_dev->backlight_duty_cycle == 0)
208 mode_dev->backlight_duty_cycle =
209 oaktrail_lvds_get_max_backlight(dev);
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200210 oaktrail_lvds_set_power(dev, gma_encoder, true);
Alan Cox1b082cc2011-11-03 18:22:26 +0000211}
212
213static const struct drm_encoder_helper_funcs oaktrail_lvds_helper_funcs = {
214 .dpms = oaktrail_lvds_dpms,
215 .mode_fixup = psb_intel_lvds_mode_fixup,
216 .prepare = oaktrail_lvds_prepare,
217 .mode_set = oaktrail_lvds_mode_set,
218 .commit = oaktrail_lvds_commit,
219};
220
Alan Cox1b082cc2011-11-03 18:22:26 +0000221/* Returns the panel fixed mode from configuration. */
222
Alan Cox1b22edf2011-11-29 22:27:57 +0000223static void oaktrail_lvds_get_configuration_mode(struct drm_device *dev,
224 struct psb_intel_mode_device *mode_dev)
Alan Cox1b082cc2011-11-03 18:22:26 +0000225{
226 struct drm_display_mode *mode = NULL;
227 struct drm_psb_private *dev_priv = dev->dev_private;
228 struct oaktrail_timing_info *ti = &dev_priv->gct_data.DTD;
229
Alan Cox1b22edf2011-11-29 22:27:57 +0000230 mode_dev->panel_fixed_mode = NULL;
231
232 /* Use the firmware provided data on Moorestown */
Kirill A. Shutemov4086b1e2012-05-03 16:27:21 +0100233 if (dev_priv->has_gct) {
Alan Cox1b082cc2011-11-03 18:22:26 +0000234 mode = kzalloc(sizeof(*mode), GFP_KERNEL);
235 if (!mode)
Alan Cox1b22edf2011-11-29 22:27:57 +0000236 return;
Alan Cox1b082cc2011-11-03 18:22:26 +0000237
238 mode->hdisplay = (ti->hactive_hi << 8) | ti->hactive_lo;
239 mode->vdisplay = (ti->vactive_hi << 8) | ti->vactive_lo;
240 mode->hsync_start = mode->hdisplay + \
241 ((ti->hsync_offset_hi << 8) | \
242 ti->hsync_offset_lo);
243 mode->hsync_end = mode->hsync_start + \
244 ((ti->hsync_pulse_width_hi << 8) | \
245 ti->hsync_pulse_width_lo);
246 mode->htotal = mode->hdisplay + ((ti->hblank_hi << 8) | \
247 ti->hblank_lo);
248 mode->vsync_start = \
249 mode->vdisplay + ((ti->vsync_offset_hi << 4) | \
250 ti->vsync_offset_lo);
251 mode->vsync_end = \
252 mode->vsync_start + ((ti->vsync_pulse_width_hi << 4) | \
253 ti->vsync_pulse_width_lo);
254 mode->vtotal = mode->vdisplay + \
255 ((ti->vblank_hi << 8) | ti->vblank_lo);
256 mode->clock = ti->pixel_clock * 10;
257#if 0
258 printk(KERN_INFO "hdisplay is %d\n", mode->hdisplay);
259 printk(KERN_INFO "vdisplay is %d\n", mode->vdisplay);
260 printk(KERN_INFO "HSS is %d\n", mode->hsync_start);
261 printk(KERN_INFO "HSE is %d\n", mode->hsync_end);
262 printk(KERN_INFO "htotal is %d\n", mode->htotal);
263 printk(KERN_INFO "VSS is %d\n", mode->vsync_start);
264 printk(KERN_INFO "VSE is %d\n", mode->vsync_end);
265 printk(KERN_INFO "vtotal is %d\n", mode->vtotal);
266 printk(KERN_INFO "clock is %d\n", mode->clock);
267#endif
Alan Cox1b22edf2011-11-29 22:27:57 +0000268 mode_dev->panel_fixed_mode = mode;
269 }
Alan Cox1b082cc2011-11-03 18:22:26 +0000270
Alan Cox1b22edf2011-11-29 22:27:57 +0000271 /* Use the BIOS VBT mode if available */
272 if (mode_dev->panel_fixed_mode == NULL && mode_dev->vbt_mode)
273 mode_dev->panel_fixed_mode = drm_mode_duplicate(dev,
274 mode_dev->vbt_mode);
Alan Cox1b082cc2011-11-03 18:22:26 +0000275
Alan Cox1b22edf2011-11-29 22:27:57 +0000276 /* Then try the LVDS VBT mode */
277 if (mode_dev->panel_fixed_mode == NULL)
278 if (dev_priv->lfp_lvds_vbt_mode)
279 mode_dev->panel_fixed_mode =
280 drm_mode_duplicate(dev,
281 dev_priv->lfp_lvds_vbt_mode);
Patrik Jakobsson49a5d872013-11-08 16:00:33 +0100282
283 /* If we still got no mode then bail */
Alan Cox1b22edf2011-11-29 22:27:57 +0000284 if (mode_dev->panel_fixed_mode == NULL)
Patrik Jakobsson49a5d872013-11-08 16:00:33 +0100285 return;
Alan Cox1b22edf2011-11-29 22:27:57 +0000286
287 drm_mode_set_name(mode_dev->panel_fixed_mode);
288 drm_mode_set_crtcinfo(mode_dev->panel_fixed_mode, 0);
Alan Cox1b082cc2011-11-03 18:22:26 +0000289}
290
291/**
292 * oaktrail_lvds_init - setup LVDS connectors on this device
293 * @dev: drm device
294 *
295 * Create the connector, register the LVDS DDC bus, and try to figure out what
296 * modes we can display on the LVDS panel (if present).
297 */
298void oaktrail_lvds_init(struct drm_device *dev,
299 struct psb_intel_mode_device *mode_dev)
300{
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200301 struct gma_encoder *gma_encoder;
Patrik Jakobssona3d5d752013-07-22 17:05:25 +0200302 struct gma_connector *gma_connector;
Alan Cox1b082cc2011-11-03 18:22:26 +0000303 struct drm_connector *connector;
304 struct drm_encoder *encoder;
Alan Cox5d3852d2011-12-20 15:58:29 +0000305 struct drm_psb_private *dev_priv = dev->dev_private;
Alan Cox1b082cc2011-11-03 18:22:26 +0000306 struct edid *edid;
Alan Cox1b082cc2011-11-03 18:22:26 +0000307 struct i2c_adapter *i2c_adap;
308 struct drm_display_mode *scan; /* *modes, *bios_mode; */
309
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200310 gma_encoder = kzalloc(sizeof(struct gma_encoder), GFP_KERNEL);
311 if (!gma_encoder)
Alan Cox1b082cc2011-11-03 18:22:26 +0000312 return;
313
Patrik Jakobssona3d5d752013-07-22 17:05:25 +0200314 gma_connector = kzalloc(sizeof(struct gma_connector), GFP_KERNEL);
315 if (!gma_connector)
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000316 goto failed_connector;
317
Patrik Jakobssona3d5d752013-07-22 17:05:25 +0200318 connector = &gma_connector->base;
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200319 encoder = &gma_encoder->base;
Alan Cox1b082cc2011-11-03 18:22:26 +0000320 dev_priv->is_lvds_on = true;
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000321 drm_connector_init(dev, connector,
Alan Cox1b082cc2011-11-03 18:22:26 +0000322 &psb_intel_lvds_connector_funcs,
323 DRM_MODE_CONNECTOR_LVDS);
324
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000325 drm_encoder_init(dev, encoder, &psb_intel_lvds_enc_funcs,
Alan Cox1b082cc2011-11-03 18:22:26 +0000326 DRM_MODE_ENCODER_LVDS);
327
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200328 gma_connector_attach_encoder(gma_connector, gma_encoder);
329 gma_encoder->type = INTEL_OUTPUT_LVDS;
Alan Cox1b082cc2011-11-03 18:22:26 +0000330
331 drm_encoder_helper_add(encoder, &oaktrail_lvds_helper_funcs);
332 drm_connector_helper_add(connector,
333 &psb_intel_lvds_connector_helper_funcs);
334 connector->display_info.subpixel_order = SubPixelHorizontalRGB;
335 connector->interlace_allowed = false;
336 connector->doublescan_allowed = false;
337
Rob Clarka69ac9e2012-10-11 20:38:23 -0500338 drm_object_attach_property(&connector->base,
Alan Cox1b082cc2011-11-03 18:22:26 +0000339 dev->mode_config.scaling_mode_property,
340 DRM_MODE_SCALE_FULLSCREEN);
Rob Clarka69ac9e2012-10-11 20:38:23 -0500341 drm_object_attach_property(&connector->base,
Alan Cox1b082cc2011-11-03 18:22:26 +0000342 dev_priv->backlight_property,
343 BRIGHTNESS_MAX_LEVEL);
344
345 mode_dev->panel_wants_dither = false;
Kirill A. Shutemov4086b1e2012-05-03 16:27:21 +0100346 if (dev_priv->has_gct)
Alan Cox1b082cc2011-11-03 18:22:26 +0000347 mode_dev->panel_wants_dither = (dev_priv->gct_data.
348 Panel_Port_Control & MRST_PANEL_8TO6_DITHER_ENABLE);
Alan Coxe2e022e2011-12-20 15:58:44 +0000349 if (dev_priv->lvds_dither)
350 mode_dev->panel_wants_dither = 1;
Alan Cox1b082cc2011-11-03 18:22:26 +0000351
352 /*
353 * LVDS discovery:
354 * 1) check for EDID on DDC
355 * 2) check for VBT data
356 * 3) check to see if LVDS is already on
357 * if none of the above, no panel
358 * 4) make sure lid is open
359 * if closed, act like it's not there for now
360 */
361
Jan Safrata5a52b1f2014-09-26 10:40:29 +0200362 edid = NULL;
Daniel Vetterc46145a2014-03-21 23:22:36 +0100363 mutex_lock(&dev->mode_config.mutex);
Alan Cox1b082cc2011-11-03 18:22:26 +0000364 i2c_adap = i2c_get_adapter(dev_priv->ops->i2c_bus);
Jan Safrata5a52b1f2014-09-26 10:40:29 +0200365 if (i2c_adap)
366 edid = drm_get_edid(connector, i2c_adap);
367 if (edid == NULL && dev_priv->lpc_gpio_base) {
368 oaktrail_lvds_i2c_init(encoder);
369 if (gma_encoder->ddc_bus != NULL) {
370 i2c_adap = &gma_encoder->ddc_bus->adapter;
371 edid = drm_get_edid(connector, i2c_adap);
372 }
373 }
Alan Cox1b082cc2011-11-03 18:22:26 +0000374 /*
375 * Attempt to get the fixed panel mode from DDC. Assume that the
376 * preferred mode is the right one.
377 */
Jan Safrata5a52b1f2014-09-26 10:40:29 +0200378 if (edid) {
379 drm_mode_connector_update_edid_property(connector, edid);
380 drm_add_edid_modes(connector, edid);
381 kfree(edid);
Alan Cox1b082cc2011-11-03 18:22:26 +0000382
383 list_for_each_entry(scan, &connector->probed_modes, head) {
384 if (scan->type & DRM_MODE_TYPE_PREFERRED) {
385 mode_dev->panel_fixed_mode =
386 drm_mode_duplicate(dev, scan);
387 goto out; /* FIXME: check for quirks */
388 }
389 }
Jan Safrata5a52b1f2014-09-26 10:40:29 +0200390 } else
391 dev_err(dev->dev, "No ddc adapter available!\n");
Alan Cox1b082cc2011-11-03 18:22:26 +0000392 /*
393 * If we didn't get EDID, try geting panel timing
394 * from configuration data
395 */
Alan Cox1b22edf2011-11-29 22:27:57 +0000396 oaktrail_lvds_get_configuration_mode(dev, mode_dev);
Alan Cox1b082cc2011-11-03 18:22:26 +0000397
398 if (mode_dev->panel_fixed_mode) {
399 mode_dev->panel_fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
400 goto out; /* FIXME: check for quirks */
401 }
402
403 /* If we still don't have a mode after all that, give up. */
404 if (!mode_dev->panel_fixed_mode) {
405 dev_err(dev->dev, "Found no modes on the lvds, ignoring the LVDS\n");
406 goto failed_find;
407 }
408
409out:
Daniel Vetterc46145a2014-03-21 23:22:36 +0100410 mutex_unlock(&dev->mode_config.mutex);
411
Thomas Wood34ea3d32014-05-29 16:57:41 +0100412 drm_connector_register(connector);
Alan Cox1b082cc2011-11-03 18:22:26 +0000413 return;
414
415failed_find:
Daniel Vetterc46145a2014-03-21 23:22:36 +0100416 mutex_unlock(&dev->mode_config.mutex);
417
Alan Cox1b082cc2011-11-03 18:22:26 +0000418 dev_dbg(dev->dev, "No LVDS modes found, disabling.\n");
Jan Safrata5a52b1f2014-09-26 10:40:29 +0200419 if (gma_encoder->ddc_bus) {
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200420 psb_intel_i2c_destroy(gma_encoder->ddc_bus);
Jan Safrata5a52b1f2014-09-26 10:40:29 +0200421 gma_encoder->ddc_bus = NULL;
422 }
Alan Cox1b082cc2011-11-03 18:22:26 +0000423
424/* failed_ddc: */
425
426 drm_encoder_cleanup(encoder);
427 drm_connector_cleanup(connector);
Patrik Jakobssona3d5d752013-07-22 17:05:25 +0200428 kfree(gma_connector);
Patrik Jakobsson9bd81ac2011-12-19 21:41:33 +0000429failed_connector:
Patrik Jakobsson367e4402013-07-22 17:45:26 +0200430 kfree(gma_encoder);
Alan Cox1b082cc2011-11-03 18:22:26 +0000431}
432