blob: ebeab360d851c1ece4952b3f5f4f294aa9673db0 [file] [log] [blame]
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -04001#ifndef _LINUX_TRACEPOINT_H
2#define _LINUX_TRACEPOINT_H
3
4/*
5 * Kernel Tracepoint API.
6 *
Li Hong8cd09a52009-09-22 18:00:44 +08007 * See Documentation/trace/tracepoints.txt.
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -04008 *
9 * (C) Copyright 2008 Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
10 *
11 * Heavily inspired from the Linux Kernel Markers.
12 *
13 * This file is released under the GPLv2.
14 * See the file COPYING for more details.
15 */
16
Wu Zhangjinb70e4f02010-06-21 19:09:09 +080017#include <linux/errno.h>
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -040018#include <linux/types.h>
19#include <linux/rcupdate.h>
Ingo Molnarc5905af2012-02-24 08:31:31 +010020#include <linux/static_key.h>
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -040021
22struct module;
23struct tracepoint;
24
Steven Rostedt38516ab2010-04-20 17:04:50 -040025struct tracepoint_func {
26 void *func;
27 void *data;
28};
29
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -040030struct tracepoint {
31 const char *name; /* Tracepoint name */
Ingo Molnarc5905af2012-02-24 08:31:31 +010032 struct static_key key;
Josh Stone97419872009-08-24 14:43:13 -070033 void (*regfunc)(void);
34 void (*unregfunc)(void);
Lai Jiangshanbd1c8b22011-01-04 16:06:09 +080035 struct tracepoint_func __rcu *funcs;
Mathieu Desnoyers65498642011-01-26 17:26:22 -050036};
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -040037
Steven Rostedt2e26ca72010-05-05 10:52:31 -040038/*
39 * Connect a probe to a tracepoint.
40 * Internal API, should not be used directly.
41 */
Steven Rostedt38516ab2010-04-20 17:04:50 -040042extern int tracepoint_probe_register(const char *name, void *probe, void *data);
Steven Rostedt2e26ca72010-05-05 10:52:31 -040043
44/*
45 * Disconnect a probe from a tracepoint.
46 * Internal API, should not be used directly.
47 */
Steven Rostedt38516ab2010-04-20 17:04:50 -040048extern int
49tracepoint_probe_unregister(const char *name, void *probe, void *data);
Steven Rostedt2e26ca72010-05-05 10:52:31 -040050
Steven Rostedt38516ab2010-04-20 17:04:50 -040051extern int tracepoint_probe_register_noupdate(const char *name, void *probe,
52 void *data);
53extern int tracepoint_probe_unregister_noupdate(const char *name, void *probe,
54 void *data);
Steven Rostedt2e26ca72010-05-05 10:52:31 -040055extern void tracepoint_probe_update_all(void);
56
Mathieu Desnoyersb75ef8b2011-08-10 15:18:39 -040057#ifdef CONFIG_MODULES
58struct tp_module {
59 struct list_head list;
60 unsigned int num_tracepoints;
61 struct tracepoint * const *tracepoints_ptrs;
62};
63#endif /* CONFIG_MODULES */
64
Steven Rostedt2e26ca72010-05-05 10:52:31 -040065struct tracepoint_iter {
Mathieu Desnoyersb75ef8b2011-08-10 15:18:39 -040066#ifdef CONFIG_MODULES
67 struct tp_module *module;
68#endif /* CONFIG_MODULES */
Mathieu Desnoyers65498642011-01-26 17:26:22 -050069 struct tracepoint * const *tracepoint;
Steven Rostedt2e26ca72010-05-05 10:52:31 -040070};
71
72extern void tracepoint_iter_start(struct tracepoint_iter *iter);
73extern void tracepoint_iter_next(struct tracepoint_iter *iter);
74extern void tracepoint_iter_stop(struct tracepoint_iter *iter);
75extern void tracepoint_iter_reset(struct tracepoint_iter *iter);
Steven Rostedt2e26ca72010-05-05 10:52:31 -040076
77/*
78 * tracepoint_synchronize_unregister must be called between the last tracepoint
79 * probe unregistration and the end of module exit to make sure there is no
80 * caller executing a probe when it is freed.
81 */
82static inline void tracepoint_synchronize_unregister(void)
83{
84 synchronize_sched();
85}
86
87#define PARAMS(args...) args
88
Steven Rostedt2e26ca72010-05-05 10:52:31 -040089#endif /* _LINUX_TRACEPOINT_H */
90
91/*
92 * Note: we keep the TRACE_EVENT and DECLARE_TRACE outside the include
93 * file ifdef protection.
94 * This is due to the way trace events work. If a file includes two
95 * trace event headers under one "CREATE_TRACE_POINTS" the first include
96 * will override the TRACE_EVENT and break the second include.
97 */
98
Steven Rostedtea20d922009-04-10 08:54:16 -040099#ifndef DECLARE_TRACE
100
Steven Rostedt2939b042009-03-09 15:47:18 -0400101#define TP_PROTO(args...) args
Li Hong8cd09a52009-09-22 18:00:44 +0800102#define TP_ARGS(args...) args
Steven Rostedt287050d2010-12-02 16:46:18 -0500103#define TP_CONDITION(args...) args
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400104
105#ifdef CONFIG_TRACEPOINTS
106
107/*
108 * it_func[0] is never NULL because there is at least one element in the array
109 * when the array itself is non NULL.
Steven Rostedt38516ab2010-04-20 17:04:50 -0400110 *
111 * Note, the proto and args passed in includes "__data" as the first parameter.
112 * The reason for this is to handle the "void" prototype. If a tracepoint
113 * has a "void" prototype, then it is invalid to declare a function
114 * as "(void *, void)". The DECLARE_TRACE_NOARGS() will pass in just
115 * "void *data", where as the DECLARE_TRACE() will pass in "void *data, proto".
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400116 */
Steven Rostedt2fbb90d2012-02-07 09:32:43 -0500117#define __DO_TRACE(tp, proto, args, cond, prercu, postrcu) \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400118 do { \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400119 struct tracepoint_func *it_func_ptr; \
120 void *it_func; \
121 void *__data; \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400122 \
Steven Rostedt287050d2010-12-02 16:46:18 -0500123 if (!(cond)) \
124 return; \
Steven Rostedt2fbb90d2012-02-07 09:32:43 -0500125 prercu; \
Mathieu Desnoyersda7b3ea2008-11-14 17:47:43 -0500126 rcu_read_lock_sched_notrace(); \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400127 it_func_ptr = rcu_dereference_sched((tp)->funcs); \
128 if (it_func_ptr) { \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400129 do { \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400130 it_func = (it_func_ptr)->func; \
131 __data = (it_func_ptr)->data; \
132 ((void(*)(proto))(it_func))(args); \
133 } while ((++it_func_ptr)->func); \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400134 } \
Mathieu Desnoyersda7b3ea2008-11-14 17:47:43 -0500135 rcu_read_unlock_sched_notrace(); \
Steven Rostedt2fbb90d2012-02-07 09:32:43 -0500136 postrcu; \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400137 } while (0)
138
Josh Triplett7ece55a2012-09-04 23:23:06 -0700139#ifndef MODULE
140#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) \
141 static inline void trace_##name##_rcuidle(proto) \
142 { \
143 if (static_key_false(&__tracepoint_##name.key)) \
144 __DO_TRACE(&__tracepoint_##name, \
145 TP_PROTO(data_proto), \
146 TP_ARGS(data_args), \
147 TP_CONDITION(cond), \
Paul E. McKenneyd6284092013-05-22 02:41:36 -0700148 rcu_irq_enter(), \
149 rcu_irq_exit()); \
Josh Triplett7ece55a2012-09-04 23:23:06 -0700150 }
151#else
152#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args)
153#endif
154
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400155/*
156 * Make sure the alignment of the structure in the __tracepoints section will
157 * not add unwanted padding between the beginning of the section and the
158 * structure. Force alignment to the same alignment as the section start.
159 */
Steven Rostedt2fbb90d2012-02-07 09:32:43 -0500160#define __DECLARE_TRACE(name, proto, args, cond, data_proto, data_args) \
Mathieu Desnoyers7e066fb2008-11-14 17:47:47 -0500161 extern struct tracepoint __tracepoint_##name; \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400162 static inline void trace_##name(proto) \
163 { \
Ingo Molnarc5905af2012-02-24 08:31:31 +0100164 if (static_key_false(&__tracepoint_##name.key)) \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400165 __DO_TRACE(&__tracepoint_##name, \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400166 TP_PROTO(data_proto), \
Steven Rostedt287050d2010-12-02 16:46:18 -0500167 TP_ARGS(data_args), \
Steven Rostedt2fbb90d2012-02-07 09:32:43 -0500168 TP_CONDITION(cond),,); \
169 } \
Josh Triplett7ece55a2012-09-04 23:23:06 -0700170 __DECLARE_TRACE_RCU(name, PARAMS(proto), PARAMS(args), \
171 PARAMS(cond), PARAMS(data_proto), PARAMS(data_args)) \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400172 static inline int \
173 register_trace_##name(void (*probe)(data_proto), void *data) \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400174 { \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400175 return tracepoint_probe_register(#name, (void *)probe, \
176 data); \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400177 } \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400178 static inline int \
179 unregister_trace_##name(void (*probe)(data_proto), void *data) \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400180 { \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400181 return tracepoint_probe_unregister(#name, (void *)probe, \
182 data); \
Mathieu Desnoyers53da59a2010-04-30 12:59:59 -0400183 } \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400184 static inline void \
185 check_trace_callback_type_##name(void (*cb)(data_proto)) \
Mathieu Desnoyers53da59a2010-04-30 12:59:59 -0400186 { \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400187 }
188
Mathieu Desnoyers65498642011-01-26 17:26:22 -0500189/*
190 * We have no guarantee that gcc and the linker won't up-align the tracepoint
191 * structures, so we create an array of pointers that will be used for iteration
192 * on the tracepoints.
193 */
Jason Barond430d3d2011-03-16 17:29:47 -0400194#define DEFINE_TRACE_FN(name, reg, unreg) \
195 static const char __tpstrtab_##name[] \
196 __attribute__((section("__tracepoints_strings"))) = #name; \
197 struct tracepoint __tracepoint_##name \
198 __attribute__((section("__tracepoints"))) = \
Ingo Molnarc5905af2012-02-24 08:31:31 +0100199 { __tpstrtab_##name, STATIC_KEY_INIT_FALSE, reg, unreg, NULL };\
Jason Barond430d3d2011-03-16 17:29:47 -0400200 static struct tracepoint * const __tracepoint_ptr_##name __used \
201 __attribute__((section("__tracepoints_ptrs"))) = \
Mathieu Desnoyers65498642011-01-26 17:26:22 -0500202 &__tracepoint_##name;
Josh Stone97419872009-08-24 14:43:13 -0700203
204#define DEFINE_TRACE(name) \
205 DEFINE_TRACE_FN(name, NULL, NULL);
Mathieu Desnoyers7e066fb2008-11-14 17:47:47 -0500206
207#define EXPORT_TRACEPOINT_SYMBOL_GPL(name) \
208 EXPORT_SYMBOL_GPL(__tracepoint_##name)
209#define EXPORT_TRACEPOINT_SYMBOL(name) \
210 EXPORT_SYMBOL(__tracepoint_##name)
211
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400212#else /* !CONFIG_TRACEPOINTS */
Steven Rostedt2fbb90d2012-02-07 09:32:43 -0500213#define __DECLARE_TRACE(name, proto, args, cond, data_proto, data_args) \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400214 static inline void trace_##name(proto) \
215 { } \
Steven Rostedt2fbb90d2012-02-07 09:32:43 -0500216 static inline void trace_##name##_rcuidle(proto) \
217 { } \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400218 static inline int \
219 register_trace_##name(void (*probe)(data_proto), \
220 void *data) \
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400221 { \
222 return -ENOSYS; \
223 } \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400224 static inline int \
225 unregister_trace_##name(void (*probe)(data_proto), \
226 void *data) \
Mathieu Desnoyersc4209702008-11-14 17:47:44 -0500227 { \
228 return -ENOSYS; \
Mathieu Desnoyers53da59a2010-04-30 12:59:59 -0400229 } \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400230 static inline void check_trace_callback_type_##name(void (*cb)(data_proto)) \
Mathieu Desnoyers53da59a2010-04-30 12:59:59 -0400231 { \
Mathieu Desnoyersc4209702008-11-14 17:47:44 -0500232 }
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400233
Josh Stone97419872009-08-24 14:43:13 -0700234#define DEFINE_TRACE_FN(name, reg, unreg)
Mathieu Desnoyers7e066fb2008-11-14 17:47:47 -0500235#define DEFINE_TRACE(name)
236#define EXPORT_TRACEPOINT_SYMBOL_GPL(name)
237#define EXPORT_TRACEPOINT_SYMBOL(name)
238
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400239#endif /* CONFIG_TRACEPOINTS */
Steven Rostedt38516ab2010-04-20 17:04:50 -0400240
241/*
242 * The need for the DECLARE_TRACE_NOARGS() is to handle the prototype
243 * (void). "void" is a special value in a function prototype and can
244 * not be combined with other arguments. Since the DECLARE_TRACE()
245 * macro adds a data element at the beginning of the prototype,
246 * we need a way to differentiate "(void *data, proto)" from
247 * "(void *data, void)". The second prototype is invalid.
248 *
249 * DECLARE_TRACE_NOARGS() passes "void" as the tracepoint prototype
250 * and "void *__data" as the callback prototype.
251 *
252 * DECLARE_TRACE() passes "proto" as the tracepoint protoype and
253 * "void *__data, proto" as the callback prototype.
254 */
255#define DECLARE_TRACE_NOARGS(name) \
Steven Rostedt287050d2010-12-02 16:46:18 -0500256 __DECLARE_TRACE(name, void, , 1, void *__data, __data)
Steven Rostedt38516ab2010-04-20 17:04:50 -0400257
258#define DECLARE_TRACE(name, proto, args) \
Steven Rostedt287050d2010-12-02 16:46:18 -0500259 __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), 1, \
Steven Rostedt38516ab2010-04-20 17:04:50 -0400260 PARAMS(void *__data, proto), \
261 PARAMS(__data, args))
262
Steven Rostedt287050d2010-12-02 16:46:18 -0500263#define DECLARE_TRACE_CONDITION(name, proto, args, cond) \
264 __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), PARAMS(cond), \
265 PARAMS(void *__data, proto), \
266 PARAMS(__data, args))
267
Frederic Weisbecker1ed0c592010-11-18 01:46:57 +0100268#define TRACE_EVENT_FLAGS(event, flag)
269
Steven Rostedtea20d922009-04-10 08:54:16 -0400270#endif /* DECLARE_TRACE */
Mathieu Desnoyers97e1c182008-07-18 12:16:16 -0400271
Steven Rostedtea20d922009-04-10 08:54:16 -0400272#ifndef TRACE_EVENT
Steven Rostedt823f9122009-03-10 12:58:51 -0400273/*
274 * For use with the TRACE_EVENT macro:
275 *
276 * We define a tracepoint, its arguments, its printk format
277 * and its 'fast binay record' layout.
278 *
279 * Firstly, name your tracepoint via TRACE_EVENT(name : the
280 * 'subsystem_event' notation is fine.
281 *
282 * Think about this whole construct as the
283 * 'trace_sched_switch() function' from now on.
284 *
285 *
286 * TRACE_EVENT(sched_switch,
287 *
288 * *
289 * * A function has a regular function arguments
290 * * prototype, declare it via TP_PROTO():
291 * *
292 *
Steven Rostedtef180122009-03-10 14:10:56 -0400293 * TP_PROTO(struct rq *rq, struct task_struct *prev,
294 * struct task_struct *next),
Steven Rostedt823f9122009-03-10 12:58:51 -0400295 *
296 * *
297 * * Define the call signature of the 'function'.
298 * * (Design sidenote: we use this instead of a
299 * * TP_PROTO1/TP_PROTO2/TP_PROTO3 ugliness.)
300 * *
301 *
Steven Rostedtef180122009-03-10 14:10:56 -0400302 * TP_ARGS(rq, prev, next),
Steven Rostedt823f9122009-03-10 12:58:51 -0400303 *
304 * *
305 * * Fast binary tracing: define the trace record via
306 * * TP_STRUCT__entry(). You can think about it like a
307 * * regular C structure local variable definition.
308 * *
309 * * This is how the trace record is structured and will
310 * * be saved into the ring buffer. These are the fields
311 * * that will be exposed to user-space in
GeunSik Lim156f5a72009-06-02 15:01:37 +0900312 * * /sys/kernel/debug/tracing/events/<*>/format.
Steven Rostedt823f9122009-03-10 12:58:51 -0400313 * *
314 * * The declared 'local variable' is called '__entry'
315 * *
316 * * __field(pid_t, prev_prid) is equivalent to a standard declariton:
317 * *
318 * * pid_t prev_pid;
319 * *
320 * * __array(char, prev_comm, TASK_COMM_LEN) is equivalent to:
321 * *
322 * * char prev_comm[TASK_COMM_LEN];
323 * *
324 *
325 * TP_STRUCT__entry(
326 * __array( char, prev_comm, TASK_COMM_LEN )
327 * __field( pid_t, prev_pid )
328 * __field( int, prev_prio )
329 * __array( char, next_comm, TASK_COMM_LEN )
330 * __field( pid_t, next_pid )
331 * __field( int, next_prio )
332 * ),
333 *
334 * *
335 * * Assign the entry into the trace record, by embedding
336 * * a full C statement block into TP_fast_assign(). You
337 * * can refer to the trace record as '__entry' -
338 * * otherwise you can put arbitrary C code in here.
339 * *
340 * * Note: this C code will execute every time a trace event
341 * * happens, on an active tracepoint.
342 * *
343 *
Steven Rostedtef180122009-03-10 14:10:56 -0400344 * TP_fast_assign(
345 * memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
346 * __entry->prev_pid = prev->pid;
347 * __entry->prev_prio = prev->prio;
Steven Rostedt823f9122009-03-10 12:58:51 -0400348 * memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
349 * __entry->next_pid = next->pid;
Steven Rostedtef180122009-03-10 14:10:56 -0400350 * __entry->next_prio = next->prio;
Mathieu Desnoyersec6e7c32011-01-06 13:45:32 -0500351 * ),
Steven Rostedt823f9122009-03-10 12:58:51 -0400352 *
353 * *
354 * * Formatted output of a trace record via TP_printk().
355 * * This is how the tracepoint will appear under ftrace
356 * * plugins that make use of this tracepoint.
357 * *
358 * * (raw-binary tracing wont actually perform this step.)
359 * *
360 *
361 * TP_printk("task %s:%d [%d] ==> %s:%d [%d]",
362 * __entry->prev_comm, __entry->prev_pid, __entry->prev_prio,
363 * __entry->next_comm, __entry->next_pid, __entry->next_prio),
364 *
365 * );
366 *
367 * This macro construct is thus used for the regular printk format
368 * tracing setup, it is used to construct a function pointer based
369 * tracepoint callback (this is used by programmatic plugins and
370 * can also by used by generic instrumentation like SystemTap), and
371 * it is also used to expose a structured trace record in
GeunSik Lim156f5a72009-06-02 15:01:37 +0900372 * /sys/kernel/debug/tracing/events/.
Josh Stone97419872009-08-24 14:43:13 -0700373 *
374 * A set of (un)registration functions can be passed to the variant
375 * TRACE_EVENT_FN to perform any (un)registration work.
Steven Rostedt823f9122009-03-10 12:58:51 -0400376 */
377
Ingo Molnar091ad362009-11-26 09:04:55 +0100378#define DECLARE_EVENT_CLASS(name, proto, args, tstruct, assign, print)
Steven Rostedtff038f52009-11-18 20:27:27 -0500379#define DEFINE_EVENT(template, name, proto, args) \
380 DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
Steven Rostedtf5abaa12013-06-20 11:44:44 -0400381#define DEFINE_EVENT_FN(template, name, proto, args, reg, unreg)\
382 DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
Steven Rostedte5bc9722009-11-18 20:36:26 -0500383#define DEFINE_EVENT_PRINT(template, name, proto, args, print) \
384 DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
Steven Rostedt287050d2010-12-02 16:46:18 -0500385#define DEFINE_EVENT_CONDITION(template, name, proto, \
386 args, cond) \
387 DECLARE_TRACE_CONDITION(name, PARAMS(proto), \
388 PARAMS(args), PARAMS(cond))
Steven Rostedtff038f52009-11-18 20:27:27 -0500389
Steven Rostedt30a8fec2009-03-10 12:41:38 -0400390#define TRACE_EVENT(name, proto, args, struct, assign, print) \
Steven Rostedtda4d0302009-03-09 17:14:30 -0400391 DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
Josh Stone97419872009-08-24 14:43:13 -0700392#define TRACE_EVENT_FN(name, proto, args, struct, \
393 assign, print, reg, unreg) \
394 DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
Steven Rostedt287050d2010-12-02 16:46:18 -0500395#define TRACE_EVENT_CONDITION(name, proto, args, cond, \
396 struct, assign, print) \
397 DECLARE_TRACE_CONDITION(name, PARAMS(proto), \
398 PARAMS(args), PARAMS(cond))
Steven Rostedt7cb2e3e2009-08-26 00:32:37 -0400399
Frederic Weisbecker1ed0c592010-11-18 01:46:57 +0100400#define TRACE_EVENT_FLAGS(event, flag)
401
Steven Rostedt7cb2e3e2009-08-26 00:32:37 -0400402#endif /* ifdef TRACE_EVENT (see note above) */