blob: a44caabb0fc247917dcae246e50ba7c9168039c5 [file] [log] [blame]
Mike Marshall5db11c22015-07-17 10:38:12 -04001/*
2 * (C) 2001 Clemson University and The University of Chicago
3 *
4 * See COPYING in top-level directory.
5 */
6
7/*
8 * Linux VFS inode operations.
9 */
10
11#include "protocol.h"
Mike Marshall575e9462015-12-04 12:56:14 -050012#include "orangefs-kernel.h"
13#include "orangefs-bufmap.h"
Mike Marshall5db11c22015-07-17 10:38:12 -040014
15static int read_one_page(struct page *page)
16{
Mike Marshall5db11c22015-07-17 10:38:12 -040017 int ret;
18 int max_block;
19 ssize_t bytes_read = 0;
20 struct inode *inode = page->mapping->host;
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +030021 const __u32 blocksize = PAGE_SIZE; /* inode->i_blksize */
22 const __u32 blockbits = PAGE_SHIFT; /* inode->i_blkbits */
Al Viro74f68fc2015-10-08 18:31:05 -040023 struct iov_iter to;
24 struct bio_vec bv = {.bv_page = page, .bv_len = PAGE_SIZE};
25
26 iov_iter_bvec(&to, ITER_BVEC | READ, &bv, 1, PAGE_SIZE);
Mike Marshall5db11c22015-07-17 10:38:12 -040027
28 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -050029 "orangefs_readpage called with page %p\n",
Mike Marshall5db11c22015-07-17 10:38:12 -040030 page);
Mike Marshall5db11c22015-07-17 10:38:12 -040031
32 max_block = ((inode->i_size / blocksize) + 1);
33
34 if (page->index < max_block) {
35 loff_t blockptr_offset = (((loff_t) page->index) << blockbits);
36
Yi Liu8bb8aef2015-11-24 15:12:14 -050037 bytes_read = orangefs_inode_read(inode,
38 &to,
39 &blockptr_offset,
40 inode->i_size);
Mike Marshall5db11c22015-07-17 10:38:12 -040041 }
Al Viro74f68fc2015-10-08 18:31:05 -040042 /* this will only zero remaining unread portions of the page data */
43 iov_iter_zero(~0U, &to);
Mike Marshall5db11c22015-07-17 10:38:12 -040044 /* takes care of potential aliasing */
45 flush_dcache_page(page);
46 if (bytes_read < 0) {
47 ret = bytes_read;
48 SetPageError(page);
49 } else {
50 SetPageUptodate(page);
51 if (PageError(page))
52 ClearPageError(page);
53 ret = 0;
54 }
Mike Marshall5db11c22015-07-17 10:38:12 -040055 /* unlock the page after the ->readpage() routine completes */
56 unlock_page(page);
57 return ret;
58}
59
Yi Liu8bb8aef2015-11-24 15:12:14 -050060static int orangefs_readpage(struct file *file, struct page *page)
Mike Marshall5db11c22015-07-17 10:38:12 -040061{
62 return read_one_page(page);
63}
64
Yi Liu8bb8aef2015-11-24 15:12:14 -050065static int orangefs_readpages(struct file *file,
Mike Marshall5db11c22015-07-17 10:38:12 -040066 struct address_space *mapping,
67 struct list_head *pages,
68 unsigned nr_pages)
69{
70 int page_idx;
71 int ret;
72
Yi Liu8bb8aef2015-11-24 15:12:14 -050073 gossip_debug(GOSSIP_INODE_DEBUG, "orangefs_readpages called\n");
Mike Marshall5db11c22015-07-17 10:38:12 -040074
75 for (page_idx = 0; page_idx < nr_pages; page_idx++) {
76 struct page *page;
77
78 page = list_entry(pages->prev, struct page, lru);
79 list_del(&page->lru);
80 if (!add_to_page_cache(page,
81 mapping,
82 page->index,
83 GFP_KERNEL)) {
84 ret = read_one_page(page);
85 gossip_debug(GOSSIP_INODE_DEBUG,
86 "failure adding page to cache, read_one_page returned: %d\n",
87 ret);
88 } else {
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +030089 put_page(page);
Mike Marshall5db11c22015-07-17 10:38:12 -040090 }
91 }
92 BUG_ON(!list_empty(pages));
93 return 0;
94}
95
Yi Liu8bb8aef2015-11-24 15:12:14 -050096static void orangefs_invalidatepage(struct page *page,
Mike Marshall5db11c22015-07-17 10:38:12 -040097 unsigned int offset,
98 unsigned int length)
99{
100 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500101 "orangefs_invalidatepage called on page %p "
Mike Marshall5db11c22015-07-17 10:38:12 -0400102 "(offset is %u)\n",
103 page,
104 offset);
105
106 ClearPageUptodate(page);
107 ClearPageMappedToDisk(page);
108 return;
109
110}
111
Yi Liu8bb8aef2015-11-24 15:12:14 -0500112static int orangefs_releasepage(struct page *page, gfp_t foo)
Mike Marshall5db11c22015-07-17 10:38:12 -0400113{
114 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500115 "orangefs_releasepage called on page %p\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400116 page);
117 return 0;
118}
119
120/*
121 * Having a direct_IO entry point in the address_space_operations
122 * struct causes the kernel to allows us to use O_DIRECT on
123 * open. Nothing will ever call this thing, but in the future we
124 * will need to be able to use O_DIRECT on open in order to support
125 * AIO. Modeled after NFS, they do this too.
126 */
Mike Marshall3903f152016-06-09 15:38:03 -0400127
128static ssize_t orangefs_direct_IO(struct kiocb *iocb,
129 struct iov_iter *iter)
130{
131 gossip_debug(GOSSIP_INODE_DEBUG,
132 "orangefs_direct_IO: %s\n",
133 iocb->ki_filp->f_path.dentry->d_name.name);
134
135 return -EINVAL;
136}
Mike Marshall5db11c22015-07-17 10:38:12 -0400137
Yi Liu8bb8aef2015-11-24 15:12:14 -0500138struct backing_dev_info orangefs_backing_dev_info = {
139 .name = "orangefs",
Mike Marshall5db11c22015-07-17 10:38:12 -0400140 .ra_pages = 0,
141 .capabilities = BDI_CAP_NO_ACCT_DIRTY | BDI_CAP_NO_WRITEBACK,
142};
143
Yi Liu8bb8aef2015-11-24 15:12:14 -0500144/** ORANGEFS2 implementation of address space operations */
145const struct address_space_operations orangefs_address_operations = {
146 .readpage = orangefs_readpage,
147 .readpages = orangefs_readpages,
148 .invalidatepage = orangefs_invalidatepage,
149 .releasepage = orangefs_releasepage,
Mike Marshall3903f152016-06-09 15:38:03 -0400150 .direct_IO = orangefs_direct_IO,
Mike Marshall5db11c22015-07-17 10:38:12 -0400151};
152
Yi Liu8bb8aef2015-11-24 15:12:14 -0500153static int orangefs_setattr_size(struct inode *inode, struct iattr *iattr)
Mike Marshall5db11c22015-07-17 10:38:12 -0400154{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500155 struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);
156 struct orangefs_kernel_op_s *new_op;
Martin Brandenburgfecd86a2016-03-23 17:06:25 -0400157 loff_t orig_size;
Mike Marshall5db11c22015-07-17 10:38:12 -0400158 int ret = -EINVAL;
159
160 gossip_debug(GOSSIP_INODE_DEBUG,
161 "%s: %pU: Handle is %pU | fs_id %d | size is %llu\n",
162 __func__,
163 get_khandle_from_ino(inode),
Yi Liu8bb8aef2015-11-24 15:12:14 -0500164 &orangefs_inode->refn.khandle,
165 orangefs_inode->refn.fs_id,
Mike Marshall5db11c22015-07-17 10:38:12 -0400166 iattr->ia_size);
167
Martin Brandenburgfecd86a2016-03-23 17:06:25 -0400168 /* Ensure that we have a up to date size, so we know if it changed. */
169 ret = orangefs_inode_getattr(inode, 0, 1);
170 if (ret == -ESTALE)
171 ret = -EIO;
172 if (ret) {
173 gossip_err("%s: orangefs_inode_getattr failed, ret:%d:.\n",
174 __func__, ret);
175 return ret;
176 }
177 orig_size = i_size_read(inode);
178
Mike Marshall5db11c22015-07-17 10:38:12 -0400179 truncate_setsize(inode, iattr->ia_size);
180
Yi Liu8bb8aef2015-11-24 15:12:14 -0500181 new_op = op_alloc(ORANGEFS_VFS_OP_TRUNCATE);
Mike Marshall5db11c22015-07-17 10:38:12 -0400182 if (!new_op)
183 return -ENOMEM;
184
Yi Liu8bb8aef2015-11-24 15:12:14 -0500185 new_op->upcall.req.truncate.refn = orangefs_inode->refn;
Mike Marshall5db11c22015-07-17 10:38:12 -0400186 new_op->upcall.req.truncate.size = (__s64) iattr->ia_size;
187
188 ret = service_operation(new_op, __func__,
189 get_interruptible_flag(inode));
190
191 /*
192 * the truncate has no downcall members to retrieve, but
193 * the status value tells us if it went through ok or not
194 */
195 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500196 "orangefs: orangefs_truncate got return value of %d\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400197 ret);
198
199 op_release(new_op);
200
201 if (ret != 0)
202 return ret;
203
Martin Brandenburgf83140c2016-04-04 16:26:36 -0400204 if (orig_size != i_size_read(inode))
Mike Marshall5db11c22015-07-17 10:38:12 -0400205 iattr->ia_valid |= ATTR_CTIME | ATTR_MTIME;
Mike Marshall5db11c22015-07-17 10:38:12 -0400206
207 return ret;
208}
209
210/*
211 * Change attributes of an object referenced by dentry.
212 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500213int orangefs_setattr(struct dentry *dentry, struct iattr *iattr)
Mike Marshall5db11c22015-07-17 10:38:12 -0400214{
215 int ret = -EINVAL;
216 struct inode *inode = dentry->d_inode;
217
218 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500219 "orangefs_setattr: called on %s\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400220 dentry->d_name.name);
221
222 ret = inode_change_ok(inode, iattr);
223 if (ret)
224 goto out;
225
226 if ((iattr->ia_valid & ATTR_SIZE) &&
227 iattr->ia_size != i_size_read(inode)) {
Yi Liu8bb8aef2015-11-24 15:12:14 -0500228 ret = orangefs_setattr_size(inode, iattr);
Mike Marshall5db11c22015-07-17 10:38:12 -0400229 if (ret)
230 goto out;
231 }
232
233 setattr_copy(inode, iattr);
234 mark_inode_dirty(inode);
235
Yi Liu8bb8aef2015-11-24 15:12:14 -0500236 ret = orangefs_inode_setattr(inode, iattr);
Mike Marshall5db11c22015-07-17 10:38:12 -0400237 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500238 "orangefs_setattr: inode_setattr returned %d\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400239 ret);
240
241 if (!ret && (iattr->ia_valid & ATTR_MODE))
242 /* change mod on a file that has ACLs */
243 ret = posix_acl_chmod(inode, inode->i_mode);
244
245out:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500246 gossip_debug(GOSSIP_INODE_DEBUG, "orangefs_setattr: returning %d\n", ret);
Mike Marshall5db11c22015-07-17 10:38:12 -0400247 return ret;
248}
249
250/*
251 * Obtain attributes of an object given a dentry
252 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500253int orangefs_getattr(struct vfsmount *mnt,
Mike Marshall5db11c22015-07-17 10:38:12 -0400254 struct dentry *dentry,
255 struct kstat *kstat)
256{
257 int ret = -ENOENT;
258 struct inode *inode = dentry->d_inode;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500259 struct orangefs_inode_s *orangefs_inode = NULL;
Mike Marshall5db11c22015-07-17 10:38:12 -0400260
261 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500262 "orangefs_getattr: called on %s\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400263 dentry->d_name.name);
264
Martin Brandenburg8f249282016-03-15 12:36:29 -0400265 ret = orangefs_inode_getattr(inode, 0, 1);
Mike Marshall5db11c22015-07-17 10:38:12 -0400266 if (ret == 0) {
267 generic_fillattr(inode, kstat);
Mike Marshalla7d3e782016-03-14 15:30:03 -0400268
Mike Marshall5db11c22015-07-17 10:38:12 -0400269 /* override block size reported to stat */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500270 orangefs_inode = ORANGEFS_I(inode);
271 kstat->blksize = orangefs_inode->blksize;
Mike Marshall5db11c22015-07-17 10:38:12 -0400272 }
273 return ret;
274}
275
Martin Brandenburg933287d2016-01-30 13:46:54 -0500276int orangefs_permission(struct inode *inode, int mask)
277{
278 int ret;
279
280 if (mask & MAY_NOT_BLOCK)
281 return -ECHILD;
282
283 gossip_debug(GOSSIP_INODE_DEBUG, "%s: refreshing\n", __func__);
284
285 /* Make sure the permission (and other common attrs) are up to date. */
Martin Brandenburg8f249282016-03-15 12:36:29 -0400286 ret = orangefs_inode_getattr(inode, 0, 0);
Martin Brandenburg933287d2016-01-30 13:46:54 -0500287 if (ret < 0)
288 return ret;
289
290 return generic_permission(inode, mask);
291}
292
Yi Liu8bb8aef2015-11-24 15:12:14 -0500293/* ORANGEDS2 implementation of VFS inode operations for files */
294struct inode_operations orangefs_file_inode_operations = {
295 .get_acl = orangefs_get_acl,
296 .set_acl = orangefs_set_acl,
297 .setattr = orangefs_setattr,
298 .getattr = orangefs_getattr,
Mike Marshall5db11c22015-07-17 10:38:12 -0400299 .setxattr = generic_setxattr,
300 .getxattr = generic_getxattr,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500301 .listxattr = orangefs_listxattr,
Mike Marshall5db11c22015-07-17 10:38:12 -0400302 .removexattr = generic_removexattr,
Martin Brandenburg933287d2016-01-30 13:46:54 -0500303 .permission = orangefs_permission,
Mike Marshall5db11c22015-07-17 10:38:12 -0400304};
305
Yi Liu8bb8aef2015-11-24 15:12:14 -0500306static int orangefs_init_iops(struct inode *inode)
Mike Marshall5db11c22015-07-17 10:38:12 -0400307{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500308 inode->i_mapping->a_ops = &orangefs_address_operations;
Mike Marshall5db11c22015-07-17 10:38:12 -0400309
310 switch (inode->i_mode & S_IFMT) {
311 case S_IFREG:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500312 inode->i_op = &orangefs_file_inode_operations;
313 inode->i_fop = &orangefs_file_operations;
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300314 inode->i_blkbits = PAGE_SHIFT;
Mike Marshall5db11c22015-07-17 10:38:12 -0400315 break;
316 case S_IFLNK:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500317 inode->i_op = &orangefs_symlink_inode_operations;
Mike Marshall5db11c22015-07-17 10:38:12 -0400318 break;
319 case S_IFDIR:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500320 inode->i_op = &orangefs_dir_inode_operations;
321 inode->i_fop = &orangefs_dir_operations;
Mike Marshall5db11c22015-07-17 10:38:12 -0400322 break;
323 default:
324 gossip_debug(GOSSIP_INODE_DEBUG,
325 "%s: unsupported mode\n",
326 __func__);
327 return -EINVAL;
328 }
329
330 return 0;
331}
332
333/*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500334 * Given a ORANGEFS object identifier (fsid, handle), convert it into a ino_t type
Mike Marshall5db11c22015-07-17 10:38:12 -0400335 * that will be used as a hash-index from where the handle will
336 * be searched for in the VFS hash table of inodes.
337 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500338static inline ino_t orangefs_handle_hash(struct orangefs_object_kref *ref)
Mike Marshall5db11c22015-07-17 10:38:12 -0400339{
340 if (!ref)
341 return 0;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500342 return orangefs_khandle_to_ino(&(ref->khandle));
Mike Marshall5db11c22015-07-17 10:38:12 -0400343}
344
345/*
346 * Called to set up an inode from iget5_locked.
347 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500348static int orangefs_set_inode(struct inode *inode, void *data)
Mike Marshall5db11c22015-07-17 10:38:12 -0400349{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500350 struct orangefs_object_kref *ref = (struct orangefs_object_kref *) data;
Martin Brandenburga4c680a2016-03-16 14:35:21 -0400351 ORANGEFS_I(inode)->refn.fs_id = ref->fs_id;
352 ORANGEFS_I(inode)->refn.khandle = ref->khandle;
Mike Marshall5db11c22015-07-17 10:38:12 -0400353 return 0;
354}
355
356/*
357 * Called to determine if handles match.
358 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500359static int orangefs_test_inode(struct inode *inode, void *data)
Mike Marshall5db11c22015-07-17 10:38:12 -0400360{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500361 struct orangefs_object_kref *ref = (struct orangefs_object_kref *) data;
362 struct orangefs_inode_s *orangefs_inode = NULL;
Mike Marshall5db11c22015-07-17 10:38:12 -0400363
Yi Liu8bb8aef2015-11-24 15:12:14 -0500364 orangefs_inode = ORANGEFS_I(inode);
365 return (!ORANGEFS_khandle_cmp(&(orangefs_inode->refn.khandle), &(ref->khandle))
366 && orangefs_inode->refn.fs_id == ref->fs_id);
Mike Marshall5db11c22015-07-17 10:38:12 -0400367}
368
369/*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500370 * Front-end to lookup the inode-cache maintained by the VFS using the ORANGEFS
Mike Marshall5db11c22015-07-17 10:38:12 -0400371 * file handle.
372 *
373 * @sb: the file system super block instance.
Yi Liu8bb8aef2015-11-24 15:12:14 -0500374 * @ref: The ORANGEFS object for which we are trying to locate an inode structure.
Mike Marshall5db11c22015-07-17 10:38:12 -0400375 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500376struct inode *orangefs_iget(struct super_block *sb, struct orangefs_object_kref *ref)
Mike Marshall5db11c22015-07-17 10:38:12 -0400377{
378 struct inode *inode = NULL;
379 unsigned long hash;
380 int error;
381
Yi Liu8bb8aef2015-11-24 15:12:14 -0500382 hash = orangefs_handle_hash(ref);
383 inode = iget5_locked(sb, hash, orangefs_test_inode, orangefs_set_inode, ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400384 if (!inode || !(inode->i_state & I_NEW))
385 return inode;
386
Martin Brandenburg075cca52016-03-15 11:36:18 -0400387 error = orangefs_inode_getattr(inode, 1, 0);
Mike Marshall5db11c22015-07-17 10:38:12 -0400388 if (error) {
389 iget_failed(inode);
390 return ERR_PTR(error);
391 }
392
393 inode->i_ino = hash; /* needed for stat etc */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500394 orangefs_init_iops(inode);
Mike Marshall5db11c22015-07-17 10:38:12 -0400395 unlock_new_inode(inode);
396
397 gossip_debug(GOSSIP_INODE_DEBUG,
398 "iget handle %pU, fsid %d hash %ld i_ino %lu\n",
399 &ref->khandle,
400 ref->fs_id,
401 hash,
402 inode->i_ino);
403
404 return inode;
405}
406
407/*
408 * Allocate an inode for a newly created file and insert it into the inode hash.
409 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500410struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir,
411 int mode, dev_t dev, struct orangefs_object_kref *ref)
Mike Marshall5db11c22015-07-17 10:38:12 -0400412{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500413 unsigned long hash = orangefs_handle_hash(ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400414 struct inode *inode;
415 int error;
416
417 gossip_debug(GOSSIP_INODE_DEBUG,
Mike Marshall52534872016-02-16 17:09:09 -0500418 "%s:(sb is %p | MAJOR(dev)=%u | MINOR(dev)=%u mode=%o)\n",
419 __func__,
Mike Marshall5db11c22015-07-17 10:38:12 -0400420 sb,
421 MAJOR(dev),
422 MINOR(dev),
423 mode);
424
425 inode = new_inode(sb);
426 if (!inode)
427 return NULL;
428
Yi Liu8bb8aef2015-11-24 15:12:14 -0500429 orangefs_set_inode(inode, ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400430 inode->i_ino = hash; /* needed for stat etc */
431
Martin Brandenburg075cca52016-03-15 11:36:18 -0400432 error = orangefs_inode_getattr(inode, 1, 0);
Mike Marshall5db11c22015-07-17 10:38:12 -0400433 if (error)
434 goto out_iput;
435
Yi Liu8bb8aef2015-11-24 15:12:14 -0500436 orangefs_init_iops(inode);
Mike Marshall5db11c22015-07-17 10:38:12 -0400437
438 inode->i_mode = mode;
439 inode->i_uid = current_fsuid();
440 inode->i_gid = current_fsgid();
441 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300442 inode->i_size = PAGE_SIZE;
Mike Marshall5db11c22015-07-17 10:38:12 -0400443 inode->i_rdev = dev;
444
Yi Liu8bb8aef2015-11-24 15:12:14 -0500445 error = insert_inode_locked4(inode, hash, orangefs_test_inode, ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400446 if (error < 0)
447 goto out_iput;
448
449 gossip_debug(GOSSIP_INODE_DEBUG,
450 "Initializing ACL's for inode %pU\n",
451 get_khandle_from_ino(inode));
Yi Liu8bb8aef2015-11-24 15:12:14 -0500452 orangefs_init_acl(inode, dir);
Mike Marshall5db11c22015-07-17 10:38:12 -0400453 return inode;
454
455out_iput:
456 iput(inode);
457 return ERR_PTR(error);
458}