Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 1 | /* |
| 2 | * builtin-probe.c |
| 3 | * |
| 4 | * Builtin probe command: Set up probe events by C expression |
| 5 | * |
| 6 | * Written by Masami Hiramatsu <mhiramat@redhat.com> |
| 7 | * |
| 8 | * This program is free software; you can redistribute it and/or modify |
| 9 | * it under the terms of the GNU General Public License as published by |
| 10 | * the Free Software Foundation; either version 2 of the License, or |
| 11 | * (at your option) any later version. |
| 12 | * |
| 13 | * This program is distributed in the hope that it will be useful, |
| 14 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 15 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 16 | * GNU General Public License for more details. |
| 17 | * |
| 18 | * You should have received a copy of the GNU General Public License |
| 19 | * along with this program; if not, write to the Free Software |
| 20 | * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. |
| 21 | * |
| 22 | */ |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 23 | #include <sys/utsname.h> |
| 24 | #include <sys/types.h> |
| 25 | #include <sys/stat.h> |
| 26 | #include <fcntl.h> |
| 27 | #include <errno.h> |
| 28 | #include <stdio.h> |
| 29 | #include <unistd.h> |
| 30 | #include <stdlib.h> |
| 31 | #include <string.h> |
| 32 | |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 33 | #include "perf.h" |
| 34 | #include "builtin.h" |
| 35 | #include "util/util.h" |
Masami Hiramatsu | fa28244 | 2009-12-08 17:03:23 -0500 | [diff] [blame] | 36 | #include "util/strlist.h" |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 37 | #include "util/strfilter.h" |
Masami Hiramatsu | e0faa8d | 2010-03-16 18:05:37 -0400 | [diff] [blame] | 38 | #include "util/symbol.h" |
Masami Hiramatsu | 89c69c0 | 2009-10-16 20:08:10 -0400 | [diff] [blame] | 39 | #include "util/debug.h" |
Borislav Petkov | 553873e | 2013-12-09 17:14:23 +0100 | [diff] [blame] | 40 | #include <api/fs/debugfs.h> |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 41 | #include "util/parse-options.h" |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 42 | #include "util/probe-finder.h" |
Masami Hiramatsu | 50656ee | 2009-11-30 19:19:58 -0500 | [diff] [blame] | 43 | #include "util/probe-event.h" |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 44 | |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 45 | #define DEFAULT_VAR_FILTER "!__k???tab_* & !__crc_*" |
Masami Hiramatsu | 3c42258 | 2011-01-20 23:15:45 +0900 | [diff] [blame] | 46 | #define DEFAULT_FUNC_FILTER "!_*" |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 47 | |
| 48 | /* Session management structure */ |
| 49 | static struct { |
Masami Hiramatsu | fac13fd | 2009-12-15 10:31:14 -0500 | [diff] [blame] | 50 | bool list_events; |
Masami Hiramatsu | d761b08 | 2009-12-15 10:32:25 -0500 | [diff] [blame] | 51 | bool force_add; |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 52 | bool show_lines; |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 53 | bool show_vars; |
Masami Hiramatsu | fb8c5a5 | 2010-10-21 19:13:35 +0900 | [diff] [blame] | 54 | bool show_ext_vars; |
Masami Hiramatsu | e80711c | 2011-01-13 21:46:11 +0900 | [diff] [blame] | 55 | bool show_funcs; |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 56 | bool mod_events; |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 57 | bool uprobes; |
Masami Hiramatsu | 4235b04 | 2010-03-16 18:06:12 -0400 | [diff] [blame] | 58 | int nevents; |
| 59 | struct perf_probe_event events[MAX_PROBES]; |
Masami Hiramatsu | fa28244 | 2009-12-08 17:03:23 -0500 | [diff] [blame] | 60 | struct strlist *dellist; |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 61 | struct line_range line_range; |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 62 | char *target; |
Masami Hiramatsu | ef4a356 | 2010-04-21 15:56:40 -0400 | [diff] [blame] | 63 | int max_probe_points; |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 64 | struct strfilter *filter; |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 65 | } params; |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 66 | |
Masami Hiramatsu | 253977b | 2009-10-27 16:43:10 -0400 | [diff] [blame] | 67 | /* Parse an event definition. Note that any error must die. */ |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 68 | static int parse_probe_event(const char *str) |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 69 | { |
Masami Hiramatsu | 4235b04 | 2010-03-16 18:06:12 -0400 | [diff] [blame] | 70 | struct perf_probe_event *pev = ¶ms.events[params.nevents]; |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 71 | int ret; |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 72 | |
Masami Hiramatsu | 4235b04 | 2010-03-16 18:06:12 -0400 | [diff] [blame] | 73 | pr_debug("probe-definition(%d): %s\n", params.nevents, str); |
Arnaldo Carvalho de Melo | 8a7ddad | 2010-05-18 22:57:27 -0300 | [diff] [blame] | 74 | if (++params.nevents == MAX_PROBES) { |
| 75 | pr_err("Too many probes (> %d) were specified.", MAX_PROBES); |
| 76 | return -1; |
| 77 | } |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 78 | |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 79 | pev->uprobes = params.uprobes; |
| 80 | |
Masami Hiramatsu | 4235b04 | 2010-03-16 18:06:12 -0400 | [diff] [blame] | 81 | /* Parse a perf-probe command into event */ |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 82 | ret = parse_perf_probe_command(str, pev); |
Masami Hiramatsu | 4235b04 | 2010-03-16 18:06:12 -0400 | [diff] [blame] | 83 | pr_debug("%d arguments\n", pev->nargs); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 84 | |
| 85 | return ret; |
Masami Hiramatsu | 46ab492 | 2009-10-27 16:43:02 -0400 | [diff] [blame] | 86 | } |
| 87 | |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 88 | static int set_target(const char *ptr) |
| 89 | { |
| 90 | int found = 0; |
| 91 | const char *buf; |
| 92 | |
| 93 | /* |
| 94 | * The first argument after options can be an absolute path |
| 95 | * to an executable / library or kernel module. |
| 96 | * |
| 97 | * TODO: Support relative path, and $PATH, $LD_LIBRARY_PATH, |
| 98 | * short module name. |
| 99 | */ |
| 100 | if (!params.target && ptr && *ptr == '/') { |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 101 | params.target = strdup(ptr); |
| 102 | if (!params.target) |
| 103 | return -ENOMEM; |
| 104 | |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 105 | found = 1; |
| 106 | buf = ptr + (strlen(ptr) - 3); |
| 107 | |
| 108 | if (strcmp(buf, ".ko")) |
| 109 | params.uprobes = true; |
| 110 | |
| 111 | } |
| 112 | |
| 113 | return found; |
| 114 | } |
| 115 | |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 116 | static int parse_probe_event_argv(int argc, const char **argv) |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 117 | { |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 118 | int i, len, ret, found_target; |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 119 | char *buf; |
| 120 | |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 121 | found_target = set_target(argv[0]); |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 122 | if (found_target < 0) |
| 123 | return found_target; |
| 124 | |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 125 | if (found_target && argc == 1) |
| 126 | return 0; |
| 127 | |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 128 | /* Bind up rest arguments */ |
| 129 | len = 0; |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 130 | for (i = 0; i < argc; i++) { |
| 131 | if (i == 0 && found_target) |
| 132 | continue; |
| 133 | |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 134 | len += strlen(argv[i]) + 1; |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 135 | } |
Arnaldo Carvalho de Melo | 8a7ddad | 2010-05-18 22:57:27 -0300 | [diff] [blame] | 136 | buf = zalloc(len + 1); |
| 137 | if (buf == NULL) |
| 138 | return -ENOMEM; |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 139 | len = 0; |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 140 | for (i = 0; i < argc; i++) { |
| 141 | if (i == 0 && found_target) |
| 142 | continue; |
| 143 | |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 144 | len += sprintf(&buf[len], "%s ", argv[i]); |
Srikar Dronamraju | 73eff9f | 2012-04-16 17:39:25 +0530 | [diff] [blame] | 145 | } |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 146 | params.mod_events = true; |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 147 | ret = parse_probe_event(buf); |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 148 | free(buf); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 149 | return ret; |
Masami Hiramatsu | d1bde3f | 2009-12-08 17:02:54 -0500 | [diff] [blame] | 150 | } |
| 151 | |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 152 | static int opt_add_probe_event(const struct option *opt __maybe_unused, |
| 153 | const char *str, int unset __maybe_unused) |
Masami Hiramatsu | 46ab492 | 2009-10-27 16:43:02 -0400 | [diff] [blame] | 154 | { |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 155 | if (str) { |
| 156 | params.mod_events = true; |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 157 | return parse_probe_event(str); |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 158 | } else |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 159 | return 0; |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 160 | } |
| 161 | |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 162 | static int opt_del_probe_event(const struct option *opt __maybe_unused, |
| 163 | const char *str, int unset __maybe_unused) |
Masami Hiramatsu | fa28244 | 2009-12-08 17:03:23 -0500 | [diff] [blame] | 164 | { |
| 165 | if (str) { |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 166 | params.mod_events = true; |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 167 | if (!params.dellist) |
| 168 | params.dellist = strlist__new(true, NULL); |
| 169 | strlist__add(params.dellist, str); |
Masami Hiramatsu | fa28244 | 2009-12-08 17:03:23 -0500 | [diff] [blame] | 170 | } |
| 171 | return 0; |
| 172 | } |
| 173 | |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 174 | static int opt_set_target(const struct option *opt, const char *str, |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 175 | int unset __maybe_unused) |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 176 | { |
| 177 | int ret = -ENOENT; |
Masami Hiramatsu | 8a613d4 | 2013-12-26 05:41:50 +0000 | [diff] [blame] | 178 | char *tmp; |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 179 | |
| 180 | if (str && !params.target) { |
| 181 | if (!strcmp(opt->long_name, "exec")) |
| 182 | params.uprobes = true; |
Ingo Molnar | 89fe808 | 2013-09-30 12:07:11 +0200 | [diff] [blame] | 183 | #ifdef HAVE_DWARF_SUPPORT |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 184 | else if (!strcmp(opt->long_name, "module")) |
| 185 | params.uprobes = false; |
| 186 | #endif |
| 187 | else |
| 188 | return ret; |
| 189 | |
Masami Hiramatsu | 8a613d4 | 2013-12-26 05:41:50 +0000 | [diff] [blame] | 190 | /* Expand given path to absolute path, except for modulename */ |
| 191 | if (params.uprobes || strchr(str, '/')) { |
| 192 | tmp = realpath(str, NULL); |
| 193 | if (!tmp) { |
| 194 | pr_warning("Failed to get the absolute path of %s: %m\n", str); |
| 195 | return ret; |
| 196 | } |
| 197 | } else { |
| 198 | tmp = strdup(str); |
| 199 | if (!tmp) |
| 200 | return -ENOMEM; |
| 201 | } |
| 202 | params.target = tmp; |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 203 | ret = 0; |
| 204 | } |
| 205 | |
| 206 | return ret; |
| 207 | } |
| 208 | |
Ingo Molnar | 89fe808 | 2013-09-30 12:07:11 +0200 | [diff] [blame] | 209 | #ifdef HAVE_DWARF_SUPPORT |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 210 | static int opt_show_lines(const struct option *opt __maybe_unused, |
| 211 | const char *str, int unset __maybe_unused) |
Hitoshi Mitake | 0eda738 | 2010-01-16 21:31:16 +0900 | [diff] [blame] | 212 | { |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 213 | int ret = 0; |
| 214 | |
Masami Hiramatsu | 13e27d7 | 2011-08-11 20:02:53 +0900 | [diff] [blame] | 215 | if (!str) |
| 216 | return 0; |
| 217 | |
| 218 | if (params.show_lines) { |
| 219 | pr_warning("Warning: more than one --line options are" |
| 220 | " detected. Only the first one is valid.\n"); |
| 221 | return 0; |
| 222 | } |
| 223 | |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 224 | params.show_lines = true; |
Masami Hiramatsu | 13e27d7 | 2011-08-11 20:02:53 +0900 | [diff] [blame] | 225 | ret = parse_line_range_desc(str, ¶ms.line_range); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 226 | |
| 227 | return ret; |
Hitoshi Mitake | 0eda738 | 2010-01-16 21:31:16 +0900 | [diff] [blame] | 228 | } |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 229 | |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 230 | static int opt_show_vars(const struct option *opt __maybe_unused, |
| 231 | const char *str, int unset __maybe_unused) |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 232 | { |
| 233 | struct perf_probe_event *pev = ¶ms.events[params.nevents]; |
| 234 | int ret; |
| 235 | |
| 236 | if (!str) |
| 237 | return 0; |
| 238 | |
| 239 | ret = parse_probe_event(str); |
| 240 | if (!ret && pev->nargs != 0) { |
| 241 | pr_err(" Error: '--vars' doesn't accept arguments.\n"); |
| 242 | return -EINVAL; |
| 243 | } |
| 244 | params.show_vars = true; |
| 245 | |
| 246 | return ret; |
| 247 | } |
Masami Hiramatsu | 3c42258 | 2011-01-20 23:15:45 +0900 | [diff] [blame] | 248 | #endif |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 249 | |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 250 | static int opt_set_filter(const struct option *opt __maybe_unused, |
| 251 | const char *str, int unset __maybe_unused) |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 252 | { |
| 253 | const char *err; |
| 254 | |
| 255 | if (str) { |
| 256 | pr_debug2("Set filter: %s\n", str); |
| 257 | if (params.filter) |
| 258 | strfilter__delete(params.filter); |
| 259 | params.filter = strfilter__new(str, &err); |
| 260 | if (!params.filter) { |
Arnaldo Carvalho de Melo | 823c716 | 2011-01-31 19:45:38 -0200 | [diff] [blame] | 261 | pr_err("Filter parse error at %td.\n", err - str + 1); |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 262 | pr_err("Source: \"%s\"\n", str); |
| 263 | pr_err(" %*c\n", (int)(err - str + 1), '^'); |
| 264 | return -EINVAL; |
| 265 | } |
| 266 | } |
| 267 | |
| 268 | return 0; |
| 269 | } |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 270 | |
Masami Hiramatsu | 5a62257 | 2014-02-06 05:32:09 +0000 | [diff] [blame] | 271 | static int init_params(void) |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 272 | { |
Masami Hiramatsu | 5a62257 | 2014-02-06 05:32:09 +0000 | [diff] [blame] | 273 | return line_range__init(¶ms.line_range); |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 274 | } |
| 275 | |
| 276 | static void cleanup_params(void) |
| 277 | { |
| 278 | int i; |
| 279 | |
| 280 | for (i = 0; i < params.nevents; i++) |
| 281 | clear_perf_probe_event(params.events + i); |
| 282 | if (params.dellist) |
| 283 | strlist__delete(params.dellist); |
| 284 | line_range__clear(¶ms.line_range); |
| 285 | free(params.target); |
| 286 | if (params.filter) |
| 287 | strfilter__delete(params.filter); |
| 288 | memset(¶ms, 0, sizeof(params)); |
| 289 | } |
| 290 | |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 291 | static void pr_err_with_code(const char *msg, int err) |
| 292 | { |
| 293 | pr_err("%s", msg); |
| 294 | pr_debug(" Reason: %s (Code: %d)", strerror(-err), err); |
| 295 | pr_err("\n"); |
| 296 | } |
| 297 | |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 298 | static int |
| 299 | __cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused) |
Arnaldo Carvalho de Melo | 11c4e4a | 2012-10-01 15:20:58 -0300 | [diff] [blame] | 300 | { |
| 301 | const char * const probe_usage[] = { |
| 302 | "perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]", |
| 303 | "perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]", |
| 304 | "perf probe [<options>] --del '[GROUP:]EVENT' ...", |
| 305 | "perf probe --list", |
Ingo Molnar | 89fe808 | 2013-09-30 12:07:11 +0200 | [diff] [blame] | 306 | #ifdef HAVE_DWARF_SUPPORT |
Arnaldo Carvalho de Melo | 11c4e4a | 2012-10-01 15:20:58 -0300 | [diff] [blame] | 307 | "perf probe [<options>] --line 'LINEDESC'", |
| 308 | "perf probe [<options>] --vars 'PROBEPOINT'", |
Masami Hiramatsu | f3ab481 | 2010-02-25 08:35:12 -0500 | [diff] [blame] | 309 | #endif |
Arnaldo Carvalho de Melo | 11c4e4a | 2012-10-01 15:20:58 -0300 | [diff] [blame] | 310 | NULL |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 311 | }; |
Arnaldo Carvalho de Melo | 11c4e4a | 2012-10-01 15:20:58 -0300 | [diff] [blame] | 312 | const struct option options[] = { |
Ian Munsie | c055564 | 2010-04-13 18:37:33 +1000 | [diff] [blame] | 313 | OPT_INCR('v', "verbose", &verbose, |
Masami Hiramatsu | 89c69c0 | 2009-10-16 20:08:10 -0400 | [diff] [blame] | 314 | "be more verbose (show parsed arguments, etc)"), |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 315 | OPT_BOOLEAN('l', "list", ¶ms.list_events, |
Masami Hiramatsu | fac13fd | 2009-12-15 10:31:14 -0500 | [diff] [blame] | 316 | "list up current probe events"), |
Masami Hiramatsu | fa28244 | 2009-12-08 17:03:23 -0500 | [diff] [blame] | 317 | OPT_CALLBACK('d', "del", NULL, "[GROUP:]EVENT", "delete a probe event.", |
| 318 | opt_del_probe_event), |
Masami Hiramatsu | 46ab492 | 2009-10-27 16:43:02 -0400 | [diff] [blame] | 319 | OPT_CALLBACK('a', "add", NULL, |
Ingo Molnar | 89fe808 | 2013-09-30 12:07:11 +0200 | [diff] [blame] | 320 | #ifdef HAVE_DWARF_SUPPORT |
Masami Hiramatsu | 32cb0dd | 2010-03-03 22:38:43 -0500 | [diff] [blame] | 321 | "[EVENT=]FUNC[@SRC][+OFF|%return|:RL|;PT]|SRC:AL|SRC;PT" |
Masami Hiramatsu | 4848193 | 2010-04-12 13:16:53 -0400 | [diff] [blame] | 322 | " [[NAME=]ARG ...]", |
Masami Hiramatsu | 4b4da7f | 2010-03-22 13:10:26 -0300 | [diff] [blame] | 323 | #else |
Masami Hiramatsu | 4848193 | 2010-04-12 13:16:53 -0400 | [diff] [blame] | 324 | "[EVENT=]FUNC[+OFF|%return] [[NAME=]ARG ...]", |
Masami Hiramatsu | 23e8ec0 | 2009-10-07 18:28:30 -0400 | [diff] [blame] | 325 | #endif |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 326 | "probe point definition, where\n" |
Masami Hiramatsu | af663d7 | 2009-12-15 10:32:18 -0500 | [diff] [blame] | 327 | "\t\tGROUP:\tGroup name (optional)\n" |
| 328 | "\t\tEVENT:\tEvent name\n" |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 329 | "\t\tFUNC:\tFunction name\n" |
Masami Hiramatsu | 2a9c8c3 | 2010-02-25 08:36:12 -0500 | [diff] [blame] | 330 | "\t\tOFF:\tOffset from function entry (in byte)\n" |
Masami Hiramatsu | 253977b | 2009-10-27 16:43:10 -0400 | [diff] [blame] | 331 | "\t\t%return:\tPut the probe at function return\n" |
Ingo Molnar | 89fe808 | 2013-09-30 12:07:11 +0200 | [diff] [blame] | 332 | #ifdef HAVE_DWARF_SUPPORT |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 333 | "\t\tSRC:\tSource code path\n" |
Masami Hiramatsu | 2a9c8c3 | 2010-02-25 08:36:12 -0500 | [diff] [blame] | 334 | "\t\tRL:\tRelative line number from function entry.\n" |
| 335 | "\t\tAL:\tAbsolute line number in file.\n" |
| 336 | "\t\tPT:\tLazy expression of line code.\n" |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 337 | "\t\tARG:\tProbe argument (local variable name or\n" |
Masami Hiramatsu | 50656ee | 2009-11-30 19:19:58 -0500 | [diff] [blame] | 338 | "\t\t\tkprobe-tracer argument format.)\n", |
Masami Hiramatsu | 4b4da7f | 2010-03-22 13:10:26 -0300 | [diff] [blame] | 339 | #else |
| 340 | "\t\tARG:\tProbe argument (kprobe-tracer argument format.)\n", |
| 341 | #endif |
Masami Hiramatsu | 253977b | 2009-10-27 16:43:10 -0400 | [diff] [blame] | 342 | opt_add_probe_event), |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 343 | OPT_BOOLEAN('f', "force", ¶ms.force_add, "forcibly add events" |
Masami Hiramatsu | d761b08 | 2009-12-15 10:32:25 -0500 | [diff] [blame] | 344 | " with existing name"), |
Ingo Molnar | 89fe808 | 2013-09-30 12:07:11 +0200 | [diff] [blame] | 345 | #ifdef HAVE_DWARF_SUPPORT |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 346 | OPT_CALLBACK('L', "line", NULL, |
Masami Hiramatsu | 085ea73 | 2010-04-02 12:50:39 -0400 | [diff] [blame] | 347 | "FUNC[:RLN[+NUM|-RLN2]]|SRC:ALN[+NUM|-ALN2]", |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 348 | "Show source code lines.", opt_show_lines), |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 349 | OPT_CALLBACK('V', "vars", NULL, |
| 350 | "FUNC[@SRC][+OFF|%return|:RL|;PT]|SRC:AL|SRC;PT", |
| 351 | "Show accessible variables on PROBEDEF", opt_show_vars), |
Masami Hiramatsu | fb8c5a5 | 2010-10-21 19:13:35 +0900 | [diff] [blame] | 352 | OPT_BOOLEAN('\0', "externs", ¶ms.show_ext_vars, |
| 353 | "Show external variables too (with --vars only)"), |
Masami Hiramatsu | 4b4da7f | 2010-03-22 13:10:26 -0300 | [diff] [blame] | 354 | OPT_STRING('k', "vmlinux", &symbol_conf.vmlinux_name, |
| 355 | "file", "vmlinux pathname"), |
Chase Douglas | 9ed7e1b | 2010-06-14 15:26:30 -0400 | [diff] [blame] | 356 | OPT_STRING('s', "source", &symbol_conf.source_prefix, |
| 357 | "directory", "path to kernel source"), |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 358 | OPT_CALLBACK('m', "module", NULL, "modname|path", |
| 359 | "target module name (for online) or path (for offline)", |
| 360 | opt_set_target), |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 361 | #endif |
Masami Hiramatsu | f4d7da4 | 2010-03-16 18:06:05 -0400 | [diff] [blame] | 362 | OPT__DRY_RUN(&probe_event_dry_run), |
Masami Hiramatsu | ef4a356 | 2010-04-21 15:56:40 -0400 | [diff] [blame] | 363 | OPT_INTEGER('\0', "max-probes", ¶ms.max_probe_points, |
| 364 | "Set how many probe points can be found for a probe."), |
Masami Hiramatsu | e80711c | 2011-01-13 21:46:11 +0900 | [diff] [blame] | 365 | OPT_BOOLEAN('F', "funcs", ¶ms.show_funcs, |
| 366 | "Show potential probe-able functions."), |
Masami Hiramatsu | 3c42258 | 2011-01-20 23:15:45 +0900 | [diff] [blame] | 367 | OPT_CALLBACK('\0', "filter", NULL, |
| 368 | "[!]FILTER", "Set a filter (with --vars/funcs only)\n" |
| 369 | "\t\t\t(default: \"" DEFAULT_VAR_FILTER "\" for --vars,\n" |
| 370 | "\t\t\t \"" DEFAULT_FUNC_FILTER "\" for --funcs)", |
| 371 | opt_set_filter), |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 372 | OPT_CALLBACK('x', "exec", NULL, "executable|path", |
| 373 | "target executable name or path", opt_set_target), |
Azat Khuzhin | 35e17b2 | 2013-10-28 12:04:24 +0400 | [diff] [blame] | 374 | OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle, |
| 375 | "Disable symbol demangling"), |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 376 | OPT_END() |
Arnaldo Carvalho de Melo | 11c4e4a | 2012-10-01 15:20:58 -0300 | [diff] [blame] | 377 | }; |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 378 | int ret; |
| 379 | |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 380 | argc = parse_options(argc, argv, options, probe_usage, |
Masami Hiramatsu | 46ab492 | 2009-10-27 16:43:02 -0400 | [diff] [blame] | 381 | PARSE_OPT_STOP_AT_NON_OPTION); |
Masami Hiramatsu | ce11a60 | 2009-12-15 10:31:28 -0500 | [diff] [blame] | 382 | if (argc > 0) { |
| 383 | if (strcmp(argv[0], "-") == 0) { |
| 384 | pr_warning(" Error: '-' is not supported.\n"); |
| 385 | usage_with_options(probe_usage, options); |
| 386 | } |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 387 | ret = parse_probe_event_argv(argc, argv); |
| 388 | if (ret < 0) { |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 389 | pr_err_with_code(" Error: Command Parse Error.", ret); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 390 | return ret; |
| 391 | } |
Masami Hiramatsu | ce11a60 | 2009-12-15 10:31:28 -0500 | [diff] [blame] | 392 | } |
Masami Hiramatsu | 46ab492 | 2009-10-27 16:43:02 -0400 | [diff] [blame] | 393 | |
Masami Hiramatsu | ef4a356 | 2010-04-21 15:56:40 -0400 | [diff] [blame] | 394 | if (params.max_probe_points == 0) |
| 395 | params.max_probe_points = MAX_PROBES; |
| 396 | |
Masami Hiramatsu | 4235b04 | 2010-03-16 18:06:12 -0400 | [diff] [blame] | 397 | if ((!params.nevents && !params.dellist && !params.list_events && |
Masami Hiramatsu | e80711c | 2011-01-13 21:46:11 +0900 | [diff] [blame] | 398 | !params.show_lines && !params.show_funcs)) |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 399 | usage_with_options(probe_usage, options); |
| 400 | |
Franck Bui-Huu | fd930ff | 2010-12-10 14:06:03 +0100 | [diff] [blame] | 401 | /* |
| 402 | * Only consider the user's kernel image path if given. |
| 403 | */ |
| 404 | symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL); |
| 405 | |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 406 | if (params.list_events) { |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 407 | if (params.mod_events) { |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 408 | pr_err(" Error: Don't use --list with --add/--del.\n"); |
Masami Hiramatsu | fa28244 | 2009-12-08 17:03:23 -0500 | [diff] [blame] | 409 | usage_with_options(probe_usage, options); |
| 410 | } |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 411 | if (params.show_lines) { |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 412 | pr_err(" Error: Don't use --list with --line.\n"); |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 413 | usage_with_options(probe_usage, options); |
| 414 | } |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 415 | if (params.show_vars) { |
| 416 | pr_err(" Error: Don't use --list with --vars.\n"); |
| 417 | usage_with_options(probe_usage, options); |
| 418 | } |
Masami Hiramatsu | e80711c | 2011-01-13 21:46:11 +0900 | [diff] [blame] | 419 | if (params.show_funcs) { |
| 420 | pr_err(" Error: Don't use --list with --funcs.\n"); |
| 421 | usage_with_options(probe_usage, options); |
| 422 | } |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 423 | if (params.uprobes) { |
| 424 | pr_warning(" Error: Don't use --list with --exec.\n"); |
| 425 | usage_with_options(probe_usage, options); |
| 426 | } |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 427 | ret = show_perf_probe_events(); |
| 428 | if (ret < 0) |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 429 | pr_err_with_code(" Error: Failed to show event list.", ret); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 430 | return ret; |
Masami Hiramatsu | 4de189f | 2009-11-30 19:20:17 -0500 | [diff] [blame] | 431 | } |
Masami Hiramatsu | e80711c | 2011-01-13 21:46:11 +0900 | [diff] [blame] | 432 | if (params.show_funcs) { |
| 433 | if (params.nevents != 0 || params.dellist) { |
| 434 | pr_err(" Error: Don't use --funcs with" |
| 435 | " --add/--del.\n"); |
| 436 | usage_with_options(probe_usage, options); |
| 437 | } |
| 438 | if (params.show_lines) { |
| 439 | pr_err(" Error: Don't use --funcs with --line.\n"); |
| 440 | usage_with_options(probe_usage, options); |
| 441 | } |
| 442 | if (params.show_vars) { |
| 443 | pr_err(" Error: Don't use --funcs with --vars.\n"); |
| 444 | usage_with_options(probe_usage, options); |
| 445 | } |
Masami Hiramatsu | 3c42258 | 2011-01-20 23:15:45 +0900 | [diff] [blame] | 446 | if (!params.filter) |
| 447 | params.filter = strfilter__new(DEFAULT_FUNC_FILTER, |
| 448 | NULL); |
Srikar Dronamraju | 225466f | 2012-04-16 17:39:09 +0530 | [diff] [blame] | 449 | ret = show_available_funcs(params.target, params.filter, |
| 450 | params.uprobes); |
Masami Hiramatsu | 3c42258 | 2011-01-20 23:15:45 +0900 | [diff] [blame] | 451 | strfilter__delete(params.filter); |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 452 | params.filter = NULL; |
Masami Hiramatsu | e80711c | 2011-01-13 21:46:11 +0900 | [diff] [blame] | 453 | if (ret < 0) |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 454 | pr_err_with_code(" Error: Failed to show functions.", ret); |
Masami Hiramatsu | e80711c | 2011-01-13 21:46:11 +0900 | [diff] [blame] | 455 | return ret; |
| 456 | } |
Masami Hiramatsu | 4de189f | 2009-11-30 19:20:17 -0500 | [diff] [blame] | 457 | |
Ingo Molnar | 89fe808 | 2013-09-30 12:07:11 +0200 | [diff] [blame] | 458 | #ifdef HAVE_DWARF_SUPPORT |
Masami Hiramatsu | fb7345b | 2013-12-26 05:41:53 +0000 | [diff] [blame] | 459 | if (params.show_lines) { |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 460 | if (params.mod_events) { |
| 461 | pr_err(" Error: Don't use --line with" |
| 462 | " --add/--del.\n"); |
| 463 | usage_with_options(probe_usage, options); |
| 464 | } |
| 465 | if (params.show_vars) { |
| 466 | pr_err(" Error: Don't use --line with --vars.\n"); |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 467 | usage_with_options(probe_usage, options); |
| 468 | } |
Masami Hiramatsu | e0faa8d | 2010-03-16 18:05:37 -0400 | [diff] [blame] | 469 | |
Srikar Dronamraju | 4eced23 | 2012-02-02 19:50:40 +0530 | [diff] [blame] | 470 | ret = show_line_range(¶ms.line_range, params.target); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 471 | if (ret < 0) |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 472 | pr_err_with_code(" Error: Failed to show lines.", ret); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 473 | return ret; |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 474 | } |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 475 | if (params.show_vars) { |
| 476 | if (params.mod_events) { |
| 477 | pr_err(" Error: Don't use --vars with" |
| 478 | " --add/--del.\n"); |
| 479 | usage_with_options(probe_usage, options); |
| 480 | } |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 481 | if (!params.filter) |
| 482 | params.filter = strfilter__new(DEFAULT_VAR_FILTER, |
| 483 | NULL); |
| 484 | |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 485 | ret = show_available_vars(params.events, params.nevents, |
Masami Hiramatsu | fb8c5a5 | 2010-10-21 19:13:35 +0900 | [diff] [blame] | 486 | params.max_probe_points, |
Srikar Dronamraju | 4eced23 | 2012-02-02 19:50:40 +0530 | [diff] [blame] | 487 | params.target, |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 488 | params.filter, |
Masami Hiramatsu | fb8c5a5 | 2010-10-21 19:13:35 +0900 | [diff] [blame] | 489 | params.show_ext_vars); |
Masami Hiramatsu | bd09d7b | 2011-01-20 23:15:39 +0900 | [diff] [blame] | 490 | strfilter__delete(params.filter); |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 491 | params.filter = NULL; |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 492 | if (ret < 0) |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 493 | pr_err_with_code(" Error: Failed to show vars.", ret); |
Masami Hiramatsu | cf6eb48 | 2010-10-21 19:13:23 +0900 | [diff] [blame] | 494 | return ret; |
| 495 | } |
Masami Hiramatsu | 631c9de | 2010-01-06 09:45:34 -0500 | [diff] [blame] | 496 | #endif |
| 497 | |
Masami Hiramatsu | 12a1fad | 2010-03-16 18:05:44 -0400 | [diff] [blame] | 498 | if (params.dellist) { |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 499 | ret = del_perf_probe_events(params.dellist); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 500 | if (ret < 0) { |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 501 | pr_err_with_code(" Error: Failed to delete events.", ret); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 502 | return ret; |
| 503 | } |
Masami Hiramatsu | fa28244 | 2009-12-08 17:03:23 -0500 | [diff] [blame] | 504 | } |
| 505 | |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 506 | if (params.nevents) { |
| 507 | ret = add_perf_probe_events(params.events, params.nevents, |
Masami Hiramatsu | c82ec0a | 2010-10-21 19:13:29 +0900 | [diff] [blame] | 508 | params.max_probe_points, |
Srikar Dronamraju | 4eced23 | 2012-02-02 19:50:40 +0530 | [diff] [blame] | 509 | params.target, |
Masami Hiramatsu | c82ec0a | 2010-10-21 19:13:29 +0900 | [diff] [blame] | 510 | params.force_add); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 511 | if (ret < 0) { |
Masami Hiramatsu | b4bf113 | 2014-06-06 07:13:52 +0000 | [diff] [blame] | 512 | pr_err_with_code(" Error: Failed to add events.", ret); |
Masami Hiramatsu | 146a143 | 2010-04-12 13:17:42 -0400 | [diff] [blame] | 513 | return ret; |
| 514 | } |
| 515 | } |
Masami Hiramatsu | 4ea42b1 | 2009-10-08 17:17:38 -0400 | [diff] [blame] | 516 | return 0; |
| 517 | } |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 518 | |
| 519 | int cmd_probe(int argc, const char **argv, const char *prefix) |
| 520 | { |
| 521 | int ret; |
| 522 | |
Masami Hiramatsu | 5a62257 | 2014-02-06 05:32:09 +0000 | [diff] [blame] | 523 | ret = init_params(); |
| 524 | if (!ret) { |
| 525 | ret = __cmd_probe(argc, argv, prefix); |
| 526 | cleanup_params(); |
| 527 | } |
Masami Hiramatsu | e53b00d | 2014-01-16 09:39:47 +0000 | [diff] [blame] | 528 | |
| 529 | return ret; |
| 530 | } |