blob: e7c8ab1b54bd8dc366b81114f76f5fb8d9dc5c7d [file] [log] [blame]
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001#!/usr/bin/perl -w
2# (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit)
Andy Whitcroft00df3442007-06-08 13:47:06 -07003# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
Andy Whitcroft0a920b52007-06-01 00:46:48 -07004# (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc)
5# Licensed under the terms of the GNU GPL License version 2
6
7use strict;
8
9my $P = $0;
Andy Whitcroft00df3442007-06-08 13:47:06 -070010$P =~ s@.*/@@g;
Andy Whitcroft0a920b52007-06-01 00:46:48 -070011
Andy Whitcroft6cbb2e72008-07-23 21:28:55 -070012my $V = '0.20';
Andy Whitcroft0a920b52007-06-01 00:46:48 -070013
14use Getopt::Long qw(:config no_auto_abbrev);
15
16my $quiet = 0;
17my $tree = 1;
18my $chk_signoff = 1;
19my $chk_patch = 1;
Andy Whitcroft653d4872007-06-23 17:16:34 -070020my $tst_type = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -070021my $tst_only;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070022my $emacs = 0;
Andy Whitcroft8905a672007-11-28 16:21:06 -080023my $terse = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070024my $file = 0;
25my $check = 0;
Andy Whitcroft8905a672007-11-28 16:21:06 -080026my $summary = 1;
27my $mailback = 0;
Andy Whitcroft13214ad2008-02-08 04:22:03 -080028my $summary_file = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070029my $root;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -080030my %debug;
Andy Whitcroft0a920b52007-06-01 00:46:48 -070031GetOptions(
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070032 'q|quiet+' => \$quiet,
Andy Whitcroft0a920b52007-06-01 00:46:48 -070033 'tree!' => \$tree,
34 'signoff!' => \$chk_signoff,
35 'patch!' => \$chk_patch,
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070036 'emacs!' => \$emacs,
Andy Whitcroft8905a672007-11-28 16:21:06 -080037 'terse!' => \$terse,
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070038 'file!' => \$file,
39 'subjective!' => \$check,
40 'strict!' => \$check,
41 'root=s' => \$root,
Andy Whitcroft8905a672007-11-28 16:21:06 -080042 'summary!' => \$summary,
43 'mailback!' => \$mailback,
Andy Whitcroft13214ad2008-02-08 04:22:03 -080044 'summary-file!' => \$summary_file,
45
Andy Whitcroftc2fdda02008-02-08 04:20:54 -080046 'debug=s' => \%debug,
Andy Whitcroft13214ad2008-02-08 04:22:03 -080047 'test-type!' => \$tst_type,
Andy Whitcroft773647a2008-03-28 14:15:58 -070048 'test-only=s' => \$tst_only,
Andy Whitcroft0a920b52007-06-01 00:46:48 -070049) or exit;
50
51my $exit = 0;
52
53if ($#ARGV < 0) {
Andy Whitcroft00df3442007-06-08 13:47:06 -070054 print "usage: $P [options] patchfile\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -070055 print "version: $V\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -080056 print "options: -q => quiet\n";
57 print " --no-tree => run without a kernel tree\n";
58 print " --terse => one line per report\n";
59 print " --emacs => emacs compile window format\n";
60 print " --file => check a source file\n";
61 print " --strict => enable more subjective tests\n";
62 print " --root => path to the kernel tree root\n";
63 print " --no-summary => suppress the per-file summary\n";
64 print " --summary-file => include the filename in summary\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -070065 exit(1);
66}
67
Andy Whitcroftc2fdda02008-02-08 04:20:54 -080068my $dbg_values = 0;
69my $dbg_possible = 0;
70for my $key (keys %debug) {
71 eval "\${dbg_$key} = '$debug{$key}';"
72}
73
Andy Whitcroft8905a672007-11-28 16:21:06 -080074if ($terse) {
75 $emacs = 1;
76 $quiet++;
77}
78
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070079if ($tree) {
80 if (defined $root) {
81 if (!top_of_kernel_tree($root)) {
82 die "$P: $root: --root does not point at a valid tree\n";
83 }
84 } else {
85 if (top_of_kernel_tree('.')) {
86 $root = '.';
87 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
88 top_of_kernel_tree($1)) {
89 $root = $1;
90 }
91 }
92
93 if (!defined $root) {
94 print "Must be run from the top-level dir. of a kernel tree\n";
95 exit(2);
96 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -070097}
98
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070099my $emitted_corrupt = 0;
100
101our $Ident = qr{[A-Za-z_][A-Za-z\d_]*};
102our $Storage = qr{extern|static|asmlinkage};
103our $Sparse = qr{
104 __user|
105 __kernel|
106 __force|
107 __iomem|
108 __must_check|
109 __init_refok|
Andy Whitcroftcf655042008-03-04 14:28:20 -0800110 __kprobes
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700111 }x;
112our $Attribute = qr{
113 const|
114 __read_mostly|
115 __kprobes|
116 __(?:mem|cpu|dev|)(?:initdata|init)
117 }x;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700118our $Modifier;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700119our $Inline = qr{inline|__always_inline|noinline};
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700120our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
121our $Lval = qr{$Ident(?:$Member)*};
122
123our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
124our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
125our $Operators = qr{
126 <=|>=|==|!=|
127 =>|->|<<|>>|<|>|!|~|
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800128 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700129 }x;
130
Andy Whitcroft8905a672007-11-28 16:21:06 -0800131our $NonptrType;
132our $Type;
133our $Declare;
134
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700135our $UTF8 = qr {
136 [\x09\x0A\x0D\x20-\x7E] # ASCII
137 | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
138 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
139 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
140 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
141 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
142 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
143 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
144}x;
145
Andy Whitcroft8905a672007-11-28 16:21:06 -0800146our @typeList = (
147 qr{void},
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700148 qr{(?:unsigned\s+)?char},
149 qr{(?:unsigned\s+)?short},
150 qr{(?:unsigned\s+)?int},
151 qr{(?:unsigned\s+)?long},
152 qr{(?:unsigned\s+)?long\s+int},
153 qr{(?:unsigned\s+)?long\s+long},
154 qr{(?:unsigned\s+)?long\s+long\s+int},
Andy Whitcroft8905a672007-11-28 16:21:06 -0800155 qr{unsigned},
156 qr{float},
157 qr{double},
158 qr{bool},
Andy Whitcroft8905a672007-11-28 16:21:06 -0800159 qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)},
160 qr{struct\s+$Ident},
161 qr{union\s+$Ident},
162 qr{enum\s+$Ident},
163 qr{${Ident}_t},
164 qr{${Ident}_handler},
165 qr{${Ident}_handler_fn},
166);
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700167our @modifierList = (
168 qr{fastcall},
169);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800170
171sub build_types {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700172 my $mods = "(?: \n" . join("|\n ", @modifierList) . "\n)";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800173 my $all = "(?: \n" . join("|\n ", @typeList) . "\n)";
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700174 $Modifier = qr{(?:$Attribute|$Sparse|$mods)};
Andy Whitcroft8905a672007-11-28 16:21:06 -0800175 $NonptrType = qr{
Andy Whitcroft8905a672007-11-28 16:21:06 -0800176 (?:const\s+)?
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700177 (?:$mods\s+)?
Andy Whitcroftcf655042008-03-04 14:28:20 -0800178 (?:
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700179 (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
180 (?:${all}\b)
Andy Whitcroftcf655042008-03-04 14:28:20 -0800181 )
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700182 (?:\s+$Modifier|\s+const)*
Andy Whitcroft8905a672007-11-28 16:21:06 -0800183 }x;
184 $Type = qr{
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700185 $NonptrType
Andy Whitcroft8905a672007-11-28 16:21:06 -0800186 (?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700187 (?:\s+$Inline|\s+$Modifier)*
Andy Whitcroft8905a672007-11-28 16:21:06 -0800188 }x;
189 $Declare = qr{(?:$Storage\s+)?$Type};
190}
191build_types();
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700192
193$chk_signoff = 0 if ($file);
194
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700195my @dep_includes = ();
196my @dep_functions = ();
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700197my $removal = "Documentation/feature-removal-schedule.txt";
198if ($tree && -f "$root/$removal") {
199 open(REMOVE, "<$root/$removal") ||
200 die "$P: $removal: open failed - $!\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700201 while (<REMOVE>) {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700202 if (/^Check:\s+(.*\S)/) {
203 for my $entry (split(/[, ]+/, $1)) {
204 if ($entry =~ m@include/(.*)@) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700205 push(@dep_includes, $1);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700206
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700207 } elsif ($entry !~ m@/@) {
208 push(@dep_functions, $entry);
209 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700210 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700211 }
212 }
213}
214
Andy Whitcroft00df3442007-06-08 13:47:06 -0700215my @rawlines = ();
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800216my @lines = ();
217my $vname;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700218for my $filename (@ARGV) {
219 if ($file) {
220 open(FILE, "diff -u /dev/null $filename|") ||
221 die "$P: $filename: diff failed - $!\n";
222 } else {
223 open(FILE, "<$filename") ||
224 die "$P: $filename: open failed - $!\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700225 }
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800226 if ($filename eq '-') {
227 $vname = 'Your patch';
228 } else {
229 $vname = $filename;
230 }
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700231 while (<FILE>) {
232 chomp;
233 push(@rawlines, $_);
234 }
235 close(FILE);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800236 if (!process($filename)) {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700237 $exit = 1;
238 }
239 @rawlines = ();
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800240 @lines = ();
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700241}
242
243exit($exit);
244
245sub top_of_kernel_tree {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700246 my ($root) = @_;
247
248 my @tree_check = (
249 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
250 "README", "Documentation", "arch", "include", "drivers",
251 "fs", "init", "ipc", "kernel", "lib", "scripts",
252 );
253
254 foreach my $check (@tree_check) {
255 if (! -e $root . '/' . $check) {
256 return 0;
257 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700258 }
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700259 return 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700260}
261
262sub expand_tabs {
263 my ($str) = @_;
264
265 my $res = '';
266 my $n = 0;
267 for my $c (split(//, $str)) {
268 if ($c eq "\t") {
269 $res .= ' ';
270 $n++;
271 for (; ($n % 8) != 0; $n++) {
272 $res .= ' ';
273 }
274 next;
275 }
276 $res .= $c;
277 $n++;
278 }
279
280 return $res;
281}
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700282sub copy_spacing {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700283 (my $res = shift) =~ tr/\t/ /c;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700284 return $res;
285}
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700286
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700287sub line_stats {
288 my ($line) = @_;
289
290 # Drop the diff line leader and expand tabs
291 $line =~ s/^.//;
292 $line = expand_tabs($line);
293
294 # Pick the indent from the front of the line.
295 my ($white) = ($line =~ /^(\s*)/);
296
297 return (length($line), length($white));
298}
299
Andy Whitcroft773647a2008-03-28 14:15:58 -0700300my $sanitise_quote = '';
301
302sub sanitise_line_reset {
303 my ($in_comment) = @_;
304
305 if ($in_comment) {
306 $sanitise_quote = '*/';
307 } else {
308 $sanitise_quote = '';
309 }
310}
Andy Whitcroft00df3442007-06-08 13:47:06 -0700311sub sanitise_line {
312 my ($line) = @_;
313
314 my $res = '';
315 my $l = '';
316
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800317 my $qlen = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700318 my $off = 0;
319 my $c;
Andy Whitcroft00df3442007-06-08 13:47:06 -0700320
Andy Whitcroft773647a2008-03-28 14:15:58 -0700321 # Always copy over the diff marker.
322 $res = substr($line, 0, 1);
323
324 for ($off = 1; $off < length($line); $off++) {
325 $c = substr($line, $off, 1);
326
327 # Comments we are wacking completly including the begin
328 # and end, all to $;.
329 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
330 $sanitise_quote = '*/';
331
332 substr($res, $off, 2, "$;$;");
333 $off++;
334 next;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800335 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700336 if (substr($line, $off, 2) eq '*/') {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700337 $sanitise_quote = '';
338 substr($res, $off, 2, "$;$;");
339 $off++;
340 next;
341 }
342
343 # A \ in a string means ignore the next character.
344 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
345 $c eq "\\") {
346 substr($res, $off, 2, 'XX');
347 $off++;
348 next;
349 }
350 # Regular quotes.
351 if ($c eq "'" || $c eq '"') {
352 if ($sanitise_quote eq '') {
353 $sanitise_quote = $c;
354
355 substr($res, $off, 1, $c);
Andy Whitcroft00df3442007-06-08 13:47:06 -0700356 next;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700357 } elsif ($sanitise_quote eq $c) {
358 $sanitise_quote = '';
Andy Whitcroft00df3442007-06-08 13:47:06 -0700359 }
360 }
Andy Whitcroft773647a2008-03-28 14:15:58 -0700361
362 #print "SQ:$sanitise_quote\n";
363 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
364 substr($res, $off, 1, $;);
365 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
366 substr($res, $off, 1, 'X');
Andy Whitcroft00df3442007-06-08 13:47:06 -0700367 } else {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700368 substr($res, $off, 1, $c);
Andy Whitcroft00df3442007-06-08 13:47:06 -0700369 }
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800370 }
371
372 # The pathname on a #include may be surrounded by '<' and '>'.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700373 if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800374 my $clean = 'X' x length($1);
375 $res =~ s@\<.*\>@<$clean>@;
376
377 # The whole of a #error is a string.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700378 } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800379 my $clean = 'X' x length($1);
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700380 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800381 }
382
Andy Whitcroft00df3442007-06-08 13:47:06 -0700383 return $res;
384}
385
Andy Whitcroft8905a672007-11-28 16:21:06 -0800386sub ctx_statement_block {
387 my ($linenr, $remain, $off) = @_;
388 my $line = $linenr - 1;
389 my $blk = '';
390 my $soff = $off;
391 my $coff = $off - 1;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700392 my $coff_set = 0;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800393
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800394 my $loff = 0;
395
Andy Whitcroft8905a672007-11-28 16:21:06 -0800396 my $type = '';
397 my $level = 0;
Andy Whitcroftcf655042008-03-04 14:28:20 -0800398 my $p;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800399 my $c;
400 my $len = 0;
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800401
402 my $remainder;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800403 while (1) {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700404 #warn "CSB: blk<$blk> remain<$remain>\n";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800405 # If we are about to drop off the end, pull in more
406 # context.
407 if ($off >= $len) {
408 for (; $remain > 0; $line++) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800409 next if ($lines[$line] =~ /^-/);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800410 $remain--;
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800411 $loff = $len;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800412 $blk .= $lines[$line] . "\n";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800413 $len = length($blk);
414 $line++;
415 last;
416 }
417 # Bail if there is no further context.
418 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800419 if ($off >= $len) {
Andy Whitcroft8905a672007-11-28 16:21:06 -0800420 last;
421 }
422 }
Andy Whitcroftcf655042008-03-04 14:28:20 -0800423 $p = $c;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800424 $c = substr($blk, $off, 1);
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800425 $remainder = substr($blk, $off);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800426
Andy Whitcroft773647a2008-03-28 14:15:58 -0700427 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800428 # Statement ends at the ';' or a close '}' at the
429 # outermost level.
430 if ($level == 0 && $c eq ';') {
431 last;
432 }
433
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800434 # An else is really a conditional as long as its not else if
Andy Whitcroft773647a2008-03-28 14:15:58 -0700435 if ($level == 0 && $coff_set == 0 &&
436 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
437 $remainder =~ /^(else)(?:\s|{)/ &&
438 $remainder !~ /^else\s+if\b/) {
439 $coff = $off + length($1) - 1;
440 $coff_set = 1;
441 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
442 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800443 }
444
Andy Whitcroft8905a672007-11-28 16:21:06 -0800445 if (($type eq '' || $type eq '(') && $c eq '(') {
446 $level++;
447 $type = '(';
448 }
449 if ($type eq '(' && $c eq ')') {
450 $level--;
451 $type = ($level != 0)? '(' : '';
452
453 if ($level == 0 && $coff < $soff) {
454 $coff = $off;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700455 $coff_set = 1;
456 #warn "CSB: mark coff<$coff>\n";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800457 }
458 }
459 if (($type eq '' || $type eq '{') && $c eq '{') {
460 $level++;
461 $type = '{';
462 }
463 if ($type eq '{' && $c eq '}') {
464 $level--;
465 $type = ($level != 0)? '{' : '';
466
467 if ($level == 0) {
468 last;
469 }
470 }
471 $off++;
472 }
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -0700473 # We are truly at the end, so shuffle to the next line.
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800474 if ($off == $len) {
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -0700475 $loff = $len + 1;
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800476 $line++;
477 $remain--;
478 }
Andy Whitcroft8905a672007-11-28 16:21:06 -0800479
480 my $statement = substr($blk, $soff, $off - $soff + 1);
481 my $condition = substr($blk, $soff, $coff - $soff + 1);
482
483 #warn "STATEMENT<$statement>\n";
484 #warn "CONDITION<$condition>\n";
485
Andy Whitcroft773647a2008-03-28 14:15:58 -0700486 #print "coff<$coff> soff<$off> loff<$loff>\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800487
488 return ($statement, $condition,
489 $line, $remain + 1, $off - $loff + 1, $level);
490}
491
Andy Whitcroftcf655042008-03-04 14:28:20 -0800492sub statement_lines {
493 my ($stmt) = @_;
494
495 # Strip the diff line prefixes and rip blank lines at start and end.
496 $stmt =~ s/(^|\n)./$1/g;
497 $stmt =~ s/^\s*//;
498 $stmt =~ s/\s*$//;
499
500 my @stmt_lines = ($stmt =~ /\n/g);
501
502 return $#stmt_lines + 2;
503}
504
505sub statement_rawlines {
506 my ($stmt) = @_;
507
508 my @stmt_lines = ($stmt =~ /\n/g);
509
510 return $#stmt_lines + 2;
511}
512
513sub statement_block_size {
514 my ($stmt) = @_;
515
516 $stmt =~ s/(^|\n)./$1/g;
517 $stmt =~ s/^\s*{//;
518 $stmt =~ s/}\s*$//;
519 $stmt =~ s/^\s*//;
520 $stmt =~ s/\s*$//;
521
522 my @stmt_lines = ($stmt =~ /\n/g);
523 my @stmt_statements = ($stmt =~ /;/g);
524
525 my $stmt_lines = $#stmt_lines + 2;
526 my $stmt_statements = $#stmt_statements + 1;
527
528 if ($stmt_lines > $stmt_statements) {
529 return $stmt_lines;
530 } else {
531 return $stmt_statements;
532 }
533}
534
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800535sub ctx_statement_full {
536 my ($linenr, $remain, $off) = @_;
537 my ($statement, $condition, $level);
538
539 my (@chunks);
540
Andy Whitcroftcf655042008-03-04 14:28:20 -0800541 # Grab the first conditional/block pair.
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800542 ($statement, $condition, $linenr, $remain, $off, $level) =
543 ctx_statement_block($linenr, $remain, $off);
Andy Whitcroft773647a2008-03-28 14:15:58 -0700544 #print "F: c<$condition> s<$statement> remain<$remain>\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -0800545 push(@chunks, [ $condition, $statement ]);
546 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
547 return ($level, $linenr, @chunks);
548 }
549
550 # Pull in the following conditional/block pairs and see if they
551 # could continue the statement.
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800552 for (;;) {
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800553 ($statement, $condition, $linenr, $remain, $off, $level) =
554 ctx_statement_block($linenr, $remain, $off);
Andy Whitcroftcf655042008-03-04 14:28:20 -0800555 #print "C: c<$condition> s<$statement> remain<$remain>\n";
Andy Whitcroft773647a2008-03-28 14:15:58 -0700556 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
Andy Whitcroftcf655042008-03-04 14:28:20 -0800557 #print "C: push\n";
558 push(@chunks, [ $condition, $statement ]);
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800559 }
560
561 return ($level, $linenr, @chunks);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800562}
563
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700564sub ctx_block_get {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700565 my ($linenr, $remain, $outer, $open, $close, $off) = @_;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700566 my $line;
567 my $start = $linenr - 1;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700568 my $blk = '';
569 my @o;
570 my @c;
571 my @res = ();
572
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700573 my $level = 0;
Andy Whitcroft00df3442007-06-08 13:47:06 -0700574 for ($line = $start; $remain > 0; $line++) {
575 next if ($rawlines[$line] =~ /^-/);
576 $remain--;
577
578 $blk .= $rawlines[$line];
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700579 foreach my $c (split(//, $rawlines[$line])) {
580 ##print "C<$c>L<$level><$open$close>O<$off>\n";
581 if ($off > 0) {
582 $off--;
583 next;
584 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700585
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700586 if ($c eq $close && $level > 0) {
587 $level--;
588 last if ($level == 0);
589 } elsif ($c eq $open) {
590 $level++;
591 }
592 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700593
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700594 if (!$outer || $level <= 1) {
Andy Whitcroft00df3442007-06-08 13:47:06 -0700595 push(@res, $rawlines[$line]);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700596 }
597
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700598 last if ($level == 0);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700599 }
600
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700601 return ($level, @res);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700602}
603sub ctx_block_outer {
604 my ($linenr, $remain) = @_;
605
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700606 my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
607 return @r;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700608}
609sub ctx_block {
610 my ($linenr, $remain) = @_;
611
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700612 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
613 return @r;
Andy Whitcroft653d4872007-06-23 17:16:34 -0700614}
615sub ctx_statement {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700616 my ($linenr, $remain, $off) = @_;
617
618 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
619 return @r;
620}
621sub ctx_block_level {
Andy Whitcroft653d4872007-06-23 17:16:34 -0700622 my ($linenr, $remain) = @_;
623
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700624 return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700625}
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700626sub ctx_statement_level {
627 my ($linenr, $remain, $off) = @_;
628
629 return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
630}
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700631
632sub ctx_locate_comment {
633 my ($first_line, $end_line) = @_;
634
635 # Catch a comment on the end of the line itself.
Andy Whitcroftbeae6332008-07-23 21:28:59 -0700636 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700637 return $current_comment if (defined $current_comment);
638
639 # Look through the context and try and figure out if there is a
640 # comment.
641 my $in_comment = 0;
642 $current_comment = '';
643 for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
Andy Whitcroft00df3442007-06-08 13:47:06 -0700644 my $line = $rawlines[$linenr - 1];
645 #warn " $line\n";
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700646 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
647 $in_comment = 1;
648 }
649 if ($line =~ m@/\*@) {
650 $in_comment = 1;
651 }
652 if (!$in_comment && $current_comment ne '') {
653 $current_comment = '';
654 }
655 $current_comment .= $line . "\n" if ($in_comment);
656 if ($line =~ m@\*/@) {
657 $in_comment = 0;
658 }
659 }
660
661 chomp($current_comment);
662 return($current_comment);
663}
664sub ctx_has_comment {
665 my ($first_line, $end_line) = @_;
666 my $cmt = ctx_locate_comment($first_line, $end_line);
667
Andy Whitcroft00df3442007-06-08 13:47:06 -0700668 ##print "LINE: $rawlines[$end_line - 1 ]\n";
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700669 ##print "CMMT: $cmt\n";
670
671 return ($cmt ne '');
672}
673
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700674sub cat_vet {
675 my ($vet) = @_;
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700676 my ($res, $coded);
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700677
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700678 $res = '';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700679 while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
680 $res .= $1;
681 if ($2 ne '') {
682 $coded = sprintf("^%c", unpack('C', $2) + 64);
683 $res .= $coded;
684 }
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700685 }
686 $res =~ s/$/\$/;
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700687
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700688 return $res;
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700689}
690
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800691my $av_preprocessor = 0;
Andy Whitcroftcf655042008-03-04 14:28:20 -0800692my $av_pending;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800693my @av_paren_type;
694
695sub annotate_reset {
696 $av_preprocessor = 0;
Andy Whitcroftcf655042008-03-04 14:28:20 -0800697 $av_pending = '_';
698 @av_paren_type = ('E');
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800699}
700
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700701sub annotate_values {
702 my ($stream, $type) = @_;
703
704 my $res;
705 my $cur = $stream;
706
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800707 print "$stream\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700708
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700709 while (length($cur)) {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700710 @av_paren_type = ('E') if ($#av_paren_type < 0);
Andy Whitcroftcf655042008-03-04 14:28:20 -0800711 print " <" . join('', @av_paren_type) .
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700712 "> <$type> <$av_pending>" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700713 if ($cur =~ /^(\s+)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800714 print "WS($1)\n" if ($dbg_values > 1);
715 if ($1 =~ /\n/ && $av_preprocessor) {
Andy Whitcroftcf655042008-03-04 14:28:20 -0800716 $type = pop(@av_paren_type);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800717 $av_preprocessor = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700718 }
719
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700720 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\))/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800721 print "DECLARE($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700722 $type = 'T';
723
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700724 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700725 print "DEFINE($1,$2)\n" if ($dbg_values > 1);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800726 $av_preprocessor = 1;
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700727 push(@av_paren_type, $type);
728 if ($2 ne '') {
729 $av_pending = 'N';
730 }
731 $type = 'E';
732
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700733 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700734 print "UNDEF($1)\n" if ($dbg_values > 1);
735 $av_preprocessor = 1;
736 push(@av_paren_type, $type);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700737
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700738 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -0800739 print "PRE_START($1)\n" if ($dbg_values > 1);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800740 $av_preprocessor = 1;
Andy Whitcroftcf655042008-03-04 14:28:20 -0800741
742 push(@av_paren_type, $type);
743 push(@av_paren_type, $type);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700744 $type = 'E';
Andy Whitcroftcf655042008-03-04 14:28:20 -0800745
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700746 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -0800747 print "PRE_RESTART($1)\n" if ($dbg_values > 1);
748 $av_preprocessor = 1;
749
750 push(@av_paren_type, $av_paren_type[$#av_paren_type]);
751
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700752 $type = 'E';
Andy Whitcroftcf655042008-03-04 14:28:20 -0800753
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700754 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -0800755 print "PRE_END($1)\n" if ($dbg_values > 1);
756
757 $av_preprocessor = 1;
758
759 # Assume all arms of the conditional end as this
760 # one does, and continue as if the #endif was not here.
761 pop(@av_paren_type);
762 push(@av_paren_type, $type);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700763 $type = 'E';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700764
765 } elsif ($cur =~ /^(\\\n)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800766 print "PRECONT($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700767
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700768 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
769 print "ATTR($1)\n" if ($dbg_values > 1);
770 $av_pending = $type;
771 $type = 'N';
772
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700773 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800774 print "SIZEOF($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700775 if (defined $2) {
Andy Whitcroftcf655042008-03-04 14:28:20 -0800776 $av_pending = 'V';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700777 }
778 $type = 'N';
779
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800780 } elsif ($cur =~ /^(if|while|typeof|__typeof__|for)\b/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800781 print "COND($1)\n" if ($dbg_values > 1);
Andy Whitcroftcf655042008-03-04 14:28:20 -0800782 $av_pending = 'N';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700783 $type = 'N';
784
Andy Whitcroft6ef9b292008-07-23 21:28:59 -0700785 } elsif ($cur =~/^(return|case|else|goto)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800786 print "KEYWORD($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700787 $type = 'N';
788
789 } elsif ($cur =~ /^(\()/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800790 print "PAREN('$1')\n" if ($dbg_values > 1);
Andy Whitcroftcf655042008-03-04 14:28:20 -0800791 push(@av_paren_type, $av_pending);
792 $av_pending = '_';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700793 $type = 'N';
794
795 } elsif ($cur =~ /^(\))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -0800796 my $new_type = pop(@av_paren_type);
797 if ($new_type ne '_') {
798 $type = $new_type;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800799 print "PAREN('$1') -> $type\n"
800 if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700801 } else {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800802 print "PAREN('$1')\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700803 }
804
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700805 } elsif ($cur =~ /^($Ident)\s*\(/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800806 print "FUNC($1)\n" if ($dbg_values > 1);
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700807 $type = 'V';
Andy Whitcroftcf655042008-03-04 14:28:20 -0800808 $av_pending = 'V';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700809
810 } elsif ($cur =~ /^($Ident|$Constant)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800811 print "IDENT($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700812 $type = 'V';
813
814 } elsif ($cur =~ /^($Assignment)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800815 print "ASSIGN($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700816 $type = 'N';
817
Andy Whitcroftcf655042008-03-04 14:28:20 -0800818 } elsif ($cur =~/^(;|{|})/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800819 print "END($1)\n" if ($dbg_values > 1);
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800820 $type = 'E';
821
Andy Whitcroftcf655042008-03-04 14:28:20 -0800822 } elsif ($cur =~ /^(;|\?|:|\[)/o) {
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800823 print "CLOSE($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700824 $type = 'N';
825
826 } elsif ($cur =~ /^($Operators)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800827 print "OP($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700828 if ($1 ne '++' && $1 ne '--') {
829 $type = 'N';
830 }
831
832 } elsif ($cur =~ /(^.)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800833 print "C($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700834 }
835 if (defined $1) {
836 $cur = substr($cur, length($1));
837 $res .= $type x length($1);
838 }
839 }
840
841 return $res;
842}
843
Andy Whitcroft8905a672007-11-28 16:21:06 -0800844sub possible {
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800845 my ($possible, $line) = @_;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800846
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700847 print "CHECK<$possible> ($line)\n" if ($dbg_possible > 1);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800848 if ($possible !~ /^(?:$Storage|$Type|DEFINE_\S+)$/ &&
849 $possible ne 'goto' && $possible ne 'return' &&
Andy Whitcroft8905a672007-11-28 16:21:06 -0800850 $possible ne 'case' && $possible ne 'else' &&
Andy Whitcroftd3ddcf42008-07-23 21:28:58 -0700851 $possible ne 'asm' && $possible ne '__asm__' &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700852 $possible !~ /^(typedef|struct|enum)\b/) {
853 # Check for modifiers.
854 $possible =~ s/\s*$Storage\s*//g;
855 $possible =~ s/\s*$Sparse\s*//g;
856 if ($possible =~ /^\s*$/) {
857
858 } elsif ($possible =~ /\s/) {
859 $possible =~ s/\s*$Type\s*//g;
860 warn "MODIFIER: $possible ($line)\n" if ($dbg_possible);
861 push(@modifierList, $possible);
862
863 } else {
864 warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
865 push(@typeList, $possible);
866 }
Andy Whitcroft8905a672007-11-28 16:21:06 -0800867 build_types();
868 }
869}
870
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700871my $prefix = '';
872
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700873sub report {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700874 if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) {
875 return 0;
876 }
Andy Whitcroft8905a672007-11-28 16:21:06 -0800877 my $line = $prefix . $_[0];
878
879 $line = (split('\n', $line))[0] . "\n" if ($terse);
880
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800881 push(our @report, $line);
Andy Whitcroft773647a2008-03-28 14:15:58 -0700882
883 return 1;
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700884}
885sub report_dump {
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800886 our @report;
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700887}
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700888sub ERROR {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700889 if (report("ERROR: $_[0]\n")) {
890 our $clean = 0;
891 our $cnt_error++;
892 }
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700893}
894sub WARN {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700895 if (report("WARNING: $_[0]\n")) {
896 our $clean = 0;
897 our $cnt_warn++;
898 }
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700899}
900sub CHK {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700901 if ($check && report("CHECK: $_[0]\n")) {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700902 our $clean = 0;
903 our $cnt_chk++;
904 }
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700905}
906
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700907sub process {
908 my $filename = shift;
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700909
910 my $linenr=0;
911 my $prevline="";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800912 my $prevrawline="";
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700913 my $stashline="";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800914 my $stashrawline="";
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700915
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700916 my $length;
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700917 my $indent;
918 my $previndent=0;
919 my $stashindent=0;
920
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700921 our $clean = 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700922 my $signoff = 0;
923 my $is_patch = 0;
924
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800925 our @report = ();
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700926 our $cnt_lines = 0;
927 our $cnt_error = 0;
928 our $cnt_warn = 0;
929 our $cnt_chk = 0;
930
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700931 # Trace the real file/line as we go.
932 my $realfile = '';
933 my $realline = 0;
934 my $realcnt = 0;
935 my $here = '';
936 my $in_comment = 0;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800937 my $comment_edge = 0;
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700938 my $first_line = 0;
939
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800940 my $prev_values = 'E';
941
942 # suppression flags
Andy Whitcroft773647a2008-03-28 14:15:58 -0700943 my %suppress_ifbraces;
Andy Whitcroft653d4872007-06-23 17:16:34 -0700944
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800945 # Pre-scan the patch sanitizing the lines.
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700946 # Pre-scan the patch looking for any __setup documentation.
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800947 #
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700948 my @setup_docs = ();
949 my $setup_docs = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700950
951 sanitise_line_reset();
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800952 my $line;
953 foreach my $rawline (@rawlines) {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700954 $linenr++;
955 $line = $rawline;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800956
Andy Whitcroft773647a2008-03-28 14:15:58 -0700957 if ($rawline=~/^\+\+\+\s+(\S+)/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700958 $setup_docs = 0;
959 if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
960 $setup_docs = 1;
961 }
Andy Whitcroft773647a2008-03-28 14:15:58 -0700962 #next;
Andy Whitcroftde7d4f02007-07-15 23:37:22 -0700963 }
Andy Whitcroft773647a2008-03-28 14:15:58 -0700964 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
965 $realline=$1-1;
966 if (defined $2) {
967 $realcnt=$3+1;
968 } else {
969 $realcnt=1+1;
970 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700971 $in_comment = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700972
973 # Guestimate if this is a continuing comment. Run
974 # the context looking for a comment "edge". If this
975 # edge is a close comment then we must be in a comment
976 # at context start.
977 my $edge;
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700978 for (my $ln = $linenr + 1; $ln < ($linenr + $realcnt); $ln++) {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700979 next if ($line =~ /^-/);
980 ($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@);
981 last if (defined $edge);
982 }
983 if (defined $edge && $edge eq '*/') {
984 $in_comment = 1;
985 }
986
987 # Guestimate if this is a continuing comment. If this
988 # is the start of a diff block and this line starts
989 # ' *' then it is very likely a comment.
990 if (!defined $edge &&
991 $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@)
992 {
993 $in_comment = 1;
994 }
995
996 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
997 sanitise_line_reset($in_comment);
998
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700999 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001000 # Standardise the strings and chars within the input to
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001001 # simplify matching -- only bother with positive lines.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001002 $line = sanitise_line($rawline);
1003 }
1004 push(@lines, $line);
1005
1006 if ($realcnt > 1) {
1007 $realcnt-- if ($line =~ /^(?:\+| |$)/);
1008 } else {
1009 $realcnt = 0;
1010 }
1011
1012 #print "==>$rawline\n";
1013 #print "-->$line\n";
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001014
1015 if ($setup_docs && $line =~ /^\+/) {
1016 push(@setup_docs, $line);
1017 }
1018 }
1019
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001020 $prefix = '';
1021
Andy Whitcroft773647a2008-03-28 14:15:58 -07001022 $realcnt = 0;
1023 $linenr = 0;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001024 foreach my $line (@lines) {
1025 $linenr++;
1026
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001027 my $rawline = $rawlines[$linenr - 1];
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001028
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001029#extract the line range in the file after the patch is applied
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001030 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001031 $is_patch = 1;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001032 $first_line = $linenr + 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001033 $realline=$1-1;
1034 if (defined $2) {
1035 $realcnt=$3+1;
1036 } else {
1037 $realcnt=1+1;
1038 }
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001039 annotate_reset();
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001040 $prev_values = 'E';
1041
Andy Whitcroft773647a2008-03-28 14:15:58 -07001042 %suppress_ifbraces = ();
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001043 next;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001044
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001045# track the line number as we move through the hunk, note that
1046# new versions of GNU diff omit the leading space on completely
1047# blank context lines so we need to count that too.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001048 } elsif ($line =~ /^( |\+|$)/) {
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001049 $realline++;
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001050 $realcnt-- if ($realcnt != 0);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001051
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001052 # Measure the line length and indent.
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001053 ($length, $indent) = line_stats($rawline);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001054
1055 # Track the previous line.
1056 ($prevline, $stashline) = ($stashline, $line);
1057 ($previndent, $stashindent) = ($stashindent, $indent);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001058 ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1059
Andy Whitcroft773647a2008-03-28 14:15:58 -07001060 #warn "line<$line>\n";
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001061
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001062 } elsif ($realcnt == 1) {
1063 $realcnt--;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001064 }
1065
1066#make up the handle for any error we report on this line
Andy Whitcroft773647a2008-03-28 14:15:58 -07001067 $prefix = "$filename:$realline: " if ($emacs && $file);
1068 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1069
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001070 $here = "#$linenr: " if (!$file);
1071 $here = "#$realline: " if ($file);
Andy Whitcroft773647a2008-03-28 14:15:58 -07001072
1073 # extract the filename as it passes
1074 if ($line=~/^\+\+\+\s+(\S+)/) {
1075 $realfile = $1;
1076 $realfile =~ s@^[^/]*/@@;
1077
1078 if ($realfile =~ m@include/asm/@) {
1079 ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1080 }
1081 next;
1082 }
1083
Randy Dunlap389834b2007-06-08 13:47:03 -07001084 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001085
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001086 my $hereline = "$here\n$rawline\n";
1087 my $herecurr = "$here\n$rawline\n";
1088 my $hereprev = "$here\n$prevrawline\n$rawline\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001089
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001090 $cnt_lines++ if ($realcnt != 0);
1091
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001092#check the patch for a signoff:
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001093 if ($line =~ /^\s*signed-off-by:/i) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001094 # This is a signoff, if ugly, so do not double report.
1095 $signoff++;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001096 if (!($line =~ /^\s*Signed-off-by:/)) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001097 WARN("Signed-off-by: is the preferred form\n" .
1098 $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001099 }
1100 if ($line =~ /^\s*signed-off-by:\S/i) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001101 WARN("space required after Signed-off-by:\n" .
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001102 $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001103 }
1104 }
1105
Andy Whitcroft00df3442007-06-08 13:47:06 -07001106# Check for wrappage within a valid hunk of the file
Andy Whitcroft8905a672007-11-28 16:21:06 -08001107 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001108 ERROR("patch seems to be corrupt (line wrapped?)\n" .
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001109 $herecurr) if (!$emitted_corrupt++);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001110 }
1111
1112# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1113 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001114 $rawline !~ m/^$UTF8*$/) {
1115 my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1116
1117 my $blank = copy_spacing($rawline);
1118 my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1119 my $hereptr = "$hereline$ptr\n";
1120
1121 ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
Andy Whitcroft00df3442007-06-08 13:47:06 -07001122 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001123
Andy Whitcroft00df3442007-06-08 13:47:06 -07001124#ignore lines being removed
1125 if ($line=~/^-/) {next;}
1126
1127# check we are in a valid source file if not then ignore this hunk
1128 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001129
1130#trailing whitespace
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001131 if ($line =~ /^\+.*\015/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001132 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001133 ERROR("DOS line endings\n" . $herevet);
1134
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001135 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1136 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001137 ERROR("trailing whitespace\n" . $herevet);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001138 }
1139#80 column limit
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001140 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
Andy Whitcroftf4c014c2008-07-23 21:29:01 -07001141 $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1142 $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
1143 $length > 80)
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001144 {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001145 WARN("line over 80 characters\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001146 }
1147
Andy Whitcroft8905a672007-11-28 16:21:06 -08001148# check for adding lines without a newline.
1149 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1150 WARN("adding a line without newline at end of file\n" . $herecurr);
1151 }
1152
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001153# check we are in a valid source file *.[hc] if not then ignore this hunk
1154 next if ($realfile !~ /\.[hc]$/);
1155
1156# at the beginning of a line any tabs must come first and anything
1157# more than 8 must use tabs.
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001158 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1159 $rawline =~ /^\+\s* \s*/) {
1160 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001161 ERROR("code indent should use tabs where possible\n" . $herevet);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001162 }
1163
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001164# check for RCS/CVS revision markers
Andy Whitcroftcf655042008-03-04 14:28:20 -08001165 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001166 WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1167 }
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001168
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001169# Check for potential 'bare' types
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001170 my ($stat, $cond);
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07001171 if ($realcnt && $line =~ /.\s*\S/) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001172 ($stat, $cond) = ctx_statement_block($linenr,
1173 $realcnt, 0);
1174 $stat =~ s/\n./\n /g;
1175 $cond =~ s/\n./\n /g;
1176
1177 my $s = $stat;
1178 $s =~ s/{.*$//s;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001179
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001180 # Ignore goto labels.
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001181 if ($s =~ /$Ident:\*$/s) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001182
1183 # Ignore functions being called
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001184 } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001185
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001186 # declarations always start with types
1187 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))\s*(?:;|=|,|\()/s) {
1188 my $type = $1;
1189 $type =~ s/\s+/ /g;
1190 possible($type, "A:" . $s);
1191
Andy Whitcroft8905a672007-11-28 16:21:06 -08001192 # definitions in global scope can only start with types
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001193 } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b/s) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001194 possible($1, "B:" . $s);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001195 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08001196
1197 # any (foo ... *) is a pointer cast, and foo is a type
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001198 while ($s =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/sg) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001199 possible($1, "C:" . $s);
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001200 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08001201
1202 # Check for any sort of function declaration.
1203 # int foo(something bar, other baz);
1204 # void (*store_gdt)(x86_descr_ptr *);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001205 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
Andy Whitcroft8905a672007-11-28 16:21:06 -08001206 my ($name_len) = length($1);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001207
Andy Whitcroftcf655042008-03-04 14:28:20 -08001208 my $ctx = $s;
Andy Whitcroft773647a2008-03-28 14:15:58 -07001209 substr($ctx, 0, $name_len + 1, '');
Andy Whitcroft8905a672007-11-28 16:21:06 -08001210 $ctx =~ s/\)[^\)]*$//;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001211
Andy Whitcroft8905a672007-11-28 16:21:06 -08001212 for my $arg (split(/\s*,\s*/, $ctx)) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001213 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
Andy Whitcroft8905a672007-11-28 16:21:06 -08001214
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001215 possible($1, "D:" . $s);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001216 }
1217 }
1218 }
1219
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001220 }
1221
Andy Whitcroft653d4872007-06-23 17:16:34 -07001222#
1223# Checks which may be anchored in the context.
1224#
1225
1226# Check for switch () and associated case and default
1227# statements should be at the same indent.
Andy Whitcroft00df3442007-06-08 13:47:06 -07001228 if ($line=~/\bswitch\s*\(.*\)/) {
1229 my $err = '';
1230 my $sep = '';
1231 my @ctx = ctx_block_outer($linenr, $realcnt);
1232 shift(@ctx);
1233 for my $ctx (@ctx) {
1234 my ($clen, $cindent) = line_stats($ctx);
1235 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1236 $indent != $cindent) {
1237 $err .= "$sep$ctx\n";
1238 $sep = '';
1239 } else {
1240 $sep = "[...]\n";
1241 }
1242 }
1243 if ($err ne '') {
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001244 ERROR("switch and case should be at the same indent\n$hereline$err");
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001245 }
1246 }
Andy Whitcrofte2a763c2008-07-23 21:29:02 -07001247 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
1248 $line !~ /\G(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$/g) {
1249 ERROR("trailing statements should be on next line\n" . $herecurr);
1250 }
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001251
1252# if/while/etc brace do not go on next line, unless defining a do while loop,
1253# or if that brace on the next line is for something else
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001254 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001255 my $pre_ctx = "$1$2";
1256
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001257 my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001258 my $ctx_cnt = $realcnt - $#ctx - 1;
1259 my $ctx = join("\n", @ctx);
1260
Andy Whitcroft548596d2008-07-23 21:29:01 -07001261 my $ctx_ln = $linenr;
1262 my $ctx_skip = $realcnt;
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001263
Andy Whitcroft548596d2008-07-23 21:29:01 -07001264 while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
1265 defined $lines[$ctx_ln - 1] &&
1266 $lines[$ctx_ln - 1] =~ /^-/)) {
1267 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
1268 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
Andy Whitcroft773647a2008-03-28 14:15:58 -07001269 $ctx_ln++;
1270 }
Andy Whitcroft548596d2008-07-23 21:29:01 -07001271
1272 ##print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
1273 ##print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
Andy Whitcroft773647a2008-03-28 14:15:58 -07001274
1275 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
1276 ERROR("that open brace { should be on the previous line\n" .
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001277 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
Andy Whitcroft00df3442007-06-08 13:47:06 -07001278 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001279 if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
1280 $ctx =~ /\)\s*\;\s*$/ &&
1281 defined $lines[$ctx_ln - 1])
1282 {
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001283 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
1284 if ($nindent > $indent) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001285 WARN("trailing semicolon indicates no statements, indent implies otherwise\n" .
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001286 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001287 }
1288 }
Andy Whitcroft00df3442007-06-08 13:47:06 -07001289 }
1290
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001291 # Track the 'values' across context and added lines.
1292 my $opline = $line; $opline =~ s/^./ /;
1293 my $curr_values = annotate_values($opline . "\n", $prev_values);
1294 $curr_values = $prev_values . $curr_values;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001295 if ($dbg_values) {
1296 my $outline = $opline; $outline =~ s/\t/ /g;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001297 print "$linenr > .$outline\n";
1298 print "$linenr > $curr_values\n";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001299 }
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001300 $prev_values = substr($curr_values, -1);
1301
Andy Whitcroft00df3442007-06-08 13:47:06 -07001302#ignore lines not being added
1303 if ($line=~/^[^\+]/) {next;}
1304
Andy Whitcroft653d4872007-06-23 17:16:34 -07001305# TEST: allow direct testing of the type matcher.
1306 if ($tst_type && $line =~ /^.$Declare$/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001307 ERROR("TEST: is type $Declare\n" . $herecurr);
Andy Whitcroft653d4872007-06-23 17:16:34 -07001308 next;
1309 }
1310
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001311# check for initialisation to aggregates open brace on the next line
1312 if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ &&
1313 $line =~ /^.\s*{/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001314 ERROR("that open brace { should be on the previous line\n" . $hereprev);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001315 }
1316
Andy Whitcroft653d4872007-06-23 17:16:34 -07001317#
1318# Checks which are anchored on the added line.
1319#
1320
1321# check for malformed paths in #include statements (uses RAW line)
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001322 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
Andy Whitcroft653d4872007-06-23 17:16:34 -07001323 my $path = $1;
1324 if ($path =~ m{//}) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001325 ERROR("malformed #include filename\n" .
1326 $herecurr);
Andy Whitcroft653d4872007-06-23 17:16:34 -07001327 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07001328 }
Andy Whitcroft00df3442007-06-08 13:47:06 -07001329
1330# no C99 // comments
1331 if ($line =~ m{//}) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001332 ERROR("do not use C99 // comments\n" . $herecurr);
Andy Whitcroft00df3442007-06-08 13:47:06 -07001333 }
1334 # Remove C99 comments.
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001335 $line =~ s@//.*@@;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001336 $opline =~ s@//.*@@;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001337
1338#EXPORT_SYMBOL should immediately follow its function closing }.
Andy Whitcroft653d4872007-06-23 17:16:34 -07001339 if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) ||
1340 ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
1341 my $name = $1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001342 if (($prevline !~ /^}/) &&
1343 ($prevline !~ /^\+}/) &&
Andy Whitcroft653d4872007-06-23 17:16:34 -07001344 ($prevline !~ /^ }/) &&
Andy Whitcroftcf655042008-03-04 14:28:20 -08001345 ($prevline !~ /^.DECLARE_$Ident\(\Q$name\E\)/) &&
1346 ($prevline !~ /^.LIST_HEAD\(\Q$name\E\)/) &&
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001347 ($prevline !~ /^.$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(/) &&
Andy Whitcroftcf655042008-03-04 14:28:20 -08001348 ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=|\[)/)) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001349 WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001350 }
1351 }
1352
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001353# check for external initialisers.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001354 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001355 ERROR("do not initialise externals to 0 or NULL\n" .
1356 $herecurr);
1357 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07001358# check for static initialisers.
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07001359 if ($line =~ /\s*static\s.*=\s*(0|NULL|false)\s*;/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001360 ERROR("do not initialise statics to 0 or NULL\n" .
1361 $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001362 }
1363
Andy Whitcroft653d4872007-06-23 17:16:34 -07001364# check for new typedefs, only function parameters and sparse annotations
1365# make sense.
1366 if ($line =~ /\btypedef\s/ &&
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001367 $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001368 $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
Andy Whitcroft653d4872007-06-23 17:16:34 -07001369 $line !~ /\b__bitwise(?:__|)\b/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001370 WARN("do not add new typedefs\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001371 }
1372
1373# * goes on variable not on type
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001374 if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001375 ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" .
1376 $herecurr);
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001377
1378 } elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001379 ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" .
1380 $herecurr);
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001381
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001382 } elsif ($line =~ m{$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001383 ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" .
1384 $herecurr);
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001385
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001386 } elsif ($line =~ m{$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001387 ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" .
1388 $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001389 }
1390
1391# # no BUG() or BUG_ON()
1392# if ($line =~ /\b(BUG|BUG_ON)\b/) {
1393# print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
1394# print "$herecurr";
1395# $clean = 0;
1396# }
1397
Andy Whitcroft8905a672007-11-28 16:21:06 -08001398 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001399 WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001400 }
1401
Andy Whitcroft00df3442007-06-08 13:47:06 -07001402# printk should use KERN_* levels. Note that follow on printk's on the
1403# same line do not need a level, so we use the current block context
1404# to try and find and validate the current printk. In summary the current
1405# printk includes all preceeding printk's which have no newline on the end.
1406# we assume the first bad printk is the one to report.
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001407 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
Andy Whitcroft00df3442007-06-08 13:47:06 -07001408 my $ok = 0;
1409 for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
1410 #print "CHECK<$lines[$ln - 1]\n";
1411 # we have a preceeding printk if it ends
1412 # with "\n" ignore it, else it is to blame
1413 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
1414 if ($rawlines[$ln - 1] !~ m{\\n"}) {
1415 $ok = 1;
1416 }
1417 last;
1418 }
1419 }
1420 if ($ok == 0) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001421 WARN("printk() should include KERN_ facility level\n" . $herecurr);
Andy Whitcroft00df3442007-06-08 13:47:06 -07001422 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001423 }
1424
Andy Whitcroft653d4872007-06-23 17:16:34 -07001425# function brace can't be on same line, except for #defines of do while,
1426# or if closed on same line
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001427 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
1428 !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001429 ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001430 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07001431
Andy Whitcroft8905a672007-11-28 16:21:06 -08001432# open braces for enum, union and struct go on the same line.
1433 if ($line =~ /^.\s*{/ &&
1434 $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
1435 ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
1436 }
1437
Andy Whitcroft8d31cfc2008-07-23 21:29:02 -07001438# check for spacing round square brackets; allowed:
1439# 1. with a type on the left -- int [] a;
1440# 2. at the beginning of a line for slice initialisers -- [0..10] = 5,
1441 while ($line =~ /(.*?\s)\[/g) {
1442 my ($where, $prefix) = ($-[1], $1);
1443 if ($prefix !~ /$Type\s+$/ &&
1444 ($where != 0 || $prefix !~ /^.\s+$/)) {
1445 ERROR("space prohibited before open square bracket '['\n" . $herecurr);
1446 }
1447 }
1448
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001449# check for spaces between functions and their parentheses.
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001450 while ($line =~ /($Ident)\s+\(/g) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001451 my $name = $1;
Andy Whitcroft773647a2008-03-28 14:15:58 -07001452 my $ctx_before = substr($line, 0, $-[1]);
1453 my $ctx = "$ctx_before$name";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001454
1455 # Ignore those directives where spaces _are_ permitted.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001456 if ($name =~ /^(?:
1457 if|for|while|switch|return|case|
1458 volatile|__volatile__|
1459 __attribute__|format|__extension__|
1460 asm|__asm__)$/x)
1461 {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001462
1463 # cpp #define statements have non-optional spaces, ie
1464 # if there is a space between the name and the open
1465 # parenthesis it is simply not a parameter group.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001466 } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001467
1468 # cpp #elif statement condition may start with a (
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001469 } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001470
1471 # If this whole things ends with a type its most
1472 # likely a typedef for a function.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001473 } elsif ($ctx =~ /$Type$/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001474
1475 } else {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001476 WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001477 }
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001478 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07001479# Check operator spacing.
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001480 if (!($line=~/\#\s*include/)) {
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001481 my $ops = qr{
1482 <<=|>>=|<=|>=|==|!=|
1483 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
1484 =>|->|<<|>>|<|>|=|!|~|
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001485 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001486 }x;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001487 my @elements = split(/($ops|;)/, $opline);
Andy Whitcroft00df3442007-06-08 13:47:06 -07001488 my $off = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001489
1490 my $blank = copy_spacing($opline);
1491
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001492 for (my $n = 0; $n < $#elements; $n += 2) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001493 $off += length($elements[$n]);
1494
Andy Whitcroft773647a2008-03-28 14:15:58 -07001495 # Pick up the preceeding and succeeding characters.
1496 my $ca = substr($opline, 0, $off);
1497 my $cc = '';
1498 if (length($opline) >= ($off + length($elements[$n + 1]))) {
1499 $cc = substr($opline, $off + length($elements[$n + 1]));
1500 }
1501 my $cb = "$ca$;$cc";
1502
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001503 my $a = '';
1504 $a = 'V' if ($elements[$n] ne '');
1505 $a = 'W' if ($elements[$n] =~ /\s$/);
Andy Whitcroftcf655042008-03-04 14:28:20 -08001506 $a = 'C' if ($elements[$n] =~ /$;$/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001507 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
1508 $a = 'O' if ($elements[$n] eq '');
Andy Whitcroft773647a2008-03-28 14:15:58 -07001509 $a = 'E' if ($ca =~ /^\s*$/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001510
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001511 my $op = $elements[$n + 1];
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001512
1513 my $c = '';
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001514 if (defined $elements[$n + 2]) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001515 $c = 'V' if ($elements[$n + 2] ne '');
1516 $c = 'W' if ($elements[$n + 2] =~ /^\s/);
Andy Whitcroftcf655042008-03-04 14:28:20 -08001517 $c = 'C' if ($elements[$n + 2] =~ /^$;/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001518 $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
1519 $c = 'O' if ($elements[$n + 2] eq '');
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001520 $c = 'E' if ($elements[$n + 2] =~ /\s*\\$/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001521 } else {
1522 $c = 'E';
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001523 }
1524
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001525 my $ctx = "${a}x${c}";
1526
1527 my $at = "(ctx:$ctx)";
1528
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001529 my $ptr = substr($blank, 0, $off) . "^";
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001530 my $hereptr = "$hereline$ptr\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001531
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001532 # Classify operators into binary, unary, or
1533 # definitions (* only) where they have more
1534 # than one mode.
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001535 my $op_type = substr($curr_values, $off + 1, 1);
1536 my $op_left = substr($curr_values, $off, 1);
1537 my $is_unary;
1538 if ($op_type eq 'T') {
1539 $is_unary = 2;
1540 } elsif ($op_left eq 'V') {
1541 $is_unary = 0;
1542 } else {
1543 $is_unary = 1;
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001544 }
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001545 #if ($op eq '-' || $op eq '&' || $op eq '*') {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001546 # print "UNARY: <$op_left$op_type $is_unary $a:$op:$c> <$ca:$op:$cc> <$unary_ctx>\n";
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001547 #}
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001548
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001549 # Ignore operators passed as parameters.
1550 if ($op_type ne 'V' &&
1551 $ca =~ /\s$/ && $cc =~ /^\s*,/) {
1552
Andy Whitcroftcf655042008-03-04 14:28:20 -08001553# # Ignore comments
1554# } elsif ($op =~ /^$;+$/) {
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001555
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001556 # ; should have either the end of line or a space or \ after it
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001557 } elsif ($op eq ';') {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001558 if ($ctx !~ /.x[WEBC]/ &&
1559 $cc !~ /^\\/ && $cc !~ /^;/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001560 ERROR("space required after that '$op' $at\n" . $hereptr);
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001561 }
1562
1563 # // is a comment
1564 } elsif ($op eq '//') {
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001565
1566 # -> should have no spaces
1567 } elsif ($op eq '->') {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001568 if ($ctx =~ /Wx.|.xW/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001569 ERROR("spaces prohibited around that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001570 }
1571
1572 # , must have a space on the right.
1573 } elsif ($op eq ',') {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001574 if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001575 ERROR("space required after that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001576 }
1577
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001578 # '*' as part of a type definition -- reported already.
1579 } elsif ($op eq '*' && $is_unary == 2) {
1580 #warn "'*' is part of type\n";
1581
1582 # unary operators should have a space before and
1583 # none after. May be left adjacent to another
1584 # unary operator, or a cast
1585 } elsif ($op eq '!' || $op eq '~' ||
1586 ($is_unary && ($op eq '*' || $op eq '-' || $op eq '&'))) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001587 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001588 ERROR("space required before that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001589 }
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001590 if ($op eq '*' && $cc =~/\s*const\b/) {
1591 # A unary '*' may be const
1592
1593 } elsif ($ctx =~ /.xW/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001594 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001595 }
1596
1597 # unary ++ and unary -- are allowed no space on one side.
1598 } elsif ($op eq '++' or $op eq '--') {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001599 if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
1600 ERROR("space required one side of that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001601 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001602 if ($ctx =~ /Wx[BE]/ ||
1603 ($ctx =~ /Wx./ && $cc =~ /^;/)) {
1604 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
Andy Whitcroft653d4872007-06-23 17:16:34 -07001605 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001606 if ($ctx =~ /ExW/) {
1607 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
1608 }
1609
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001610
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001611 # << and >> may either have or not have spaces both sides
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001612 } elsif ($op eq '<<' or $op eq '>>' or
1613 $op eq '&' or $op eq '^' or $op eq '|' or
1614 $op eq '+' or $op eq '-' or
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001615 $op eq '*' or $op eq '/' or
1616 $op eq '%')
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001617 {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001618 if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001619 ERROR("need consistent spacing around '$op' $at\n" .
1620 $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001621 }
1622
1623 # All the others need spaces both sides.
Andy Whitcroftcf655042008-03-04 14:28:20 -08001624 } elsif ($ctx !~ /[EWC]x[CWE]/) {
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001625 # Ignore email addresses <foo@bar>
1626 if (!($op eq '<' && $cb =~ /$;\S+\@\S+>/) &&
1627 !($op eq '>' && $cb =~ /<\S+\@\S+$;/)) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001628 ERROR("spaces required around that '$op' $at\n" . $hereptr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001629 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001630 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001631 $off += length($elements[$n + 1]);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001632 }
1633 }
1634
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001635# check for multiple assignments
1636 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001637 CHK("multiple assignments should be avoided\n" . $herecurr);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001638 }
1639
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001640## # check for multiple declarations, allowing for a function declaration
1641## # continuation.
1642## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
1643## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
1644##
1645## # Remove any bracketed sections to ensure we do not
1646## # falsly report the parameters of functions.
1647## my $ln = $line;
1648## while ($ln =~ s/\([^\(\)]*\)//g) {
1649## }
1650## if ($ln =~ /,/) {
1651## WARN("declaring multiple variables together should be avoided\n" . $herecurr);
1652## }
1653## }
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001654
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001655#need space before brace following if, while, etc
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001656 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
1657 $line =~ /do{/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001658 ERROR("space required before the open brace '{'\n" . $herecurr);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001659 }
1660
1661# closing brace should have a space following it when it has anything
1662# on the line
1663 if ($line =~ /}(?!(?:,|;|\)))\S/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001664 ERROR("space required after that close brace '}'\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001665 }
1666
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001667# check spacing on square brackets
1668 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001669 ERROR("space prohibited after that open square bracket '['\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001670 }
1671 if ($line =~ /\s\]/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001672 ERROR("space prohibited before that close square bracket ']'\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001673 }
1674
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001675# check spacing on parentheses
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001676 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
1677 $line !~ /for\s*\(\s+;/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001678 ERROR("space prohibited after that open parenthesis '('\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001679 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001680 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001681 $line !~ /for\s*\(.*;\s+\)/ &&
1682 $line !~ /:\s+\)/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001683 ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001684 }
1685
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001686#goto labels aren't indented, allow a single space however
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001687 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001688 !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001689 WARN("labels should not be indented\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001690 }
1691
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001692# Return is not a function.
1693 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
1694 my $spacing = $1;
1695 my $value = $2;
1696
1697 # Flatten any parentheses and braces
Andy Whitcroftfee61c42008-07-23 21:28:56 -07001698 $value =~ s/\)\(/\) \(/g;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001699 while ($value =~ s/\([^\(\)]*\)/1/) {
1700 }
1701
1702 if ($value =~ /^(?:$Ident|-?$Constant)$/) {
1703 ERROR("return is not a function, parentheses are not required\n" . $herecurr);
1704
1705 } elsif ($spacing !~ /\s+/) {
1706 ERROR("space required before the open parenthesis '('\n" . $herecurr);
1707 }
1708 }
1709
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001710# Need a space before open parenthesis after if, while etc
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001711 if ($line=~/\b(if|while|for|switch)\(/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001712 ERROR("space required before the open parenthesis '('\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001713 }
1714
1715# Check for illegal assignment in if conditional.
Andy Whitcroft8905a672007-11-28 16:21:06 -08001716 if ($line =~ /\bif\s*\(/) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001717 my ($s, $c) = ($stat, $cond);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001718
1719 if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001720 ERROR("do not use assignment in if condition\n" . $herecurr);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001721 }
1722
1723 # Find out what is on the end of the line after the
1724 # conditional.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001725 substr($s, 0, length($c), '');
Andy Whitcroft8905a672007-11-28 16:21:06 -08001726 $s =~ s/\n.*//g;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001727 $s =~ s/$;//g; # Remove any comments
Andy Whitcroft773647a2008-03-28 14:15:58 -07001728 if (length($c) && $s !~ /^\s*({|;|)\s*\\*\s*$/ &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001729 $c !~ /^.\s*\#\s*if/)
Andy Whitcroft773647a2008-03-28 14:15:58 -07001730 {
Andy Whitcroft8905a672007-11-28 16:21:06 -08001731 ERROR("trailing statements should be on next line\n" . $herecurr);
1732 }
1733 }
1734
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001735# Check for bitwise tests written as boolean
1736 if ($line =~ /
1737 (?:
1738 (?:\[|\(|\&\&|\|\|)
1739 \s*0[xX][0-9]+\s*
1740 (?:\&\&|\|\|)
1741 |
1742 (?:\&\&|\|\|)
1743 \s*0[xX][0-9]+\s*
1744 (?:\&\&|\|\||\)|\])
1745 )/x)
1746 {
1747 WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
1748 }
1749
Andy Whitcroft8905a672007-11-28 16:21:06 -08001750# if and else should not have general statements after it
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001751 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
1752 my $s = $1;
1753 $s =~ s/$;//g; # Remove any comments
1754 if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
1755 ERROR("trailing statements should be on next line\n" . $herecurr);
1756 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001757 }
1758
1759 # Check for }<nl>else {, these must be at the same
1760 # indent level to be relevant to each other.
1761 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
1762 $previndent == $indent) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001763 ERROR("else should follow close brace '}'\n" . $hereprev);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001764 }
1765
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001766 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
1767 $previndent == $indent) {
1768 my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
1769
1770 # Find out what is on the end of the line after the
1771 # conditional.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001772 substr($s, 0, length($c), '');
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001773 $s =~ s/\n.*//g;
1774
1775 if ($s =~ /^\s*;/) {
1776 ERROR("while should follow close brace '}'\n" . $hereprev);
1777 }
1778 }
1779
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001780#studly caps, commented out until figure out how to distinguish between use of existing and adding new
1781# if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
1782# print "No studly caps, use _\n";
1783# print "$herecurr";
1784# $clean = 0;
1785# }
1786
1787#no spaces allowed after \ in define
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001788 if ($line=~/\#\s*define.*\\\s$/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001789 WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001790 }
1791
Andy Whitcroft653d4872007-06-23 17:16:34 -07001792#warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001793 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
1794 my $checkfile = "include/linux/$1.h";
1795 if (-f "$root/$checkfile" && $realfile ne $checkfile &&
1796 $1 ne 'irq')
1797 {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001798 WARN("Use #include <linux/$1.h> instead of <asm/$1.h>\n" .
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001799 $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001800 }
1801 }
1802
Andy Whitcroft653d4872007-06-23 17:16:34 -07001803# multi-statement macros should be enclosed in a do while loop, grab the
1804# first statement and ensure its the whole macro if its not enclosed
Andy Whitcroftcf655042008-03-04 14:28:20 -08001805# in a known good container
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001806 if ($line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001807 my $ln = $linenr;
1808 my $cnt = $realcnt;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001809 my ($off, $dstat, $dcond, $rest);
1810 my $ctx = '';
Andy Whitcroft653d4872007-06-23 17:16:34 -07001811
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001812 my $args = defined($1);
1813
1814 # Find the end of the macro and limit our statement
1815 # search to that.
1816 while ($cnt > 0 && defined $lines[$ln - 1] &&
1817 $lines[$ln - 1] =~ /^(?:-|..*\\$)/)
1818 {
1819 $ctx .= $rawlines[$ln - 1] . "\n";
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -07001820 $cnt-- if ($lines[$ln - 1] !~ /^-/);
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001821 $ln++;
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001822 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001823 $ctx .= $rawlines[$ln - 1];
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001824
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001825 ($dstat, $dcond, $ln, $cnt, $off) =
1826 ctx_statement_block($linenr, $ln - $linenr + 1, 0);
1827 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -07001828 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001829
1830 # Extract the remainder of the define (if any) and
1831 # rip off surrounding spaces, and trailing \'s.
1832 $rest = '';
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -07001833 while ($off != 0 || ($cnt > 0 && $rest =~ /(?:^|\\)\s*$/)) {
1834 #print "ADDING $off <" . substr($lines[$ln - 1], $off) . ">\n";
1835 if ($off != 0 || $lines[$ln - 1] !~ /^-/) {
1836 $rest .= substr($lines[$ln - 1], $off) . "\n";
1837 $cnt--;
1838 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001839 $ln++;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001840 $off = 0;
1841 }
1842 $rest =~ s/\\\n.//g;
1843 $rest =~ s/^\s*//s;
1844 $rest =~ s/\s*$//s;
1845
1846 # Clean up the original statement.
1847 if ($args) {
1848 substr($dstat, 0, length($dcond), '');
1849 } else {
1850 $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//;
1851 }
1852 $dstat =~ s/\\\n.//g;
1853 $dstat =~ s/^\s*//s;
1854 $dstat =~ s/\s*$//s;
1855
1856 # Flatten any parentheses and braces
1857 while ($dstat =~ s/\([^\(\)]*\)/1/) {
1858 }
1859 while ($dstat =~ s/\{[^\{\}]*\}/1/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001860 }
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001861
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001862 my $exceptions = qr{
1863 $Declare|
1864 module_param_named|
1865 MODULE_PARAM_DESC|
1866 DECLARE_PER_CPU|
1867 DEFINE_PER_CPU|
1868 __typeof__\(
1869 }x;
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -07001870 #print "REST<$rest>\n";
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001871 if ($rest ne '') {
1872 if ($rest !~ /while\s*\(/ &&
1873 $dstat !~ /$exceptions/)
1874 {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001875 ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n");
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001876 }
1877
1878 } elsif ($ctx !~ /;/) {
1879 if ($dstat ne '' &&
1880 $dstat !~ /^(?:$Ident|-?$Constant)$/ &&
1881 $dstat !~ /$exceptions/ &&
1882 $dstat =~ /$Operators/)
1883 {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001884 ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001885 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07001886 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001887 }
1888
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001889# check for redundant bracing round if etc
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001890 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
1891 my ($level, $endln, @chunks) =
Andy Whitcroftcf655042008-03-04 14:28:20 -08001892 ctx_statement_full($linenr, $realcnt, 1);
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001893 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08001894 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
1895 if ($#chunks > 0 && $level == 0) {
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001896 my $allowed = 0;
1897 my $seen = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -07001898 my $herectx = $here . "\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08001899 my $ln = $linenr - 1;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001900 for my $chunk (@chunks) {
1901 my ($cond, $block) = @{$chunk};
1902
Andy Whitcroft773647a2008-03-28 14:15:58 -07001903 # If the condition carries leading newlines, then count those as offsets.
1904 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
1905 my $offset = statement_rawlines($whitespace) - 1;
1906
1907 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
1908
1909 # We have looked at and allowed this specific line.
1910 $suppress_ifbraces{$ln + $offset} = 1;
1911
1912 $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08001913 $ln += statement_rawlines($block) - 1;
1914
Andy Whitcroft773647a2008-03-28 14:15:58 -07001915 substr($block, 0, length($cond), '');
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001916
1917 $seen++ if ($block =~ /^\s*{/);
1918
Andy Whitcroftcf655042008-03-04 14:28:20 -08001919 #print "cond<$cond> block<$block> allowed<$allowed>\n";
1920 if (statement_lines($cond) > 1) {
1921 #print "APW: ALLOWED: cond<$cond>\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001922 $allowed = 1;
1923 }
1924 if ($block =~/\b(?:if|for|while)\b/) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001925 #print "APW: ALLOWED: block<$block>\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001926 $allowed = 1;
1927 }
Andy Whitcroftcf655042008-03-04 14:28:20 -08001928 if (statement_block_size($block) > 1) {
1929 #print "APW: ALLOWED: lines block<$block>\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001930 $allowed = 1;
1931 }
1932 }
1933 if ($seen && !$allowed) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001934 WARN("braces {} are not necessary for any arm of this statement\n" . $herectx);
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001935 }
1936 }
1937 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001938 if (!defined $suppress_ifbraces{$linenr - 1} &&
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001939 $line =~ /\b(if|while|for|else)\b/) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001940 my $allowed = 0;
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001941
Andy Whitcroftcf655042008-03-04 14:28:20 -08001942 # Check the pre-context.
1943 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
1944 #print "APW: ALLOWED: pre<$1>\n";
1945 $allowed = 1;
1946 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001947
1948 my ($level, $endln, @chunks) =
1949 ctx_statement_full($linenr, $realcnt, $-[0]);
1950
Andy Whitcroftcf655042008-03-04 14:28:20 -08001951 # Check the condition.
1952 my ($cond, $block) = @{$chunks[0]};
Andy Whitcroft773647a2008-03-28 14:15:58 -07001953 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08001954 if (defined $cond) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001955 substr($block, 0, length($cond), '');
Andy Whitcroftcf655042008-03-04 14:28:20 -08001956 }
1957 if (statement_lines($cond) > 1) {
1958 #print "APW: ALLOWED: cond<$cond>\n";
1959 $allowed = 1;
1960 }
1961 if ($block =~/\b(?:if|for|while)\b/) {
1962 #print "APW: ALLOWED: block<$block>\n";
1963 $allowed = 1;
1964 }
1965 if (statement_block_size($block) > 1) {
1966 #print "APW: ALLOWED: lines block<$block>\n";
1967 $allowed = 1;
1968 }
1969 # Check the post-context.
1970 if (defined $chunks[1]) {
1971 my ($cond, $block) = @{$chunks[1]};
1972 if (defined $cond) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001973 substr($block, 0, length($cond), '');
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001974 }
Andy Whitcroftcf655042008-03-04 14:28:20 -08001975 if ($block =~ /^\s*\{/) {
1976 #print "APW: ALLOWED: chunk-1 block<$block>\n";
1977 $allowed = 1;
1978 }
1979 }
1980 if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
1981 my $herectx = $here . "\n";;
1982 my $end = $linenr + statement_rawlines($block) - 1;
1983
1984 for (my $ln = $linenr - 1; $ln < $end; $ln++) {
1985 $herectx .= $rawlines[$ln] . "\n";;
1986 }
1987
1988 WARN("braces {} are not necessary for single statement blocks\n" . $herectx);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001989 }
1990 }
1991
Andy Whitcroft653d4872007-06-23 17:16:34 -07001992# don't include deprecated include files (uses RAW line)
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001993 for my $inc (@dep_includes) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001994 if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001995 ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001996 }
1997 }
1998
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001999# don't use deprecated functions
2000 for my $func (@dep_functions) {
Andy Whitcroft00df3442007-06-08 13:47:06 -07002001 if ($line =~ /\b$func\b/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002002 ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002003 }
2004 }
2005
2006# no volatiles please
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002007 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
2008 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002009 WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002010 }
2011
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002012# SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated
2013 if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) {
2014 ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr);
2015 }
2016
Andy Whitcroft00df3442007-06-08 13:47:06 -07002017# warn about #if 0
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002018 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002019 CHK("if this code is redundant consider removing it\n" .
2020 $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002021 }
2022
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002023# check for needless kfree() checks
2024 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2025 my $expr = $1;
2026 if ($line =~ /\bkfree\(\Q$expr\E\);/) {
2027 WARN("kfree(NULL) is safe this check is probabally not required\n" . $hereprev);
2028 }
2029 }
2030
Andy Whitcroft00df3442007-06-08 13:47:06 -07002031# warn about #ifdefs in C files
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002032# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
Andy Whitcroft00df3442007-06-08 13:47:06 -07002033# print "#ifdef in C files should be avoided\n";
2034# print "$herecurr";
2035# $clean = 0;
2036# }
2037
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002038# warn about spacing in #ifdefs
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002039 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002040 ERROR("exactly one space required after that #$1\n" . $herecurr);
2041 }
2042
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002043# check for spinlock_t definitions without a comment.
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002044 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
2045 $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002046 my $which = $1;
2047 if (!ctx_has_comment($first_line, $linenr)) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002048 CHK("$1 definition without comment\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002049 }
2050 }
2051# check for memory barriers without a comment.
2052 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
2053 if (!ctx_has_comment($first_line, $linenr)) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002054 CHK("memory barrier without comment\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002055 }
2056 }
2057# check of hardware specific defines
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002058 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002059 CHK("architecture specific defines should be avoided\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002060 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002061
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002062# check the location of the inline attribute, that it is between
2063# storage class and type.
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002064 if ($line =~ /\b$Type\s+$Inline\b/ ||
2065 $line =~ /\b$Inline\s+$Storage\b/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002066 ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
2067 }
2068
Andy Whitcroft8905a672007-11-28 16:21:06 -08002069# Check for __inline__ and __inline, prefer inline
2070 if ($line =~ /\b(__inline__|__inline)\b/) {
2071 WARN("plain inline is preferred over $1\n" . $herecurr);
2072 }
2073
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002074# check for new externs in .c files.
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002075 if ($realfile =~ /\.c$/ && defined $stat &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002076 $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002077 {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002078 my $function_name = $1;
2079 my $paren_space = $2;
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002080
2081 my $s = $stat;
2082 if (defined $cond) {
2083 substr($s, 0, length($cond), '');
2084 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002085 if ($s =~ /^\s*;/ &&
2086 $function_name ne 'uninitialized_var')
2087 {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002088 WARN("externs should be avoided in .c files\n" . $herecurr);
2089 }
2090
2091 if ($paren_space =~ /\n/) {
2092 WARN("arguments for function declarations should follow identifier\n" . $herecurr);
2093 }
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07002094
2095 } elsif ($realfile =~ /\.c$/ && defined $stat &&
2096 $stat =~ /^.\s*extern\s+/)
2097 {
2098 WARN("externs should be avoided in .c files\n" . $herecurr);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002099 }
2100
2101# checks for new __setup's
2102 if ($rawline =~ /\b__setup\("([^"]*)"/) {
2103 my $name = $1;
2104
2105 if (!grep(/$name/, @setup_docs)) {
2106 CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
2107 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002108 }
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002109
2110# check for pointless casting of kmalloc return
2111 if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) {
2112 WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
2113 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002114
2115# check for gcc specific __FUNCTION__
2116 if ($line =~ /__FUNCTION__/) {
2117 WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
2118 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07002119
2120# check for semaphores used as mutexes
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002121 if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07002122 WARN("mutexes are preferred for single holder semaphores\n" . $herecurr);
2123 }
2124# check for semaphores used as mutexes
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002125 if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07002126 WARN("consider using a completion\n" . $herecurr);
2127 }
2128# recommend strict_strto* over simple_strto*
2129 if ($line =~ /\bsimple_(strto.*?)\s*\(/) {
2130 WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr);
2131 }
Michael Ellermanf3db6632008-07-23 21:28:57 -07002132# check for __initcall(), use device_initcall() explicitly please
2133 if ($line =~ /^.\s*__initcall\s*\(/) {
2134 WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
2135 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07002136
2137# use of NR_CPUS is usually wrong
2138# ignore definitions of NR_CPUS and usage to define arrays as likely right
2139 if ($line =~ /\bNR_CPUS\b/ &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002140 $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
2141 $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002142 $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
2143 $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
2144 $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
Andy Whitcroft773647a2008-03-28 14:15:58 -07002145 {
2146 WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
2147 }
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07002148
2149# check for %L{u,d,i} in strings
2150 my $string;
2151 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
2152 $string = substr($rawline, $-[1], $+[1] - $-[1]);
2153 if ($string =~ /(?<!%)%L[udi]/) {
2154 WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
2155 last;
2156 }
2157 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002158 }
2159
2160 # If we have no input at all, then there is nothing to report on
2161 # so just keep quiet.
2162 if ($#rawlines == -1) {
2163 exit(0);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002164 }
2165
Andy Whitcroft8905a672007-11-28 16:21:06 -08002166 # In mailback mode only produce a report in the negative, for
2167 # things that appear to be patches.
2168 if ($mailback && ($clean == 1 || !$is_patch)) {
2169 exit(0);
2170 }
2171
2172 # This is not a patch, and we are are in 'no-patch' mode so
2173 # just keep quiet.
2174 if (!$chk_patch && !$is_patch) {
2175 exit(0);
2176 }
2177
2178 if (!$is_patch) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002179 ERROR("Does not appear to be a unified-diff format patch\n");
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002180 }
2181 if ($is_patch && $chk_signoff && $signoff == 0) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002182 ERROR("Missing Signed-off-by: line(s)\n");
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002183 }
2184
Andy Whitcroft8905a672007-11-28 16:21:06 -08002185 print report_dump();
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002186 if ($summary && !($clean == 1 && $quiet == 1)) {
2187 print "$filename " if ($summary_file);
Andy Whitcroft8905a672007-11-28 16:21:06 -08002188 print "total: $cnt_error errors, $cnt_warn warnings, " .
2189 (($check)? "$cnt_chk checks, " : "") .
2190 "$cnt_lines lines checked\n";
2191 print "\n" if ($quiet == 0);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002192 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08002193
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002194 if ($clean == 1 && $quiet == 0) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002195 print "$vname has no obvious style problems and is ready for submission.\n"
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002196 }
2197 if ($clean == 0 && $quiet == 0) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002198 print "$vname has style problems, please review. If any of these errors\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002199 print "are false positives report them to the maintainer, see\n";
2200 print "CHECKPATCH in MAINTAINERS.\n";
2201 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002202
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002203 return $clean;
2204}