tree c135a4a5527ce98bb3473342061f3990feef7d42
parent 1abb8a8b841354e7a09ba2009376f0a6368b5cec
author Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 1181308469 +0200
committer Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> 1181308469 +0200

it821x: RAID mode fixes

The DMA support for RAID mode broke after:

	commit 71ef51cc1756d1c56b57c70e7cc27a3559c81ee6
	Author: Jens Axboe <axboe@suse.de>
	Date: Â  Fri Jul 28 09:02:17 2006 +0200

	Â  Â  [PATCH] it821x: fix ide dma setup bug

	Â  Â  Only enable dma for a valid speed setting.

	Â  Â  Signed-off-by: Jens Axboe <axboe@suse.de>

	commit 0a8348d08677ad77ee353f96eb8745c693a05a13
	Author: Jens Axboe <axboe@suse.de>
	Date: Â  Fri Jul 28 08:58:26 2006 +0200

	Â  Â  [PATCH] ide: if the id fields looks screwy, disable DMA

	Â  Â  It's the safer choice. Originally due to a bug in itx821x, but a
	Â  Â  generally sound thing to do.

	Â  Â  Signed-off-by: Jens Axboe <axboe@suse.de>

However it worked by pure luck before Jens' fixes: bogus ide_dma_enable()
usage in it821x driver combined with loosy check in ide_dma_verbose() allowed
the hardware to operate in DMA mode.  When these problems were fixed the DMA
support broke...

The source root for the regression turned out to be that the it821x.c code
was clearing too much of id->field_valid.  The IDE core code was using the
original value of id->field_valid to do the tuning but later DMA got disabled
in ide_dma_verbose() because of the incorrect id->field_valid fixup.  Fix it.

While at it:

* Do fixup() after probing the drives but before tuning them (which is also
  OK w.r.t. ide_undecoded_slave() fixup).  This change fixes device IDENTIFY
  data to be consistent before/after the tuning and allows us to remove extra
  re-tuning of drives from it821x_fixups().

* Fake MWDMA0 enabled/supported bits in IDENTIFY data if the device has
  DMA capable bit set (this is just to tell the IDE core that DMA is
  supported since it821x firmware takes care of DMA mode programming).

* Don't touch timing registers and don't program transfer modes on devices
  et all when in RAID mode - depend solely on firmware to do the tuning
  (as suggested by Alan Cox and done in libata pata_it821x driver).

Thanks for testing the patch goes out to Thomas Kuther.

Cc: Thomas Kuther <gimpel@sonnenkinder.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jens Axboe <axboe@suse.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>