tree 5d55c9a62c7bbdaac8ae6fee80fb62e704f30cb7
parent 13931ae31b67a8a26a4cd417088fc43e3d4a8591
author Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> 1558724959 -0500
committer Mark Brown <broonie@kernel.org> 1559054839 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQFHBAABCgAxFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlztSfcTHGJyb29uaWVA
 a2VybmVsLm9yZwAKCRAk1otyXVSH0MLmB/4+PCSxigSlYmPU8mD17FuaZOpMetEl
 n9MHVTjC8ZwpI+hLjsdcKs1fIv2FNzjrbaiIq9dkXNJiQ8Pie1UfuncvMipzDkud
 IYig0d3ottv31gYhUbAf6lbQ7hnx4lDCaIAwdVXaXRP+GNDRC+xuwX8K/EmJYpZM
 vi5VZckF4egRXleBxustcJ1o8cpnvawgJTis8QCU+DGHN/QsAVyhBM32GGTrOxel
 I6jUYiXd8EVrls8aVJ1EHq8GJBG+D9+XOp97K5cRsAvCp/wVBPKKtOHdymMOe5Em
 g8Y9SfRemQRXTW7El1EMKXWz4eLt5isVEgi3k2u6PbYxzeIYBDMqZf3f
 =743h
 -----END PGP SIGNATURE-----

ASoC: SOF: core: fix error handling with the probe workqueue

In some configurations, it's a requirement to split the probe in two,
with a second part handled in a workqueue (e.g. for HDMI support
which depends on the DRM modules).

SOF already handles these configurations but the error flow is
incorrect. When an error occurs in the workqueue, the probe has
technically already completed. If we release the resources on errors,
this generates kernel oops/use-after-free when the resources are
released a second time on module removal.

GitHub issue: https://github.com/thesofproject/linux/issues/945
Fixes: c16211d6226 ("ASoC: SOF: Add Sound Open Firmware driver core")
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>