| commit | 0f2886057be322ddfa4858384c40a505f7a32a4a | [log] [tgz] |
|---|---|---|
| author | Tom Gundersen <teg@jklm.no> | Wed Sep 21 16:59:19 2016 +0200 |
| committer | Sean Paul <seanpaul@chromium.org> | Thu Sep 22 04:03:48 2016 -0700 |
| tree | 95fd93e32cce031f99920cd1937b4e46491e65b3 | |
| parent | c6bf811a0b55ab224fb2c75345641b4bb599475c [diff] [blame] |
drm: Don't swallow error codes in drm_dev_alloc() There are many reasons other than ENOMEM that drm_dev_init() can fail. Return ERR_PTR rather than NULL to be able to distinguish these in the caller. Signed-off-by: Tom Gundersen <teg@jklm.no> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: http://patchwork.freedesktop.org/patch/msgid/20160921145919.13754-2-teg@jklm.no
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 76eaf1d..446b5d7 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -143,8 +143,8 @@ int ret; drm_dev = drm_dev_alloc(&rockchip_drm_driver, dev); - if (!drm_dev) - return -ENOMEM; + if (IS_ERR(drm_dev)) + return PTR_ERR(drm_dev); dev_set_drvdata(dev, drm_dev);