tree 47ce773ce58dd4f584ba8baffce973b9d55a1148
parent 523d939ef98fd712632d93a5a2b588e477a7565e
author Miklos Szeredi <mszeredi@redhat.com> 1470224667 +0200
committer Miklos Szeredi <mszeredi@redhat.com> 1470225476 +0200

vfs: fix deadlock in file_remove_privs() on overlayfs

file_remove_privs() is called with inode lock on file_inode(), which
proceeds to calling notify_change() on file->f_path.dentry.  Which triggers
the WARN_ON_ONCE(!inode_is_locked(inode)) in addition to deadlocking later
when ovl_setattr tries to lock the underlying inode again.

Fix this mess by not mixing the layers, but doing everything on underlying
dentry/inode.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 07a2daab49c5 ("ovl: Copy up underlying inode's ->i_mode to overlay inode")
Cc: <stable@vger.kernel.org>