mei: use type struct mei_cl *cl instead of void in struct mei_cb
We can use correct type 'struct mei_cl' instead of
'void *' for file_private in the struct mei_cb
as there is no other type assigned to this member of the structure
We rename the member from file_private to cl
Remove about 10 lines of declarations of temporary variables
used for type casting
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c
index 7193149..acc994e 100644
--- a/drivers/misc/mei/interrupt.c
+++ b/drivers/misc/mei/interrupt.c
@@ -113,7 +113,7 @@
goto quit;
list_for_each_entry_safe(cb_pos, cb_next, &dev->read_list.list, list) {
- cl = (struct mei_cl *)cb_pos->file_private;
+ cl = cb_pos->cl;
if (cl && _mei_irq_thread_state_ok(cl, mei_hdr)) {
cl->reading_state = MEI_READING;
buffer = cb_pos->response_buffer.data + cb_pos->buf_idx;
@@ -263,7 +263,7 @@
}
list_for_each_entry_safe(pos, next, &dev->ctrl_rd_list.list, list) {
- cl = (struct mei_cl *)pos->file_private;
+ cl = pos->cl;
if (!cl) {
list_del(&pos->list);
return;
@@ -301,7 +301,7 @@
rs->status);
list_for_each_entry_safe(pos, next, &dev->ctrl_rd_list.list, list) {
- cl = (struct mei_cl *)pos->file_private;
+ cl = pos->cl;
if (!cl) {
list_del(&pos->list);
@@ -981,7 +981,7 @@
list = &dev->write_waiting_list;
list_for_each_entry_safe(pos, next, &list->list, list) {
- cl = (struct mei_cl *)pos->file_private;
+ cl = pos->cl;
if (cl == NULL)
continue;
@@ -1039,7 +1039,7 @@
/* complete control write list CB */
dev_dbg(&dev->pdev->dev, "complete control write list cb.\n");
list_for_each_entry_safe(pos, next, &dev->ctrl_wr_list.list, list) {
- cl = (struct mei_cl *) pos->file_private;
+ cl = pos->cl;
if (!cl) {
list_del(&pos->list);
return -ENODEV;
@@ -1077,7 +1077,7 @@
/* complete write list CB */
dev_dbg(&dev->pdev->dev, "complete write list cb.\n");
list_for_each_entry_safe(pos, next, &dev->write_list.list, list) {
- cl = (struct mei_cl *)pos->file_private;
+ cl = pos->cl;
if (cl == NULL)
continue;
@@ -1316,7 +1316,7 @@
list_for_each_entry_safe(cb_pos, cb_next, &complete_list.list, list) {
- cl = (struct mei_cl *)cb_pos->file_private;
+ cl = cb_pos->cl;
list_del(&cb_pos->list);
if (cl) {
if (cl != &dev->iamthif_cl) {