| commit | dbc6e0222d79e78925fe20733844a796a4b72cf9 | [log] [tgz] |
|---|---|---|
| author | Al Viro <viro@zeniv.linux.org.uk> | Wed Aug 01 13:07:04 2012 +0400 |
| committer | Al Viro <viro@zeniv.linux.org.uk> | Wed Aug 01 16:53:16 2012 +0400 |
| tree | 49eabccaa420103bd5ecddc2b77bc916440db812 | |
| parent | 06fd516c1a504828780fcd81dfe21f94dec4c868 [diff] |
delousing target_core_file a bit * set_fs(KERNEL_DS) + getname() is probably the weirdest implementation of strdup() I've seen. Especially since they don't to copy it at all... * filp_open() never returns NULL; it's ERR_PTR(-E...) on failure. * file->f_dentry is never going to be NULL, TYVM. * match_strdup() + snprintf() + kfree() is a bloody weird way to spell match_strlcpy(). Pox on cargo-cult programmers... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>