tree 91aeee4cfe6cfa4a07e2373d7d1f4d3d65b0b549
parent 39e88fcfb1d5c6c4b1ff76ca2ab76cf449b850e8
author Xi Wang <xi.wang@gmail.com> 1357287777 -0500
committer Trond Myklebust <Trond.Myklebust@netapp.com> 1357314883 -0500

nfs: fix null checking in nfs_get_option_str()

The following null pointer check is broken.

	*option = match_strdup(args);
	return !option;

The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.

The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some
cut-and-paste code.").

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>