drm/nouveau/fan: fix selection of fan speed when fan->get returns an error
fan->get returns int, but we write it to unsigned variable, and then check
whether it's >= 0 (it always is)
Found by smatch:
drivers/gpu/drm/nouveau/core/subdev/therm/fan.c:61 nouveau_fan_update() warn: always true condition '(duty >= 0) => (0-u32max >= 0)'
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
diff --git a/drivers/gpu/drm/nouveau/core/subdev/therm/fan.c b/drivers/gpu/drm/nouveau/core/subdev/therm/fan.c
index b179655..c728380 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/therm/fan.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/therm/fan.c
@@ -39,7 +39,7 @@
struct nouveau_timer *ptimer = nouveau_timer(priv);
unsigned long flags;
int ret = 0;
- u32 duty;
+ int duty;
/* update target fan speed, restricting to allowed range */
spin_lock_irqsave(&fan->lock, flags);
@@ -64,9 +64,9 @@
* it is meant to bump the fan speed more incrementally
*/
if (duty < target)
- duty = min(duty + 3, (u32) target);
+ duty = min(duty + 3, target);
else if (duty > target)
- duty = max(duty - 3, (u32) target);
+ duty = max(duty - 3, target);
} else {
duty = target;
}