blob: 1fd9539a969dce20d292c70885758945be84acdd [file] [log] [blame]
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -05001/*
2 * Copyright (C) 2011 IBM Corporation
3 *
4 * Author:
5 * Mimi Zohar <zohar@us.ibm.com>
6 *
7 * This program is free software; you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation, version 2 of the License.
10 */
11#include <linux/module.h>
12#include <linux/file.h>
13#include <linux/fs.h>
14#include <linux/xattr.h>
15#include <linux/magic.h>
16#include <linux/ima.h>
17#include <linux/evm.h>
18
19#include "ima.h"
20
21static int __init default_appraise_setup(char *str)
22{
23 if (strncmp(str, "off", 3) == 0)
24 ima_appraise = 0;
Dmitry Kasatkin2faa6ef2014-05-08 13:11:29 +030025 else if (strncmp(str, "log", 3) == 0)
26 ima_appraise = IMA_APPRAISE_LOG;
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -050027 else if (strncmp(str, "fix", 3) == 0)
28 ima_appraise = IMA_APPRAISE_FIX;
29 return 1;
30}
31
32__setup("ima_appraise=", default_appraise_setup);
33
34/*
35 * ima_must_appraise - set appraise flag
36 *
37 * Return 1 to appraise
38 */
Dmitry Kasatkind26e1932012-09-27 18:26:53 +030039int ima_must_appraise(struct inode *inode, int mask, enum ima_hooks func)
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -050040{
Mimi Zohar07f6a792011-03-09 22:25:48 -050041 if (!ima_appraise)
42 return 0;
43
Eric Richter725de7f2016-06-01 13:14:02 -050044 return ima_match_policy(inode, func, mask, IMA_APPRAISE, NULL);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -050045}
46
Dmitry Kasatkindef3e8b2012-09-20 22:38:53 +030047static int ima_fix_xattr(struct dentry *dentry,
Dmitry Kasatkinc7c8bb22013-04-25 10:43:56 +030048 struct integrity_iint_cache *iint)
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -050049{
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +030050 int rc, offset;
51 u8 algo = iint->ima_hash->algo;
52
53 if (algo <= HASH_ALGO_SHA1) {
54 offset = 1;
55 iint->ima_hash->xattr.sha1.type = IMA_XATTR_DIGEST;
56 } else {
57 offset = 0;
58 iint->ima_hash->xattr.ng.type = IMA_XATTR_DIGEST_NG;
59 iint->ima_hash->xattr.ng.algo = algo;
60 }
61 rc = __vfs_setxattr_noperm(dentry, XATTR_NAME_IMA,
62 &iint->ima_hash->xattr.data[offset],
63 (sizeof(iint->ima_hash->xattr) - offset) +
64 iint->ima_hash->length, 0);
65 return rc;
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -050066}
67
Mimi Zohard79d72e2012-12-03 17:08:11 -050068/* Return specific func appraised cached result */
69enum integrity_status ima_get_cache_status(struct integrity_iint_cache *iint,
Mimi Zohar4ad87a32016-01-14 20:59:14 -050070 enum ima_hooks func)
Mimi Zohard79d72e2012-12-03 17:08:11 -050071{
Dmitry Kasatkin089bc8e2013-10-10 15:56:13 +090072 switch (func) {
Mimi Zohard79d72e2012-12-03 17:08:11 -050073 case MMAP_CHECK:
74 return iint->ima_mmap_status;
75 case BPRM_CHECK:
76 return iint->ima_bprm_status;
Mimi Zohard79d72e2012-12-03 17:08:11 -050077 case FILE_CHECK:
Mimi Zoharc6af8ef2015-11-19 12:39:22 -050078 case POST_SETATTR:
Mimi Zohard79d72e2012-12-03 17:08:11 -050079 return iint->ima_file_status;
Mimi Zoharc6af8ef2015-11-19 12:39:22 -050080 case MODULE_CHECK ... MAX_CHECK - 1:
81 default:
82 return iint->ima_read_status;
Mimi Zohard79d72e2012-12-03 17:08:11 -050083 }
84}
85
86static void ima_set_cache_status(struct integrity_iint_cache *iint,
Mimi Zohar4ad87a32016-01-14 20:59:14 -050087 enum ima_hooks func,
88 enum integrity_status status)
Mimi Zohard79d72e2012-12-03 17:08:11 -050089{
Dmitry Kasatkin089bc8e2013-10-10 15:56:13 +090090 switch (func) {
Mimi Zohard79d72e2012-12-03 17:08:11 -050091 case MMAP_CHECK:
92 iint->ima_mmap_status = status;
93 break;
94 case BPRM_CHECK:
95 iint->ima_bprm_status = status;
96 break;
Mimi Zohard79d72e2012-12-03 17:08:11 -050097 case FILE_CHECK:
Mimi Zoharc6af8ef2015-11-19 12:39:22 -050098 case POST_SETATTR:
Mimi Zohard79d72e2012-12-03 17:08:11 -050099 iint->ima_file_status = status;
Mimi Zoharc6af8ef2015-11-19 12:39:22 -0500100 break;
101 case MODULE_CHECK ... MAX_CHECK - 1:
102 default:
103 iint->ima_read_status = status;
104 break;
Mimi Zohard79d72e2012-12-03 17:08:11 -0500105 }
106}
107
Mimi Zohar4ad87a32016-01-14 20:59:14 -0500108static void ima_cache_flags(struct integrity_iint_cache *iint,
109 enum ima_hooks func)
Mimi Zohard79d72e2012-12-03 17:08:11 -0500110{
Dmitry Kasatkin089bc8e2013-10-10 15:56:13 +0900111 switch (func) {
Mimi Zohard79d72e2012-12-03 17:08:11 -0500112 case MMAP_CHECK:
113 iint->flags |= (IMA_MMAP_APPRAISED | IMA_APPRAISED);
114 break;
115 case BPRM_CHECK:
116 iint->flags |= (IMA_BPRM_APPRAISED | IMA_APPRAISED);
117 break;
Mimi Zohard79d72e2012-12-03 17:08:11 -0500118 case FILE_CHECK:
Mimi Zoharc6af8ef2015-11-19 12:39:22 -0500119 case POST_SETATTR:
Mimi Zohard79d72e2012-12-03 17:08:11 -0500120 iint->flags |= (IMA_FILE_APPRAISED | IMA_APPRAISED);
Mimi Zoharc6af8ef2015-11-19 12:39:22 -0500121 break;
122 case MODULE_CHECK ... MAX_CHECK - 1:
123 default:
124 iint->flags |= (IMA_READ_APPRAISED | IMA_APPRAISED);
125 break;
Mimi Zohard79d72e2012-12-03 17:08:11 -0500126 }
127}
128
Dmitry Kasatkin1525b062014-10-30 12:39:39 +0200129enum hash_algo ima_get_hash_algo(struct evm_ima_xattr_data *xattr_value,
130 int xattr_len)
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300131{
132 struct signature_v2_hdr *sig;
Seth Forsheeb4bfec72016-08-01 08:19:10 -0500133 enum hash_algo ret;
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300134
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300135 if (!xattr_value || xattr_len < 2)
Dmitry Kasatkin1525b062014-10-30 12:39:39 +0200136 /* return default hash algo */
137 return ima_hash_algo;
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300138
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300139 switch (xattr_value->type) {
140 case EVM_IMA_XATTR_DIGSIG:
141 sig = (typeof(sig))xattr_value;
142 if (sig->version != 2 || xattr_len <= sizeof(*sig))
Dmitry Kasatkin1525b062014-10-30 12:39:39 +0200143 return ima_hash_algo;
144 return sig->hash_algo;
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300145 break;
146 case IMA_XATTR_DIGEST_NG:
Seth Forsheeb4bfec72016-08-01 08:19:10 -0500147 ret = xattr_value->digest[0];
148 if (ret < HASH_ALGO__LAST)
149 return ret;
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300150 break;
151 case IMA_XATTR_DIGEST:
152 /* this is for backward compatibility */
153 if (xattr_len == 21) {
154 unsigned int zero = 0;
155 if (!memcmp(&xattr_value->digest[16], &zero, 4))
Dmitry Kasatkin1525b062014-10-30 12:39:39 +0200156 return HASH_ALGO_MD5;
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300157 else
Dmitry Kasatkin1525b062014-10-30 12:39:39 +0200158 return HASH_ALGO_SHA1;
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300159 } else if (xattr_len == 17)
Dmitry Kasatkin1525b062014-10-30 12:39:39 +0200160 return HASH_ALGO_MD5;
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300161 break;
162 }
Dmitry Kasatkin1525b062014-10-30 12:39:39 +0200163
164 /* return default hash algo */
165 return ima_hash_algo;
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300166}
167
168int ima_read_xattr(struct dentry *dentry,
169 struct evm_ima_xattr_data **xattr_value)
170{
Andreas Gruenbacher5d6c3192016-09-29 17:48:42 +0200171 ssize_t ret;
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300172
Andreas Gruenbacher5d6c3192016-09-29 17:48:42 +0200173 ret = vfs_getxattr_alloc(dentry, XATTR_NAME_IMA, (char **)xattr_value,
174 0, GFP_NOFS);
175 if (ret == -EOPNOTSUPP)
176 ret = 0;
177 return ret;
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300178}
179
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500180/*
181 * ima_appraise_measurement - appraise file measurement
182 *
183 * Call evm_verifyxattr() to verify the integrity of 'security.ima'.
184 * Assuming success, compare the xattr hash with the collected measurement.
185 *
186 * Return 0 on success, error code otherwise
187 */
Mimi Zohar4ad87a32016-01-14 20:59:14 -0500188int ima_appraise_measurement(enum ima_hooks func,
189 struct integrity_iint_cache *iint,
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300190 struct file *file, const unsigned char *filename,
191 struct evm_ima_xattr_data *xattr_value,
Dmitry Kasatkin3034a142014-06-27 18:15:44 +0300192 int xattr_len, int opened)
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500193{
Mimi Zohar52a13282013-12-11 14:44:04 -0500194 static const char op[] = "appraise_data";
195 char *cause = "unknown";
Miklos Szeredie71b9df2016-09-16 12:44:20 +0200196 struct dentry *dentry = file_dentry(file);
David Howellsc6f493d2015-03-17 22:26:22 +0000197 struct inode *inode = d_backing_inode(dentry);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500198 enum integrity_status status = INTEGRITY_UNKNOWN;
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300199 int rc = xattr_len, hash_start = 0;
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500200
Andreas Gruenbacher5d6c3192016-09-29 17:48:42 +0200201 if (!(inode->i_opflags & IOP_XATTR))
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500202 return INTEGRITY_UNKNOWN;
203
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500204 if (rc <= 0) {
205 if (rc && rc != -ENODATA)
206 goto out;
207
208 cause = "missing-hash";
Dmitry Kasatkinb151d6b2014-06-27 18:04:27 +0300209 status = INTEGRITY_NOLABEL;
Dmitry Kasatkin3034a142014-06-27 18:15:44 +0300210 if (opened & FILE_CREATED) {
Dmitry Kasatkinb151d6b2014-06-27 18:04:27 +0300211 iint->flags |= IMA_NEW_FILE;
212 status = INTEGRITY_PASS;
213 }
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500214 goto out;
215 }
216
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300217 status = evm_verifyxattr(dentry, XATTR_NAME_IMA, xattr_value, rc, iint);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500218 if ((status != INTEGRITY_PASS) && (status != INTEGRITY_UNKNOWN)) {
219 if ((status == INTEGRITY_NOLABEL)
220 || (status == INTEGRITY_NOXATTRS))
221 cause = "missing-HMAC";
222 else if (status == INTEGRITY_FAIL)
223 cause = "invalid-HMAC";
224 goto out;
225 }
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300226 switch (xattr_value->type) {
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300227 case IMA_XATTR_DIGEST_NG:
228 /* first byte contains algorithm id */
229 hash_start = 1;
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300230 case IMA_XATTR_DIGEST:
Dmitry Kasatkin0e5a2472012-06-08 13:58:49 +0300231 if (iint->flags & IMA_DIGSIG_REQUIRED) {
Richard Guy Briggs7e9001f2014-06-16 15:52:07 -0400232 cause = "IMA-signature-required";
Dmitry Kasatkin0e5a2472012-06-08 13:58:49 +0300233 status = INTEGRITY_FAIL;
234 break;
235 }
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300236 if (xattr_len - sizeof(xattr_value->type) - hash_start >=
237 iint->ima_hash->length)
Dmitry Kasatkind3634d02013-04-25 10:44:04 +0300238 /* xattr length may be longer. md5 hash in previous
239 version occupied 20 bytes in xattr, instead of 16
240 */
Dmitry Kasatkin3ea7a562013-08-12 11:22:51 +0300241 rc = memcmp(&xattr_value->digest[hash_start],
Dmitry Kasatkina35c3fb2013-04-25 10:44:04 +0300242 iint->ima_hash->digest,
243 iint->ima_hash->length);
Dmitry Kasatkinc7c8bb22013-04-25 10:43:56 +0300244 else
245 rc = -EINVAL;
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300246 if (rc) {
247 cause = "invalid-hash";
248 status = INTEGRITY_FAIL;
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300249 break;
250 }
251 status = INTEGRITY_PASS;
252 break;
253 case EVM_IMA_XATTR_DIGSIG:
254 iint->flags |= IMA_DIGSIG;
255 rc = integrity_digsig_verify(INTEGRITY_KEYRING_IMA,
Dmitry Kasatkinb1aaab22013-10-10 16:12:03 +0900256 (const char *)xattr_value, rc,
Dmitry Kasatkina35c3fb2013-04-25 10:44:04 +0300257 iint->ima_hash->digest,
258 iint->ima_hash->length);
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300259 if (rc == -EOPNOTSUPP) {
260 status = INTEGRITY_UNKNOWN;
261 } else if (rc) {
262 cause = "invalid-signature";
263 status = INTEGRITY_FAIL;
264 } else {
265 status = INTEGRITY_PASS;
266 }
267 break;
268 default:
269 status = INTEGRITY_UNKNOWN;
270 cause = "unknown-ima-data";
271 break;
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500272 }
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300273
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500274out:
275 if (status != INTEGRITY_PASS) {
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300276 if ((ima_appraise & IMA_APPRAISE_FIX) &&
277 (!xattr_value ||
278 xattr_value->type != EVM_IMA_XATTR_DIGSIG)) {
Dmitry Kasatkindef3e8b2012-09-20 22:38:53 +0300279 if (!ima_fix_xattr(dentry, iint))
280 status = INTEGRITY_PASS;
Mimi Zohar05d1a712016-02-29 19:52:05 -0500281 } else if ((inode->i_size == 0) &&
282 (iint->flags & IMA_NEW_FILE) &&
283 (xattr_value &&
284 xattr_value->type == EVM_IMA_XATTR_DIGSIG)) {
285 status = INTEGRITY_PASS;
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500286 }
287 integrity_audit_msg(AUDIT_INTEGRITY_DATA, inode, filename,
288 op, cause, rc, 0);
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300289 } else {
Mimi Zohard79d72e2012-12-03 17:08:11 -0500290 ima_cache_flags(iint, func);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500291 }
Mimi Zohard79d72e2012-12-03 17:08:11 -0500292 ima_set_cache_status(iint, func, status);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500293 return status;
294}
295
296/*
297 * ima_update_xattr - update 'security.ima' hash value
298 */
299void ima_update_xattr(struct integrity_iint_cache *iint, struct file *file)
300{
Miklos Szeredie71b9df2016-09-16 12:44:20 +0200301 struct dentry *dentry = file_dentry(file);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500302 int rc = 0;
303
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300304 /* do not collect and update hash for digital signatures */
305 if (iint->flags & IMA_DIGSIG)
306 return;
307
Mimi Zoharcf222212016-01-14 17:57:47 -0500308 rc = ima_collect_measurement(iint, file, NULL, 0, ima_hash_algo);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500309 if (rc < 0)
310 return;
Dmitry Kasatkin86064042011-08-31 14:07:06 +0300311
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500312 ima_fix_xattr(dentry, iint);
313}
314
315/**
316 * ima_inode_post_setattr - reflect file metadata changes
317 * @dentry: pointer to the affected dentry
318 *
319 * Changes to a dentry's metadata might result in needing to appraise.
320 *
321 * This function is called from notify_change(), which expects the caller
322 * to lock the inode's i_mutex.
323 */
324void ima_inode_post_setattr(struct dentry *dentry)
325{
David Howellsc6f493d2015-03-17 22:26:22 +0000326 struct inode *inode = d_backing_inode(dentry);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500327 struct integrity_iint_cache *iint;
Andreas Gruenbacher5d6c3192016-09-29 17:48:42 +0200328 int must_appraise;
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500329
Roberto Sassua7560242014-09-12 19:35:54 +0200330 if (!(ima_policy_flag & IMA_APPRAISE) || !S_ISREG(inode->i_mode)
Andreas Gruenbacher5d6c3192016-09-29 17:48:42 +0200331 || !(inode->i_opflags & IOP_XATTR))
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500332 return;
333
334 must_appraise = ima_must_appraise(inode, MAY_ACCESS, POST_SETATTR);
335 iint = integrity_iint_find(inode);
336 if (iint) {
Mimi Zohard79d72e2012-12-03 17:08:11 -0500337 iint->flags &= ~(IMA_APPRAISE | IMA_APPRAISED |
338 IMA_APPRAISE_SUBMASK | IMA_APPRAISED_SUBMASK |
Mimi Zohar42a4c602016-02-29 08:30:12 -0500339 IMA_ACTION_RULE_FLAGS);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500340 if (must_appraise)
341 iint->flags |= IMA_APPRAISE;
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500342 }
343 if (!must_appraise)
Andreas Gruenbacher5d6c3192016-09-29 17:48:42 +0200344 __vfs_removexattr(dentry, XATTR_NAME_IMA);
Mimi Zohar2fe5d6d2012-02-13 10:15:05 -0500345}
Mimi Zohar42c63332011-03-10 18:54:15 -0500346
347/*
348 * ima_protect_xattr - protect 'security.ima'
349 *
350 * Ensure that not just anyone can modify or remove 'security.ima'.
351 */
352static int ima_protect_xattr(struct dentry *dentry, const char *xattr_name,
353 const void *xattr_value, size_t xattr_value_len)
354{
355 if (strcmp(xattr_name, XATTR_NAME_IMA) == 0) {
356 if (!capable(CAP_SYS_ADMIN))
357 return -EPERM;
358 return 1;
359 }
360 return 0;
361}
362
Mimi Zohar060bdebfb2014-03-17 23:24:18 -0400363static void ima_reset_appraise_flags(struct inode *inode, int digsig)
Mimi Zohar42c63332011-03-10 18:54:15 -0500364{
365 struct integrity_iint_cache *iint;
366
Roberto Sassua7560242014-09-12 19:35:54 +0200367 if (!(ima_policy_flag & IMA_APPRAISE) || !S_ISREG(inode->i_mode))
Mimi Zohar42c63332011-03-10 18:54:15 -0500368 return;
369
370 iint = integrity_iint_find(inode);
371 if (!iint)
372 return;
373
Dmitry Kasatkin45e24722012-09-12 20:51:32 +0300374 iint->flags &= ~IMA_DONE_MASK;
Eric Richtera4226382016-06-01 13:14:06 -0500375 iint->measured_pcrs = 0;
Mimi Zohar060bdebfb2014-03-17 23:24:18 -0400376 if (digsig)
377 iint->flags |= IMA_DIGSIG;
Mimi Zohar42c63332011-03-10 18:54:15 -0500378 return;
379}
380
381int ima_inode_setxattr(struct dentry *dentry, const char *xattr_name,
382 const void *xattr_value, size_t xattr_value_len)
383{
Mimi Zohar060bdebfb2014-03-17 23:24:18 -0400384 const struct evm_ima_xattr_data *xvalue = xattr_value;
Mimi Zohar42c63332011-03-10 18:54:15 -0500385 int result;
386
387 result = ima_protect_xattr(dentry, xattr_name, xattr_value,
388 xattr_value_len);
389 if (result == 1) {
Dmitry Kasatkina48fda92014-10-28 13:31:22 +0200390 if (!xattr_value_len || (xvalue->type >= IMA_XATTR_LAST))
391 return -EINVAL;
Mimi Zoharf5acb3d2016-11-02 09:14:16 -0400392 ima_reset_appraise_flags(d_backing_inode(dentry),
393 (xvalue->type == EVM_IMA_XATTR_DIGSIG) ? 1 : 0);
Mimi Zohar42c63332011-03-10 18:54:15 -0500394 result = 0;
395 }
396 return result;
397}
398
399int ima_inode_removexattr(struct dentry *dentry, const char *xattr_name)
400{
401 int result;
402
403 result = ima_protect_xattr(dentry, xattr_name, NULL, 0);
404 if (result == 1) {
David Howellsc6f493d2015-03-17 22:26:22 +0000405 ima_reset_appraise_flags(d_backing_inode(dentry), 0);
Mimi Zohar42c63332011-03-10 18:54:15 -0500406 result = 0;
407 }
408 return result;
409}