Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 1 | /* |
| 2 | * linux/fs/nfs/unlink.c |
| 3 | * |
| 4 | * nfs sillydelete handling |
| 5 | * |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 6 | */ |
| 7 | |
| 8 | #include <linux/slab.h> |
| 9 | #include <linux/string.h> |
| 10 | #include <linux/dcache.h> |
| 11 | #include <linux/sunrpc/sched.h> |
| 12 | #include <linux/sunrpc/clnt.h> |
| 13 | #include <linux/nfs_fs.h> |
Linus Torvalds | b35e704 | 2007-10-19 19:59:18 -0700 | [diff] [blame] | 14 | #include <linux/sched.h> |
| 15 | #include <linux/wait.h> |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 16 | #include <linux/namei.h> |
Jeff Layton | f7be728 | 2014-03-17 07:06:58 -0400 | [diff] [blame] | 17 | #include <linux/fsnotify.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 18 | |
Steve Dickson | ef818a2 | 2007-11-08 04:05:04 -0500 | [diff] [blame] | 19 | #include "internal.h" |
Andy Adamson | 472cfbd | 2009-04-01 09:22:24 -0400 | [diff] [blame] | 20 | #include "nfs4_fs.h" |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 21 | #include "iostat.h" |
| 22 | #include "delegation.h" |
Steve Dickson | ef818a2 | 2007-11-08 04:05:04 -0500 | [diff] [blame] | 23 | |
Trond Myklebust | 70ded20 | 2013-08-21 12:08:45 -0400 | [diff] [blame] | 24 | #include "nfstrace.h" |
| 25 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 26 | /** |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 27 | * nfs_free_unlinkdata - release data from a sillydelete operation. |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 28 | * @data: pointer to unlink structure. |
| 29 | */ |
| 30 | static void |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 31 | nfs_free_unlinkdata(struct nfs_unlinkdata *data) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 32 | { |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 33 | iput(data->dir); |
| 34 | put_rpccred(data->cred); |
| 35 | kfree(data->args.name.name); |
| 36 | kfree(data); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 37 | } |
| 38 | |
| 39 | #define NAME_ALLOC_LEN(len) ((len+16) & ~15) |
| 40 | /** |
| 41 | * nfs_copy_dname - copy dentry name to data structure |
| 42 | * @dentry: pointer to dentry |
| 43 | * @data: nfs_unlinkdata |
| 44 | */ |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 45 | static int nfs_copy_dname(struct dentry *dentry, struct nfs_unlinkdata *data) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 46 | { |
| 47 | char *str; |
| 48 | int len = dentry->d_name.len; |
| 49 | |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 50 | str = kmemdup(dentry->d_name.name, NAME_ALLOC_LEN(len), GFP_KERNEL); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 51 | if (!str) |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 52 | return -ENOMEM; |
| 53 | data->args.name.len = len; |
| 54 | data->args.name.name = str; |
| 55 | return 0; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 56 | } |
| 57 | |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 58 | static void nfs_free_dname(struct nfs_unlinkdata *data) |
| 59 | { |
| 60 | kfree(data->args.name.name); |
| 61 | data->args.name.name = NULL; |
| 62 | data->args.name.len = 0; |
| 63 | } |
| 64 | |
| 65 | static void nfs_dec_sillycount(struct inode *dir) |
| 66 | { |
| 67 | struct nfs_inode *nfsi = NFS_I(dir); |
| 68 | if (atomic_dec_return(&nfsi->silly_count) == 1) |
| 69 | wake_up(&nfsi->waitqueue); |
| 70 | } |
| 71 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 72 | /** |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 73 | * nfs_async_unlink_done - Sillydelete post-processing |
| 74 | * @task: rpc_task of the sillydelete |
| 75 | * |
| 76 | * Do the directory attribute update. |
| 77 | */ |
Trond Myklebust | 963d8fe | 2006-01-03 09:55:04 +0100 | [diff] [blame] | 78 | static void nfs_async_unlink_done(struct rpc_task *task, void *calldata) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 79 | { |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 80 | struct nfs_unlinkdata *data = calldata; |
| 81 | struct inode *dir = data->dir; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 82 | |
Trond Myklebust | 70ded20 | 2013-08-21 12:08:45 -0400 | [diff] [blame] | 83 | trace_nfs_sillyrename_unlink(data, task->tk_status); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 84 | if (!NFS_PROTO(dir)->unlink_done(task, dir)) |
Trond Myklebust | d00c5d4 | 2011-10-19 12:17:29 -0700 | [diff] [blame] | 85 | rpc_restart_call_prepare(task); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 86 | } |
| 87 | |
| 88 | /** |
| 89 | * nfs_async_unlink_release - Release the sillydelete data. |
| 90 | * @task: rpc_task of the sillydelete |
| 91 | * |
| 92 | * We need to call nfs_put_unlinkdata as a 'tk_release' task since the |
| 93 | * rpc_task would be freed too. |
| 94 | */ |
Trond Myklebust | 963d8fe | 2006-01-03 09:55:04 +0100 | [diff] [blame] | 95 | static void nfs_async_unlink_release(void *calldata) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 96 | { |
Trond Myklebust | 963d8fe | 2006-01-03 09:55:04 +0100 | [diff] [blame] | 97 | struct nfs_unlinkdata *data = calldata; |
Trond Myklebust | 744d18d | 2008-07-27 18:03:19 -0400 | [diff] [blame] | 98 | struct super_block *sb = data->dir->i_sb; |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 99 | |
| 100 | nfs_dec_sillycount(data->dir); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 101 | nfs_free_unlinkdata(data); |
Trond Myklebust | 322b2b9 | 2013-01-11 16:39:51 -0500 | [diff] [blame] | 102 | nfs_sb_deactive(sb); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 103 | } |
| 104 | |
Trond Myklebust | 1728017 | 2012-03-11 13:11:00 -0400 | [diff] [blame] | 105 | static void nfs_unlink_prepare(struct rpc_task *task, void *calldata) |
Andy Adamson | 472cfbd | 2009-04-01 09:22:24 -0400 | [diff] [blame] | 106 | { |
| 107 | struct nfs_unlinkdata *data = calldata; |
Bryan Schumaker | 34e137c | 2012-03-19 14:54:41 -0400 | [diff] [blame] | 108 | NFS_PROTO(data->dir)->unlink_rpc_prepare(task, data); |
Andy Adamson | 472cfbd | 2009-04-01 09:22:24 -0400 | [diff] [blame] | 109 | } |
Andy Adamson | 472cfbd | 2009-04-01 09:22:24 -0400 | [diff] [blame] | 110 | |
Trond Myklebust | 963d8fe | 2006-01-03 09:55:04 +0100 | [diff] [blame] | 111 | static const struct rpc_call_ops nfs_unlink_ops = { |
| 112 | .rpc_call_done = nfs_async_unlink_done, |
| 113 | .rpc_release = nfs_async_unlink_release, |
Andy Adamson | 472cfbd | 2009-04-01 09:22:24 -0400 | [diff] [blame] | 114 | .rpc_call_prepare = nfs_unlink_prepare, |
Trond Myklebust | 963d8fe | 2006-01-03 09:55:04 +0100 | [diff] [blame] | 115 | }; |
| 116 | |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 117 | static int nfs_do_call_unlink(struct dentry *parent, struct inode *dir, struct nfs_unlinkdata *data) |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 118 | { |
Trond Myklebust | 5138fde | 2007-07-14 15:40:01 -0400 | [diff] [blame] | 119 | struct rpc_message msg = { |
| 120 | .rpc_argp = &data->args, |
| 121 | .rpc_resp = &data->res, |
| 122 | .rpc_cred = data->cred, |
| 123 | }; |
Trond Myklebust | c970aa8 | 2007-07-14 15:39:59 -0400 | [diff] [blame] | 124 | struct rpc_task_setup task_setup_data = { |
Trond Myklebust | 5138fde | 2007-07-14 15:40:01 -0400 | [diff] [blame] | 125 | .rpc_message = &msg, |
Trond Myklebust | c970aa8 | 2007-07-14 15:39:59 -0400 | [diff] [blame] | 126 | .callback_ops = &nfs_unlink_ops, |
| 127 | .callback_data = data, |
Trond Myklebust | 1daef0a | 2008-07-27 18:19:01 -0400 | [diff] [blame] | 128 | .workqueue = nfsiod_workqueue, |
Trond Myklebust | c970aa8 | 2007-07-14 15:39:59 -0400 | [diff] [blame] | 129 | .flags = RPC_TASK_ASYNC, |
| 130 | }; |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 131 | struct rpc_task *task; |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 132 | struct dentry *alias; |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 133 | |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 134 | alias = d_lookup(parent, &data->args.name); |
| 135 | if (alias != NULL) { |
Jeff Layton | 73ca100 | 2011-07-18 11:26:30 -0400 | [diff] [blame] | 136 | int ret; |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 137 | void *devname_garbage = NULL; |
Trond Myklebust | 609005c | 2008-01-28 19:42:59 -0500 | [diff] [blame] | 138 | |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 139 | /* |
| 140 | * Hey, we raced with lookup... See if we need to transfer |
| 141 | * the sillyrename information to the aliased dentry. |
| 142 | */ |
| 143 | nfs_free_dname(data); |
Jeff Layton | 73ca100 | 2011-07-18 11:26:30 -0400 | [diff] [blame] | 144 | ret = nfs_copy_dname(alias, data); |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 145 | spin_lock(&alias->d_lock); |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 146 | if (ret == 0 && d_really_is_positive(alias) && |
Trond Myklebust | 609005c | 2008-01-28 19:42:59 -0500 | [diff] [blame] | 147 | !(alias->d_flags & DCACHE_NFSFS_RENAMED)) { |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 148 | devname_garbage = alias->d_fsdata; |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 149 | alias->d_fsdata = data; |
Trond Myklebust | fccca7f | 2008-01-26 17:37:47 -0500 | [diff] [blame] | 150 | alias->d_flags |= DCACHE_NFSFS_RENAMED; |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 151 | ret = 1; |
Jeff Layton | 73ca100 | 2011-07-18 11:26:30 -0400 | [diff] [blame] | 152 | } else |
| 153 | ret = 0; |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 154 | spin_unlock(&alias->d_lock); |
| 155 | nfs_dec_sillycount(dir); |
| 156 | dput(alias); |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 157 | /* |
| 158 | * If we'd displaced old cached devname, free it. At that |
| 159 | * point dentry is definitely not a root, so we won't need |
| 160 | * that anymore. |
| 161 | */ |
Jeff Layton | 73ca100 | 2011-07-18 11:26:30 -0400 | [diff] [blame] | 162 | kfree(devname_garbage); |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 163 | return ret; |
| 164 | } |
| 165 | data->dir = igrab(dir); |
| 166 | if (!data->dir) { |
| 167 | nfs_dec_sillycount(dir); |
| 168 | return 0; |
| 169 | } |
Trond Myklebust | 1daef0a | 2008-07-27 18:19:01 -0400 | [diff] [blame] | 170 | nfs_sb_active(dir->i_sb); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 171 | data->args.fh = NFS_FH(dir); |
Trond Myklebust | d346890 | 2010-04-16 16:22:50 -0400 | [diff] [blame] | 172 | nfs_fattr_init(data->res.dir_attr); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 173 | |
Trond Myklebust | 5138fde | 2007-07-14 15:40:01 -0400 | [diff] [blame] | 174 | NFS_PROTO(dir)->unlink_setup(&msg, dir); |
Trond Myklebust | c970aa8 | 2007-07-14 15:39:59 -0400 | [diff] [blame] | 175 | |
Trond Myklebust | 5138fde | 2007-07-14 15:40:01 -0400 | [diff] [blame] | 176 | task_setup_data.rpc_client = NFS_CLIENT(dir); |
Trond Myklebust | c970aa8 | 2007-07-14 15:39:59 -0400 | [diff] [blame] | 177 | task = rpc_run_task(&task_setup_data); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 178 | if (!IS_ERR(task)) |
Trond Myklebust | bf294b4 | 2011-02-21 11:05:41 -0800 | [diff] [blame] | 179 | rpc_put_task_async(task); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 180 | return 1; |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 181 | } |
| 182 | |
| 183 | static int nfs_call_unlink(struct dentry *dentry, struct nfs_unlinkdata *data) |
| 184 | { |
| 185 | struct dentry *parent; |
| 186 | struct inode *dir; |
| 187 | int ret = 0; |
| 188 | |
| 189 | |
| 190 | parent = dget_parent(dentry); |
| 191 | if (parent == NULL) |
| 192 | goto out_free; |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 193 | dir = d_inode(parent); |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 194 | /* Non-exclusive lock protects against concurrent lookup() calls */ |
| 195 | spin_lock(&dir->i_lock); |
| 196 | if (atomic_inc_not_zero(&NFS_I(dir)->silly_count) == 0) { |
| 197 | /* Deferred delete */ |
| 198 | hlist_add_head(&data->list, &NFS_I(dir)->silly_list); |
| 199 | spin_unlock(&dir->i_lock); |
| 200 | ret = 1; |
| 201 | goto out_dput; |
| 202 | } |
| 203 | spin_unlock(&dir->i_lock); |
| 204 | ret = nfs_do_call_unlink(parent, dir, data); |
| 205 | out_dput: |
| 206 | dput(parent); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 207 | out_free: |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 208 | return ret; |
| 209 | } |
| 210 | |
Trond Myklebust | ba6c059 | 2013-08-30 12:24:25 -0400 | [diff] [blame] | 211 | void nfs_wait_on_sillyrename(struct dentry *dentry) |
| 212 | { |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 213 | struct nfs_inode *nfsi = NFS_I(d_inode(dentry)); |
Trond Myklebust | ba6c059 | 2013-08-30 12:24:25 -0400 | [diff] [blame] | 214 | |
| 215 | wait_event(nfsi->waitqueue, atomic_read(&nfsi->silly_count) <= 1); |
| 216 | } |
| 217 | |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 218 | void nfs_block_sillyrename(struct dentry *dentry) |
| 219 | { |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 220 | struct nfs_inode *nfsi = NFS_I(d_inode(dentry)); |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 221 | |
| 222 | wait_event(nfsi->waitqueue, atomic_cmpxchg(&nfsi->silly_count, 1, 0) == 1); |
| 223 | } |
| 224 | |
| 225 | void nfs_unblock_sillyrename(struct dentry *dentry) |
| 226 | { |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 227 | struct inode *dir = d_inode(dentry); |
Trond Myklebust | 565277f | 2007-10-15 18:17:53 -0400 | [diff] [blame] | 228 | struct nfs_inode *nfsi = NFS_I(dir); |
| 229 | struct nfs_unlinkdata *data; |
| 230 | |
| 231 | atomic_inc(&nfsi->silly_count); |
| 232 | spin_lock(&dir->i_lock); |
| 233 | while (!hlist_empty(&nfsi->silly_list)) { |
| 234 | if (!atomic_inc_not_zero(&nfsi->silly_count)) |
| 235 | break; |
| 236 | data = hlist_entry(nfsi->silly_list.first, struct nfs_unlinkdata, list); |
| 237 | hlist_del(&data->list); |
| 238 | spin_unlock(&dir->i_lock); |
| 239 | if (nfs_do_call_unlink(dentry, dir, data) == 0) |
| 240 | nfs_free_unlinkdata(data); |
| 241 | spin_lock(&dir->i_lock); |
| 242 | } |
| 243 | spin_unlock(&dir->i_lock); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 244 | } |
| 245 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 246 | /** |
| 247 | * nfs_async_unlink - asynchronous unlinking of a file |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 248 | * @dir: parent directory of dentry |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 249 | * @dentry: dentry to unlink |
| 250 | */ |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 251 | static int |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 252 | nfs_async_unlink(struct inode *dir, struct dentry *dentry) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 253 | { |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 254 | struct nfs_unlinkdata *data; |
| 255 | int status = -ENOMEM; |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 256 | void *devname_garbage = NULL; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 257 | |
Eric Sesterhenn | bd64754 | 2006-03-20 13:44:10 -0500 | [diff] [blame] | 258 | data = kzalloc(sizeof(*data), GFP_KERNEL); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 259 | if (data == NULL) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 260 | goto out; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 261 | |
Trond Myklebust | 98a8e32 | 2008-03-12 12:25:28 -0400 | [diff] [blame] | 262 | data->cred = rpc_lookup_cred(); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 263 | if (IS_ERR(data->cred)) { |
| 264 | status = PTR_ERR(data->cred); |
| 265 | goto out_free; |
| 266 | } |
Trond Myklebust | d346890 | 2010-04-16 16:22:50 -0400 | [diff] [blame] | 267 | data->res.dir_attr = &data->dir_attr; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 268 | |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 269 | status = -EBUSY; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 270 | spin_lock(&dentry->d_lock); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 271 | if (dentry->d_flags & DCACHE_NFSFS_RENAMED) |
| 272 | goto out_unlock; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 273 | dentry->d_flags |= DCACHE_NFSFS_RENAMED; |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 274 | devname_garbage = dentry->d_fsdata; |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 275 | dentry->d_fsdata = data; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 276 | spin_unlock(&dentry->d_lock); |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 277 | /* |
| 278 | * If we'd displaced old cached devname, free it. At that |
| 279 | * point dentry is definitely not a root, so we won't need |
| 280 | * that anymore. |
| 281 | */ |
Tim Gardner | 96aa154 | 2013-02-12 13:03:42 -0700 | [diff] [blame] | 282 | kfree(devname_garbage); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 283 | return 0; |
| 284 | out_unlock: |
| 285 | spin_unlock(&dentry->d_lock); |
| 286 | put_rpccred(data->cred); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 287 | out_free: |
| 288 | kfree(data); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 289 | out: |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 290 | return status; |
| 291 | } |
| 292 | |
| 293 | /** |
| 294 | * nfs_complete_unlink - Initialize completion of the sillydelete |
| 295 | * @dentry: dentry to delete |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 296 | * @inode: inode |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 297 | * |
| 298 | * Since we're most likely to be called by dentry_iput(), we |
| 299 | * only use the dentry to find the sillydelete. We then copy the name |
| 300 | * into the qstr. |
| 301 | */ |
| 302 | void |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 303 | nfs_complete_unlink(struct dentry *dentry, struct inode *inode) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 304 | { |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 305 | struct nfs_unlinkdata *data = NULL; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 306 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 307 | spin_lock(&dentry->d_lock); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 308 | if (dentry->d_flags & DCACHE_NFSFS_RENAMED) { |
| 309 | dentry->d_flags &= ~DCACHE_NFSFS_RENAMED; |
| 310 | data = dentry->d_fsdata; |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 311 | dentry->d_fsdata = NULL; |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 312 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 313 | spin_unlock(&dentry->d_lock); |
Trond Myklebust | e4eff1a | 2007-07-14 15:39:58 -0400 | [diff] [blame] | 314 | |
| 315 | if (data != NULL && (NFS_STALE(inode) || !nfs_call_unlink(dentry, data))) |
| 316 | nfs_free_unlinkdata(data); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 317 | } |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 318 | |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 319 | /* Cancel a queued async unlink. Called when a sillyrename run fails. */ |
| 320 | static void |
| 321 | nfs_cancel_async_unlink(struct dentry *dentry) |
| 322 | { |
| 323 | spin_lock(&dentry->d_lock); |
| 324 | if (dentry->d_flags & DCACHE_NFSFS_RENAMED) { |
| 325 | struct nfs_unlinkdata *data = dentry->d_fsdata; |
| 326 | |
| 327 | dentry->d_flags &= ~DCACHE_NFSFS_RENAMED; |
Al Viro | b1942c5 | 2011-03-16 05:44:14 -0400 | [diff] [blame] | 328 | dentry->d_fsdata = NULL; |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 329 | spin_unlock(&dentry->d_lock); |
| 330 | nfs_free_unlinkdata(data); |
| 331 | return; |
| 332 | } |
| 333 | spin_unlock(&dentry->d_lock); |
| 334 | } |
| 335 | |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 336 | /** |
| 337 | * nfs_async_rename_done - Sillyrename post-processing |
| 338 | * @task: rpc_task of the sillyrename |
| 339 | * @calldata: nfs_renamedata for the sillyrename |
| 340 | * |
| 341 | * Do the directory attribute updates and the d_move |
| 342 | */ |
| 343 | static void nfs_async_rename_done(struct rpc_task *task, void *calldata) |
| 344 | { |
| 345 | struct nfs_renamedata *data = calldata; |
| 346 | struct inode *old_dir = data->old_dir; |
| 347 | struct inode *new_dir = data->new_dir; |
Jeff Layton | 73ca100 | 2011-07-18 11:26:30 -0400 | [diff] [blame] | 348 | struct dentry *old_dentry = data->old_dentry; |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 349 | |
Trond Myklebust | 70ded20 | 2013-08-21 12:08:45 -0400 | [diff] [blame] | 350 | trace_nfs_sillyrename_rename(old_dir, old_dentry, |
| 351 | new_dir, data->new_dentry, task->tk_status); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 352 | if (!NFS_PROTO(old_dir)->rename_done(task, old_dir, new_dir)) { |
Trond Myklebust | d00c5d4 | 2011-10-19 12:17:29 -0700 | [diff] [blame] | 353 | rpc_restart_call_prepare(task); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 354 | return; |
| 355 | } |
| 356 | |
Jeff Layton | 96f9d8c | 2014-03-17 07:06:54 -0400 | [diff] [blame] | 357 | if (data->complete) |
| 358 | data->complete(task, data); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 359 | } |
| 360 | |
| 361 | /** |
| 362 | * nfs_async_rename_release - Release the sillyrename data. |
| 363 | * @calldata: the struct nfs_renamedata to be released |
| 364 | */ |
| 365 | static void nfs_async_rename_release(void *calldata) |
| 366 | { |
| 367 | struct nfs_renamedata *data = calldata; |
| 368 | struct super_block *sb = data->old_dir->i_sb; |
| 369 | |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 370 | if (d_really_is_positive(data->old_dentry)) |
| 371 | nfs_mark_for_revalidate(d_inode(data->old_dentry)); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 372 | |
| 373 | dput(data->old_dentry); |
| 374 | dput(data->new_dentry); |
| 375 | iput(data->old_dir); |
| 376 | iput(data->new_dir); |
| 377 | nfs_sb_deactive(sb); |
| 378 | put_rpccred(data->cred); |
| 379 | kfree(data); |
| 380 | } |
| 381 | |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 382 | static void nfs_rename_prepare(struct rpc_task *task, void *calldata) |
| 383 | { |
| 384 | struct nfs_renamedata *data = calldata; |
Bryan Schumaker | c6bfa1a | 2012-03-19 14:54:42 -0400 | [diff] [blame] | 385 | NFS_PROTO(data->old_dir)->rename_rpc_prepare(task, data); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 386 | } |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 387 | |
| 388 | static const struct rpc_call_ops nfs_rename_ops = { |
| 389 | .rpc_call_done = nfs_async_rename_done, |
| 390 | .rpc_release = nfs_async_rename_release, |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 391 | .rpc_call_prepare = nfs_rename_prepare, |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 392 | }; |
| 393 | |
| 394 | /** |
| 395 | * nfs_async_rename - perform an asynchronous rename operation |
| 396 | * @old_dir: directory that currently holds the dentry to be renamed |
| 397 | * @new_dir: target directory for the rename |
| 398 | * @old_dentry: original dentry to be renamed |
| 399 | * @new_dentry: dentry to which the old_dentry should be renamed |
| 400 | * |
| 401 | * It's expected that valid references to the dentries and inodes are held |
| 402 | */ |
Jeff Layton | 0e862a4 | 2014-03-17 07:06:55 -0400 | [diff] [blame] | 403 | struct rpc_task * |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 404 | nfs_async_rename(struct inode *old_dir, struct inode *new_dir, |
Jeff Layton | 96f9d8c | 2014-03-17 07:06:54 -0400 | [diff] [blame] | 405 | struct dentry *old_dentry, struct dentry *new_dentry, |
| 406 | void (*complete)(struct rpc_task *, struct nfs_renamedata *)) |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 407 | { |
| 408 | struct nfs_renamedata *data; |
| 409 | struct rpc_message msg = { }; |
| 410 | struct rpc_task_setup task_setup_data = { |
| 411 | .rpc_message = &msg, |
| 412 | .callback_ops = &nfs_rename_ops, |
| 413 | .workqueue = nfsiod_workqueue, |
| 414 | .rpc_client = NFS_CLIENT(old_dir), |
| 415 | .flags = RPC_TASK_ASYNC, |
| 416 | }; |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 417 | |
Benny Halevy | dfb4f309 | 2010-09-24 09:17:01 -0400 | [diff] [blame] | 418 | data = kzalloc(sizeof(*data), GFP_KERNEL); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 419 | if (data == NULL) |
| 420 | return ERR_PTR(-ENOMEM); |
Trond Myklebust | 1174dd1 | 2010-12-21 10:52:24 -0500 | [diff] [blame] | 421 | task_setup_data.callback_data = data; |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 422 | |
| 423 | data->cred = rpc_lookup_cred(); |
| 424 | if (IS_ERR(data->cred)) { |
Trond Myklebust | f7732d6 | 2010-09-21 16:52:40 -0400 | [diff] [blame] | 425 | struct rpc_task *task = ERR_CAST(data->cred); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 426 | kfree(data); |
| 427 | return task; |
| 428 | } |
| 429 | |
| 430 | msg.rpc_argp = &data->args; |
| 431 | msg.rpc_resp = &data->res; |
| 432 | msg.rpc_cred = data->cred; |
| 433 | |
| 434 | /* set up nfs_renamedata */ |
| 435 | data->old_dir = old_dir; |
Al Viro | a4118ee | 2010-10-27 11:00:08 -0400 | [diff] [blame] | 436 | ihold(old_dir); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 437 | data->new_dir = new_dir; |
Al Viro | a4118ee | 2010-10-27 11:00:08 -0400 | [diff] [blame] | 438 | ihold(new_dir); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 439 | data->old_dentry = dget(old_dentry); |
| 440 | data->new_dentry = dget(new_dentry); |
| 441 | nfs_fattr_init(&data->old_fattr); |
| 442 | nfs_fattr_init(&data->new_fattr); |
Jeff Layton | 96f9d8c | 2014-03-17 07:06:54 -0400 | [diff] [blame] | 443 | data->complete = complete; |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 444 | |
| 445 | /* set up nfs_renameargs */ |
| 446 | data->args.old_dir = NFS_FH(old_dir); |
| 447 | data->args.old_name = &old_dentry->d_name; |
| 448 | data->args.new_dir = NFS_FH(new_dir); |
| 449 | data->args.new_name = &new_dentry->d_name; |
| 450 | |
| 451 | /* set up nfs_renameres */ |
| 452 | data->res.old_fattr = &data->old_fattr; |
| 453 | data->res.new_fattr = &data->new_fattr; |
| 454 | |
| 455 | nfs_sb_active(old_dir->i_sb); |
| 456 | |
| 457 | NFS_PROTO(data->old_dir)->rename_setup(&msg, old_dir); |
| 458 | |
Trond Myklebust | f7732d6 | 2010-09-21 16:52:40 -0400 | [diff] [blame] | 459 | return rpc_run_task(&task_setup_data); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 460 | } |
| 461 | |
Jeff Layton | 96f9d8c | 2014-03-17 07:06:54 -0400 | [diff] [blame] | 462 | /* |
| 463 | * Perform tasks needed when a sillyrename is done such as cancelling the |
| 464 | * queued async unlink if it failed. |
| 465 | */ |
| 466 | static void |
| 467 | nfs_complete_sillyrename(struct rpc_task *task, struct nfs_renamedata *data) |
| 468 | { |
Jeff Layton | f7be728 | 2014-03-17 07:06:58 -0400 | [diff] [blame] | 469 | struct dentry *dentry = data->old_dentry; |
| 470 | |
| 471 | if (task->tk_status != 0) { |
| 472 | nfs_cancel_async_unlink(dentry); |
| 473 | return; |
| 474 | } |
| 475 | |
| 476 | /* |
| 477 | * vfs_unlink and the like do not issue this when a file is |
| 478 | * sillyrenamed, so do it here. |
| 479 | */ |
| 480 | fsnotify_nameremove(dentry, 0); |
Jeff Layton | 96f9d8c | 2014-03-17 07:06:54 -0400 | [diff] [blame] | 481 | } |
| 482 | |
Trond Myklebust | c2dd137 | 2013-08-21 19:54:08 -0400 | [diff] [blame] | 483 | #define SILLYNAME_PREFIX ".nfs" |
| 484 | #define SILLYNAME_PREFIX_LEN ((unsigned)sizeof(SILLYNAME_PREFIX) - 1) |
| 485 | #define SILLYNAME_FILEID_LEN ((unsigned)sizeof(u64) << 1) |
| 486 | #define SILLYNAME_COUNTER_LEN ((unsigned)sizeof(unsigned int) << 1) |
| 487 | #define SILLYNAME_LEN (SILLYNAME_PREFIX_LEN + \ |
| 488 | SILLYNAME_FILEID_LEN + \ |
| 489 | SILLYNAME_COUNTER_LEN) |
| 490 | |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 491 | /** |
| 492 | * nfs_sillyrename - Perform a silly-rename of a dentry |
| 493 | * @dir: inode of directory that contains dentry |
| 494 | * @dentry: dentry to be sillyrenamed |
| 495 | * |
| 496 | * NFSv2/3 is stateless and the server doesn't know when the client is |
| 497 | * holding a file open. To prevent application problems when a file is |
| 498 | * unlinked while it's still open, the client performs a "silly-rename". |
| 499 | * That is, it renames the file to a hidden file in the same directory, |
| 500 | * and only performs the unlink once the last reference to it is put. |
| 501 | * |
| 502 | * The final cleanup is done during dentry_iput. |
J. Bruce Fields | 674e405 | 2011-07-15 19:09:08 -0400 | [diff] [blame] | 503 | * |
| 504 | * (Note: NFSv4 is stateful, and has opens, so in theory an NFSv4 server |
| 505 | * could take responsibility for keeping open files referenced. The server |
| 506 | * would also need to ensure that opened-but-deleted files were kept over |
| 507 | * reboots. However, we may not assume a server does so. (RFC 5661 |
| 508 | * does provide an OPEN4_RESULT_PRESERVE_UNLINKED flag that a server can |
| 509 | * use to advertise that it does this; some day we may take advantage of |
| 510 | * it.)) |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 511 | */ |
| 512 | int |
| 513 | nfs_sillyrename(struct inode *dir, struct dentry *dentry) |
| 514 | { |
| 515 | static unsigned int sillycounter; |
Trond Myklebust | c2dd137 | 2013-08-21 19:54:08 -0400 | [diff] [blame] | 516 | unsigned char silly[SILLYNAME_LEN + 1]; |
| 517 | unsigned long long fileid; |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 518 | struct dentry *sdentry; |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 519 | struct rpc_task *task; |
Geyslan G. Bem | 4f5829d | 2013-10-11 17:15:54 -0300 | [diff] [blame] | 520 | int error = -EBUSY; |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 521 | |
Al Viro | 6de1472 | 2013-09-16 10:53:17 -0400 | [diff] [blame] | 522 | dfprintk(VFS, "NFS: silly-rename(%pd2, ct=%d)\n", |
| 523 | dentry, d_count(dentry)); |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 524 | nfs_inc_stats(dir, NFSIOS_SILLYRENAME); |
| 525 | |
| 526 | /* |
| 527 | * We don't allow a dentry to be silly-renamed twice. |
| 528 | */ |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 529 | if (dentry->d_flags & DCACHE_NFSFS_RENAMED) |
| 530 | goto out; |
| 531 | |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 532 | fileid = NFS_FILEID(d_inode(dentry)); |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 533 | |
| 534 | /* Return delegation in anticipation of the rename */ |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 535 | NFS_PROTO(d_inode(dentry))->return_delegation(d_inode(dentry)); |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 536 | |
| 537 | sdentry = NULL; |
| 538 | do { |
Trond Myklebust | c2dd137 | 2013-08-21 19:54:08 -0400 | [diff] [blame] | 539 | int slen; |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 540 | dput(sdentry); |
| 541 | sillycounter++; |
Trond Myklebust | c2dd137 | 2013-08-21 19:54:08 -0400 | [diff] [blame] | 542 | slen = scnprintf(silly, sizeof(silly), |
| 543 | SILLYNAME_PREFIX "%0*llx%0*x", |
| 544 | SILLYNAME_FILEID_LEN, fileid, |
| 545 | SILLYNAME_COUNTER_LEN, sillycounter); |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 546 | |
Al Viro | 6de1472 | 2013-09-16 10:53:17 -0400 | [diff] [blame] | 547 | dfprintk(VFS, "NFS: trying to rename %pd to %s\n", |
| 548 | dentry, silly); |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 549 | |
| 550 | sdentry = lookup_one_len(silly, dentry->d_parent, slen); |
| 551 | /* |
| 552 | * N.B. Better to return EBUSY here ... it could be |
| 553 | * dangerous to delete the file while it's in use. |
| 554 | */ |
| 555 | if (IS_ERR(sdentry)) |
| 556 | goto out; |
David Howells | 2b0143b | 2015-03-17 22:25:59 +0000 | [diff] [blame^] | 557 | } while (d_inode(sdentry) != NULL); /* need negative lookup */ |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 558 | |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 559 | /* queue unlink first. Can't do this from rpc_release as it |
| 560 | * has to allocate memory |
| 561 | */ |
| 562 | error = nfs_async_unlink(dir, dentry); |
| 563 | if (error) |
| 564 | goto out_dput; |
| 565 | |
Jeff Layton | 73ca100 | 2011-07-18 11:26:30 -0400 | [diff] [blame] | 566 | /* populate unlinkdata with the right dname */ |
| 567 | error = nfs_copy_dname(sdentry, |
| 568 | (struct nfs_unlinkdata *)dentry->d_fsdata); |
| 569 | if (error) { |
| 570 | nfs_cancel_async_unlink(dentry); |
| 571 | goto out_dput; |
| 572 | } |
| 573 | |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 574 | /* run the rename task, undo unlink if it fails */ |
Jeff Layton | 96f9d8c | 2014-03-17 07:06:54 -0400 | [diff] [blame] | 575 | task = nfs_async_rename(dir, dir, dentry, sdentry, |
| 576 | nfs_complete_sillyrename); |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 577 | if (IS_ERR(task)) { |
| 578 | error = -EBUSY; |
| 579 | nfs_cancel_async_unlink(dentry); |
| 580 | goto out_dput; |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 581 | } |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 582 | |
| 583 | /* wait for the RPC task to complete, unless a SIGKILL intervenes */ |
| 584 | error = rpc_wait_for_completion_task(task); |
| 585 | if (error == 0) |
| 586 | error = task->tk_status; |
Trond Myklebust | 5a7a613 | 2013-02-22 12:53:43 -0500 | [diff] [blame] | 587 | switch (error) { |
| 588 | case 0: |
| 589 | /* The rename succeeded */ |
| 590 | nfs_set_verifier(dentry, nfs_save_change_attribute(dir)); |
| 591 | d_move(dentry, sdentry); |
| 592 | break; |
| 593 | case -ERESTARTSYS: |
| 594 | /* The result of the rename is unknown. Play it safe by |
| 595 | * forcing a new lookup */ |
| 596 | d_drop(dentry); |
| 597 | d_drop(sdentry); |
| 598 | } |
Jeff Layton | d3d4152 | 2010-09-17 17:31:57 -0400 | [diff] [blame] | 599 | rpc_put_task(task); |
| 600 | out_dput: |
Jeff Layton | 779c517 | 2010-09-17 17:31:30 -0400 | [diff] [blame] | 601 | dput(sdentry); |
| 602 | out: |
| 603 | return error; |
| 604 | } |