blob: adab71b170174271b633af5ff18e5f857375459f [file] [log] [blame]
Rob Clarkbb5c2d92012-01-16 12:51:16 -06001/*
Rob Clark8bb0daf2013-02-11 12:43:09 -05002 * drivers/gpu/drm/omapdrm/omap_plane.c
Rob Clarkbb5c2d92012-01-16 12:51:16 -06003 *
4 * Copyright (C) 2011 Texas Instruments
5 * Author: Rob Clark <rob.clark@linaro.org>
6 *
7 * This program is free software; you can redistribute it and/or modify it
8 * under the terms of the GNU General Public License version 2 as published by
9 * the Free Software Foundation.
10 *
11 * This program is distributed in the hope that it will be useful, but WITHOUT
12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
14 * more details.
15 *
16 * You should have received a copy of the GNU General Public License along with
17 * this program. If not, see <http://www.gnu.org/licenses/>.
18 */
19
Tomi Valkeinenc423bc82015-06-16 14:54:51 +030020#include <drm/drm_atomic.h>
Laurent Pinchart69a12262015-03-05 21:38:16 +020021#include <drm/drm_atomic_helper.h>
Laurent Pinchartde8e4102015-03-05 13:39:56 +020022#include <drm/drm_plane_helper.h>
Laurent Pinchart69a12262015-03-05 21:38:16 +020023
Rob Clark3c810c62012-08-15 15:18:01 -050024#include "omap_dmm_tiler.h"
Laurent Pinchart2d278f52015-03-05 21:31:37 +020025#include "omap_drv.h"
Rob Clarkbb5c2d92012-01-16 12:51:16 -060026
27/* some hackery because omapdss has an 'enum omap_plane' (which would be
28 * better named omap_plane_id).. and compiler seems unhappy about having
29 * both a 'struct omap_plane' and 'enum omap_plane'
30 */
31#define omap_plane _omap_plane
32
33/*
34 * plane funcs
35 */
36
37#define to_omap_plane(x) container_of(x, struct omap_plane, base)
38
39struct omap_plane {
40 struct drm_plane base;
Rob Clarkf5f94542012-12-04 13:59:12 -060041 int id; /* TODO rename omap_plane -> omap_plane_id in omapdss so I can use the enum */
42 const char *name;
Rob Clarkbb5c2d92012-01-16 12:51:16 -060043
Rob Clarka890e662012-03-05 10:48:31 -060044 uint32_t nformats;
45 uint32_t formats[32];
Rob Clarkb33f34d2012-03-05 10:48:35 -060046
Rob Clarkf5f94542012-12-04 13:59:12 -060047 struct omap_drm_irq error_irq;
Rob Clarka890e662012-03-05 10:48:31 -060048};
Rob Clarkbb5c2d92012-01-16 12:51:16 -060049
Laurent Pinchartafc34932015-03-06 18:35:16 +020050struct omap_plane_state {
51 struct drm_plane_state base;
52
53 unsigned int zorder;
54};
55
56static inline struct omap_plane_state *
57to_omap_plane_state(struct drm_plane_state *state)
Rob Clarkbb5c2d92012-01-16 12:51:16 -060058{
Laurent Pinchartafc34932015-03-06 18:35:16 +020059 return container_of(state, struct omap_plane_state, base);
60}
61
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030062static int omap_plane_prepare_fb(struct drm_plane *plane,
Chris Wilson18320402016-08-18 19:00:16 +010063 struct drm_plane_state *new_state)
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030064{
Maarten Lankhorst844f9112015-09-02 10:42:40 +020065 if (!new_state->fb)
66 return 0;
67
68 return omap_framebuffer_pin(new_state->fb);
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030069}
70
71static void omap_plane_cleanup_fb(struct drm_plane *plane,
Chris Wilson18320402016-08-18 19:00:16 +010072 struct drm_plane_state *old_state)
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030073{
Maarten Lankhorst844f9112015-09-02 10:42:40 +020074 if (old_state->fb)
75 omap_framebuffer_unpin(old_state->fb);
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030076}
77
78static void omap_plane_atomic_update(struct drm_plane *plane,
79 struct drm_plane_state *old_state)
Laurent Pinchartafc34932015-03-06 18:35:16 +020080{
Laurent Pinchartedc72552015-03-06 19:18:56 +020081 struct omap_plane *omap_plane = to_omap_plane(plane);
82 struct drm_plane_state *state = plane->state;
Laurent Pinchartafc34932015-03-06 18:35:16 +020083 struct omap_plane_state *omap_state = to_omap_plane_state(state);
Laurent Pinchartfb730c92015-03-06 19:00:18 +020084 struct omap_overlay_info info;
85 struct omap_drm_window win;
Rob Clark9a0774e2012-01-16 12:51:17 -060086 int ret;
Rob Clarkbb5c2d92012-01-16 12:51:16 -060087
Laurent Pinchartedc72552015-03-06 19:18:56 +020088 DBG("%s, crtc=%p fb=%p", omap_plane->name, state->crtc, state->fb);
Rob Clarkf5f94542012-12-04 13:59:12 -060089
Laurent Pinchartfb730c92015-03-06 19:00:18 +020090 memset(&info, 0, sizeof(info));
91 info.rotation_type = OMAP_DSS_ROT_DMA;
92 info.rotation = OMAP_DSS_ROT_0;
93 info.global_alpha = 0xff;
94 info.mirror = 0;
95 info.zorder = omap_state->zorder;
96
97 memset(&win, 0, sizeof(win));
98 win.rotation = state->rotation;
99 win.crtc_x = state->crtc_x;
100 win.crtc_y = state->crtc_y;
101 win.crtc_w = state->crtc_w;
102 win.crtc_h = state->crtc_h;
103
104 /*
105 * src values are in Q16 fixed point, convert to integer.
106 * omap_framebuffer_update_scanout() takes adjusted src.
107 */
108 win.src_x = state->src_x >> 16;
109 win.src_y = state->src_y >> 16;
110
Ville Syrjäläbd2ef252016-09-26 19:30:46 +0300111 if (drm_rotation_90_or_270(state->rotation)) {
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200112 win.src_w = state->src_h >> 16;
113 win.src_h = state->src_w >> 16;
Ville Syrjäläbd2ef252016-09-26 19:30:46 +0300114 } else {
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200115 win.src_w = state->src_w >> 16;
116 win.src_h = state->src_h >> 16;
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200117 }
Laurent Pinchartafc34932015-03-06 18:35:16 +0200118
Rob Clarkf5f94542012-12-04 13:59:12 -0600119 /* update scanout: */
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200120 omap_framebuffer_update_scanout(state->fb, &win, &info);
Rob Clark9a0774e2012-01-16 12:51:17 -0600121
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200122 DBG("%dx%d -> %dx%d (%d)", info.width, info.height,
123 info.out_width, info.out_height,
124 info.screen_width);
125 DBG("%d,%d %pad %pad", info.pos_x, info.pos_y,
126 &info.paddr, &info.p_uv_addr);
Rob Clarkf5f94542012-12-04 13:59:12 -0600127
Laurent Pincharta42133a2015-01-17 19:09:26 +0200128 dispc_ovl_set_channel_out(omap_plane->id,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200129 omap_crtc_channel(state->crtc));
Tomi Valkeinen2dd38872014-10-03 15:14:08 +0000130
Rob Clarkf5f94542012-12-04 13:59:12 -0600131 /* and finally, update omapdss: */
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200132 ret = dispc_ovl_setup(omap_plane->id, &info, false,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200133 omap_crtc_timings(state->crtc), false);
Tomi Valkeinen794a65f2015-05-29 11:06:07 +0300134 if (WARN_ON(ret)) {
135 dispc_ovl_enable(omap_plane->id, false);
Tomi Valkeinend9157df2015-05-29 11:03:15 +0300136 return;
Tomi Valkeinen794a65f2015-05-29 11:06:07 +0300137 }
Rob Clarkf5f94542012-12-04 13:59:12 -0600138
139 dispc_ovl_enable(omap_plane->id, true);
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200140}
141
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200142static void omap_plane_atomic_disable(struct drm_plane *plane,
143 struct drm_plane_state *old_state)
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600144{
Laurent Pinchartafc34932015-03-06 18:35:16 +0200145 struct omap_plane_state *omap_state = to_omap_plane_state(plane->state);
Rob Clark3c810c62012-08-15 15:18:01 -0500146 struct omap_plane *omap_plane = to_omap_plane(plane);
Laurent Pinchart2debab92015-01-12 22:38:16 +0200147
Joonas Lahtinen31ad61e2016-07-29 08:50:05 +0300148 plane->state->rotation = DRM_ROTATE_0;
Laurent Pinchartafc34932015-03-06 18:35:16 +0200149 omap_state->zorder = plane->type == DRM_PLANE_TYPE_PRIMARY
150 ? 0 : omap_plane->id;
Laurent Pinchart82e588552015-01-12 23:56:57 +0200151
Tomi Valkeinen11ffd032015-05-29 11:05:37 +0300152 dispc_ovl_enable(omap_plane->id, false);
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600153}
154
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300155static int omap_plane_atomic_check(struct drm_plane *plane,
156 struct drm_plane_state *state)
157{
158 struct drm_crtc_state *crtc_state;
159
Tomi Valkeinen70dd2a62016-06-10 12:50:53 +0300160 if (!state->fb)
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300161 return 0;
162
Tomi Valkeinen70dd2a62016-06-10 12:50:53 +0300163 /* crtc should only be NULL when disabling (i.e., !state->fb) */
164 if (WARN_ON(!state->crtc))
165 return 0;
166
167 crtc_state = drm_atomic_get_existing_crtc_state(state->state, state->crtc);
168 /* we should have a crtc state if the plane is attached to a crtc */
169 if (WARN_ON(!crtc_state))
170 return 0;
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300171
Tomi Valkeinenaaf76422016-06-10 12:50:39 +0300172 if (!crtc_state->enable)
173 return 0;
174
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300175 if (state->crtc_x < 0 || state->crtc_y < 0)
176 return -EINVAL;
177
178 if (state->crtc_x + state->crtc_w > crtc_state->adjusted_mode.hdisplay)
179 return -EINVAL;
180
181 if (state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay)
182 return -EINVAL;
183
Tomi Valkeinen70dd2a62016-06-10 12:50:53 +0300184 if (state->rotation != DRM_ROTATE_0 &&
185 !omap_framebuffer_supports_rotation(state->fb))
186 return -EINVAL;
Tomi Valkeinenbfeece52015-08-27 13:09:22 +0300187
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300188 return 0;
189}
190
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200191static const struct drm_plane_helper_funcs omap_plane_helper_funcs = {
192 .prepare_fb = omap_plane_prepare_fb,
193 .cleanup_fb = omap_plane_cleanup_fb,
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300194 .atomic_check = omap_plane_atomic_check,
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200195 .atomic_update = omap_plane_atomic_update,
196 .atomic_disable = omap_plane_atomic_disable,
197};
198
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600199static void omap_plane_destroy(struct drm_plane *plane)
200{
201 struct omap_plane *omap_plane = to_omap_plane(plane);
Rob Clarkf5f94542012-12-04 13:59:12 -0600202
203 DBG("%s", omap_plane->name);
204
205 omap_irq_unregister(plane->dev, &omap_plane->error_irq);
206
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600207 drm_plane_cleanup(plane);
Rob Clarkf5f94542012-12-04 13:59:12 -0600208
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600209 kfree(omap_plane);
210}
211
Rob Clark3c810c62012-08-15 15:18:01 -0500212/* helper to install properties which are common to planes and crtcs */
213void omap_plane_install_properties(struct drm_plane *plane,
214 struct drm_mode_object *obj)
215{
216 struct drm_device *dev = plane->dev;
217 struct omap_drm_private *priv = dev->dev_private;
Rob Clark3c810c62012-08-15 15:18:01 -0500218
Rob Clarkc2a6a552012-10-25 17:14:13 -0500219 if (priv->has_dmm) {
Ville Syrjälä0da88db2016-09-26 19:30:52 +0300220 if (!plane->rotation_property)
221 drm_plane_create_rotation_property(plane,
222 DRM_ROTATE_0,
223 DRM_ROTATE_0 | DRM_ROTATE_90 |
224 DRM_ROTATE_180 | DRM_ROTATE_270 |
225 DRM_REFLECT_X | DRM_REFLECT_Y);
Laurent Pincharte2cd09b2015-03-06 17:16:43 +0200226
Ville Syrjälä0da88db2016-09-26 19:30:52 +0300227 /* Attach the rotation property also to the crtc object */
228 if (plane->rotation_property && obj != &plane->base)
229 drm_object_attach_property(obj, plane->rotation_property,
230 DRM_ROTATE_0);
Rob Clark3c810c62012-08-15 15:18:01 -0500231 }
Andre Renaud8451b5a2012-08-15 15:18:02 -0500232
Laurent Pincharte2cd09b2015-03-06 17:16:43 +0200233 drm_object_attach_property(obj, priv->zorder_prop, 0);
Rob Clark3c810c62012-08-15 15:18:01 -0500234}
235
Laurent Pinchartafc34932015-03-06 18:35:16 +0200236static struct drm_plane_state *
237omap_plane_atomic_duplicate_state(struct drm_plane *plane)
Rob Clark3c810c62012-08-15 15:18:01 -0500238{
Laurent Pinchartafc34932015-03-06 18:35:16 +0200239 struct omap_plane_state *state;
240 struct omap_plane_state *copy;
241
242 if (WARN_ON(!plane->state))
243 return NULL;
244
245 state = to_omap_plane_state(plane->state);
246 copy = kmemdup(state, sizeof(*state), GFP_KERNEL);
247 if (copy == NULL)
248 return NULL;
249
250 __drm_atomic_helper_plane_duplicate_state(plane, &copy->base);
251
252 return &copy->base;
253}
254
255static void omap_plane_atomic_destroy_state(struct drm_plane *plane,
256 struct drm_plane_state *state)
257{
Daniel Vetter2f701692016-05-09 16:34:10 +0200258 __drm_atomic_helper_plane_destroy_state(state);
Laurent Pinchartafc34932015-03-06 18:35:16 +0200259 kfree(to_omap_plane_state(state));
260}
261
Tomi Valkeinene07323c2015-12-15 11:33:23 +0200262static void omap_plane_reset(struct drm_plane *plane)
263{
264 struct omap_plane *omap_plane = to_omap_plane(plane);
265 struct omap_plane_state *omap_state;
266
Laurent Pinchartf8ef29e2015-12-14 22:39:29 +0200267 if (plane->state) {
268 omap_plane_atomic_destroy_state(plane, plane->state);
269 plane->state = NULL;
270 }
Tomi Valkeinene07323c2015-12-15 11:33:23 +0200271
272 omap_state = kzalloc(sizeof(*omap_state), GFP_KERNEL);
273 if (omap_state == NULL)
274 return;
275
276 /*
277 * Set defaults depending on whether we are a primary or overlay
278 * plane.
279 */
280 omap_state->zorder = plane->type == DRM_PLANE_TYPE_PRIMARY
281 ? 0 : omap_plane->id;
Joonas Lahtinen31ad61e2016-07-29 08:50:05 +0300282 omap_state->base.rotation = DRM_ROTATE_0;
Tomi Valkeinene07323c2015-12-15 11:33:23 +0200283
284 plane->state = &omap_state->base;
285 plane->state->plane = plane;
286}
287
Laurent Pinchartafc34932015-03-06 18:35:16 +0200288static int omap_plane_atomic_set_property(struct drm_plane *plane,
289 struct drm_plane_state *state,
290 struct drm_property *property,
291 uint64_t val)
292{
Rob Clark3c810c62012-08-15 15:18:01 -0500293 struct omap_drm_private *priv = plane->dev->dev_private;
Laurent Pinchartafc34932015-03-06 18:35:16 +0200294 struct omap_plane_state *omap_state = to_omap_plane_state(state);
Rob Clark3c810c62012-08-15 15:18:01 -0500295
Laurent Pinchartafc34932015-03-06 18:35:16 +0200296 if (property == priv->zorder_prop)
297 omap_state->zorder = val;
298 else
Laurent Pincharta42133a2015-01-17 19:09:26 +0200299 return -EINVAL;
Rob Clark3c810c62012-08-15 15:18:01 -0500300
Laurent Pinchartafc34932015-03-06 18:35:16 +0200301 return 0;
302}
Laurent Pincharta42133a2015-01-17 19:09:26 +0200303
Laurent Pinchartafc34932015-03-06 18:35:16 +0200304static int omap_plane_atomic_get_property(struct drm_plane *plane,
305 const struct drm_plane_state *state,
306 struct drm_property *property,
307 uint64_t *val)
308{
309 struct omap_drm_private *priv = plane->dev->dev_private;
310 const struct omap_plane_state *omap_state =
311 container_of(state, const struct omap_plane_state, base);
Laurent Pincharta42133a2015-01-17 19:09:26 +0200312
Laurent Pinchartafc34932015-03-06 18:35:16 +0200313 if (property == priv->zorder_prop)
314 *val = omap_state->zorder;
315 else
316 return -EINVAL;
317
318 return 0;
Rob Clark3c810c62012-08-15 15:18:01 -0500319}
320
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600321static const struct drm_plane_funcs omap_plane_funcs = {
Laurent Pinchartcef77d42015-03-05 21:50:00 +0200322 .update_plane = drm_atomic_helper_update_plane,
323 .disable_plane = drm_atomic_helper_disable_plane,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200324 .reset = omap_plane_reset,
Laurent Pinchart222025e2015-01-11 00:02:07 +0200325 .destroy = omap_plane_destroy,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200326 .set_property = drm_atomic_helper_plane_set_property,
327 .atomic_duplicate_state = omap_plane_atomic_duplicate_state,
328 .atomic_destroy_state = omap_plane_atomic_destroy_state,
329 .atomic_set_property = omap_plane_atomic_set_property,
330 .atomic_get_property = omap_plane_atomic_get_property,
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600331};
332
Rob Clarkf5f94542012-12-04 13:59:12 -0600333static void omap_plane_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
334{
335 struct omap_plane *omap_plane =
336 container_of(irq, struct omap_plane, error_irq);
Tomi Valkeinen3b143fc2014-11-19 12:50:13 +0200337 DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_plane->name,
338 irqstatus);
Rob Clarkf5f94542012-12-04 13:59:12 -0600339}
340
341static const char *plane_names[] = {
Laurent Pinchart222025e2015-01-11 00:02:07 +0200342 [OMAP_DSS_GFX] = "gfx",
343 [OMAP_DSS_VIDEO1] = "vid1",
344 [OMAP_DSS_VIDEO2] = "vid2",
345 [OMAP_DSS_VIDEO3] = "vid3",
Rob Clarkf5f94542012-12-04 13:59:12 -0600346};
347
348static const uint32_t error_irqs[] = {
Laurent Pinchart222025e2015-01-11 00:02:07 +0200349 [OMAP_DSS_GFX] = DISPC_IRQ_GFX_FIFO_UNDERFLOW,
350 [OMAP_DSS_VIDEO1] = DISPC_IRQ_VID1_FIFO_UNDERFLOW,
351 [OMAP_DSS_VIDEO2] = DISPC_IRQ_VID2_FIFO_UNDERFLOW,
352 [OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
Rob Clarkf5f94542012-12-04 13:59:12 -0600353};
354
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600355/* initialize plane */
356struct drm_plane *omap_plane_init(struct drm_device *dev,
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200357 int id, enum drm_plane_type type)
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600358{
Rob Clarkf5f94542012-12-04 13:59:12 -0600359 struct omap_drm_private *priv = dev->dev_private;
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200360 struct drm_plane *plane;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600361 struct omap_plane *omap_plane;
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200362 int ret;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600363
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200364 DBG("%s: type=%d", plane_names[id], type);
Rob Clarkb33f34d2012-03-05 10:48:35 -0600365
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600366 omap_plane = kzalloc(sizeof(*omap_plane), GFP_KERNEL);
Joe Perches78110bb2013-02-11 09:41:29 -0800367 if (!omap_plane)
Laurent Pinchartfb9a35f2015-01-11 16:30:44 +0200368 return ERR_PTR(-ENOMEM);
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600369
Rob Clarka890e662012-03-05 10:48:31 -0600370 omap_plane->nformats = omap_framebuffer_get_formats(
371 omap_plane->formats, ARRAY_SIZE(omap_plane->formats),
Rob Clarkf5f94542012-12-04 13:59:12 -0600372 dss_feat_get_supported_color_modes(id));
373 omap_plane->id = id;
374 omap_plane->name = plane_names[id];
375
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600376 plane = &omap_plane->base;
377
Rob Clarkf5f94542012-12-04 13:59:12 -0600378 omap_plane->error_irq.irqmask = error_irqs[id];
379 omap_plane->error_irq.irq = omap_plane_error_irq;
380 omap_irq_register(dev, &omap_plane->error_irq);
381
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200382 ret = drm_universal_plane_init(dev, plane, (1 << priv->num_crtcs) - 1,
383 &omap_plane_funcs, omap_plane->formats,
Ville Syrjäläb0b3b792015-12-09 16:19:55 +0200384 omap_plane->nformats, type, NULL);
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200385 if (ret < 0)
386 goto error;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600387
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200388 drm_plane_helper_add(plane, &omap_plane_helper_funcs);
389
Rob Clark3c810c62012-08-15 15:18:01 -0500390 omap_plane_install_properties(plane, &plane->base);
391
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600392 return plane;
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200393
394error:
395 omap_irq_unregister(plane->dev, &omap_plane->error_irq);
396 kfree(omap_plane);
397 return NULL;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600398}