Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 1 | /****************************************************************************** |
| 2 | * |
| 3 | * This file is provided under a dual BSD/GPLv2 license. When using or |
| 4 | * redistributing this file, you may do so under either license. |
| 5 | * |
| 6 | * GPL LICENSE SUMMARY |
| 7 | * |
Emmanuel Grumbach | 51368bf | 2013-12-30 13:15:54 +0200 | [diff] [blame] | 8 | * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved. |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 9 | * |
| 10 | * This program is free software; you can redistribute it and/or modify |
| 11 | * it under the terms of version 2 of the GNU General Public License as |
| 12 | * published by the Free Software Foundation. |
| 13 | * |
| 14 | * This program is distributed in the hope that it will be useful, but |
| 15 | * WITHOUT ANY WARRANTY; without even the implied warranty of |
| 16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
| 17 | * General Public License for more details. |
| 18 | * |
| 19 | * You should have received a copy of the GNU General Public License |
| 20 | * along with this program; if not, write to the Free Software |
| 21 | * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110, |
| 22 | * USA |
| 23 | * |
| 24 | * The full GNU General Public License is included in this distribution |
Emmanuel Grumbach | 410dc5a | 2013-02-18 09:22:28 +0200 | [diff] [blame] | 25 | * in the file called COPYING. |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 26 | * |
| 27 | * Contact Information: |
| 28 | * Intel Linux Wireless <ilw@linux.intel.com> |
| 29 | * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497 |
| 30 | * |
| 31 | * BSD LICENSE |
| 32 | * |
Emmanuel Grumbach | 51368bf | 2013-12-30 13:15:54 +0200 | [diff] [blame] | 33 | * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved. |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 34 | * All rights reserved. |
| 35 | * |
| 36 | * Redistribution and use in source and binary forms, with or without |
| 37 | * modification, are permitted provided that the following conditions |
| 38 | * are met: |
| 39 | * |
| 40 | * * Redistributions of source code must retain the above copyright |
| 41 | * notice, this list of conditions and the following disclaimer. |
| 42 | * * Redistributions in binary form must reproduce the above copyright |
| 43 | * notice, this list of conditions and the following disclaimer in |
| 44 | * the documentation and/or other materials provided with the |
| 45 | * distribution. |
| 46 | * * Neither the name Intel Corporation nor the names of its |
| 47 | * contributors may be used to endorse or promote products derived |
| 48 | * from this software without specific prior written permission. |
| 49 | * |
| 50 | * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
| 51 | * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
| 52 | * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
| 53 | * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
| 54 | * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
| 55 | * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
| 56 | * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
| 57 | * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
| 58 | * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 59 | * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 60 | * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 61 | * |
| 62 | *****************************************************************************/ |
| 63 | |
| 64 | #include <net/mac80211.h> |
| 65 | #include "fw-api.h" |
| 66 | #include "mvm.h" |
| 67 | |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 68 | #define QUOTA_100 IWL_MVM_MAX_QUOTA |
| 69 | #define QUOTA_LOWLAT_MIN ((QUOTA_100 * IWL_MVM_LOWLAT_QUOTA_MIN_PERCENT) / 100) |
| 70 | |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 71 | struct iwl_mvm_quota_iterator_data { |
| 72 | int n_interfaces[MAX_BINDINGS]; |
| 73 | int colors[MAX_BINDINGS]; |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 74 | int low_latency[MAX_BINDINGS]; |
| 75 | int n_low_latency_bindings; |
Johannes Berg | 0166230 | 2014-06-06 15:18:45 +0200 | [diff] [blame] | 76 | struct ieee80211_vif *disabled_vif; |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 77 | }; |
| 78 | |
| 79 | static void iwl_mvm_quota_iterator(void *_data, u8 *mac, |
| 80 | struct ieee80211_vif *vif) |
| 81 | { |
| 82 | struct iwl_mvm_quota_iterator_data *data = _data; |
| 83 | struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); |
| 84 | u16 id; |
| 85 | |
Johannes Berg | 0166230 | 2014-06-06 15:18:45 +0200 | [diff] [blame] | 86 | /* skip disabled interfaces here immediately */ |
| 87 | if (vif == data->disabled_vif) |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 88 | return; |
| 89 | |
| 90 | if (!mvmvif->phy_ctxt) |
| 91 | return; |
| 92 | |
| 93 | /* currently, PHY ID == binding ID */ |
| 94 | id = mvmvif->phy_ctxt->id; |
| 95 | |
| 96 | /* need at least one binding per PHY */ |
| 97 | BUILD_BUG_ON(NUM_PHY_CTX > MAX_BINDINGS); |
| 98 | |
| 99 | if (WARN_ON_ONCE(id >= MAX_BINDINGS)) |
| 100 | return; |
| 101 | |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 102 | switch (vif->type) { |
| 103 | case NL80211_IFTYPE_STATION: |
| 104 | if (vif->bss_conf.assoc) |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 105 | break; |
| 106 | return; |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 107 | case NL80211_IFTYPE_AP: |
Johannes Berg | 5023d96 | 2013-07-31 14:07:43 +0200 | [diff] [blame] | 108 | case NL80211_IFTYPE_ADHOC: |
| 109 | if (mvmvif->ap_ibss_active) |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 110 | break; |
| 111 | return; |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 112 | case NL80211_IFTYPE_MONITOR: |
Ilan Peer | 1e1391c | 2013-03-13 14:52:04 +0200 | [diff] [blame] | 113 | if (mvmvif->monitor_active) |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 114 | break; |
| 115 | return; |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 116 | case NL80211_IFTYPE_P2P_DEVICE: |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 117 | return; |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 118 | default: |
| 119 | WARN_ON_ONCE(1); |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 120 | return; |
| 121 | } |
| 122 | |
Johannes Berg | 63faceb | 2014-05-23 16:15:11 +0200 | [diff] [blame] | 123 | if (data->colors[id] < 0) |
| 124 | data->colors[id] = mvmvif->phy_ctxt->color; |
| 125 | else |
| 126 | WARN_ON_ONCE(data->colors[id] != mvmvif->phy_ctxt->color); |
| 127 | |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 128 | data->n_interfaces[id]++; |
| 129 | |
| 130 | if (iwl_mvm_vif_low_latency(mvmvif) && !data->low_latency[id]) { |
| 131 | data->n_low_latency_bindings++; |
| 132 | data->low_latency[id] = true; |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 133 | } |
| 134 | } |
| 135 | |
David Spinadel | 507cadf | 2013-07-31 18:07:21 +0300 | [diff] [blame] | 136 | static void iwl_mvm_adjust_quota_for_noa(struct iwl_mvm *mvm, |
| 137 | struct iwl_time_quota_cmd *cmd) |
| 138 | { |
| 139 | #ifdef CONFIG_NL80211_TESTMODE |
| 140 | struct iwl_mvm_vif *mvmvif; |
| 141 | int i, phy_id = -1, beacon_int = 0; |
| 142 | |
| 143 | if (!mvm->noa_duration || !mvm->noa_vif) |
| 144 | return; |
| 145 | |
| 146 | mvmvif = iwl_mvm_vif_from_mac80211(mvm->noa_vif); |
Johannes Berg | 5023d96 | 2013-07-31 14:07:43 +0200 | [diff] [blame] | 147 | if (!mvmvif->ap_ibss_active) |
David Spinadel | 507cadf | 2013-07-31 18:07:21 +0300 | [diff] [blame] | 148 | return; |
| 149 | |
| 150 | phy_id = mvmvif->phy_ctxt->id; |
| 151 | beacon_int = mvm->noa_vif->bss_conf.beacon_int; |
| 152 | |
| 153 | for (i = 0; i < MAX_BINDINGS; i++) { |
| 154 | u32 id_n_c = le32_to_cpu(cmd->quotas[i].id_and_color); |
| 155 | u32 id = (id_n_c & FW_CTXT_ID_MSK) >> FW_CTXT_ID_POS; |
| 156 | u32 quota = le32_to_cpu(cmd->quotas[i].quota); |
| 157 | |
| 158 | if (id != phy_id) |
| 159 | continue; |
| 160 | |
David Spinadel | 246dd99 | 2013-10-17 09:49:12 +0300 | [diff] [blame] | 161 | quota *= (beacon_int - mvm->noa_duration); |
| 162 | quota /= beacon_int; |
David Spinadel | 507cadf | 2013-07-31 18:07:21 +0300 | [diff] [blame] | 163 | |
Johannes Berg | a43ad46 | 2014-08-04 16:39:54 +0200 | [diff] [blame] | 164 | IWL_DEBUG_QUOTA(mvm, "quota: adjust for NoA from %d to %d\n", |
| 165 | le32_to_cpu(cmd->quotas[i].quota), quota); |
| 166 | |
David Spinadel | 507cadf | 2013-07-31 18:07:21 +0300 | [diff] [blame] | 167 | cmd->quotas[i].quota = cpu_to_le32(quota); |
| 168 | } |
| 169 | #endif |
| 170 | } |
| 171 | |
Johannes Berg | 0166230 | 2014-06-06 15:18:45 +0200 | [diff] [blame] | 172 | int iwl_mvm_update_quotas(struct iwl_mvm *mvm, |
| 173 | struct ieee80211_vif *disabled_vif) |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 174 | { |
Johannes Berg | f5e45f2 | 2013-07-25 22:36:27 +0200 | [diff] [blame] | 175 | struct iwl_time_quota_cmd cmd = {}; |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 176 | int i, idx, ret, num_active_macs, quota, quota_rem, n_non_lowlat; |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 177 | struct iwl_mvm_quota_iterator_data data = { |
| 178 | .n_interfaces = {}, |
| 179 | .colors = { -1, -1, -1, -1 }, |
Johannes Berg | 0166230 | 2014-06-06 15:18:45 +0200 | [diff] [blame] | 180 | .disabled_vif = disabled_vif, |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 181 | }; |
| 182 | |
Johannes Berg | f5e45f2 | 2013-07-25 22:36:27 +0200 | [diff] [blame] | 183 | lockdep_assert_held(&mvm->mutex); |
| 184 | |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 185 | /* update all upon completion */ |
| 186 | if (test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status)) |
| 187 | return 0; |
| 188 | |
Johannes Berg | f5e45f2 | 2013-07-25 22:36:27 +0200 | [diff] [blame] | 189 | /* iterator data above must match */ |
| 190 | BUILD_BUG_ON(MAX_BINDINGS != 4); |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 191 | |
| 192 | ieee80211_iterate_active_interfaces_atomic( |
| 193 | mvm->hw, IEEE80211_IFACE_ITER_NORMAL, |
| 194 | iwl_mvm_quota_iterator, &data); |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 195 | |
Ilan Peer | 35adfd6 | 2013-02-04 13:16:24 +0200 | [diff] [blame] | 196 | /* |
| 197 | * The FW's scheduling session consists of |
| 198 | * IWL_MVM_MAX_QUOTA fragments. Divide these fragments |
| 199 | * equally between all the bindings that require quota |
| 200 | */ |
Johannes Berg | 7b8359c | 2013-07-10 12:59:38 +0200 | [diff] [blame] | 201 | num_active_macs = 0; |
Ilan Peer | 35adfd6 | 2013-02-04 13:16:24 +0200 | [diff] [blame] | 202 | for (i = 0; i < MAX_BINDINGS; i++) { |
| 203 | cmd.quotas[i].id_and_color = cpu_to_le32(FW_CTXT_INVALID); |
Johannes Berg | 7b8359c | 2013-07-10 12:59:38 +0200 | [diff] [blame] | 204 | num_active_macs += data.n_interfaces[i]; |
Ilan Peer | 35adfd6 | 2013-02-04 13:16:24 +0200 | [diff] [blame] | 205 | } |
| 206 | |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 207 | n_non_lowlat = num_active_macs; |
| 208 | |
| 209 | if (data.n_low_latency_bindings == 1) { |
| 210 | for (i = 0; i < MAX_BINDINGS; i++) { |
| 211 | if (data.low_latency[i]) { |
| 212 | n_non_lowlat -= data.n_interfaces[i]; |
| 213 | break; |
| 214 | } |
| 215 | } |
Ilan Peer | 7b4fe06 | 2014-01-19 11:38:39 +0200 | [diff] [blame] | 216 | } |
| 217 | |
| 218 | if (data.n_low_latency_bindings == 1 && n_non_lowlat) { |
| 219 | /* |
| 220 | * Reserve quota for the low latency binding in case that |
| 221 | * there are several data bindings but only a single |
| 222 | * low latency one. Split the rest of the quota equally |
| 223 | * between the other data interfaces. |
| 224 | */ |
| 225 | quota = (QUOTA_100 - QUOTA_LOWLAT_MIN) / n_non_lowlat; |
| 226 | quota_rem = QUOTA_100 - n_non_lowlat * quota - |
| 227 | QUOTA_LOWLAT_MIN; |
Johannes Berg | a43ad46 | 2014-08-04 16:39:54 +0200 | [diff] [blame] | 228 | IWL_DEBUG_QUOTA(mvm, |
| 229 | "quota: low-latency binding active, remaining quota per other binding: %d\n", |
| 230 | quota); |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 231 | } else if (num_active_macs) { |
Ilan Peer | 7b4fe06 | 2014-01-19 11:38:39 +0200 | [diff] [blame] | 232 | /* |
| 233 | * There are 0 or more than 1 low latency bindings, or all the |
| 234 | * data interfaces belong to the single low latency binding. |
| 235 | * Split the quota equally between the data interfaces. |
| 236 | */ |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 237 | quota = QUOTA_100 / num_active_macs; |
| 238 | quota_rem = QUOTA_100 % num_active_macs; |
Johannes Berg | a43ad46 | 2014-08-04 16:39:54 +0200 | [diff] [blame] | 239 | IWL_DEBUG_QUOTA(mvm, |
| 240 | "quota: splitting evenly per binding: %d\n", |
| 241 | quota); |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 242 | } else { |
| 243 | /* values don't really matter - won't be used */ |
| 244 | quota = 0; |
| 245 | quota_rem = 0; |
Ilan Peer | 8d683b7 | 2013-05-30 07:31:01 +0300 | [diff] [blame] | 246 | } |
Ilan Peer | 35adfd6 | 2013-02-04 13:16:24 +0200 | [diff] [blame] | 247 | |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 248 | for (idx = 0, i = 0; i < MAX_BINDINGS; i++) { |
Ilan Peer | 8d683b7 | 2013-05-30 07:31:01 +0300 | [diff] [blame] | 249 | if (data.colors[i] < 0) |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 250 | continue; |
| 251 | |
| 252 | cmd.quotas[idx].id_and_color = |
| 253 | cpu_to_le32(FW_CMD_ID_AND_COLOR(i, data.colors[i])); |
Ilan Peer | 8d683b7 | 2013-05-30 07:31:01 +0300 | [diff] [blame] | 254 | |
Johannes Berg | 1fb184b | 2013-11-12 22:18:45 +0100 | [diff] [blame] | 255 | if (data.n_interfaces[i] <= 0) |
Ilan Peer | 8d683b7 | 2013-05-30 07:31:01 +0300 | [diff] [blame] | 256 | cmd.quotas[idx].quota = cpu_to_le32(0); |
Johannes Berg | 1fb184b | 2013-11-12 22:18:45 +0100 | [diff] [blame] | 257 | else if (data.n_low_latency_bindings == 1 && n_non_lowlat && |
| 258 | data.low_latency[i]) |
Ilan Peer | 7b4fe06 | 2014-01-19 11:38:39 +0200 | [diff] [blame] | 259 | /* |
| 260 | * There is more than one binding, but only one of the |
| 261 | * bindings is in low latency. For this case, allocate |
| 262 | * the minimal required quota for the low latency |
| 263 | * binding. |
| 264 | */ |
Johannes Berg | 6ca40d6 | 2013-12-18 15:56:28 +0100 | [diff] [blame] | 265 | cmd.quotas[idx].quota = cpu_to_le32(QUOTA_LOWLAT_MIN); |
Johannes Berg | 1fb184b | 2013-11-12 22:18:45 +0100 | [diff] [blame] | 266 | else |
Johannes Berg | 7b8359c | 2013-07-10 12:59:38 +0200 | [diff] [blame] | 267 | cmd.quotas[idx].quota = |
| 268 | cpu_to_le32(quota * data.n_interfaces[i]); |
Johannes Berg | 1fb184b | 2013-11-12 22:18:45 +0100 | [diff] [blame] | 269 | |
Ilan Peer | 7b4fe06 | 2014-01-19 11:38:39 +0200 | [diff] [blame] | 270 | WARN_ONCE(le32_to_cpu(cmd.quotas[idx].quota) > QUOTA_100, |
| 271 | "Binding=%d, quota=%u > max=%u\n", |
| 272 | idx, le32_to_cpu(cmd.quotas[idx].quota), QUOTA_100); |
| 273 | |
Johannes Berg | 65d6662 | 2014-03-17 09:34:29 +0100 | [diff] [blame] | 274 | cmd.quotas[idx].max_duration = cpu_to_le32(0); |
Johannes Berg | 1fb184b | 2013-11-12 22:18:45 +0100 | [diff] [blame] | 275 | |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 276 | idx++; |
| 277 | } |
| 278 | |
Ilan Peer | 2d675e5 | 2014-01-19 11:46:52 +0200 | [diff] [blame] | 279 | /* Give the remainder of the session to the first data binding */ |
| 280 | for (i = 0; i < MAX_BINDINGS; i++) { |
| 281 | if (le32_to_cpu(cmd.quotas[i].quota) != 0) { |
| 282 | le32_add_cpu(&cmd.quotas[i].quota, quota_rem); |
Johannes Berg | a43ad46 | 2014-08-04 16:39:54 +0200 | [diff] [blame] | 283 | IWL_DEBUG_QUOTA(mvm, |
| 284 | "quota: giving remainder of %d to binding %d\n", |
| 285 | quota_rem, i); |
Ilan Peer | 2d675e5 | 2014-01-19 11:46:52 +0200 | [diff] [blame] | 286 | break; |
| 287 | } |
| 288 | } |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 289 | |
David Spinadel | 507cadf | 2013-07-31 18:07:21 +0300 | [diff] [blame] | 290 | iwl_mvm_adjust_quota_for_noa(mvm, &cmd); |
| 291 | |
Johannes Berg | 99a1230 | 2014-05-23 16:13:57 +0200 | [diff] [blame] | 292 | /* check that we have non-zero quota for all valid bindings */ |
| 293 | for (i = 0; i < MAX_BINDINGS; i++) { |
| 294 | if (cmd.quotas[i].id_and_color == cpu_to_le32(FW_CTXT_INVALID)) |
| 295 | continue; |
| 296 | WARN_ONCE(cmd.quotas[i].quota == 0, |
| 297 | "zero quota on binding %d\n", i); |
| 298 | } |
| 299 | |
Emmanuel Grumbach | a102292 | 2014-05-12 11:36:41 +0300 | [diff] [blame] | 300 | ret = iwl_mvm_send_cmd_pdu(mvm, TIME_QUOTA_CMD, 0, |
Johannes Berg | 8ca151b | 2013-01-24 14:25:36 +0100 | [diff] [blame] | 301 | sizeof(cmd), &cmd); |
| 302 | if (ret) |
| 303 | IWL_ERR(mvm, "Failed to send quota: %d\n", ret); |
| 304 | return ret; |
| 305 | } |