Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 1 | /* |
| 2 | * |
| 3 | * Copyright (C) 2011 Novell Inc. |
| 4 | * |
| 5 | * This program is free software; you can redistribute it and/or modify it |
| 6 | * under the terms of the GNU General Public License version 2 as published by |
| 7 | * the Free Software Foundation. |
| 8 | */ |
| 9 | |
| 10 | #include <linux/fs.h> |
| 11 | #include <linux/slab.h> |
Ingo Molnar | 5b825c3 | 2017-02-02 17:54:15 +0100 | [diff] [blame] | 12 | #include <linux/cred.h> |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 13 | #include <linux/xattr.h> |
Miklos Szeredi | 5201dc4 | 2016-09-01 11:11:59 +0200 | [diff] [blame] | 14 | #include <linux/posix_acl.h> |
Amir Goldstein | 5f8415d | 2017-06-20 15:35:14 +0300 | [diff] [blame] | 15 | #include <linux/ratelimit.h> |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 16 | #include "overlayfs.h" |
| 17 | |
Chandan Rajendra | ba1e563 | 2017-07-24 01:57:54 -0500 | [diff] [blame] | 18 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 19 | int ovl_setattr(struct dentry *dentry, struct iattr *attr) |
| 20 | { |
| 21 | int err; |
| 22 | struct dentry *upperdentry; |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 23 | const struct cred *old_cred; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 24 | |
Jan Kara | 31051c8 | 2016-05-26 16:55:18 +0200 | [diff] [blame] | 25 | err = setattr_prepare(dentry, attr); |
Miklos Szeredi | cf9a678 | 2015-12-11 16:30:49 +0100 | [diff] [blame] | 26 | if (err) |
| 27 | return err; |
| 28 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 29 | err = ovl_want_write(dentry); |
| 30 | if (err) |
| 31 | goto out; |
| 32 | |
Miklos Szeredi | 5812160 | 2018-07-18 15:44:41 +0200 | [diff] [blame] | 33 | if (attr->ia_valid & ATTR_SIZE) { |
| 34 | struct inode *realinode = d_inode(ovl_dentry_real(dentry)); |
| 35 | |
| 36 | err = -ETXTBSY; |
| 37 | if (atomic_read(&realinode->i_writecount) < 0) |
| 38 | goto out_drop_write; |
| 39 | } |
| 40 | |
Miklos Szeredi | acff81e | 2015-12-04 19:18:48 +0100 | [diff] [blame] | 41 | err = ovl_copy_up(dentry); |
| 42 | if (!err) { |
Miklos Szeredi | 5812160 | 2018-07-18 15:44:41 +0200 | [diff] [blame] | 43 | struct inode *winode = NULL; |
| 44 | |
Miklos Szeredi | acff81e | 2015-12-04 19:18:48 +0100 | [diff] [blame] | 45 | upperdentry = ovl_dentry_upper(dentry); |
| 46 | |
Miklos Szeredi | 5812160 | 2018-07-18 15:44:41 +0200 | [diff] [blame] | 47 | if (attr->ia_valid & ATTR_SIZE) { |
| 48 | winode = d_inode(upperdentry); |
| 49 | err = get_write_access(winode); |
| 50 | if (err) |
| 51 | goto out_drop_write; |
| 52 | } |
| 53 | |
Miklos Szeredi | b99c2d9 | 2016-07-04 16:49:48 +0200 | [diff] [blame] | 54 | if (attr->ia_valid & (ATTR_KILL_SUID|ATTR_KILL_SGID)) |
| 55 | attr->ia_valid &= ~ATTR_MODE; |
| 56 | |
Al Viro | 5955102 | 2016-01-22 15:40:57 -0500 | [diff] [blame] | 57 | inode_lock(upperdentry->d_inode); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 58 | old_cred = ovl_override_creds(dentry->d_sb); |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 59 | err = notify_change(upperdentry, attr, NULL); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 60 | revert_creds(old_cred); |
Konstantin Khlebnikov | b81de06 | 2016-01-31 16:21:29 +0300 | [diff] [blame] | 61 | if (!err) |
| 62 | ovl_copyattr(upperdentry->d_inode, dentry->d_inode); |
Al Viro | 5955102 | 2016-01-22 15:40:57 -0500 | [diff] [blame] | 63 | inode_unlock(upperdentry->d_inode); |
Miklos Szeredi | 5812160 | 2018-07-18 15:44:41 +0200 | [diff] [blame] | 64 | |
| 65 | if (winode) |
| 66 | put_write_access(winode); |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 67 | } |
Miklos Szeredi | 5812160 | 2018-07-18 15:44:41 +0200 | [diff] [blame] | 68 | out_drop_write: |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 69 | ovl_drop_write(dentry); |
| 70 | out: |
| 71 | return err; |
| 72 | } |
| 73 | |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 74 | static int ovl_map_dev_ino(struct dentry *dentry, struct kstat *stat, |
| 75 | struct ovl_layer *lower_layer) |
| 76 | { |
| 77 | bool samefs = ovl_same_sb(dentry->d_sb); |
Amir Goldstein | e487d88 | 2017-11-07 13:55:04 +0200 | [diff] [blame] | 78 | unsigned int xinobits = ovl_xino_bits(dentry->d_sb); |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 79 | |
| 80 | if (samefs) { |
| 81 | /* |
| 82 | * When all layers are on the same fs, all real inode |
| 83 | * number are unique, so we use the overlay st_dev, |
| 84 | * which is friendly to du -x. |
| 85 | */ |
| 86 | stat->dev = dentry->d_sb->s_dev; |
Amir Goldstein | e487d88 | 2017-11-07 13:55:04 +0200 | [diff] [blame] | 87 | return 0; |
| 88 | } else if (xinobits) { |
| 89 | unsigned int shift = 64 - xinobits; |
| 90 | /* |
| 91 | * All inode numbers of underlying fs should not be using the |
| 92 | * high xinobits, so we use high xinobits to partition the |
| 93 | * overlay st_ino address space. The high bits holds the fsid |
| 94 | * (upper fsid is 0). This way overlay inode numbers are unique |
| 95 | * and all inodes use overlay st_dev. Inode numbers are also |
| 96 | * persistent for a given layer configuration. |
| 97 | */ |
| 98 | if (stat->ino >> shift) { |
| 99 | pr_warn_ratelimited("overlayfs: inode number too big (%pd2, ino=%llu, xinobits=%d)\n", |
| 100 | dentry, stat->ino, xinobits); |
| 101 | } else { |
| 102 | if (lower_layer) |
| 103 | stat->ino |= ((u64)lower_layer->fsid) << shift; |
| 104 | |
| 105 | stat->dev = dentry->d_sb->s_dev; |
| 106 | return 0; |
| 107 | } |
| 108 | } |
| 109 | |
| 110 | /* The inode could not be mapped to a unified st_ino address space */ |
| 111 | if (S_ISDIR(dentry->d_inode->i_mode)) { |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 112 | /* |
| 113 | * Always use the overlay st_dev for directories, so 'find |
| 114 | * -xdev' will scan the entire overlay mount and won't cross the |
| 115 | * overlay mount boundaries. |
| 116 | * |
| 117 | * If not all layers are on the same fs the pair {real st_ino; |
| 118 | * overlay st_dev} is not unique, so use the non persistent |
| 119 | * overlay st_ino for directories. |
| 120 | */ |
| 121 | stat->dev = dentry->d_sb->s_dev; |
| 122 | stat->ino = dentry->d_inode->i_ino; |
Amir Goldstein | 5148626 | 2018-03-28 20:22:41 +0300 | [diff] [blame] | 123 | } else if (lower_layer && lower_layer->fsid) { |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 124 | /* |
| 125 | * For non-samefs setup, if we cannot map all layers st_ino |
| 126 | * to a unified address space, we need to make sure that st_dev |
Amir Goldstein | 5148626 | 2018-03-28 20:22:41 +0300 | [diff] [blame] | 127 | * is unique per lower fs. Upper layer uses real st_dev and |
| 128 | * lower layers use the unique anonymous bdev assigned to the |
| 129 | * lower fs. |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 130 | */ |
Amir Goldstein | 5148626 | 2018-03-28 20:22:41 +0300 | [diff] [blame] | 131 | stat->dev = lower_layer->fs->pseudo_dev; |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 132 | } |
| 133 | |
| 134 | return 0; |
| 135 | } |
| 136 | |
Miklos Szeredi | 5b71209 | 2017-05-05 11:38:58 +0200 | [diff] [blame] | 137 | int ovl_getattr(const struct path *path, struct kstat *stat, |
| 138 | u32 request_mask, unsigned int flags) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 139 | { |
David Howells | a528d35 | 2017-01-31 16:46:22 +0000 | [diff] [blame] | 140 | struct dentry *dentry = path->dentry; |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 141 | enum ovl_path_type type; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 142 | struct path realpath; |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 143 | const struct cred *old_cred; |
Miklos Szeredi | 5b71209 | 2017-05-05 11:38:58 +0200 | [diff] [blame] | 144 | bool is_dir = S_ISDIR(dentry->d_inode->i_mode); |
Amir Goldstein | a0c5ad3 | 2017-11-01 00:45:40 +0200 | [diff] [blame] | 145 | bool samefs = ovl_same_sb(dentry->d_sb); |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 146 | struct ovl_layer *lower_layer = NULL; |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 147 | int err; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 148 | |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 149 | type = ovl_path_real(dentry, &realpath); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 150 | old_cred = ovl_override_creds(dentry->d_sb); |
David Howells | a528d35 | 2017-01-31 16:46:22 +0000 | [diff] [blame] | 151 | err = vfs_getattr(&realpath, stat, request_mask, flags); |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 152 | if (err) |
| 153 | goto out; |
| 154 | |
| 155 | /* |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 156 | * For non-dir or same fs, we use st_ino of the copy up origin. |
| 157 | * This guaranties constant st_dev/st_ino across copy up. |
Amir Goldstein | e487d88 | 2017-11-07 13:55:04 +0200 | [diff] [blame] | 158 | * With xino feature and non-samefs, we use st_ino of the copy up |
| 159 | * origin masked with high bits that represent the layer id. |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 160 | * |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 161 | * If lower filesystem supports NFS file handles, this also guaranties |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 162 | * persistent st_ino across mount cycle. |
| 163 | */ |
Amir Goldstein | e487d88 | 2017-11-07 13:55:04 +0200 | [diff] [blame] | 164 | if (!is_dir || samefs || ovl_xino_bits(dentry->d_sb)) { |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 165 | if (!OVL_TYPE_UPPER(type)) { |
| 166 | lower_layer = ovl_layer_lower(dentry); |
| 167 | } else if (OVL_TYPE_ORIGIN(type)) { |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 168 | struct kstat lowerstat; |
Miklos Szeredi | 5b71209 | 2017-05-05 11:38:58 +0200 | [diff] [blame] | 169 | u32 lowermask = STATX_INO | (!is_dir ? STATX_NLINK : 0); |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 170 | |
| 171 | ovl_path_lower(dentry, &realpath); |
| 172 | err = vfs_getattr(&realpath, &lowerstat, |
Miklos Szeredi | 5b71209 | 2017-05-05 11:38:58 +0200 | [diff] [blame] | 173 | lowermask, flags); |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 174 | if (err) |
| 175 | goto out; |
| 176 | |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 177 | /* |
Amir Goldstein | 359f392 | 2017-06-21 15:28:41 +0300 | [diff] [blame] | 178 | * Lower hardlinks may be broken on copy up to different |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 179 | * upper files, so we cannot use the lower origin st_ino |
| 180 | * for those different files, even for the same fs case. |
Amir Goldstein | 86eaa13 | 2017-11-21 13:55:51 +0200 | [diff] [blame] | 181 | * |
| 182 | * Similarly, several redirected dirs can point to the |
| 183 | * same dir on a lower layer. With the "verify_lower" |
| 184 | * feature, we do not use the lower origin st_ino, if |
| 185 | * we haven't verified that this redirect is unique. |
| 186 | * |
Amir Goldstein | 359f392 | 2017-06-21 15:28:41 +0300 | [diff] [blame] | 187 | * With inodes index enabled, it is safe to use st_ino |
Amir Goldstein | 86eaa13 | 2017-11-21 13:55:51 +0200 | [diff] [blame] | 188 | * of an indexed origin. The index validates that the |
| 189 | * upper hardlink is not broken and that a redirected |
| 190 | * dir is the only redirect to that origin. |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 191 | */ |
Amir Goldstein | 86eaa13 | 2017-11-21 13:55:51 +0200 | [diff] [blame] | 192 | if (ovl_test_flag(OVL_INDEX, d_inode(dentry)) || |
| 193 | (!ovl_verify_lower(dentry->d_sb) && |
Amir Goldstein | 9f99e50 | 2018-04-11 20:09:29 +0300 | [diff] [blame] | 194 | (is_dir || lowerstat.nlink == 1))) { |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 195 | stat->ino = lowerstat.ino; |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 196 | lower_layer = ovl_layer_lower(dentry); |
Amir Goldstein | 9f99e50 | 2018-04-11 20:09:29 +0300 | [diff] [blame] | 197 | } |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 198 | } |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 199 | } |
Miklos Szeredi | 5b71209 | 2017-05-05 11:38:58 +0200 | [diff] [blame] | 200 | |
Amir Goldstein | da309e8 | 2017-11-08 19:39:51 +0200 | [diff] [blame] | 201 | err = ovl_map_dev_ino(dentry, stat, lower_layer); |
| 202 | if (err) |
| 203 | goto out; |
| 204 | |
Miklos Szeredi | 5b71209 | 2017-05-05 11:38:58 +0200 | [diff] [blame] | 205 | /* |
| 206 | * It's probably not worth it to count subdirs to get the |
| 207 | * correct link count. nlink=1 seems to pacify 'find' and |
| 208 | * other utilities. |
| 209 | */ |
| 210 | if (is_dir && OVL_TYPE_MERGE(type)) |
| 211 | stat->nlink = 1; |
| 212 | |
Amir Goldstein | 5f8415d | 2017-06-20 15:35:14 +0300 | [diff] [blame] | 213 | /* |
| 214 | * Return the overlay inode nlinks for indexed upper inodes. |
| 215 | * Overlay inode nlink counts the union of the upper hardlinks |
| 216 | * and non-covered lower hardlinks. It does not include the upper |
| 217 | * index hardlink. |
| 218 | */ |
| 219 | if (!is_dir && ovl_test_flag(OVL_INDEX, d_inode(dentry))) |
| 220 | stat->nlink = dentry->d_inode->i_nlink; |
| 221 | |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 222 | out: |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 223 | revert_creds(old_cred); |
Amir Goldstein | 72b608f | 2017-04-24 00:25:49 +0300 | [diff] [blame] | 224 | |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 225 | return err; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 226 | } |
| 227 | |
| 228 | int ovl_permission(struct inode *inode, int mask) |
| 229 | { |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 230 | struct inode *upperinode = ovl_inode_upper(inode); |
| 231 | struct inode *realinode = upperinode ?: ovl_inode_lower(inode); |
Vivek Goyal | c0ca3d7 | 2016-07-01 16:34:27 -0400 | [diff] [blame] | 232 | const struct cred *old_cred; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 233 | int err; |
| 234 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 235 | /* Careful in RCU walk mode */ |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 236 | if (!realinode) { |
| 237 | WARN_ON(!(mask & MAY_NOT_BLOCK)); |
Miklos Szeredi | a999d7e | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 238 | return -ECHILD; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 239 | } |
| 240 | |
Vivek Goyal | c0ca3d7 | 2016-07-01 16:34:27 -0400 | [diff] [blame] | 241 | /* |
| 242 | * Check overlay inode with the creds of task and underlying inode |
| 243 | * with creds of mounter |
| 244 | */ |
| 245 | err = generic_permission(inode, mask); |
| 246 | if (err) |
| 247 | return err; |
| 248 | |
| 249 | old_cred = ovl_override_creds(inode->i_sb); |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 250 | if (!upperinode && |
| 251 | !special_file(realinode->i_mode) && mask & MAY_WRITE) { |
Vivek Goyal | 754f8cb | 2016-07-01 16:34:29 -0400 | [diff] [blame] | 252 | mask &= ~(MAY_WRITE | MAY_APPEND); |
Vivek Goyal | 500cac3 | 2016-07-13 11:00:14 -0400 | [diff] [blame] | 253 | /* Make sure mounter can read file for copy up later */ |
| 254 | mask |= MAY_READ; |
| 255 | } |
Miklos Szeredi | 9c630eb | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 256 | err = inode_permission(realinode, mask); |
Vivek Goyal | c0ca3d7 | 2016-07-01 16:34:27 -0400 | [diff] [blame] | 257 | revert_creds(old_cred); |
| 258 | |
| 259 | return err; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 260 | } |
| 261 | |
Al Viro | 6b25539 | 2015-11-17 10:20:54 -0500 | [diff] [blame] | 262 | static const char *ovl_get_link(struct dentry *dentry, |
Al Viro | fceef39 | 2015-12-29 15:58:39 -0500 | [diff] [blame] | 263 | struct inode *inode, |
| 264 | struct delayed_call *done) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 265 | { |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 266 | const struct cred *old_cred; |
| 267 | const char *p; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 268 | |
Al Viro | 6b25539 | 2015-11-17 10:20:54 -0500 | [diff] [blame] | 269 | if (!dentry) |
| 270 | return ERR_PTR(-ECHILD); |
| 271 | |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 272 | old_cred = ovl_override_creds(dentry->d_sb); |
Miklos Szeredi | 7764235b | 2016-10-04 14:40:45 +0200 | [diff] [blame] | 273 | p = vfs_get_link(ovl_dentry_real(dentry), done); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 274 | revert_creds(old_cred); |
| 275 | return p; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 276 | } |
| 277 | |
Miklos Szeredi | 0956254 | 2016-08-08 15:08:49 +0200 | [diff] [blame] | 278 | bool ovl_is_private_xattr(const char *name) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 279 | { |
Andreas Gruenbacher | fe2b759 | 2016-08-22 17:59:22 +0200 | [diff] [blame] | 280 | return strncmp(name, OVL_XATTR_PREFIX, |
| 281 | sizeof(OVL_XATTR_PREFIX) - 1) == 0; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 282 | } |
| 283 | |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 284 | int ovl_xattr_set(struct dentry *dentry, struct inode *inode, const char *name, |
| 285 | const void *value, size_t size, int flags) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 286 | { |
| 287 | int err; |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 288 | struct dentry *upperdentry = ovl_i_dentry_upper(inode); |
| 289 | struct dentry *realdentry = upperdentry ?: ovl_dentry_lower(dentry); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 290 | const struct cred *old_cred; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 291 | |
| 292 | err = ovl_want_write(dentry); |
| 293 | if (err) |
| 294 | goto out; |
| 295 | |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 296 | if (!value && !upperdentry) { |
| 297 | err = vfs_getxattr(realdentry, name, NULL, 0); |
Andreas Gruenbacher | 0e585cc | 2016-08-22 17:22:11 +0200 | [diff] [blame] | 298 | if (err < 0) |
| 299 | goto out_drop_write; |
| 300 | } |
| 301 | |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 302 | if (!upperdentry) { |
| 303 | err = ovl_copy_up(dentry); |
| 304 | if (err) |
| 305 | goto out_drop_write; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 306 | |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 307 | realdentry = ovl_dentry_upper(dentry); |
| 308 | } |
Andreas Gruenbacher | 0e585cc | 2016-08-22 17:22:11 +0200 | [diff] [blame] | 309 | |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 310 | old_cred = ovl_override_creds(dentry->d_sb); |
Andreas Gruenbacher | 0e585cc | 2016-08-22 17:22:11 +0200 | [diff] [blame] | 311 | if (value) |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 312 | err = vfs_setxattr(realdentry, name, value, size, flags); |
Andreas Gruenbacher | 0e585cc | 2016-08-22 17:22:11 +0200 | [diff] [blame] | 313 | else { |
| 314 | WARN_ON(flags != XATTR_REPLACE); |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 315 | err = vfs_removexattr(realdentry, name); |
Andreas Gruenbacher | 0e585cc | 2016-08-22 17:22:11 +0200 | [diff] [blame] | 316 | } |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 317 | revert_creds(old_cred); |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 318 | |
Miklos Szeredi | d9854c8 | 2018-07-18 15:44:40 +0200 | [diff] [blame] | 319 | /* copy c/mtime */ |
| 320 | ovl_copyattr(d_inode(realdentry), inode); |
| 321 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 322 | out_drop_write: |
| 323 | ovl_drop_write(dentry); |
| 324 | out: |
| 325 | return err; |
| 326 | } |
| 327 | |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 328 | int ovl_xattr_get(struct dentry *dentry, struct inode *inode, const char *name, |
Andreas Gruenbacher | 0eb45fc | 2016-08-22 17:52:55 +0200 | [diff] [blame] | 329 | void *value, size_t size) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 330 | { |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 331 | ssize_t res; |
| 332 | const struct cred *old_cred; |
Miklos Szeredi | 1d88f18 | 2017-07-20 11:08:21 +0200 | [diff] [blame] | 333 | struct dentry *realdentry = |
| 334 | ovl_i_dentry_upper(inode) ?: ovl_dentry_lower(dentry); |
Miklos Szeredi | 5214846 | 2014-11-20 16:40:00 +0100 | [diff] [blame] | 335 | |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 336 | old_cred = ovl_override_creds(dentry->d_sb); |
| 337 | res = vfs_getxattr(realdentry, name, value, size); |
| 338 | revert_creds(old_cred); |
| 339 | return res; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 340 | } |
| 341 | |
Miklos Szeredi | a082c6f | 2017-05-29 15:15:27 +0200 | [diff] [blame] | 342 | static bool ovl_can_list(const char *s) |
| 343 | { |
| 344 | /* List all non-trusted xatts */ |
| 345 | if (strncmp(s, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) != 0) |
| 346 | return true; |
| 347 | |
| 348 | /* Never list trusted.overlay, list other trusted for superuser only */ |
| 349 | return !ovl_is_private_xattr(s) && capable(CAP_SYS_ADMIN); |
| 350 | } |
| 351 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 352 | ssize_t ovl_listxattr(struct dentry *dentry, char *list, size_t size) |
| 353 | { |
Miklos Szeredi | b581755 | 2016-06-06 16:21:37 +0200 | [diff] [blame] | 354 | struct dentry *realdentry = ovl_dentry_real(dentry); |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 355 | ssize_t res; |
Miklos Szeredi | 7cb3511 | 2016-09-01 11:12:00 +0200 | [diff] [blame] | 356 | size_t len; |
| 357 | char *s; |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 358 | const struct cred *old_cred; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 359 | |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 360 | old_cred = ovl_override_creds(dentry->d_sb); |
Miklos Szeredi | b581755 | 2016-06-06 16:21:37 +0200 | [diff] [blame] | 361 | res = vfs_listxattr(realdentry, list, size); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 362 | revert_creds(old_cred); |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 363 | if (res <= 0 || size == 0) |
| 364 | return res; |
| 365 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 366 | /* filter out private xattrs */ |
Miklos Szeredi | 7cb3511 | 2016-09-01 11:12:00 +0200 | [diff] [blame] | 367 | for (s = list, len = res; len;) { |
| 368 | size_t slen = strnlen(s, len) + 1; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 369 | |
Miklos Szeredi | 7cb3511 | 2016-09-01 11:12:00 +0200 | [diff] [blame] | 370 | /* underlying fs providing us with an broken xattr list? */ |
| 371 | if (WARN_ON(slen > len)) |
| 372 | return -EIO; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 373 | |
Miklos Szeredi | 7cb3511 | 2016-09-01 11:12:00 +0200 | [diff] [blame] | 374 | len -= slen; |
Miklos Szeredi | a082c6f | 2017-05-29 15:15:27 +0200 | [diff] [blame] | 375 | if (!ovl_can_list(s)) { |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 376 | res -= slen; |
Miklos Szeredi | 7cb3511 | 2016-09-01 11:12:00 +0200 | [diff] [blame] | 377 | memmove(s, s + slen, len); |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 378 | } else { |
Miklos Szeredi | 7cb3511 | 2016-09-01 11:12:00 +0200 | [diff] [blame] | 379 | s += slen; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 380 | } |
| 381 | } |
| 382 | |
| 383 | return res; |
| 384 | } |
| 385 | |
Vivek Goyal | 39a25b2 | 2016-07-01 16:34:26 -0400 | [diff] [blame] | 386 | struct posix_acl *ovl_get_acl(struct inode *inode, int type) |
| 387 | { |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 388 | struct inode *realinode = ovl_inode_real(inode); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 389 | const struct cred *old_cred; |
| 390 | struct posix_acl *acl; |
Vivek Goyal | 39a25b2 | 2016-07-01 16:34:26 -0400 | [diff] [blame] | 391 | |
Miklos Szeredi | 5201dc4 | 2016-09-01 11:11:59 +0200 | [diff] [blame] | 392 | if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !IS_POSIXACL(realinode)) |
Vivek Goyal | 39a25b2 | 2016-07-01 16:34:26 -0400 | [diff] [blame] | 393 | return NULL; |
| 394 | |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 395 | old_cred = ovl_override_creds(inode->i_sb); |
Miklos Szeredi | 5201dc4 | 2016-09-01 11:11:59 +0200 | [diff] [blame] | 396 | acl = get_acl(realinode, type); |
Vivek Goyal | 1175b6b | 2016-07-01 16:34:28 -0400 | [diff] [blame] | 397 | revert_creds(old_cred); |
| 398 | |
| 399 | return acl; |
Vivek Goyal | 39a25b2 | 2016-07-01 16:34:26 -0400 | [diff] [blame] | 400 | } |
| 401 | |
Amir Goldstein | 59be097 | 2017-06-20 15:25:46 +0300 | [diff] [blame] | 402 | static bool ovl_open_need_copy_up(struct dentry *dentry, int flags) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 403 | { |
Amir Goldstein | aa3ff3c | 2017-10-15 18:00:20 +0300 | [diff] [blame] | 404 | /* Copy up of disconnected dentry does not set upper alias */ |
Amir Goldstein | 59be097 | 2017-06-20 15:25:46 +0300 | [diff] [blame] | 405 | if (ovl_dentry_upper(dentry) && |
Amir Goldstein | aa3ff3c | 2017-10-15 18:00:20 +0300 | [diff] [blame] | 406 | (ovl_dentry_has_upper_alias(dentry) || |
| 407 | (dentry->d_flags & DCACHE_DISCONNECTED))) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 408 | return false; |
| 409 | |
Amir Goldstein | 59be097 | 2017-06-20 15:25:46 +0300 | [diff] [blame] | 410 | if (special_file(d_inode(dentry)->i_mode)) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 411 | return false; |
| 412 | |
| 413 | if (!(OPEN_FMODE(flags) & FMODE_WRITE) && !(flags & O_TRUNC)) |
| 414 | return false; |
| 415 | |
| 416 | return true; |
| 417 | } |
| 418 | |
Miklos Szeredi | 2d90267 | 2016-06-30 08:53:27 +0200 | [diff] [blame] | 419 | int ovl_open_maybe_copy_up(struct dentry *dentry, unsigned int file_flags) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 420 | { |
Miklos Szeredi | 2d90267 | 2016-06-30 08:53:27 +0200 | [diff] [blame] | 421 | int err = 0; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 422 | |
Amir Goldstein | 59be097 | 2017-06-20 15:25:46 +0300 | [diff] [blame] | 423 | if (ovl_open_need_copy_up(dentry, file_flags)) { |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 424 | err = ovl_want_write(dentry); |
Miklos Szeredi | 2d90267 | 2016-06-30 08:53:27 +0200 | [diff] [blame] | 425 | if (!err) { |
Amir Goldstein | 9aba652 | 2016-11-12 21:36:03 +0200 | [diff] [blame] | 426 | err = ovl_copy_up_flags(dentry, file_flags); |
Miklos Szeredi | 2d90267 | 2016-06-30 08:53:27 +0200 | [diff] [blame] | 427 | ovl_drop_write(dentry); |
| 428 | } |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 429 | } |
| 430 | |
Miklos Szeredi | 2d90267 | 2016-06-30 08:53:27 +0200 | [diff] [blame] | 431 | return err; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 432 | } |
| 433 | |
Deepa Dinamani | 95582b0 | 2018-05-08 19:36:02 -0700 | [diff] [blame] | 434 | int ovl_update_time(struct inode *inode, struct timespec64 *ts, int flags) |
Miklos Szeredi | d719e8f | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 435 | { |
Miklos Szeredi | 8f35cf5 | 2018-04-12 12:04:50 +0200 | [diff] [blame] | 436 | if (flags & S_ATIME) { |
| 437 | struct ovl_fs *ofs = inode->i_sb->s_fs_info; |
| 438 | struct path upperpath = { |
| 439 | .mnt = ofs->upper_mnt, |
| 440 | .dentry = ovl_upperdentry_dereference(OVL_I(inode)), |
| 441 | }; |
Miklos Szeredi | d719e8f | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 442 | |
Miklos Szeredi | 8f35cf5 | 2018-04-12 12:04:50 +0200 | [diff] [blame] | 443 | if (upperpath.dentry) { |
| 444 | touch_atime(&upperpath); |
| 445 | inode->i_atime = d_inode(upperpath.dentry)->i_atime; |
| 446 | } |
Miklos Szeredi | d719e8f | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 447 | } |
Miklos Szeredi | d719e8f | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 448 | return 0; |
| 449 | } |
| 450 | |
Miklos Szeredi | 9e142c4 | 2018-07-18 15:44:42 +0200 | [diff] [blame^] | 451 | static int ovl_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, |
| 452 | u64 start, u64 len) |
| 453 | { |
| 454 | int err; |
| 455 | struct inode *realinode = ovl_inode_real(inode); |
| 456 | const struct cred *old_cred; |
| 457 | |
| 458 | if (!realinode->i_op->fiemap) |
| 459 | return -EOPNOTSUPP; |
| 460 | |
| 461 | old_cred = ovl_override_creds(inode->i_sb); |
| 462 | err = realinode->i_op->fiemap(realinode, fieinfo, start, len); |
| 463 | revert_creds(old_cred); |
| 464 | |
| 465 | return err; |
| 466 | } |
| 467 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 468 | static const struct inode_operations ovl_file_inode_operations = { |
| 469 | .setattr = ovl_setattr, |
| 470 | .permission = ovl_permission, |
| 471 | .getattr = ovl_getattr, |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 472 | .listxattr = ovl_listxattr, |
Vivek Goyal | 39a25b2 | 2016-07-01 16:34:26 -0400 | [diff] [blame] | 473 | .get_acl = ovl_get_acl, |
Miklos Szeredi | d719e8f | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 474 | .update_time = ovl_update_time, |
Miklos Szeredi | 9e142c4 | 2018-07-18 15:44:42 +0200 | [diff] [blame^] | 475 | .fiemap = ovl_fiemap, |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 476 | }; |
| 477 | |
| 478 | static const struct inode_operations ovl_symlink_inode_operations = { |
| 479 | .setattr = ovl_setattr, |
Al Viro | 6b25539 | 2015-11-17 10:20:54 -0500 | [diff] [blame] | 480 | .get_link = ovl_get_link, |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 481 | .getattr = ovl_getattr, |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 482 | .listxattr = ovl_listxattr, |
Miklos Szeredi | d719e8f | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 483 | .update_time = ovl_update_time, |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 484 | }; |
| 485 | |
Miklos Szeredi | 9e142c4 | 2018-07-18 15:44:42 +0200 | [diff] [blame^] | 486 | static const struct inode_operations ovl_special_inode_operations = { |
| 487 | .setattr = ovl_setattr, |
| 488 | .permission = ovl_permission, |
| 489 | .getattr = ovl_getattr, |
| 490 | .listxattr = ovl_listxattr, |
| 491 | .get_acl = ovl_get_acl, |
| 492 | .update_time = ovl_update_time, |
| 493 | }; |
| 494 | |
Amir Goldstein | b1eaa95 | 2017-01-11 12:07:46 +0200 | [diff] [blame] | 495 | /* |
| 496 | * It is possible to stack overlayfs instance on top of another |
| 497 | * overlayfs instance as lower layer. We need to annonate the |
| 498 | * stackable i_mutex locks according to stack level of the super |
| 499 | * block instance. An overlayfs instance can never be in stack |
| 500 | * depth 0 (there is always a real fs below it). An overlayfs |
| 501 | * inode lock will use the lockdep annotaion ovl_i_mutex_key[depth]. |
| 502 | * |
| 503 | * For example, here is a snip from /proc/lockdep_chains after |
| 504 | * dir_iterate of nested overlayfs: |
| 505 | * |
| 506 | * [...] &ovl_i_mutex_dir_key[depth] (stack_depth=2) |
| 507 | * [...] &ovl_i_mutex_dir_key[depth]#2 (stack_depth=1) |
| 508 | * [...] &type->i_mutex_dir_key (stack_depth=0) |
| 509 | */ |
| 510 | #define OVL_MAX_NESTING FILESYSTEM_MAX_STACK_DEPTH |
| 511 | |
| 512 | static inline void ovl_lockdep_annotate_inode_mutex_key(struct inode *inode) |
| 513 | { |
| 514 | #ifdef CONFIG_LOCKDEP |
| 515 | static struct lock_class_key ovl_i_mutex_key[OVL_MAX_NESTING]; |
| 516 | static struct lock_class_key ovl_i_mutex_dir_key[OVL_MAX_NESTING]; |
Amir Goldstein | 4eae06d | 2017-10-27 15:44:08 +0300 | [diff] [blame] | 517 | static struct lock_class_key ovl_i_lock_key[OVL_MAX_NESTING]; |
Amir Goldstein | b1eaa95 | 2017-01-11 12:07:46 +0200 | [diff] [blame] | 518 | |
| 519 | int depth = inode->i_sb->s_stack_depth - 1; |
| 520 | |
| 521 | if (WARN_ON_ONCE(depth < 0 || depth >= OVL_MAX_NESTING)) |
| 522 | depth = 0; |
| 523 | |
| 524 | if (S_ISDIR(inode->i_mode)) |
| 525 | lockdep_set_class(&inode->i_rwsem, &ovl_i_mutex_dir_key[depth]); |
| 526 | else |
| 527 | lockdep_set_class(&inode->i_rwsem, &ovl_i_mutex_key[depth]); |
Amir Goldstein | 4eae06d | 2017-10-27 15:44:08 +0300 | [diff] [blame] | 528 | |
| 529 | lockdep_set_class(&OVL_I(inode)->lock, &ovl_i_lock_key[depth]); |
Amir Goldstein | b1eaa95 | 2017-01-11 12:07:46 +0200 | [diff] [blame] | 530 | #endif |
| 531 | } |
| 532 | |
Amir Goldstein | 695b46e | 2018-03-15 23:39:01 +0200 | [diff] [blame] | 533 | static void ovl_fill_inode(struct inode *inode, umode_t mode, dev_t rdev, |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 534 | unsigned long ino, int fsid) |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 535 | { |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 536 | int xinobits = ovl_xino_bits(inode->i_sb); |
| 537 | |
Amir Goldstein | 695b46e | 2018-03-15 23:39:01 +0200 | [diff] [blame] | 538 | /* |
| 539 | * When NFS export is enabled and d_ino is consistent with st_ino |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 540 | * (samefs or i_ino has enough bits to encode layer), set the same |
| 541 | * value used for d_ino to i_ino, because nfsd readdirplus compares |
| 542 | * d_ino values to i_ino values of child entries. When called from |
| 543 | * ovl_new_inode(), ino arg is 0, so i_ino will be updated to real |
Amir Goldstein | 695b46e | 2018-03-15 23:39:01 +0200 | [diff] [blame] | 544 | * upper inode i_ino on ovl_inode_init() or ovl_inode_update(). |
| 545 | */ |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 546 | if (inode->i_sb->s_export_op && |
| 547 | (ovl_same_sb(inode->i_sb) || xinobits)) { |
Amir Goldstein | 695b46e | 2018-03-15 23:39:01 +0200 | [diff] [blame] | 548 | inode->i_ino = ino; |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 549 | if (xinobits && fsid && !(ino >> (64 - xinobits))) |
| 550 | inode->i_ino |= (unsigned long)fsid << (64 - xinobits); |
| 551 | } else { |
Amir Goldstein | 695b46e | 2018-03-15 23:39:01 +0200 | [diff] [blame] | 552 | inode->i_ino = get_next_ino(); |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 553 | } |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 554 | inode->i_mode = mode; |
Miklos Szeredi | d719e8f | 2016-07-29 12:05:23 +0200 | [diff] [blame] | 555 | inode->i_flags |= S_NOCMTIME; |
Miklos Szeredi | 2a3a2a3 | 2016-09-01 11:11:59 +0200 | [diff] [blame] | 556 | #ifdef CONFIG_FS_POSIX_ACL |
| 557 | inode->i_acl = inode->i_default_acl = ACL_DONT_CACHE; |
| 558 | #endif |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 559 | |
Amir Goldstein | b1eaa95 | 2017-01-11 12:07:46 +0200 | [diff] [blame] | 560 | ovl_lockdep_annotate_inode_mutex_key(inode); |
| 561 | |
Miklos Szeredi | ca4c8a3 | 2016-12-16 11:02:55 +0100 | [diff] [blame] | 562 | switch (mode & S_IFMT) { |
| 563 | case S_IFREG: |
| 564 | inode->i_op = &ovl_file_inode_operations; |
Miklos Szeredi | d1d04ef | 2018-07-18 15:44:41 +0200 | [diff] [blame] | 565 | inode->i_fop = &ovl_file_operations; |
Miklos Szeredi | ca4c8a3 | 2016-12-16 11:02:55 +0100 | [diff] [blame] | 566 | break; |
| 567 | |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 568 | case S_IFDIR: |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 569 | inode->i_op = &ovl_dir_inode_operations; |
| 570 | inode->i_fop = &ovl_dir_operations; |
| 571 | break; |
| 572 | |
| 573 | case S_IFLNK: |
| 574 | inode->i_op = &ovl_symlink_inode_operations; |
| 575 | break; |
| 576 | |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 577 | default: |
Miklos Szeredi | 9e142c4 | 2018-07-18 15:44:42 +0200 | [diff] [blame^] | 578 | inode->i_op = &ovl_special_inode_operations; |
Miklos Szeredi | ca4c8a3 | 2016-12-16 11:02:55 +0100 | [diff] [blame] | 579 | init_special_inode(inode, mode, rdev); |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 580 | break; |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 581 | } |
| 582 | } |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 583 | |
Amir Goldstein | 5f8415d | 2017-06-20 15:35:14 +0300 | [diff] [blame] | 584 | /* |
| 585 | * With inodes index enabled, an overlay inode nlink counts the union of upper |
| 586 | * hardlinks and non-covered lower hardlinks. During the lifetime of a non-pure |
| 587 | * upper inode, the following nlink modifying operations can happen: |
| 588 | * |
| 589 | * 1. Lower hardlink copy up |
| 590 | * 2. Upper hardlink created, unlinked or renamed over |
| 591 | * 3. Lower hardlink whiteout or renamed over |
| 592 | * |
| 593 | * For the first, copy up case, the union nlink does not change, whether the |
| 594 | * operation succeeds or fails, but the upper inode nlink may change. |
| 595 | * Therefore, before copy up, we store the union nlink value relative to the |
| 596 | * lower inode nlink in the index inode xattr trusted.overlay.nlink. |
| 597 | * |
| 598 | * For the second, upper hardlink case, the union nlink should be incremented |
| 599 | * or decremented IFF the operation succeeds, aligned with nlink change of the |
| 600 | * upper inode. Therefore, before link/unlink/rename, we store the union nlink |
| 601 | * value relative to the upper inode nlink in the index inode. |
| 602 | * |
| 603 | * For the last, lower cover up case, we simplify things by preceding the |
| 604 | * whiteout or cover up with copy up. This makes sure that there is an index |
| 605 | * upper inode where the nlink xattr can be stored before the copied up upper |
| 606 | * entry is unlink. |
| 607 | */ |
| 608 | #define OVL_NLINK_ADD_UPPER (1 << 0) |
| 609 | |
| 610 | /* |
| 611 | * On-disk format for indexed nlink: |
| 612 | * |
| 613 | * nlink relative to the upper inode - "U[+-]NUM" |
| 614 | * nlink relative to the lower inode - "L[+-]NUM" |
| 615 | */ |
| 616 | |
| 617 | static int ovl_set_nlink_common(struct dentry *dentry, |
| 618 | struct dentry *realdentry, const char *format) |
| 619 | { |
| 620 | struct inode *inode = d_inode(dentry); |
| 621 | struct inode *realinode = d_inode(realdentry); |
| 622 | char buf[13]; |
| 623 | int len; |
| 624 | |
| 625 | len = snprintf(buf, sizeof(buf), format, |
| 626 | (int) (inode->i_nlink - realinode->i_nlink)); |
| 627 | |
Miklos Szeredi | 6787341 | 2017-07-27 21:54:05 +0200 | [diff] [blame] | 628 | if (WARN_ON(len >= sizeof(buf))) |
| 629 | return -EIO; |
| 630 | |
Amir Goldstein | 5f8415d | 2017-06-20 15:35:14 +0300 | [diff] [blame] | 631 | return ovl_do_setxattr(ovl_dentry_upper(dentry), |
| 632 | OVL_XATTR_NLINK, buf, len, 0); |
| 633 | } |
| 634 | |
| 635 | int ovl_set_nlink_upper(struct dentry *dentry) |
| 636 | { |
| 637 | return ovl_set_nlink_common(dentry, ovl_dentry_upper(dentry), "U%+i"); |
| 638 | } |
| 639 | |
| 640 | int ovl_set_nlink_lower(struct dentry *dentry) |
| 641 | { |
| 642 | return ovl_set_nlink_common(dentry, ovl_dentry_lower(dentry), "L%+i"); |
| 643 | } |
| 644 | |
Amir Goldstein | caf70cb | 2017-06-21 13:46:12 +0300 | [diff] [blame] | 645 | unsigned int ovl_get_nlink(struct dentry *lowerdentry, |
| 646 | struct dentry *upperdentry, |
| 647 | unsigned int fallback) |
Amir Goldstein | 5f8415d | 2017-06-20 15:35:14 +0300 | [diff] [blame] | 648 | { |
| 649 | int nlink_diff; |
| 650 | int nlink; |
| 651 | char buf[13]; |
| 652 | int err; |
| 653 | |
| 654 | if (!lowerdentry || !upperdentry || d_inode(lowerdentry)->i_nlink == 1) |
| 655 | return fallback; |
| 656 | |
| 657 | err = vfs_getxattr(upperdentry, OVL_XATTR_NLINK, &buf, sizeof(buf) - 1); |
| 658 | if (err < 0) |
| 659 | goto fail; |
| 660 | |
| 661 | buf[err] = '\0'; |
| 662 | if ((buf[0] != 'L' && buf[0] != 'U') || |
| 663 | (buf[1] != '+' && buf[1] != '-')) |
| 664 | goto fail; |
| 665 | |
| 666 | err = kstrtoint(buf + 1, 10, &nlink_diff); |
| 667 | if (err < 0) |
| 668 | goto fail; |
| 669 | |
| 670 | nlink = d_inode(buf[0] == 'L' ? lowerdentry : upperdentry)->i_nlink; |
| 671 | nlink += nlink_diff; |
| 672 | |
| 673 | if (nlink <= 0) |
| 674 | goto fail; |
| 675 | |
| 676 | return nlink; |
| 677 | |
| 678 | fail: |
| 679 | pr_warn_ratelimited("overlayfs: failed to get index nlink (%pd2, err=%i)\n", |
| 680 | upperdentry, err); |
| 681 | return fallback; |
| 682 | } |
| 683 | |
Miklos Szeredi | ca4c8a3 | 2016-12-16 11:02:55 +0100 | [diff] [blame] | 684 | struct inode *ovl_new_inode(struct super_block *sb, umode_t mode, dev_t rdev) |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 685 | { |
| 686 | struct inode *inode; |
| 687 | |
| 688 | inode = new_inode(sb); |
| 689 | if (inode) |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 690 | ovl_fill_inode(inode, mode, rdev, 0, 0); |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 691 | |
| 692 | return inode; |
| 693 | } |
| 694 | |
| 695 | static int ovl_inode_test(struct inode *inode, void *data) |
| 696 | { |
Miklos Szeredi | 25b7713 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 697 | return inode->i_private == data; |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 698 | } |
| 699 | |
| 700 | static int ovl_inode_set(struct inode *inode, void *data) |
| 701 | { |
Miklos Szeredi | 25b7713 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 702 | inode->i_private = data; |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 703 | return 0; |
| 704 | } |
| 705 | |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 706 | static bool ovl_verify_inode(struct inode *inode, struct dentry *lowerdentry, |
Amir Goldstein | 4b91c30 | 2018-01-18 16:39:13 +0200 | [diff] [blame] | 707 | struct dentry *upperdentry, bool strict) |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 708 | { |
Amir Goldstein | 4b91c30 | 2018-01-18 16:39:13 +0200 | [diff] [blame] | 709 | /* |
| 710 | * For directories, @strict verify from lookup path performs consistency |
| 711 | * checks, so NULL lower/upper in dentry must match NULL lower/upper in |
| 712 | * inode. Non @strict verify from NFS handle decode path passes NULL for |
| 713 | * 'unknown' lower/upper. |
| 714 | */ |
| 715 | if (S_ISDIR(inode->i_mode) && strict) { |
Amir Goldstein | 31747ed | 2018-01-14 18:35:40 +0200 | [diff] [blame] | 716 | /* Real lower dir moved to upper layer under us? */ |
| 717 | if (!lowerdentry && ovl_inode_lower(inode)) |
| 718 | return false; |
| 719 | |
| 720 | /* Lookup of an uncovered redirect origin? */ |
| 721 | if (!upperdentry && ovl_inode_upper(inode)) |
| 722 | return false; |
| 723 | } |
| 724 | |
Amir Goldstein | 939ae4e | 2017-09-11 16:30:15 +0300 | [diff] [blame] | 725 | /* |
| 726 | * Allow non-NULL lower inode in ovl_inode even if lowerdentry is NULL. |
| 727 | * This happens when finding a copied up overlay inode for a renamed |
| 728 | * or hardlinked overlay dentry and lower dentry cannot be followed |
| 729 | * by origin because lower fs does not support file handles. |
| 730 | */ |
| 731 | if (lowerdentry && ovl_inode_lower(inode) != d_inode(lowerdentry)) |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 732 | return false; |
| 733 | |
| 734 | /* |
| 735 | * Allow non-NULL __upperdentry in inode even if upperdentry is NULL. |
| 736 | * This happens when finding a lower alias for a copied up hard link. |
| 737 | */ |
| 738 | if (upperdentry && ovl_inode_upper(inode) != d_inode(upperdentry)) |
| 739 | return false; |
| 740 | |
| 741 | return true; |
| 742 | } |
| 743 | |
Amir Goldstein | 4b91c30 | 2018-01-18 16:39:13 +0200 | [diff] [blame] | 744 | struct inode *ovl_lookup_inode(struct super_block *sb, struct dentry *real, |
| 745 | bool is_upper) |
Amir Goldstein | 9436a1a | 2017-12-24 18:28:04 +0200 | [diff] [blame] | 746 | { |
Amir Goldstein | 4b91c30 | 2018-01-18 16:39:13 +0200 | [diff] [blame] | 747 | struct inode *inode, *key = d_inode(real); |
Amir Goldstein | 9436a1a | 2017-12-24 18:28:04 +0200 | [diff] [blame] | 748 | |
| 749 | inode = ilookup5(sb, (unsigned long) key, ovl_inode_test, key); |
| 750 | if (!inode) |
| 751 | return NULL; |
| 752 | |
Amir Goldstein | 4b91c30 | 2018-01-18 16:39:13 +0200 | [diff] [blame] | 753 | if (!ovl_verify_inode(inode, is_upper ? NULL : real, |
| 754 | is_upper ? real : NULL, false)) { |
Amir Goldstein | 9436a1a | 2017-12-24 18:28:04 +0200 | [diff] [blame] | 755 | iput(inode); |
| 756 | return ERR_PTR(-ESTALE); |
| 757 | } |
| 758 | |
| 759 | return inode; |
| 760 | } |
| 761 | |
Amir Goldstein | 764baba | 2018-02-04 15:35:09 +0200 | [diff] [blame] | 762 | /* |
| 763 | * Does overlay inode need to be hashed by lower inode? |
| 764 | */ |
| 765 | static bool ovl_hash_bylower(struct super_block *sb, struct dentry *upper, |
| 766 | struct dentry *lower, struct dentry *index) |
| 767 | { |
| 768 | struct ovl_fs *ofs = sb->s_fs_info; |
| 769 | |
| 770 | /* No, if pure upper */ |
| 771 | if (!lower) |
| 772 | return false; |
| 773 | |
| 774 | /* Yes, if already indexed */ |
| 775 | if (index) |
| 776 | return true; |
| 777 | |
| 778 | /* Yes, if won't be copied up */ |
| 779 | if (!ofs->upper_mnt) |
| 780 | return true; |
| 781 | |
| 782 | /* No, if lower hardlink is or will be broken on copy up */ |
| 783 | if ((upper || !ovl_indexdir(sb)) && |
| 784 | !d_is_dir(lower) && d_inode(lower)->i_nlink > 1) |
| 785 | return false; |
| 786 | |
| 787 | /* No, if non-indexed upper with NFS export */ |
| 788 | if (sb->s_export_op && upper) |
| 789 | return false; |
| 790 | |
| 791 | /* Otherwise, hash by lower inode for fsnotify */ |
| 792 | return true; |
| 793 | } |
| 794 | |
Amir Goldstein | 01b39dc | 2018-05-11 11:15:15 +0300 | [diff] [blame] | 795 | static struct inode *ovl_iget5(struct super_block *sb, struct inode *newinode, |
| 796 | struct inode *key) |
| 797 | { |
| 798 | return newinode ? inode_insert5(newinode, (unsigned long) key, |
| 799 | ovl_inode_test, ovl_inode_set, key) : |
| 800 | iget5_locked(sb, (unsigned long) key, |
| 801 | ovl_inode_test, ovl_inode_set, key); |
| 802 | } |
| 803 | |
Vivek Goyal | ac6a52e | 2018-05-08 09:27:21 -0400 | [diff] [blame] | 804 | struct inode *ovl_get_inode(struct super_block *sb, |
| 805 | struct ovl_inode_params *oip) |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 806 | { |
Vivek Goyal | ac6a52e | 2018-05-08 09:27:21 -0400 | [diff] [blame] | 807 | struct dentry *upperdentry = oip->upperdentry; |
| 808 | struct ovl_path *lowerpath = oip->lowerpath; |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 809 | struct inode *realinode = upperdentry ? d_inode(upperdentry) : NULL; |
Miklos Szeredi | 51f7e52 | 2016-07-29 12:05:24 +0200 | [diff] [blame] | 810 | struct inode *inode; |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 811 | struct dentry *lowerdentry = lowerpath ? lowerpath->dentry : NULL; |
Vivek Goyal | ac6a52e | 2018-05-08 09:27:21 -0400 | [diff] [blame] | 812 | bool bylower = ovl_hash_bylower(sb, upperdentry, lowerdentry, |
| 813 | oip->index); |
| 814 | int fsid = bylower ? oip->lowerpath->layer->fsid : 0; |
Amir Goldstein | 31747ed | 2018-01-14 18:35:40 +0200 | [diff] [blame] | 815 | bool is_dir; |
Amir Goldstein | 695b46e | 2018-03-15 23:39:01 +0200 | [diff] [blame] | 816 | unsigned long ino = 0; |
Amir Goldstein | 6eaf011 | 2017-10-12 19:03:04 +0300 | [diff] [blame] | 817 | |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 818 | if (!realinode) |
| 819 | realinode = d_inode(lowerdentry); |
| 820 | |
Amir Goldstein | 6eaf011 | 2017-10-12 19:03:04 +0300 | [diff] [blame] | 821 | /* |
Amir Goldstein | 764baba | 2018-02-04 15:35:09 +0200 | [diff] [blame] | 822 | * Copy up origin (lower) may exist for non-indexed upper, but we must |
| 823 | * not use lower as hash key if this is a broken hardlink. |
Amir Goldstein | 6eaf011 | 2017-10-12 19:03:04 +0300 | [diff] [blame] | 824 | */ |
Amir Goldstein | 31747ed | 2018-01-14 18:35:40 +0200 | [diff] [blame] | 825 | is_dir = S_ISDIR(realinode->i_mode); |
Amir Goldstein | 764baba | 2018-02-04 15:35:09 +0200 | [diff] [blame] | 826 | if (upperdentry || bylower) { |
| 827 | struct inode *key = d_inode(bylower ? lowerdentry : |
| 828 | upperdentry); |
Amir Goldstein | 31747ed | 2018-01-14 18:35:40 +0200 | [diff] [blame] | 829 | unsigned int nlink = is_dir ? 1 : realinode->i_nlink; |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 830 | |
Amir Goldstein | 01b39dc | 2018-05-11 11:15:15 +0300 | [diff] [blame] | 831 | inode = ovl_iget5(sb, oip->newinode, key); |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 832 | if (!inode) |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 833 | goto out_nomem; |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 834 | if (!(inode->i_state & I_NEW)) { |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 835 | /* |
| 836 | * Verify that the underlying files stored in the inode |
| 837 | * match those in the dentry. |
| 838 | */ |
Amir Goldstein | 4b91c30 | 2018-01-18 16:39:13 +0200 | [diff] [blame] | 839 | if (!ovl_verify_inode(inode, lowerdentry, upperdentry, |
| 840 | true)) { |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 841 | iput(inode); |
| 842 | inode = ERR_PTR(-ESTALE); |
| 843 | goto out; |
| 844 | } |
| 845 | |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 846 | dput(upperdentry); |
| 847 | goto out; |
| 848 | } |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 849 | |
Amir Goldstein | 31747ed | 2018-01-14 18:35:40 +0200 | [diff] [blame] | 850 | /* Recalculate nlink for non-dir due to indexing */ |
| 851 | if (!is_dir) |
| 852 | nlink = ovl_get_nlink(lowerdentry, upperdentry, nlink); |
Amir Goldstein | 5f8415d | 2017-06-20 15:35:14 +0300 | [diff] [blame] | 853 | set_nlink(inode, nlink); |
Amir Goldstein | 695b46e | 2018-03-15 23:39:01 +0200 | [diff] [blame] | 854 | ino = key->i_ino; |
Miklos Szeredi | e6d2ebd | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 855 | } else { |
Amir Goldstein | 764baba | 2018-02-04 15:35:09 +0200 | [diff] [blame] | 856 | /* Lower hardlink that will be broken on copy up */ |
Amir Goldstein | 0aceb53 | 2017-12-12 23:43:16 +0200 | [diff] [blame] | 857 | inode = new_inode(sb); |
Miklos Szeredi | e6d2ebd | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 858 | if (!inode) |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 859 | goto out_nomem; |
Miklos Szeredi | e6d2ebd | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 860 | } |
Amir Goldstein | 12574a9 | 2018-03-16 10:39:37 +0200 | [diff] [blame] | 861 | ovl_fill_inode(inode, realinode->i_mode, realinode->i_rdev, ino, fsid); |
Miklos Szeredi | 09d8b58 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 862 | ovl_inode_init(inode, upperdentry, lowerdentry); |
Miklos Szeredi | 13c7207 | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 863 | |
| 864 | if (upperdentry && ovl_is_impuredir(upperdentry)) |
| 865 | ovl_set_flag(OVL_IMPURE, inode); |
| 866 | |
Vivek Goyal | ac6a52e | 2018-05-08 09:27:21 -0400 | [diff] [blame] | 867 | if (oip->index) |
Vivek Goyal | 0471a9c | 2018-03-20 16:35:40 -0400 | [diff] [blame] | 868 | ovl_set_flag(OVL_INDEX, inode); |
| 869 | |
Amir Goldstein | b79e05a | 2017-06-25 16:37:17 +0300 | [diff] [blame] | 870 | /* Check for non-merge dir that may have whiteouts */ |
Amir Goldstein | 31747ed | 2018-01-14 18:35:40 +0200 | [diff] [blame] | 871 | if (is_dir) { |
Vivek Goyal | ac6a52e | 2018-05-08 09:27:21 -0400 | [diff] [blame] | 872 | if (((upperdentry && lowerdentry) || oip->numlower > 1) || |
Amir Goldstein | b79e05a | 2017-06-25 16:37:17 +0300 | [diff] [blame] | 873 | ovl_check_origin_xattr(upperdentry ?: lowerdentry)) { |
| 874 | ovl_set_flag(OVL_WHITEOUTS, inode); |
| 875 | } |
| 876 | } |
| 877 | |
Miklos Szeredi | e6d2ebd | 2017-07-04 22:03:16 +0200 | [diff] [blame] | 878 | if (inode->i_state & I_NEW) |
| 879 | unlock_new_inode(inode); |
| 880 | out: |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 881 | return inode; |
Miklos Szeredi | b9ac5c27 | 2017-07-04 22:03:17 +0200 | [diff] [blame] | 882 | |
| 883 | out_nomem: |
| 884 | inode = ERR_PTR(-ENOMEM); |
| 885 | goto out; |
Miklos Szeredi | e9be9d5 | 2014-10-24 00:14:38 +0200 | [diff] [blame] | 886 | } |