Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 1 | /* |
Jubin John | 05d6ac1 | 2016-02-14 20:22:17 -0800 | [diff] [blame] | 2 | * Copyright(c) 2015, 2016 Intel Corporation. |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 3 | * |
| 4 | * This file is provided under a dual BSD/GPLv2 license. When using or |
| 5 | * redistributing this file, you may do so under either license. |
| 6 | * |
| 7 | * GPL LICENSE SUMMARY |
| 8 | * |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 9 | * This program is free software; you can redistribute it and/or modify |
| 10 | * it under the terms of version 2 of the GNU General Public License as |
| 11 | * published by the Free Software Foundation. |
| 12 | * |
| 13 | * This program is distributed in the hope that it will be useful, but |
| 14 | * WITHOUT ANY WARRANTY; without even the implied warranty of |
| 15 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
| 16 | * General Public License for more details. |
| 17 | * |
| 18 | * BSD LICENSE |
| 19 | * |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 20 | * Redistribution and use in source and binary forms, with or without |
| 21 | * modification, are permitted provided that the following conditions |
| 22 | * are met: |
| 23 | * |
| 24 | * - Redistributions of source code must retain the above copyright |
| 25 | * notice, this list of conditions and the following disclaimer. |
| 26 | * - Redistributions in binary form must reproduce the above copyright |
| 27 | * notice, this list of conditions and the following disclaimer in |
| 28 | * the documentation and/or other materials provided with the |
| 29 | * distribution. |
| 30 | * - Neither the name of Intel Corporation nor the names of its |
| 31 | * contributors may be used to endorse or promote products derived |
| 32 | * from this software without specific prior written permission. |
| 33 | * |
| 34 | * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
| 35 | * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
| 36 | * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
| 37 | * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
| 38 | * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
| 39 | * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
| 40 | * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
| 41 | * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
| 42 | * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 43 | * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 44 | * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 45 | * |
| 46 | */ |
| 47 | #include <linux/topology.h> |
| 48 | #include <linux/cpumask.h> |
| 49 | #include <linux/module.h> |
| 50 | |
| 51 | #include "hfi.h" |
| 52 | #include "affinity.h" |
| 53 | #include "sdma.h" |
| 54 | #include "trace.h" |
| 55 | |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 56 | struct hfi1_affinity_node_list node_affinity = { |
| 57 | .list = LIST_HEAD_INIT(node_affinity.list), |
| 58 | .lock = __SPIN_LOCK_UNLOCKED(&node_affinity.lock), |
| 59 | }; |
| 60 | |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 61 | /* Name of IRQ types, indexed by enum irq_type */ |
| 62 | static const char * const irq_type_names[] = { |
| 63 | "SDMA", |
| 64 | "RCVCTXT", |
| 65 | "GENERAL", |
| 66 | "OTHER", |
| 67 | }; |
| 68 | |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 69 | /* Per NUMA node count of HFI devices */ |
| 70 | static unsigned int *hfi1_per_node_cntr; |
| 71 | |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 72 | static inline void init_cpu_mask_set(struct cpu_mask_set *set) |
| 73 | { |
| 74 | cpumask_clear(&set->mask); |
| 75 | cpumask_clear(&set->used); |
| 76 | set->gen = 0; |
| 77 | } |
| 78 | |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 79 | /* Initialize non-HT cpu cores mask */ |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 80 | void init_real_cpu_mask(void) |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 81 | { |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 82 | int possible, curr_cpu, i, ht; |
| 83 | |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 84 | cpumask_clear(&node_affinity.real_cpu_mask); |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 85 | |
| 86 | /* Start with cpu online mask as the real cpu mask */ |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 87 | cpumask_copy(&node_affinity.real_cpu_mask, cpu_online_mask); |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 88 | |
| 89 | /* |
| 90 | * Remove HT cores from the real cpu mask. Do this in two steps below. |
| 91 | */ |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 92 | possible = cpumask_weight(&node_affinity.real_cpu_mask); |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 93 | ht = cpumask_weight(topology_sibling_cpumask( |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 94 | cpumask_first(&node_affinity.real_cpu_mask))); |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 95 | /* |
| 96 | * Step 1. Skip over the first N HT siblings and use them as the |
| 97 | * "real" cores. Assumes that HT cores are not enumerated in |
| 98 | * succession (except in the single core case). |
| 99 | */ |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 100 | curr_cpu = cpumask_first(&node_affinity.real_cpu_mask); |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 101 | for (i = 0; i < possible / ht; i++) |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 102 | curr_cpu = cpumask_next(curr_cpu, &node_affinity.real_cpu_mask); |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 103 | /* |
| 104 | * Step 2. Remove the remaining HT siblings. Use cpumask_next() to |
| 105 | * skip any gaps. |
| 106 | */ |
| 107 | for (; i < possible; i++) { |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 108 | cpumask_clear_cpu(curr_cpu, &node_affinity.real_cpu_mask); |
| 109 | curr_cpu = cpumask_next(curr_cpu, &node_affinity.real_cpu_mask); |
| 110 | } |
| 111 | } |
| 112 | |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 113 | int node_affinity_init(void) |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 114 | { |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 115 | int node; |
| 116 | struct pci_dev *dev = NULL; |
| 117 | const struct pci_device_id *ids = hfi1_pci_tbl; |
| 118 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 119 | cpumask_clear(&node_affinity.proc.used); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 120 | cpumask_copy(&node_affinity.proc.mask, cpu_online_mask); |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 121 | |
| 122 | node_affinity.proc.gen = 0; |
| 123 | node_affinity.num_core_siblings = |
| 124 | cpumask_weight(topology_sibling_cpumask( |
| 125 | cpumask_first(&node_affinity.proc.mask) |
| 126 | )); |
| 127 | node_affinity.num_online_nodes = num_online_nodes(); |
| 128 | node_affinity.num_online_cpus = num_online_cpus(); |
| 129 | |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 130 | /* |
| 131 | * The real cpu mask is part of the affinity struct but it has to be |
| 132 | * initialized early. It is needed to calculate the number of user |
| 133 | * contexts in set_up_context_variables(). |
| 134 | */ |
| 135 | init_real_cpu_mask(); |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 136 | |
| 137 | hfi1_per_node_cntr = kcalloc(num_possible_nodes(), |
| 138 | sizeof(*hfi1_per_node_cntr), GFP_KERNEL); |
| 139 | if (!hfi1_per_node_cntr) |
| 140 | return -ENOMEM; |
| 141 | |
| 142 | while (ids->vendor) { |
| 143 | dev = NULL; |
| 144 | while ((dev = pci_get_device(ids->vendor, ids->device, dev))) { |
| 145 | node = pcibus_to_node(dev->bus); |
| 146 | if (node < 0) |
| 147 | node = numa_node_id(); |
| 148 | |
| 149 | hfi1_per_node_cntr[node]++; |
| 150 | } |
| 151 | ids++; |
| 152 | } |
| 153 | |
| 154 | return 0; |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 155 | } |
| 156 | |
| 157 | void node_affinity_destroy(void) |
| 158 | { |
| 159 | struct list_head *pos, *q; |
| 160 | struct hfi1_affinity_node *entry; |
| 161 | |
| 162 | spin_lock(&node_affinity.lock); |
| 163 | list_for_each_safe(pos, q, &node_affinity.list) { |
| 164 | entry = list_entry(pos, struct hfi1_affinity_node, |
| 165 | list); |
| 166 | list_del(pos); |
| 167 | kfree(entry); |
| 168 | } |
| 169 | spin_unlock(&node_affinity.lock); |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 170 | kfree(hfi1_per_node_cntr); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 171 | } |
| 172 | |
| 173 | static struct hfi1_affinity_node *node_affinity_allocate(int node) |
| 174 | { |
| 175 | struct hfi1_affinity_node *entry; |
| 176 | |
| 177 | entry = kzalloc(sizeof(*entry), GFP_KERNEL); |
| 178 | if (!entry) |
| 179 | return NULL; |
| 180 | entry->node = node; |
| 181 | INIT_LIST_HEAD(&entry->list); |
| 182 | |
| 183 | return entry; |
| 184 | } |
| 185 | |
| 186 | /* |
| 187 | * It appends an entry to the list. |
| 188 | * It *must* be called with node_affinity.lock held. |
| 189 | */ |
| 190 | static void node_affinity_add_tail(struct hfi1_affinity_node *entry) |
| 191 | { |
| 192 | list_add_tail(&entry->list, &node_affinity.list); |
| 193 | } |
| 194 | |
| 195 | /* It must be called with node_affinity.lock held */ |
| 196 | static struct hfi1_affinity_node *node_affinity_lookup(int node) |
| 197 | { |
| 198 | struct list_head *pos; |
| 199 | struct hfi1_affinity_node *entry; |
| 200 | |
| 201 | list_for_each(pos, &node_affinity.list) { |
| 202 | entry = list_entry(pos, struct hfi1_affinity_node, list); |
| 203 | if (entry->node == node) |
| 204 | return entry; |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 205 | } |
| 206 | |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 207 | return NULL; |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 208 | } |
| 209 | |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 210 | /* |
| 211 | * Interrupt affinity. |
| 212 | * |
| 213 | * non-rcv avail gets a default mask that |
| 214 | * starts as possible cpus with threads reset |
| 215 | * and each rcv avail reset. |
| 216 | * |
| 217 | * rcv avail gets node relative 1 wrapping back |
| 218 | * to the node relative 1 as necessary. |
| 219 | * |
| 220 | */ |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 221 | int hfi1_dev_affinity_init(struct hfi1_devdata *dd) |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 222 | { |
| 223 | int node = pcibus_to_node(dd->pcidev->bus); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 224 | struct hfi1_affinity_node *entry; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 225 | const struct cpumask *local_mask; |
Jubin John | 0852d24 | 2016-04-12 11:30:08 -0700 | [diff] [blame] | 226 | int curr_cpu, possible, i; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 227 | |
| 228 | if (node < 0) |
| 229 | node = numa_node_id(); |
| 230 | dd->node = node; |
| 231 | |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 232 | local_mask = cpumask_of_node(dd->node); |
| 233 | if (cpumask_first(local_mask) >= nr_cpu_ids) |
| 234 | local_mask = topology_core_cpumask(0); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 235 | |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 236 | spin_lock(&node_affinity.lock); |
| 237 | entry = node_affinity_lookup(dd->node); |
| 238 | spin_unlock(&node_affinity.lock); |
| 239 | |
| 240 | /* |
| 241 | * If this is the first time this NUMA node's affinity is used, |
| 242 | * create an entry in the global affinity structure and initialize it. |
| 243 | */ |
| 244 | if (!entry) { |
| 245 | entry = node_affinity_allocate(node); |
| 246 | if (!entry) { |
| 247 | dd_dev_err(dd, |
| 248 | "Unable to allocate global affinity node\n"); |
| 249 | return -ENOMEM; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 250 | } |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 251 | init_cpu_mask_set(&entry->def_intr); |
| 252 | init_cpu_mask_set(&entry->rcv_intr); |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 253 | cpumask_clear(&entry->general_intr_mask); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 254 | /* Use the "real" cpu mask of this node as the default */ |
| 255 | cpumask_and(&entry->def_intr.mask, &node_affinity.real_cpu_mask, |
| 256 | local_mask); |
| 257 | |
| 258 | /* fill in the receive list */ |
| 259 | possible = cpumask_weight(&entry->def_intr.mask); |
| 260 | curr_cpu = cpumask_first(&entry->def_intr.mask); |
| 261 | |
| 262 | if (possible == 1) { |
| 263 | /* only one CPU, everyone will use it */ |
| 264 | cpumask_set_cpu(curr_cpu, &entry->rcv_intr.mask); |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 265 | cpumask_set_cpu(curr_cpu, &entry->general_intr_mask); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 266 | } else { |
| 267 | /* |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 268 | * The general/control context will be the first CPU in |
| 269 | * the default list, so it is removed from the default |
| 270 | * list and added to the general interrupt list. |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 271 | */ |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 272 | cpumask_clear_cpu(curr_cpu, &entry->def_intr.mask); |
| 273 | cpumask_set_cpu(curr_cpu, &entry->general_intr_mask); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 274 | curr_cpu = cpumask_next(curr_cpu, |
| 275 | &entry->def_intr.mask); |
| 276 | |
| 277 | /* |
| 278 | * Remove the remaining kernel receive queues from |
| 279 | * the default list and add them to the receive list. |
| 280 | */ |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 281 | for (i = 0; |
| 282 | i < (dd->n_krcv_queues - 1) * |
| 283 | hfi1_per_node_cntr[dd->node]; |
| 284 | i++) { |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 285 | cpumask_clear_cpu(curr_cpu, |
| 286 | &entry->def_intr.mask); |
| 287 | cpumask_set_cpu(curr_cpu, |
| 288 | &entry->rcv_intr.mask); |
| 289 | curr_cpu = cpumask_next(curr_cpu, |
| 290 | &entry->def_intr.mask); |
| 291 | if (curr_cpu >= nr_cpu_ids) |
| 292 | break; |
| 293 | } |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 294 | |
| 295 | /* |
| 296 | * If there ends up being 0 CPU cores leftover for SDMA |
| 297 | * engines, use the same CPU cores as general/control |
| 298 | * context. |
| 299 | */ |
| 300 | if (cpumask_weight(&entry->def_intr.mask) == 0) |
| 301 | cpumask_copy(&entry->def_intr.mask, |
| 302 | &entry->general_intr_mask); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 303 | } |
| 304 | |
| 305 | spin_lock(&node_affinity.lock); |
| 306 | node_affinity_add_tail(entry); |
| 307 | spin_unlock(&node_affinity.lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 308 | } |
| 309 | |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 310 | return 0; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 311 | } |
| 312 | |
| 313 | int hfi1_get_irq_affinity(struct hfi1_devdata *dd, struct hfi1_msix_entry *msix) |
| 314 | { |
| 315 | int ret; |
| 316 | cpumask_var_t diff; |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 317 | struct hfi1_affinity_node *entry; |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 318 | struct cpu_mask_set *set = NULL; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 319 | struct sdma_engine *sde = NULL; |
| 320 | struct hfi1_ctxtdata *rcd = NULL; |
| 321 | char extra[64]; |
| 322 | int cpu = -1; |
| 323 | |
| 324 | extra[0] = '\0'; |
| 325 | cpumask_clear(&msix->mask); |
| 326 | |
| 327 | ret = zalloc_cpumask_var(&diff, GFP_KERNEL); |
| 328 | if (!ret) |
| 329 | return -ENOMEM; |
| 330 | |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 331 | spin_lock(&node_affinity.lock); |
| 332 | entry = node_affinity_lookup(dd->node); |
| 333 | spin_unlock(&node_affinity.lock); |
| 334 | |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 335 | switch (msix->type) { |
| 336 | case IRQ_SDMA: |
| 337 | sde = (struct sdma_engine *)msix->arg; |
| 338 | scnprintf(extra, 64, "engine %u", sde->this_idx); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 339 | set = &entry->def_intr; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 340 | break; |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 341 | case IRQ_GENERAL: |
| 342 | cpu = cpumask_first(&entry->general_intr_mask); |
| 343 | break; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 344 | case IRQ_RCVCTXT: |
| 345 | rcd = (struct hfi1_ctxtdata *)msix->arg; |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 346 | if (rcd->ctxt == HFI1_CTRL_CTXT) |
| 347 | cpu = cpumask_first(&entry->general_intr_mask); |
| 348 | else |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 349 | set = &entry->rcv_intr; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 350 | scnprintf(extra, 64, "ctxt %u", rcd->ctxt); |
| 351 | break; |
| 352 | default: |
| 353 | dd_dev_err(dd, "Invalid IRQ type %d\n", msix->type); |
| 354 | return -EINVAL; |
| 355 | } |
| 356 | |
| 357 | /* |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 358 | * The general and control contexts are placed on a particular |
| 359 | * CPU, which is set above. Skip accounting for it. Everything else |
| 360 | * finds its CPU here. |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 361 | */ |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 362 | if (cpu == -1 && set) { |
| 363 | spin_lock(&node_affinity.lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 364 | if (cpumask_equal(&set->mask, &set->used)) { |
| 365 | /* |
| 366 | * We've used up all the CPUs, bump up the generation |
| 367 | * and reset the 'used' map |
| 368 | */ |
| 369 | set->gen++; |
| 370 | cpumask_clear(&set->used); |
| 371 | } |
| 372 | cpumask_andnot(diff, &set->mask, &set->used); |
| 373 | cpu = cpumask_first(diff); |
| 374 | cpumask_set_cpu(cpu, &set->used); |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 375 | spin_unlock(&node_affinity.lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 376 | } |
| 377 | |
| 378 | switch (msix->type) { |
| 379 | case IRQ_SDMA: |
| 380 | sde->cpu = cpu; |
| 381 | break; |
| 382 | case IRQ_GENERAL: |
| 383 | case IRQ_RCVCTXT: |
| 384 | case IRQ_OTHER: |
| 385 | break; |
| 386 | } |
| 387 | |
| 388 | cpumask_set_cpu(cpu, &msix->mask); |
| 389 | dd_dev_info(dd, "IRQ vector: %u, type %s %s -> cpu: %d\n", |
| 390 | msix->msix.vector, irq_type_names[msix->type], |
| 391 | extra, cpu); |
| 392 | irq_set_affinity_hint(msix->msix.vector, &msix->mask); |
| 393 | |
| 394 | free_cpumask_var(diff); |
| 395 | return 0; |
| 396 | } |
| 397 | |
| 398 | void hfi1_put_irq_affinity(struct hfi1_devdata *dd, |
| 399 | struct hfi1_msix_entry *msix) |
| 400 | { |
| 401 | struct cpu_mask_set *set = NULL; |
| 402 | struct hfi1_ctxtdata *rcd; |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 403 | struct hfi1_affinity_node *entry; |
| 404 | |
| 405 | spin_lock(&node_affinity.lock); |
| 406 | entry = node_affinity_lookup(dd->node); |
| 407 | spin_unlock(&node_affinity.lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 408 | |
| 409 | switch (msix->type) { |
| 410 | case IRQ_SDMA: |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 411 | set = &entry->def_intr; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 412 | break; |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 413 | case IRQ_GENERAL: |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 414 | /* Don't do accounting for general contexts */ |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 415 | break; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 416 | case IRQ_RCVCTXT: |
| 417 | rcd = (struct hfi1_ctxtdata *)msix->arg; |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 418 | /* Don't do accounting for control contexts */ |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 419 | if (rcd->ctxt != HFI1_CTRL_CTXT) |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 420 | set = &entry->rcv_intr; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 421 | break; |
| 422 | default: |
| 423 | return; |
| 424 | } |
| 425 | |
| 426 | if (set) { |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 427 | spin_lock(&node_affinity.lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 428 | cpumask_andnot(&set->used, &set->used, &msix->mask); |
| 429 | if (cpumask_empty(&set->used) && set->gen) { |
| 430 | set->gen--; |
| 431 | cpumask_copy(&set->used, &set->mask); |
| 432 | } |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 433 | spin_unlock(&node_affinity.lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 434 | } |
| 435 | |
| 436 | irq_set_affinity_hint(msix->msix.vector, NULL); |
| 437 | cpumask_clear(&msix->mask); |
| 438 | } |
| 439 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 440 | /* This should be called with node_affinity.lock held */ |
| 441 | static void find_hw_thread_mask(uint hw_thread_no, cpumask_var_t hw_thread_mask, |
| 442 | struct hfi1_affinity_node_list *affinity) |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 443 | { |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 444 | int possible, curr_cpu, i; |
| 445 | uint num_cores_per_socket = node_affinity.num_online_cpus / |
| 446 | affinity->num_core_siblings / |
| 447 | node_affinity.num_online_nodes; |
| 448 | |
| 449 | cpumask_copy(hw_thread_mask, &affinity->proc.mask); |
| 450 | if (affinity->num_core_siblings > 0) { |
| 451 | /* Removing other siblings not needed for now */ |
| 452 | possible = cpumask_weight(hw_thread_mask); |
| 453 | curr_cpu = cpumask_first(hw_thread_mask); |
| 454 | for (i = 0; |
| 455 | i < num_cores_per_socket * node_affinity.num_online_nodes; |
| 456 | i++) |
| 457 | curr_cpu = cpumask_next(curr_cpu, hw_thread_mask); |
| 458 | |
| 459 | for (; i < possible; i++) { |
| 460 | cpumask_clear_cpu(curr_cpu, hw_thread_mask); |
| 461 | curr_cpu = cpumask_next(curr_cpu, hw_thread_mask); |
| 462 | } |
| 463 | |
| 464 | /* Identifying correct HW threads within physical cores */ |
| 465 | cpumask_shift_left(hw_thread_mask, hw_thread_mask, |
| 466 | num_cores_per_socket * |
| 467 | node_affinity.num_online_nodes * |
| 468 | hw_thread_no); |
| 469 | } |
| 470 | } |
| 471 | |
| 472 | int hfi1_get_proc_affinity(int node) |
| 473 | { |
| 474 | int cpu = -1, ret, i; |
Dennis Dalessandro | 4197344 | 2016-07-25 07:52:36 -0700 | [diff] [blame] | 475 | struct hfi1_affinity_node *entry; |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 476 | cpumask_var_t diff, hw_thread_mask, available_mask, intrs_mask; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 477 | const struct cpumask *node_mask, |
| 478 | *proc_mask = tsk_cpus_allowed(current); |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 479 | struct hfi1_affinity_node_list *affinity = &node_affinity; |
| 480 | struct cpu_mask_set *set = &affinity->proc; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 481 | |
| 482 | /* |
| 483 | * check whether process/context affinity has already |
| 484 | * been set |
| 485 | */ |
| 486 | if (cpumask_weight(proc_mask) == 1) { |
Leon Romanovsky | f242d93a | 2016-05-31 10:54:36 +0300 | [diff] [blame] | 487 | hfi1_cdbg(PROC, "PID %u %s affinity set to CPU %*pbl", |
| 488 | current->pid, current->comm, |
| 489 | cpumask_pr_args(proc_mask)); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 490 | /* |
| 491 | * Mark the pre-set CPU as used. This is atomic so we don't |
| 492 | * need the lock |
| 493 | */ |
| 494 | cpu = cpumask_first(proc_mask); |
| 495 | cpumask_set_cpu(cpu, &set->used); |
| 496 | goto done; |
| 497 | } else if (cpumask_weight(proc_mask) < cpumask_weight(&set->mask)) { |
Leon Romanovsky | f242d93a | 2016-05-31 10:54:36 +0300 | [diff] [blame] | 498 | hfi1_cdbg(PROC, "PID %u %s affinity set to CPU set(s) %*pbl", |
| 499 | current->pid, current->comm, |
| 500 | cpumask_pr_args(proc_mask)); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 501 | goto done; |
| 502 | } |
| 503 | |
| 504 | /* |
| 505 | * The process does not have a preset CPU affinity so find one to |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 506 | * recommend using the following algorithm: |
| 507 | * |
| 508 | * For each user process that is opening a context on HFI Y: |
| 509 | * a) If all cores are filled, reinitialize the bitmask |
| 510 | * b) Fill real cores first, then HT cores (First set of HT |
| 511 | * cores on all physical cores, then second set of HT core, |
| 512 | * and, so on) in the following order: |
| 513 | * |
| 514 | * 1. Same NUMA node as HFI Y and not running an IRQ |
| 515 | * handler |
| 516 | * 2. Same NUMA node as HFI Y and running an IRQ handler |
| 517 | * 3. Different NUMA node to HFI Y and not running an IRQ |
| 518 | * handler |
| 519 | * 4. Different NUMA node to HFI Y and running an IRQ |
| 520 | * handler |
| 521 | * c) Mark core as filled in the bitmask. As user processes are |
| 522 | * done, clear cores from the bitmask. |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 523 | */ |
| 524 | |
| 525 | ret = zalloc_cpumask_var(&diff, GFP_KERNEL); |
| 526 | if (!ret) |
| 527 | goto done; |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 528 | ret = zalloc_cpumask_var(&hw_thread_mask, GFP_KERNEL); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 529 | if (!ret) |
| 530 | goto free_diff; |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 531 | ret = zalloc_cpumask_var(&available_mask, GFP_KERNEL); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 532 | if (!ret) |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 533 | goto free_hw_thread_mask; |
| 534 | ret = zalloc_cpumask_var(&intrs_mask, GFP_KERNEL); |
| 535 | if (!ret) |
| 536 | goto free_available_mask; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 537 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 538 | spin_lock(&affinity->lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 539 | /* |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 540 | * If we've used all available HW threads, clear the mask and start |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 541 | * overloading. |
| 542 | */ |
| 543 | if (cpumask_equal(&set->mask, &set->used)) { |
| 544 | set->gen++; |
| 545 | cpumask_clear(&set->used); |
| 546 | } |
| 547 | |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 548 | /* |
| 549 | * If NUMA node has CPUs used by interrupt handlers, include them in the |
| 550 | * interrupt handler mask. |
| 551 | */ |
| 552 | entry = node_affinity_lookup(node); |
| 553 | if (entry) { |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 554 | cpumask_copy(intrs_mask, (entry->def_intr.gen ? |
| 555 | &entry->def_intr.mask : |
| 556 | &entry->def_intr.used)); |
| 557 | cpumask_or(intrs_mask, intrs_mask, (entry->rcv_intr.gen ? |
| 558 | &entry->rcv_intr.mask : |
| 559 | &entry->rcv_intr.used)); |
| 560 | cpumask_or(intrs_mask, intrs_mask, &entry->general_intr_mask); |
Sebastian Sanchez | d637301 | 2016-07-25 07:54:48 -0700 | [diff] [blame] | 561 | } |
Leon Romanovsky | f242d93a | 2016-05-31 10:54:36 +0300 | [diff] [blame] | 562 | hfi1_cdbg(PROC, "CPUs used by interrupts: %*pbl", |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 563 | cpumask_pr_args(intrs_mask)); |
| 564 | |
| 565 | cpumask_copy(hw_thread_mask, &set->mask); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 566 | |
| 567 | /* |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 568 | * If HT cores are enabled, identify which HW threads within the |
| 569 | * physical cores should be used. |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 570 | */ |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 571 | if (affinity->num_core_siblings > 0) { |
| 572 | for (i = 0; i < affinity->num_core_siblings; i++) { |
| 573 | find_hw_thread_mask(i, hw_thread_mask, affinity); |
| 574 | |
| 575 | /* |
| 576 | * If there's at least one available core for this HW |
| 577 | * thread number, stop looking for a core. |
| 578 | * |
| 579 | * diff will always be not empty at least once in this |
| 580 | * loop as the used mask gets reset when |
| 581 | * (set->mask == set->used) before this loop. |
| 582 | */ |
| 583 | cpumask_andnot(diff, hw_thread_mask, &set->used); |
| 584 | if (!cpumask_empty(diff)) |
| 585 | break; |
| 586 | } |
| 587 | } |
| 588 | hfi1_cdbg(PROC, "Same available HW thread on all physical CPUs: %*pbl", |
| 589 | cpumask_pr_args(hw_thread_mask)); |
| 590 | |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 591 | node_mask = cpumask_of_node(node); |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 592 | hfi1_cdbg(PROC, "Device on NUMA %u, CPUs %*pbl", node, |
Leon Romanovsky | f242d93a | 2016-05-31 10:54:36 +0300 | [diff] [blame] | 593 | cpumask_pr_args(node_mask)); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 594 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 595 | /* Get cpumask of available CPUs on preferred NUMA */ |
| 596 | cpumask_and(available_mask, hw_thread_mask, node_mask); |
| 597 | cpumask_andnot(available_mask, available_mask, &set->used); |
| 598 | hfi1_cdbg(PROC, "Available CPUs on NUMA %u: %*pbl", node, |
| 599 | cpumask_pr_args(available_mask)); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 600 | |
| 601 | /* |
| 602 | * At first, we don't want to place processes on the same |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 603 | * CPUs as interrupt handlers. Then, CPUs running interrupt |
| 604 | * handlers are used. |
| 605 | * |
| 606 | * 1) If diff is not empty, then there are CPUs not running |
| 607 | * non-interrupt handlers available, so diff gets copied |
| 608 | * over to available_mask. |
| 609 | * 2) If diff is empty, then all CPUs not running interrupt |
| 610 | * handlers are taken, so available_mask contains all |
| 611 | * available CPUs running interrupt handlers. |
| 612 | * 3) If available_mask is empty, then all CPUs on the |
| 613 | * preferred NUMA node are taken, so other NUMA nodes are |
| 614 | * used for process assignments using the same method as |
| 615 | * the preferred NUMA node. |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 616 | */ |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 617 | cpumask_andnot(diff, available_mask, intrs_mask); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 618 | if (!cpumask_empty(diff)) |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 619 | cpumask_copy(available_mask, diff); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 620 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 621 | /* If we don't have CPUs on the preferred node, use other NUMA nodes */ |
| 622 | if (cpumask_empty(available_mask)) { |
| 623 | cpumask_andnot(available_mask, hw_thread_mask, &set->used); |
| 624 | /* Excluding preferred NUMA cores */ |
| 625 | cpumask_andnot(available_mask, available_mask, node_mask); |
| 626 | hfi1_cdbg(PROC, |
| 627 | "Preferred NUMA node cores are taken, cores available in other NUMA nodes: %*pbl", |
| 628 | cpumask_pr_args(available_mask)); |
| 629 | |
| 630 | /* |
| 631 | * At first, we don't want to place processes on the same |
| 632 | * CPUs as interrupt handlers. |
| 633 | */ |
| 634 | cpumask_andnot(diff, available_mask, intrs_mask); |
| 635 | if (!cpumask_empty(diff)) |
| 636 | cpumask_copy(available_mask, diff); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 637 | } |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 638 | hfi1_cdbg(PROC, "Possible CPUs for process: %*pbl", |
| 639 | cpumask_pr_args(available_mask)); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 640 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 641 | cpu = cpumask_first(available_mask); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 642 | if (cpu >= nr_cpu_ids) /* empty */ |
| 643 | cpu = -1; |
| 644 | else |
| 645 | cpumask_set_cpu(cpu, &set->used); |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 646 | spin_unlock(&affinity->lock); |
| 647 | hfi1_cdbg(PROC, "Process assigned to CPU %d", cpu); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 648 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 649 | free_cpumask_var(intrs_mask); |
| 650 | free_available_mask: |
| 651 | free_cpumask_var(available_mask); |
| 652 | free_hw_thread_mask: |
| 653 | free_cpumask_var(hw_thread_mask); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 654 | free_diff: |
| 655 | free_cpumask_var(diff); |
| 656 | done: |
| 657 | return cpu; |
| 658 | } |
| 659 | |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 660 | void hfi1_put_proc_affinity(int cpu) |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 661 | { |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 662 | struct hfi1_affinity_node_list *affinity = &node_affinity; |
| 663 | struct cpu_mask_set *set = &affinity->proc; |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 664 | |
| 665 | if (cpu < 0) |
| 666 | return; |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 667 | spin_lock(&affinity->lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 668 | cpumask_clear_cpu(cpu, &set->used); |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 669 | hfi1_cdbg(PROC, "Returning CPU %d for future process assignment", cpu); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 670 | if (cpumask_empty(&set->used) && set->gen) { |
| 671 | set->gen--; |
| 672 | cpumask_copy(&set->used, &set->mask); |
| 673 | } |
Sebastian Sanchez | b094a36 | 2016-07-25 07:54:57 -0700 | [diff] [blame] | 674 | spin_unlock(&affinity->lock); |
Mitko Haralanov | 957558c | 2016-02-03 14:33:40 -0800 | [diff] [blame] | 675 | } |