blob: 2dddcd257eb344f5c675d23bea497be562deb3c4 [file] [log] [blame]
Miklos Szeredie9be9d52014-10-24 00:14:38 +02001/*
2 *
3 * Copyright (C) 2011 Novell Inc.
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 */
9
10#include <linux/kernel.h>
Amir Goldstein3a1e8192017-03-30 15:22:16 +030011#include <linux/uuid.h>
Amir Goldsteinee023c32017-10-30 13:33:11 +020012#include "ovl_entry.h"
Miklos Szeredie9be9d52014-10-24 00:14:38 +020013
Miklos Szeredie9be9d52014-10-24 00:14:38 +020014enum ovl_path_type {
Miklos Szeredi38e813d2016-12-16 11:02:55 +010015 __OVL_PATH_UPPER = (1 << 0),
16 __OVL_PATH_MERGE = (1 << 1),
Amir Goldstein59548502017-04-23 23:12:34 +030017 __OVL_PATH_ORIGIN = (1 << 2),
Miklos Szeredie9be9d52014-10-24 00:14:38 +020018};
19
Miklos Szeredi1afaba12014-12-13 00:59:42 +010020#define OVL_TYPE_UPPER(type) ((type) & __OVL_PATH_UPPER)
21#define OVL_TYPE_MERGE(type) ((type) & __OVL_PATH_MERGE)
Amir Goldstein59548502017-04-23 23:12:34 +030022#define OVL_TYPE_ORIGIN(type) ((type) & __OVL_PATH_ORIGIN)
Miklos Szeredid837a492016-07-29 12:05:24 +020023
Andreas Gruenbacherfe2b7592016-08-22 17:59:22 +020024#define OVL_XATTR_PREFIX XATTR_TRUSTED_PREFIX "overlay."
25#define OVL_XATTR_OPAQUE OVL_XATTR_PREFIX "opaque"
Miklos Szeredi02b69b22016-12-16 11:02:56 +010026#define OVL_XATTR_REDIRECT OVL_XATTR_PREFIX "redirect"
Amir Goldstein3a1e8192017-03-30 15:22:16 +030027#define OVL_XATTR_ORIGIN OVL_XATTR_PREFIX "origin"
Amir Goldsteinee1d6d372017-05-11 16:42:26 +030028#define OVL_XATTR_IMPURE OVL_XATTR_PREFIX "impure"
Amir Goldstein5f8415d2017-06-20 15:35:14 +030029#define OVL_XATTR_NLINK OVL_XATTR_PREFIX "nlink"
Amir Goldsteinad1d6152018-01-11 10:47:03 +020030#define OVL_XATTR_UPPER OVL_XATTR_PREFIX "upper"
Amir Goldstein3a1e8192017-03-30 15:22:16 +030031
Amir Goldsteinc62520a2018-01-14 19:25:31 +020032enum ovl_inode_flag {
Amir Goldsteinb79e05a2017-06-25 16:37:17 +030033 /* Pure upper dir that may contain non pure upper entries */
Miklos Szeredi13c72072017-07-04 22:03:16 +020034 OVL_IMPURE,
Amir Goldsteinb79e05a2017-06-25 16:37:17 +030035 /* Non-merge dir that may contain whiteout entries */
36 OVL_WHITEOUTS,
Amir Goldstein359f3922017-06-21 15:28:41 +030037 OVL_INDEX,
Miklos Szeredi13c72072017-07-04 22:03:16 +020038};
39
Amir Goldsteinc62520a2018-01-14 19:25:31 +020040enum ovl_entry_flag {
41 OVL_E_UPPER_ALIAS,
42 OVL_E_OPAQUE,
43};
44
Amir Goldstein3a1e8192017-03-30 15:22:16 +030045/*
46 * The tuple (fh,uuid) is a universal unique identifier for a copy up origin,
47 * where:
48 * origin.fh - exported file handle of the lower file
49 * origin.uuid - uuid of the lower filesystem
50 */
51#define OVL_FH_VERSION 0
52#define OVL_FH_MAGIC 0xfb
53
54/* CPU byte order required for fid decoding: */
55#define OVL_FH_FLAG_BIG_ENDIAN (1 << 0)
56#define OVL_FH_FLAG_ANY_ENDIAN (1 << 1)
Amir Goldstein54fb3472017-06-21 15:28:38 +030057/* Is the real inode encoded in fid an upper inode? */
58#define OVL_FH_FLAG_PATH_UPPER (1 << 2)
Amir Goldstein3a1e8192017-03-30 15:22:16 +030059
Amir Goldstein961af642017-07-11 15:58:36 +030060#define OVL_FH_FLAG_ALL (OVL_FH_FLAG_BIG_ENDIAN | OVL_FH_FLAG_ANY_ENDIAN | \
61 OVL_FH_FLAG_PATH_UPPER)
Amir Goldstein3a1e8192017-03-30 15:22:16 +030062
63#if defined(__LITTLE_ENDIAN)
64#define OVL_FH_FLAG_CPU_ENDIAN 0
65#elif defined(__BIG_ENDIAN)
66#define OVL_FH_FLAG_CPU_ENDIAN OVL_FH_FLAG_BIG_ENDIAN
67#else
68#error Endianness not defined
69#endif
70
71/* On-disk and in-memeory format for redirect by file handle */
72struct ovl_fh {
73 u8 version; /* 0 */
74 u8 magic; /* 0xfb */
75 u8 len; /* size of this header + size of fid */
76 u8 flags; /* OVL_FH_FLAG_* */
77 u8 type; /* fid_type of fid */
Christoph Hellwig01633fd2017-05-17 09:32:50 +020078 uuid_t uuid; /* uuid of filesystem */
Amir Goldstein3a1e8192017-03-30 15:22:16 +030079 u8 fid[0]; /* file identifier */
80} __packed;
Miklos Szeredie9be9d52014-10-24 00:14:38 +020081
82static inline int ovl_do_rmdir(struct inode *dir, struct dentry *dentry)
83{
84 int err = vfs_rmdir(dir, dentry);
85 pr_debug("rmdir(%pd2) = %i\n", dentry, err);
86 return err;
87}
88
89static inline int ovl_do_unlink(struct inode *dir, struct dentry *dentry)
90{
91 int err = vfs_unlink(dir, dentry, NULL);
92 pr_debug("unlink(%pd2) = %i\n", dentry, err);
93 return err;
94}
95
96static inline int ovl_do_link(struct dentry *old_dentry, struct inode *dir,
97 struct dentry *new_dentry, bool debug)
98{
99 int err = vfs_link(old_dentry, dir, new_dentry, NULL);
100 if (debug) {
101 pr_debug("link(%pd2, %pd2) = %i\n",
102 old_dentry, new_dentry, err);
103 }
104 return err;
105}
106
107static inline int ovl_do_create(struct inode *dir, struct dentry *dentry,
108 umode_t mode, bool debug)
109{
110 int err = vfs_create(dir, dentry, mode, true);
111 if (debug)
112 pr_debug("create(%pd2, 0%o) = %i\n", dentry, mode, err);
113 return err;
114}
115
116static inline int ovl_do_mkdir(struct inode *dir, struct dentry *dentry,
117 umode_t mode, bool debug)
118{
119 int err = vfs_mkdir(dir, dentry, mode);
120 if (debug)
121 pr_debug("mkdir(%pd2, 0%o) = %i\n", dentry, mode, err);
122 return err;
123}
124
125static inline int ovl_do_mknod(struct inode *dir, struct dentry *dentry,
126 umode_t mode, dev_t dev, bool debug)
127{
128 int err = vfs_mknod(dir, dentry, mode, dev);
129 if (debug) {
130 pr_debug("mknod(%pd2, 0%o, 0%o) = %i\n",
131 dentry, mode, dev, err);
132 }
133 return err;
134}
135
136static inline int ovl_do_symlink(struct inode *dir, struct dentry *dentry,
137 const char *oldname, bool debug)
138{
139 int err = vfs_symlink(dir, dentry, oldname);
140 if (debug)
141 pr_debug("symlink(\"%s\", %pd2) = %i\n", oldname, dentry, err);
142 return err;
143}
144
145static inline int ovl_do_setxattr(struct dentry *dentry, const char *name,
146 const void *value, size_t size, int flags)
147{
148 int err = vfs_setxattr(dentry, name, value, size, flags);
149 pr_debug("setxattr(%pd2, \"%s\", \"%*s\", 0x%x) = %i\n",
150 dentry, name, (int) size, (char *) value, flags, err);
151 return err;
152}
153
154static inline int ovl_do_removexattr(struct dentry *dentry, const char *name)
155{
156 int err = vfs_removexattr(dentry, name);
157 pr_debug("removexattr(%pd2, \"%s\") = %i\n", dentry, name, err);
158 return err;
159}
160
161static inline int ovl_do_rename(struct inode *olddir, struct dentry *olddentry,
162 struct inode *newdir, struct dentry *newdentry,
163 unsigned int flags)
164{
165 int err;
166
Miklos Szeredi2773bf02016-09-27 11:03:58 +0200167 pr_debug("rename(%pd2, %pd2, 0x%x)\n",
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200168 olddentry, newdentry, flags);
169
170 err = vfs_rename(olddir, olddentry, newdir, newdentry, NULL, flags);
171
172 if (err) {
Miklos Szeredi2773bf02016-09-27 11:03:58 +0200173 pr_debug("...rename(%pd2, %pd2, ...) = %i\n",
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200174 olddentry, newdentry, err);
175 }
176 return err;
177}
178
179static inline int ovl_do_whiteout(struct inode *dir, struct dentry *dentry)
180{
181 int err = vfs_whiteout(dir, dentry);
182 pr_debug("whiteout(%pd2) = %i\n", dentry, err);
183 return err;
184}
185
Amir Goldsteine7f52422017-01-17 06:34:53 +0200186static inline struct dentry *ovl_do_tmpfile(struct dentry *dentry, umode_t mode)
187{
188 struct dentry *ret = vfs_tmpfile(dentry, mode, 0);
Vasyl Gomonovych7879cb42017-11-28 00:09:23 +0100189 int err = PTR_ERR_OR_ZERO(ret);
Amir Goldsteine7f52422017-01-17 06:34:53 +0200190
191 pr_debug("tmpfile(%pd2, 0%o) = %i\n", dentry, mode, err);
192 return ret;
193}
194
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100195/* util.c */
196int ovl_want_write(struct dentry *dentry);
197void ovl_drop_write(struct dentry *dentry);
198struct dentry *ovl_workdir(struct dentry *dentry);
199const struct cred *ovl_override_creds(struct super_block *sb);
Amir Goldstein7bcd74b2017-03-22 08:42:21 -0400200struct super_block *ovl_same_sb(struct super_block *sb);
Amir Goldstein02bcd152017-06-21 15:28:36 +0300201bool ovl_can_decode_fh(struct super_block *sb);
202struct dentry *ovl_indexdir(struct super_block *sb);
Amir Goldsteinf168f102018-01-19 11:26:53 +0200203bool ovl_index_all(struct super_block *sb);
204bool ovl_verify_lower(struct super_block *sb);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100205struct ovl_entry *ovl_alloc_entry(unsigned int numlower);
206bool ovl_dentry_remote(struct dentry *dentry);
207bool ovl_dentry_weird(struct dentry *dentry);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200208enum ovl_path_type ovl_path_type(struct dentry *dentry);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200209void ovl_path_upper(struct dentry *dentry, struct path *path);
210void ovl_path_lower(struct dentry *dentry, struct path *path);
211enum ovl_path_type ovl_path_real(struct dentry *dentry, struct path *path);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200212struct dentry *ovl_dentry_upper(struct dentry *dentry);
213struct dentry *ovl_dentry_lower(struct dentry *dentry);
214struct dentry *ovl_dentry_real(struct dentry *dentry);
Miklos Szeredi1d88f182017-07-20 11:08:21 +0200215struct dentry *ovl_i_dentry_upper(struct inode *inode);
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200216struct inode *ovl_inode_upper(struct inode *inode);
217struct inode *ovl_inode_lower(struct inode *inode);
218struct inode *ovl_inode_real(struct inode *inode);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200219struct ovl_dir_cache *ovl_dir_cache(struct inode *inode);
220void ovl_set_dir_cache(struct inode *inode, struct ovl_dir_cache *cache);
Amir Goldsteinc62520a2018-01-14 19:25:31 +0200221void ovl_dentry_set_flag(unsigned long flag, struct dentry *dentry);
222void ovl_dentry_clear_flag(unsigned long flag, struct dentry *dentry);
223bool ovl_dentry_test_flag(unsigned long flag, struct dentry *dentry);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200224bool ovl_dentry_is_opaque(struct dentry *dentry);
Miklos Szeredic412ce42016-12-16 11:02:55 +0100225bool ovl_dentry_is_whiteout(struct dentry *dentry);
Miklos Szeredi5cf5b472016-12-16 11:02:57 +0100226void ovl_dentry_set_opaque(struct dentry *dentry);
Miklos Szeredi55acc662017-07-04 22:03:18 +0200227bool ovl_dentry_has_upper_alias(struct dentry *dentry);
228void ovl_dentry_set_upper_alias(struct dentry *dentry);
Miklos Szeredia6c60652016-12-16 11:02:56 +0100229bool ovl_redirect_dir(struct super_block *sb);
Miklos Szeredia6c60652016-12-16 11:02:56 +0100230const char *ovl_dentry_get_redirect(struct dentry *dentry);
231void ovl_dentry_set_redirect(struct dentry *dentry, const char *redirect);
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200232void ovl_inode_init(struct inode *inode, struct dentry *upperdentry,
233 struct dentry *lowerdentry);
234void ovl_inode_update(struct inode *inode, struct dentry *upperdentry);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200235void ovl_dentry_version_inc(struct dentry *dentry, bool impurity);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100236u64 ovl_dentry_version_get(struct dentry *dentry);
237bool ovl_is_whiteout(struct dentry *dentry);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200238struct file *ovl_path_open(struct path *path, int flags);
Amir Goldstein39d3d602017-01-17 06:34:56 +0200239int ovl_copy_up_start(struct dentry *dentry);
240void ovl_copy_up_end(struct dentry *dentry);
Amir Goldsteinb79e05a2017-06-25 16:37:17 +0300241bool ovl_check_origin_xattr(struct dentry *dentry);
Amir Goldsteinf3a15682017-05-24 15:29:33 +0300242bool ovl_check_dir_xattr(struct dentry *dentry, const char *name);
243int ovl_check_setxattr(struct dentry *dentry, struct dentry *upperdentry,
244 const char *name, const void *value, size_t size,
245 int xerr);
246int ovl_set_impure(struct dentry *dentry, struct dentry *upperdentry);
Miklos Szeredi13c72072017-07-04 22:03:16 +0200247void ovl_set_flag(unsigned long flag, struct inode *inode);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200248void ovl_clear_flag(unsigned long flag, struct inode *inode);
Miklos Szeredi13c72072017-07-04 22:03:16 +0200249bool ovl_test_flag(unsigned long flag, struct inode *inode);
Amir Goldsteinad0af712017-06-21 15:28:32 +0300250bool ovl_inuse_trylock(struct dentry *dentry);
251void ovl_inuse_unlock(struct dentry *dentry);
Amir Goldstein24b33ee2017-09-26 07:55:26 +0300252bool ovl_need_index(struct dentry *dentry);
Amir Goldstein5f8415d2017-06-20 15:35:14 +0300253int ovl_nlink_start(struct dentry *dentry, bool *locked);
254void ovl_nlink_end(struct dentry *dentry, bool locked);
Amir Goldstein5820dc02017-09-25 16:39:55 +0300255int ovl_lock_rename_workdir(struct dentry *workdir, struct dentry *upperdir);
Amir Goldsteinf3a15682017-05-24 15:29:33 +0300256
257static inline bool ovl_is_impuredir(struct dentry *dentry)
258{
259 return ovl_check_dir_xattr(dentry, OVL_XATTR_IMPURE);
260}
261
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200262
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100263/* namei.c */
Amir Goldstein05122442018-01-11 08:25:32 +0200264int ovl_verify_set_fh(struct dentry *dentry, const char *name,
265 struct dentry *real, bool is_upper, bool set);
Amir Goldstein1eff1a12017-12-12 22:40:46 +0200266int ovl_verify_index(struct ovl_fs *ofs, struct dentry *index);
Amir Goldstein359f3922017-06-21 15:28:41 +0300267int ovl_get_index_name(struct dentry *origin, struct qstr *name);
Amir Goldstein91ffe7b2017-12-28 20:23:05 +0200268struct dentry *ovl_get_index_fh(struct ovl_fs *ofs, struct ovl_fh *fh);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100269int ovl_path_next(int idx, struct dentry *dentry, struct path *path);
Amir Goldstein1eff1a12017-12-12 22:40:46 +0200270struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
271 unsigned int flags);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100272bool ovl_lower_positive(struct dentry *dentry);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200273
Amir Goldstein05122442018-01-11 08:25:32 +0200274static inline int ovl_verify_origin(struct dentry *upper,
275 struct dentry *origin, bool set)
276{
277 return ovl_verify_set_fh(upper, OVL_XATTR_ORIGIN, origin, false, set);
278}
279
Amir Goldsteinad1d6152018-01-11 10:47:03 +0200280static inline int ovl_verify_upper(struct dentry *index,
281 struct dentry *upper, bool set)
282{
283 return ovl_verify_set_fh(index, OVL_XATTR_UPPER, upper, true, set);
284}
285
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200286/* readdir.c */
287extern const struct file_operations ovl_dir_operations;
288int ovl_check_empty_dir(struct dentry *dentry, struct list_head *list);
289void ovl_cleanup_whiteouts(struct dentry *upper, struct list_head *list);
290void ovl_cache_free(struct list_head *list);
Miklos Szeredi4edb83b2017-07-27 21:54:06 +0200291void ovl_dir_cache_free(struct inode *inode);
Vivek Goyal45aebea2016-02-22 09:28:34 -0500292int ovl_check_d_type_supported(struct path *realpath);
Miklos Szeredieea2fb42016-09-01 11:11:59 +0200293void ovl_workdir_cleanup(struct inode *dir, struct vfsmount *mnt,
294 struct dentry *dentry, int level);
Amir Goldstein1eff1a12017-12-12 22:40:46 +0200295int ovl_indexdir_cleanup(struct ovl_fs *ofs);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200296
297/* inode.c */
Amir Goldstein5f8415d2017-06-20 15:35:14 +0300298int ovl_set_nlink_upper(struct dentry *dentry);
299int ovl_set_nlink_lower(struct dentry *dentry);
Amir Goldsteincaf70cb2017-06-21 13:46:12 +0300300unsigned int ovl_get_nlink(struct dentry *lowerdentry,
301 struct dentry *upperdentry,
302 unsigned int fallback);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200303int ovl_setattr(struct dentry *dentry, struct iattr *attr);
Miklos Szeredi5b712092017-05-05 11:38:58 +0200304int ovl_getattr(const struct path *path, struct kstat *stat,
305 u32 request_mask, unsigned int flags);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200306int ovl_permission(struct inode *inode, int mask);
Miklos Szeredi1d88f182017-07-20 11:08:21 +0200307int ovl_xattr_set(struct dentry *dentry, struct inode *inode, const char *name,
308 const void *value, size_t size, int flags);
309int ovl_xattr_get(struct dentry *dentry, struct inode *inode, const char *name,
Andreas Gruenbacher0eb45fc2016-08-22 17:52:55 +0200310 void *value, size_t size);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200311ssize_t ovl_listxattr(struct dentry *dentry, char *list, size_t size);
Vivek Goyal39a25b22016-07-01 16:34:26 -0400312struct posix_acl *ovl_get_acl(struct inode *inode, int type);
Miklos Szeredi2d902672016-06-30 08:53:27 +0200313int ovl_open_maybe_copy_up(struct dentry *dentry, unsigned int file_flags);
Miklos Szeredid719e8f2016-07-29 12:05:23 +0200314int ovl_update_time(struct inode *inode, struct timespec *ts, int flags);
Miklos Szeredi09562542016-08-08 15:08:49 +0200315bool ovl_is_private_xattr(const char *name);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200316
Miklos Szeredica4c8a32016-12-16 11:02:55 +0100317struct inode *ovl_new_inode(struct super_block *sb, umode_t mode, dev_t rdev);
Amir Goldstein0aceb532017-12-12 23:43:16 +0200318struct inode *ovl_get_inode(struct super_block *sb, struct dentry *upperdentry,
319 struct dentry *lowerdentry, struct dentry *index,
320 unsigned int numlower);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200321static inline void ovl_copyattr(struct inode *from, struct inode *to)
322{
323 to->i_uid = from->i_uid;
324 to->i_gid = from->i_gid;
Vivek Goyal07a2daa2016-07-01 16:34:25 -0400325 to->i_mode = from->i_mode;
Miklos Szeredid719e8f2016-07-29 12:05:23 +0200326 to->i_atime = from->i_atime;
327 to->i_mtime = from->i_mtime;
328 to->i_ctime = from->i_ctime;
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200329}
330
331/* dir.c */
332extern const struct inode_operations ovl_dir_inode_operations;
Miklos Szeredi3d275732017-05-19 09:33:49 +0200333struct dentry *ovl_lookup_temp(struct dentry *workdir);
Amir Goldsteine7dd0e72017-10-24 17:38:33 +0300334int ovl_cleanup_and_whiteout(struct dentry *workdir, struct inode *dir,
335 struct dentry *dentry);
Al Viro32a3d842016-12-04 17:33:17 +0000336struct cattr {
337 dev_t rdev;
338 umode_t mode;
339 const char *link;
340};
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200341int ovl_create_real(struct inode *dir, struct dentry *newdentry,
Al Viro32a3d842016-12-04 17:33:17 +0000342 struct cattr *attr,
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200343 struct dentry *hardlink, bool debug);
Amir Goldstein415543d2017-06-21 15:28:42 +0300344int ovl_cleanup(struct inode *dir, struct dentry *dentry);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200345
346/* copy_up.c */
347int ovl_copy_up(struct dentry *dentry);
Amir Goldstein9aba6522016-11-12 21:36:03 +0200348int ovl_copy_up_flags(struct dentry *dentry, int flags);
Miklos Szeredie9be9d52014-10-24 00:14:38 +0200349int ovl_copy_xattr(struct dentry *old, struct dentry *new);
350int ovl_set_attr(struct dentry *upper, struct kstat *stat);
Amir Goldstein05122442018-01-11 08:25:32 +0200351struct ovl_fh *ovl_encode_fh(struct dentry *real, bool is_upper);
Amir Goldstein9678e632018-01-03 19:34:45 +0200352int ovl_set_origin(struct dentry *dentry, struct dentry *lower,
353 struct dentry *upper);